Re: [HACKERS] PL/pgSQL RENAME functionality in TODOs

2007-01-30 Thread imad
OK, so renaming does not work in the same block. You can rename a vairable in a nested block and thats why it works for OLD/NEW. BTW, what is the purpose behind it? Declaring a variable in a block and quickly renaming it does not make sense to me. --Imad www.EnterpriseDB.com On 1/31/07, Bruce M

Re: [HACKERS] stack usage in toast_insert_or_update()

2007-01-30 Thread Tom Lane
"Pavan Deolasee" <[EMAIL PROTECTED]> writes: > Btw, I noticed that the toast_insert_or_update() is re-entrant. > toast_save_datum() calls simple_heap_insert() which somewhere down the > line calls toast_insert_or_update() again. The toast code takes pains to ensure that the tuples it creates won't

Re: [HACKERS] stack usage in toast_insert_or_update()

2007-01-30 Thread Pavan Deolasee
On 1/30/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Pavan Deolasee" <[EMAIL PROTECTED]> writes: > The stack usage for toast_insert_or_update() may run into several KBs since > the MaxHeapAttributeNumber is set to a very large value of 1600. The usage > could anywhere between 28K to 48K depending on

Re: [HACKERS] PL/pgSQL RENAME functionality in TODOs

2007-01-30 Thread Bruce Momjian
URL added to TODO. (I didn't have URLs in there at the time). --- Tom Lane wrote: > imad <[EMAIL PROTECTED]> writes: > > "Fix RENAME to work on variables other than OLD/NEW" > > I can rename just any variable declared in a

Re: [HACKERS] Modifying and solidifying contrib

2007-01-30 Thread Michael Glaesemann
On Jan 31, 2007, at 12:42 , David Fetter wrote: On Tue, Jan 30, 2007 at 03:49:14PM -0500, Andrew Dunstan wrote: 6. they all need proper docs. READMEs and the like are nowhere near good enough. Agreed. I'm thinking a new major section in the SGML docs is in order with a subsection for ea

Re: [HACKERS] Modifying and solidifying contrib

2007-01-30 Thread David Fetter
On Tue, Jan 30, 2007 at 03:49:14PM -0500, Andrew Dunstan wrote: > Bruce Momjian wrote: > >Joshua D. Drake wrote: > > > >>>This seems like a good first step in growing a packaging > >>>infrastructure. I'd rather grow it organically than try to design > >>>it all up front. > >>> > >>I am in D

Re: [HACKERS] Logging Lock Waits

2007-01-30 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes: > I'm thinking to write an INFO message, so that people can choose to log > this and/or the SQL statement if they choose. > e.g. INFO: lock wait time of XXX secs has been exceeded The available timer resources are already overloaded; adding an independent

Re: [HACKERS] parsenodes vs. primnodes

2007-01-30 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > If something from primnodes.h (XmlExpr) needs something from > parsenodes.h (TypeName), should I just move the former to the latter, > or is there some major semantic dividing line between the two? Or > maybe TypeName should really be a primnode?

[HACKERS] Logging Lock Waits

2007-01-30 Thread Simon Riggs
Right now, I need a way to log the lock wait times for certain queries, to see if they are acceptable. DTrace is not available. I'm dealing with a problem that is either a standard lock wait involving RI trigger locking, or a weirder problem involving lock starvation as a result of soft deadlock q

Re: [HACKERS] Improving NOT IN

2007-01-30 Thread Simon Riggs
On Tue, 2007-01-30 at 18:06 -0500, Tom Lane wrote: > "Simon Riggs" <[EMAIL PROTECTED]> writes: > > What would be wrong with checking for a NOT NULL constraint? Thats how > > other planners cope with it. Or are you thinking about lack of plan > > invalidation? > > Yup, without that, depending on co

Re: [HACKERS] Improving NOT IN

2007-01-30 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes: > On Tue, 2007-01-30 at 17:34 -0500, Tom Lane wrote: >> Since that is unlikely to be the case, I can't see that this is worth >> implementing... > Integers are typically used as keys... Yeah, in the form of sequences, so you have a hole for every failed i

Re: [HACKERS] Improving NOT IN

2007-01-30 Thread Simon Riggs
On Tue, 2007-01-30 at 17:34 -0500, Tom Lane wrote: > "Simon Riggs" <[EMAIL PROTECTED]> writes: > > First we need to show that the referenced table's PK values are a fully > > continuous sequence of integers with no gaps. > > Since that is unlikely to be the case, I can't see that this is worth > i

Re: [HACKERS] Improving NOT IN

2007-01-30 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes: > First we need to show that the referenced table's PK values are a fully > continuous sequence of integers with no gaps. Since that is unlikely to be the case, I can't see that this is worth implementing... > I'll describe this using SQL statements, whic

[HACKERS] parsenodes vs. primnodes

2007-01-30 Thread Peter Eisentraut
If something from primnodes.h (XmlExpr) needs something from parsenodes.h (TypeName), should I just move the former to the latter, or is there some major semantic dividing line between the two? Or maybe TypeName should really be a primnode? -- Peter Eisentraut http://developer.postgresql.org/

Re: [HACKERS] RI checks during UPDATEs

2007-01-30 Thread Simon Riggs
On Tue, 2007-01-30 at 15:24 -0500, Tom Lane wrote: > "Simon Riggs" <[EMAIL PROTECTED]> writes: > > Any objections to implementing this? > > Only that it was done a long time ago --- see > RI_FKey_keyequal_upd_pk/fk. OK, funny guy. :-) Its not very well documented, is all I can say. The code comm

[HACKERS] Improving NOT IN

2007-01-30 Thread Simon Riggs
It's a fairly common case to want to improve a query along the lines of TableA intersect ~TableB. We can write this as select * from tableA where key not in (select * from tableB) or we can get more fancy select tableA.* from tableA left outer

Re: [HACKERS] PL/pgSQL RENAME functionality in TODOs

2007-01-30 Thread Tom Lane
imad <[EMAIL PROTECTED]> writes: > "Fix RENAME to work on variables other than OLD/NEW" > I can rename just any variable declared in a PL block apart from > OLD/NEW. Is the TODOs list out of sync or I am missing the point here? Really? It looks pretty broken to me still: regression=# create func

Re: [HACKERS] Modifying and solidifying contrib

2007-01-30 Thread Nikolay Samokhvalov
On 1/30/07, Andrew Dunstan <[EMAIL PROTECTED]> wrote: [...] 4. visibility/searchpath issues. I don't think long search paths are a huge issue, but I think we can make life a bit easier by tweaking searchpath support a bit (David's clever SQL notwithstanding). As for search_path -- is it reall

[HACKERS] Talks for OSCON? Only 5 days left!

2007-01-30 Thread Josh Berkus
All, We only have five days left to submit talks for OSCON (Portland, last week of July): http://conferences.oreillynet.com/cs/os2007/create/e_sess I'd like to check & coordinate what people are submitting from PostgreSQL to make sure we have the strongest possible PostgreSQL content. So far w

Re: [HACKERS] [ADMIN] How to configure Postgres NOT to use (load) openssl libraries libeay32.dll and ssleay32.dll

2007-01-30 Thread Magnus Hagander
On Tue, Jan 30, 2007 at 03:59:08PM -0500, Tom Dong wrote: > Thanks! Mangus, > > Our developers are currently working on the build. Just > wondering if there are any builds, without the encryption, we can > download. > None that I know of. All the official builds from postgresql.org (wihch

Re: [HACKERS] [ADMIN] How to configure Postgres NOT to use (load) openssl libraries libeay32.dll and ssleay32.dll

2007-01-30 Thread Tom Dong
Thanks! Mangus, Our developers are currently working on the build. Just wondering if there are any builds, without the encryption, we can download. Thanks again for the response! Tom -Original Message- From: Magnus Hagander [mailto:[EMAIL PROTECTED] Sent: Tuesda

Re: [HACKERS] log ssl mode with connections?

2007-01-30 Thread Magnus Hagander
On Tue, Jan 30, 2007 at 12:35:01PM -0500, Kris Jurka wrote: > > > On Tue, 30 Jan 2007, Andrew Dunstan wrote: > > >If I am allowing both SSL and non-SSL I might like to know which is used > >by a particular connection. > > > > Other places I've heard people ask for this info: > > 1) pg_stat_ac

Re: [HACKERS] [ADMIN] How to configure Postgres NOT to use (load) openssl libraries libeay32.dll and ssleay32.dll

2007-01-30 Thread Magnus Hagander
On Tue, Jan 30, 2007 at 11:14:15AM -0500, Tom Dong wrote: > Thanks! Tom, > > We are using the win32 version of the postgres 8.0.10.5031. We > need to replace that with the same version (not necessarily to the same > point release) without using SSL (without using the openssl libraries > men

Re: [HACKERS] Modifying and solidifying contrib

2007-01-30 Thread Andrew Dunstan
Bruce Momjian wrote: Joshua D. Drake wrote: This seems like a good first step in growing a packaging infrastructure. I'd rather grow it organically than try to design it all up front. I am in Denver and have spotty inet access so forgive me. So where does this above leave us? What

Re: [HACKERS] [DOCS] "May", "can", "might"

2007-01-30 Thread Guillaume Lelarge
Bruce Momjian a écrit : Standard English uses "may", "can", and "might" in different ways: may - permission, "You may borrow my rake." can - ability, "I can lift that log." might - possibility, "It might rain today." Unfortunately, in conversational Eng

Re: [HACKERS] RI checks during UPDATEs

2007-01-30 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes: > Any objections to implementing this? Only that it was done a long time ago --- see RI_FKey_keyequal_upd_pk/fk. > It would be even better if there was some way of not executing the > trigger at all if we knew that the UPDATE statement doesn't SET the FK

Re: [HACKERS] [pgsql-patches] pg_dump pretty_print

2007-01-30 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Tom Lane wrote: > The original definition of the prettyprint flag was that it'd produce a > version that was nice to look at but not guaranteed to parse back > exactly the same; in particular it might omit parentheses that perhaps > were really

[HACKERS] RI checks during UPDATEs

2007-01-30 Thread Simon Riggs
My understanding is that an UPDATE statement will fire exactly the same number of RI checks as does an INSERT, in all cases. ISTM possible that we could optimise away some RI checks in the case of UPDATEs. This might or might not save some cycles but it will definitely reduce the amount of locking

[HACKERS] PL/pgSQL RENAME functionality in TODOs

2007-01-30 Thread imad
I was testing the following statement and found it working fine on version 8.2.1. "Fix RENAME to work on variables other than OLD/NEW" I can rename just any variable declared in a PL block apart from OLD/NEW. Is the TODOs list out of sync or I am missing the point here? --Imad www.EnterpriseDB.

Re: [HACKERS] Questions about parser code

2007-01-30 Thread Gregory Stark
So I have basic non-recursive queries working. However currently it's essentially inlining the subquery at every call-site which obvious will never handle recursive queries and in fact doesn't even do what people expect from the basic syntax. The use case for the WITH syntax is when you have an ex

Re: [HACKERS] "May", "can", "might"

2007-01-30 Thread Sean Utt
- Original Message - From: "Bruce Momjian" <[EMAIL PROTECTED]> -- snip -- I would like to clean up our documentation to consistently use these words. Objections? (Who says were obsessive?) :-) -- more snip -- Did you mean, "Who says we're obsessive?" ;-) Sean ---

Re: [HACKERS] "May", "can", "might"

2007-01-30 Thread Mike Rylander
On 1/30/07, Gregory Stark <[EMAIL PROTECTED]> wrote: "Bruce Momjian" <[EMAIL PROTECTED]> writes: > (Who says were obsessive?) :-) I may not fall into your clever trap... But you certainly can! (sorry...) -- Gregory Stark EnterpriseDB http://www.enterprisedb.com -

Re: [HACKERS] "May", "can", "might"

2007-01-30 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > (Who says were obsessive?) :-) I may not fall into your clever trap... -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---(end of broadcast)--- TIP 1: if posting/reading throu

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Guido Goldstein
Peter Eisentraut wrote: Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? The issue isn't so much which versions we want to support. There is certainly some flexibility with that. But when a patch breaks the buildfarm a) unannounced and b) without

[HACKERS] Proposal for partial resove issue of GIN fullscan.

2007-01-30 Thread Teodor Sigaev
Small introduction: GIN index doesn't support full scan of index now because of disaster performance. Pointer to each heap tuple will be returned several times. Next, if extractQuery doesn't return anything, GIN generates error 'GIN index does not support search with void query'. That is becaus

[HACKERS] "May", "can", "might"

2007-01-30 Thread Bruce Momjian
Standard English uses "may", "can", and "might" in different ways: may - permission, "You may borrow my rake." can - ability, "I can lift that log." might - possibility, "It might rain today." Unfortunately, in conversational English, their use is often m

Re: [HACKERS] log ssl mode with connections?

2007-01-30 Thread Kris Jurka
On Tue, 30 Jan 2007, Andrew Dunstan wrote: If I am allowing both SSL and non-SSL I might like to know which is used by a particular connection. Other places I've heard people ask for this info: 1) pg_stat_activity to see who's currently connected and how. 2) Via a function (boolean am_i_

Re: [HACKERS] SQL to get a table columns comments?

2007-01-30 Thread codeWarrior
SELECT CASE WHEN sfl.description IS NOT NULL THEN sfl.description WHEN sfl.description IS NULL THEN pa.attname::character varying ELSE pd.description::character varying END AS label FROM ONLY pg_class pc JOIN ONLY pg_attribute pa ON pc.oid

Re: [HACKERS] log ssl mode with connections?

2007-01-30 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: I just turned on SSL for a test server and noticed that SSL mode isn't logged with the connection. Should it be? Why? If I am allowing both SSL and non-SSL I might like to know which is used by a particular conn

Re: [HACKERS] Bug? CREATE TABLE AS (... UNION ...)

2007-01-30 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Hm, it appears I have this wrong somehow since I can create tables using > CREATE TABLE AS specifying tablespaces just fine. But I do't see how it can > work. Look at the first few lines of transformSetOperationStmt. regards, tom

Re: [HACKERS] standard_conforming_strings 'on' for 8.3?

2007-01-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Are we going to turn on standard_conforming_strings for 8.3? > > I'd be inclined to wait a bit longer, i.e., 8.4, seeing that this is > intended to be a short release cycle. 8.2 has not been out long enough > to draw any meaningful c

Re: [HACKERS] log ssl mode with connections?

2007-01-30 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > I just turned on SSL for a test server and noticed that SSL mode isn't > logged with the connection. Should it be? Why? regards, tom lane ---(end of broadcast)--- TIP 6: explain

Re: [HACKERS] standard_conforming_strings 'on' for 8.3?

2007-01-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Are we going to turn on standard_conforming_strings for 8.3? I'd be inclined to wait a bit longer, i.e., 8.4, seeing that this is intended to be a short release cycle. 8.2 has not been out long enough to draw any meaningful conclusions about whether we

Re: [HACKERS] Questions about parser code

2007-01-30 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Is it ok to scribble on and reuse objects from the parse tree when generating > the transformed tree? Or should the transformed query object be built from > freshly allocated nodes? We do both already; take your pick. If you do the former, though, I sug

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread J. Andrew Rogers
On Jan 30, 2007, at 2:43 AM, Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? Just as a hint: 2.5 is the current stable version. I support a lot of python on several platforms. For broad compatibility with pre-installed Python versions on recent

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > But I guess maybe the added check has to be not just (!syslogger_started) > but (!syslogger_started && is_postmaster)? That would at least get you out of the problem of having to transmit the syslogger_started flag to the backends...

[HACKERS] Patch queue

2007-01-30 Thread Bruce Momjian
FYI, I have been working all January to process 8.3 held patches/ideas, plus process the items arriving during the month. While I have been able to make some progress, there are still a significant number of items for me to address. I will keep working on it and try to complete it by mid-February

[HACKERS] log ssl mode with connections?

2007-01-30 Thread Andrew Dunstan
I just turned on SSL for a test server and noticed that SSL mode isn't logged with the connection. Should it be? It should be relatively simple to add. cheers andrew ---(end of broadcast)--- TIP 6: explain analyze is your friend

[HACKERS] standard_conforming_strings 'on' for 8.3?

2007-01-30 Thread Bruce Momjian
Are we going to turn on standard_conforming_strings for 8.3? We discussed the idea when we added it in 8.1, and enabled the backslash warning in 8.2. We have gotten almost no pushback on the warning, so it seems enabling it might be good. Right now, for default postgresql.conf, users are getting

[HACKERS] Questions about parser code

2007-01-30 Thread Gregory Stark
Is it considered ok for the pstate data structures to have references to nodes in the query tree? Or should they do copyObject() if they need to refer to them? Is it ok to scribble on and reuse objects from the parse tree when generating the transformed tree? Or should the transformed query obje

Re: [HACKERS] [ADMIN] How to configure Postgres NOT to use (load) openssl libraries libeay32.dll and ssleay32.dll

2007-01-30 Thread Tom Dong
Thanks! Tom, We are using the win32 version of the postgres 8.0.10.5031. We need to replace that with the same version (not necessarily to the same point release) without using SSL (without using the openssl libraries mentioned below). We are trying to rebuild the binary as you suggested

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Magnus Hagander
On Tue, Jan 30, 2007 at 10:32:14AM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > So I still tthink it's a good idea. Even though it doesn't solve every > > case, it solves a lot of them I think. And more importantly on that, I > > don't see how it would *break* anything (

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > So I still tthink it's a good idea. Even though it doesn't solve every > case, it solves a lot of them I think. And more importantly on that, I > don't see how it would *break* anything (given that it still fires only > when running as a service, when e

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Guido Goldstein wrote: >> Is it possible to tell me which python versions you want to >> support? > There are still products shipping with 2.3 (e.g. RHEL4). I'd be > surprised if we need to go back before that. As far as Red Hat is concerned, we won't

Re: [HACKERS] 10 weeks to feature freeze (Pending Work)

2007-01-30 Thread Magnus Hagander
On Mon, Jan 29, 2007 at 12:44:51PM -0800, Henry B. Hotz wrote: > > On Jan 29, 2007, at 9:49 AM, Magnus Hagander wrote: > > >Henry B. Hotz wrote: > >>Henry B. Hotz: GSSAPI authentication method for C (FE/BE) and > >>Java (FE). > >>Magnus Haglander: SSPI (GSSAPI compatible) authentication metho

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Magnus Hagander
On Mon, Jan 29, 2007 at 09:56:16PM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > I'm thinking we need a check in elog.c on the: > > if ((!Redirect_stderr || am_syslogger) && pgwin32_is_service()) > > write_eventlog(edata->elevel, buf.data);

Re: [HACKERS] stack usage in toast_insert_or_update()

2007-01-30 Thread Tom Lane
"Pavan Deolasee" <[EMAIL PROTECTED]> writes: > The stack usage for toast_insert_or_update() may run into several KBs since > the MaxHeapAttributeNumber is set to a very large value of 1600. The usage > could anywhere between 28K to 48K depending on alignment and whether its a > 32-bit or a 64-bit m

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Andrew Dunstan
Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? There are still products shipping with 2.3 (e.g. RHEL4). I'd be surprised if we need to go back before that. cheers andrew ---(end of broadcast)

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Peter Eisentraut
Guido Goldstein wrote: > Is it possible to tell me which python versions you want to > support? The issue isn't so much which versions we want to support. There is certainly some flexibility with that. But when a patch breaks the buildfarm a) unannounced and b) without any apparent feature gai

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Guido Goldstein
Hi! Sorry for the late reply. On Thu, 25 Jan 2007 01:52:32 -0500 Tom Lane <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: >> Fix for plpython functions; return true/false for boolean, > > This patch has broken a majority of the buildfarm. > Is it possible to tell me wh

Re: [HACKERS] Bug? CREATE TABLE AS (... UNION ...)

2007-01-30 Thread Gregory Stark
"Gregory Stark" <[EMAIL PROTECTED]> writes: > Should I just copy the same code over or is anyone interested in refactoring > this? Or do I have it wrong somehow? Hm, it appears I have this wrong somehow since I can create tables using CREATE TABLE AS specifying tablespaces just fine. But I do't s

[HACKERS] Bug? CREATE TABLE AS (... UNION ...)

2007-01-30 Thread Gregory Stark
I think I found a bug, or at least a discrepancy. Afaict the transformSetOperationsStmt function should have identical code to transformSelectStmt outside of the operations affected by set operations. If that's the case then the SELECT INTO/CREATE TABLE AS code was not updated when last it was to

[HACKERS] stack usage in toast_insert_or_update()

2007-01-30 Thread Pavan Deolasee
Not sure whether its worth optimizing, but had spotted this while browsing the code a while back. So thought would post it anyways. The stack usage for toast_insert_or_update() may run into several KBs since the MaxHeapAttributeNumber is set to a very large value of 1600. The usage could anywhere