On Thu, 04 Sep 2008, Tom Lane <[EMAIL PROTECTED]> writes:
> This is not ready to go: you've lost the ability to localize most of
> the error message strings.
How can I make this available? What's your suggestion?
> Also, "char *msg" should be "const char *msg"
Done.
> if you're going to pass li
On Thu, 4 Sep 2008, Alvaro Herrera <[EMAIL PROTECTED]> writes:
> Cool, thanks. I had a look and you had some of the expected vs.
> returned reversed.
I'll happy to fix the reversed ones if you can report them in more
details.
Regards.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@post
"Brendan Jurd" <[EMAIL PROTECTED]> wrote:
> Josh assigned your patch to me for an initial review. Here's what I
> have so far.
Thank your for reviewing!
> The -T option seems to work as advertised, and I wasn't able to detect
> any performance degradation (or a significant variation of any kin
On Tue, Aug 19, 2008 at 12:24 PM, ITAGAKI Takahiro
<[EMAIL PROTECTED]> wrote:
> Ok, I rewrote the patch to use SIGALRM instead of gettimeofday.
>
Hi Itagaki-san,
Josh assigned your patch to me for an initial review. Here's what I
have so far.
The patch applies cleanly on the latest git HEAD, an
On Sep 4, 2008, at 21:40, Ryan Bradetich wrote:
Overall I think the patch looks good. After reviewing the patch, I
played with
citext for an hour or so and I did not encounter any bugs or other
surprises.
Thanks for the review, Ryan!
Best,
David
--
Sent via pgsql-hackers mailing list (p
Hello all,
Here is my review of the Test citext casts written by David Wheeler:
http://archives.postgresql.org/message-id/[EMAIL PROTECTED]
1. The patch applies cleanly to the latest GIT repository.
2. The citext type installs, uninstalls, and re-installs cleanly.
3. The coding style is mostly
On Fri, Sep 5, 2008 at 6:54 AM, Simon Riggs <[EMAIL PROTECTED]> wrote:
> On Thu, 2008-09-04 at 10:45 -0700, Josh Berkus wrote:
>
>> Please volunteer now!
>
> Everybody is stuck in "I'm not good enough to do a full review". They're
> right (myself included), so that just means we're organising it wr
After I disable SSL option in postgresql.conf the server is starting
successfully.
Please, advise.
Jan-Peter Seifert wrote:
Hello Andriy,
the reply-to settings are a bit uncomfortable here. Your mail went only
to me. But I'm not part of the developer or support team. It's strange
that pg_ctl
Tom Lane wrote:
Some other review nitpicking:
Thank you for your review. I really need all suggestions, since I never
posted any patch to the community before.
The next patch will emit the SET ROLE command in the generated dump,
as you and Stephen said. This will fit in my workflow too, si
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> I wasn't able to run the tests in contrib, I don't know why, and I have
> to go out now. I'll commit this tomorrow.
This is not ready to go: you've lost the ability to localize most of the
error message strings. Also, "char *msg" should be "const char
"Alex Hunsaker" <[EMAIL PROTECTED]> writes:
> I can happily through some hardware at this. Although
> "production-grade" is in the eye of the beholder...
I just posted a revised patch in the pgsql-patches thread.
regards, tom lane
--
Sent via pgsql-hackers mailing list (
On Thu, Sep 4, 2008 at 12:01 PM, Tom Lane <[EMAIL PROTECTED]> wrote:
> I think what the hash index patch really needs is some performance
> testing. I'm willing to take responsibility for the code being okay
> or not, but I haven't got any production-grade hardware to do realistic
> performance te
Thanks, I'll take a look at these issues.
-- Michelle
Alvaro Herrera wrote:
Michelle Caisse wrote:
I've attached a patch that allows the generation of code coverage
statistics. To test it, apply the patch, then:
autoconf
./configure --enable-coverage
make
make check (or execute any othe
Volkan YAZICI wrote:
> Made callers pass related error message as a string parameter, and
> appended required details using errdetail().
Cool, thanks. I had a look and you had some of the expected vs.
returned reversed. This patch should be OK. Amazingly, none of the
regression tests need chan
Michelle Caisse wrote:
> I've attached a patch that allows the generation of code coverage
> statistics. To test it, apply the patch, then:
>
> autoconf
> ./configure --enable-coverage
> make
> make check (or execute any other application against the database to see
> the coverage of that app)
The patch seems to be missing the new htup.c file.
Zdenek Kotala wrote:
Attached patch is prototype of in-place upgrade as was presented on
PGCon this year.
Main idea is to learn postgres to handle different version of page and
tuple structures.
1) page - Patch contains new page API and all
Simon Riggs <[EMAIL PROTECTED]> writes:
> On Thu, 2008-09-04 at 14:01 -0400, Tom Lane wrote:
>> If anyone is willing to do comparative performance testing, I'll
>> volunteer to make up two variant patches that do it both ways and
>> are otherwise equivalent.
> Why not do both, set via a reloption?
Zdenek Kotala wrote:
The original proposal
(http://archives.postgresql.org/message-id/[EMAIL PROTECTED])
contains two parts. First part is implementation of --footprint cmd line
switch which shows you page layout structures footprint. It is useful
for development (mostly for in-place upgrade)
On Thu, 2008-09-04 at 10:45 -0700, Josh Berkus wrote:
> We currently have 38 patches pending, and only nine people reviewing them.
> At this rate, the September commitfest will take three months.
>
> If you are a postgresql hacker at all, or even want to be one, we need your
> help reviewin
On Thu, 2008-09-04 at 14:01 -0400, Tom Lane wrote:
> If anyone is willing to do comparative performance testing, I'll
> volunteer to make up two variant patches that do it both ways and
> are otherwise equivalent.
Why not do both, set via a reloption? We can then set the default to
whichever win
On Thu, 4 Sep 2008, Kevin Grittner wrote:
Personally, I would take the "Min", "Default", and "Max" to mean what
Greg intends; it's the "Current" one that gives me pause.
That's the output of current_setting(name) which shows what it is right
now; no more, no less. See
http://www.postgresql.
Kenneth Marshall <[EMAIL PROTECTED]> writes:
> On Thu, Sep 04, 2008 at 02:01:18PM -0400, Tom Lane wrote:
>> I think what the hash index patch really needs is some performance
>> testing. I'm willing to take responsibility for the code being okay
>> or not, but I haven't got any production-grade ha
On Thu, Sep 04, 2008 at 02:01:18PM -0400, Tom Lane wrote:
> "Jonah H. Harris" <[EMAIL PROTECTED]> writes:
> > I'll push forward on reviewing and testing Xiao's hash index
> > improvements for inclusion into core. Though, someone will still need
> > to review my stuff.
>
> I think what the hash in
Heikki Linnakangas wrote:
I'll review the parser/planner changes from the current patch.
Looks pretty sane to me. Few issues:
Is it always OK to share a window between two separate window function
invocations, if they both happen to have identical OVER clause? It seems
OK for stable function
"Jonah H. Harris" <[EMAIL PROTECTED]> writes:
> I'll push forward on reviewing and testing Xiao's hash index
> improvements for inclusion into core. Though, someone will still need
> to review my stuff.
I think what the hash index patch really needs is some performance
testing. I'm willing to ta
On Thu, Sep 4, 2008 at 1:45 PM, Josh Berkus <[EMAIL PROTECTED]> wrote:
> We currently have 38 patches pending, and only nine people reviewing them.
> At this rate, the September commitfest will take three months.
I'll push forward on reviewing and testing Xiao's hash index
improvements for inclusi
Hackers,
We currently have 38 patches pending, and only nine people reviewing them.
At this rate, the September commitfest will take three months.
If you are a postgresql hacker at all, or even want to be one, we need your
help reviewing patches! There are several "easy" patches in the list
On Thu, 2008-09-04 at 21:03 +0800, Xiao Meng wrote:
> On Thu, Sep 4, 2008 at 10:06 AM, Simon Riggs <[EMAIL PROTECTED]>
> wrote:
> You don't give the text of the query used to do these
> performance tests,
>
> so I can't validate your test results.
>
> The attachme
Jaime,
* Jaime Casanova ([EMAIL PROTECTED]) wrote:
> On 7/25/08, Stephen Frost <[EMAIL PROTECTED]> wrote:
> > Yes, I'm working on it
>
> hi, any work on it? may i help?
If you look at the commitfest, I've posted my WIP so far there. Most of
the grammer, parser, and catalog changes are there. T
On Wed, Sep 3, 2008 at 7:03 PM, Tom Lane <[EMAIL PROTECTED]> wrote:
>
> In short, this patch isn't much more ready to commit than it was
> in the last fest.
>
Just for the record, i put this updated patch just because there were
an entry for "Extending grant insert on tables to sequences" for this
On Thu, 2008-09-04 at 12:18 -0400, Tom Lane wrote:
> Simon Riggs <[EMAIL PROTECTED]> writes:
> > I was thinking about what happens when you are performing a PITR using
> > log records that contain a crash/recovery/shutdown checkpoint sequence.
>
> > I take it there's no problem there?
>
> I don'
Simon Riggs <[EMAIL PROTECTED]> writes:
> I was thinking about what happens when you are performing a PITR using
> log records that contain a crash/recovery/shutdown checkpoint sequence.
> I take it there's no problem there?
I don't really see one. I believe the reason for the StartupCLOG action
M2Y <[EMAIL PROTECTED]> writes:
> I am a beginner to Postgres and I am going through code. I would like
> to know the debugging methods used in development.
> Some of my requirements are; for a given query, how parse structures
> are created in pg_parse_query, how they are analyzed and rewritten i
On Thu, 2008-09-04 at 11:12 -0400, Tom Lane wrote:
> Simon Riggs <[EMAIL PROTECTED]> writes:
> > I notice that StartupCLOG zeroes out entries later than the nextxid when
> > we complete recovery in StartupXLOG, reason given is safety in case we
> > crash.
>
> > ISTM that we should also do that wh
On Thu, Sep 04, 2008 at 07:01:18AM -0700, Steve Atkins wrote:
> Settings in postgresql.conf are currently case-insensitive. Except
> for the units.
And, of course, filenames when you are using a case-sensitive
filesystem. Because these are things that are defined by some
convention other than the
Simon Riggs <[EMAIL PROTECTED]> writes:
> I notice that StartupCLOG zeroes out entries later than the nextxid when
> we complete recovery in StartupXLOG, reason given is safety in case we
> crash.
> ISTM that we should also do that whenever we see a Shutdown Checkpoint
> in WAL, since that can be
On Thu, 2008-09-04 at 09:29 -0400, Andrew Sullivan wrote:
> On Thu, Sep 04, 2008 at 01:26:44AM +0300, Hannu Krosing wrote:
>
> > So Andrews opinion was that Mb (meaning Mbit) is different from MB (for
> > megabyte) and that if someone thinks that we define shared buffers in
> > megabits can get co
>>> Greg Smith <[EMAIL PROTECTED]> wrote:
> name | Recommended | Current | Min | Default | Max
> -+-+-+---+-+-
> wal_buffers | 1024kB | 64kB| 32 kB | 64 kB | 2048 MB
Personally, I would take the "Min", "Default", and
On Sep 4, 2008, at 6:29 AM, Andrew Sullivan wrote:
On Thu, Sep 04, 2008 at 01:26:44AM +0300, Hannu Krosing wrote:
So Andrews opinion was that Mb (meaning Mbit) is different from MB
(for
megabyte) and that if someone thinks that we define shared buffers in
megabits can get confused and order
Hi,
M2Y wrote:
I am a beginner to Postgres and I am going through code. I would like
to know the debugging methods used in development.
Try ./configure with '--enable-debug' and '--enable-cassert', as
outlined in the developer's FAQ [1], where you certainly find more
information as well. The
Hello,
I am a beginner to Postgres and I am going through code. I would like
to know the debugging methods used in development.
Some of my requirements are; for a given query, how parse structures
are created in pg_parse_query, how they are analyzed and rewritten in
pg_analyze_and_rewrite and how
Hello Srinivas,
M2Y wrote:
Markus: It looks like the hybrid approach used by Postgres-R(as
described in that paper) is good.
Well, yeah. That's why am working on it ;-)
You are very welcome to download the patch and dig into the sources. See
www.postgres-r.org for more information.
To answ
On Thu, Sep 04, 2008 at 01:26:44AM +0300, Hannu Krosing wrote:
> So Andrews opinion was that Mb (meaning Mbit) is different from MB (for
> megabyte) and that if someone thinks that we define shared buffers in
> megabits can get confused and order wrong kind of network card ?
I know it's fun to po
Hannu Krosing escribió:
> On Wed, 2008-09-03 at 20:01 -0400, Alvaro Herrera wrote:
> > Yes there is --- it's the SI.
> >
> > http://en.wikipedia.org/wiki/SI#SI_writing_style
> >
> > I don't know about it being "evil" and punishment, but it's wrong.
>
> SI defines decimal-based prefixes, where k
Hi,
I am writing you this mail, because I am currently using xml2 functionality
in PostgreSQL 8.3.x and want to substitute it by the newer API as mentioned
here:
>From PostgreSQL 8.3 on, there is XML-related functionality based on the
SQL/XML standard in the core server. That functionality
On Thu, Sep 4, 2008 at 10:06 AM, Simon Riggs <[EMAIL PROTECTED]> wrote:
> You don't give the text of the query used to do these performance tests,
> so I can't validate your test results.
>
The attachment is the code to generate the text.
Just
$g++ my-permu-code.cpp
$./a.out > /tmp/words
--
Bes
Thank you very much Robert and Markus.
> What kind of replication are you interested in?
>
Markus: It looks like the hybrid approach used by Postgres-R(as
described in that paper) is good.
Thanks,
Srinivas
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
Hitoshi Harada wrote:
BTW, I think it is better to put together the discussion points we
have done as "general roadmap to complete window functions". It is not
about the features for the next release but is the complete tasks.
Where to go? Wiki, or my design docs?
That's up to you, really. I li
On Thu, 2008-09-04 at 11:07 +0300, Heikki Linnakangas wrote:
> Thanks for the review!
Not as thorough as I would have liked, I must admit.
Thanks for the other confirmations.
> Scenario: The binary tree on a page is corrupt, so that the value of an
> upper node is > Max(leftchild, rightchild).
Hello Srinivas,
M2Y wrote:
My basic question is: in multimaster replication, if each site goes
ahead and does the modifications issued by the transaction and then
sends the writeset to others in the group, how the ACID properties be
maintained?
Well, there are different approaches. With regard
I notice that StartupCLOG zeroes out entries later than the nextxid when
we complete recovery in StartupXLOG, reason given is safety in case we
crash.
ISTM that we should also do that whenever we see a Shutdown Checkpoint
in WAL, since that can be caused by a shutdown immediate, shutdown abort
or
Thanks for the review!
Simon Riggs wrote:
Can I check some aspects of this related to Hot Standby? Some of them
sound obvious, but worth double checking.
* There will be no need to read FSM by any normal operation of a
read-only transaction, so locking correctness considerations can
possibly be
Le jeudi 04 septembre 2008, Robert Treat a écrit :
> To paraphrase, "if you can't write a config file correctly before
> restarting, I do not want you anywhere near any instance of a production
> system"
Do you really want to TCO of PostgreSQL to raise that much when the software
could help lower
53 matches
Mail list logo
