Re: [HACKERS] posix_fadvise v22

2009-01-11 Thread Gregory Stark
Tom Lane writes: > "Robert Haas" writes: >> OK, here's an update of Greg's patch with the runtime configure test >> ripped out, some minor documentation tweaks, and a few unnecessary >> whitespace diff hunks quashed. I think this is about ready for >> committer review. > > I've applied most of

Re: [HACKERS] posix_fadvise v22

2009-01-11 Thread Tom Lane
"Robert Haas" writes: > OK, here's an update of Greg's patch with the runtime configure test > ripped out, some minor documentation tweaks, and a few unnecessary > whitespace diff hunks quashed. I think this is about ready for > committer review. I've applied most of this, with a couple of notab

Re: [HACKERS] Documenting pglesslog

2009-01-11 Thread Robert Haas
> In general, IMHO, I don't think it's a good direction to go in to > include links to works of other copyright holders. I think it's a great idea. IMHO, one of the major selling points of PostgreSQL is its awesome documentation. However, one of its weaknesses is that contrib module, pgfoundry p

Re: [HACKERS] autovacuum and reloptions

2009-01-11 Thread Robert Haas
On Sun, Jan 11, 2009 at 6:47 PM, Euler Taveira de Oliveira wrote: > Robert Haas escreveu: >> Several things related to this patch have been committed: >> >> http://archives.postgresql.org/message-id/20081219143958.6f2dd756...@cvs.postgresql.org >> http://archives.postgresql.org/message-id/20090105

Re: [HACKERS] autovacuum and reloptions

2009-01-11 Thread Euler Taveira de Oliveira
Robert Haas escreveu: > Several things related to this patch have been committed: > > http://archives.postgresql.org/message-id/20081219143958.6f2dd756...@cvs.postgresql.org > http://archives.postgresql.org/message-id/20090105171428.77b29754...@cvs.postgresql.org > (and several follow-on commits)

Re: [HACKERS] Review: B-Tree emulation for GIN

2009-01-11 Thread Jeff Davis
sion > of the patch because I thought you may have some reason for using it. > Attached an updated patch with this change. Regards, Jeff Davis btree-gin.20090111.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

Re: [HACKERS] posix_fadvise v22

2009-01-11 Thread Tom Lane
"Robert Haas" writes: > FWIW, following your first set of commits, I extracted, cleaned up, > and re-posted the uncommitted portion of the patch last night. Based > on this it doesn't sound like there's much point in continuing to do > that, but I'm happy to do so if anyone thinks otherwise. Pro

Re: [HACKERS] posix_fadvise v22

2009-01-11 Thread Gregory Stark
Tom Lane writes: > "Robert Haas" writes: >> OK, here's an update of Greg's patch with the runtime configure test >> ripped out, some minor documentation tweaks, and a few unnecessary >> whitespace diff hunks quashed. I think this is about ready for >> committer review. > > I've started to look

Re: [HACKERS] foreign_data test fails with non-C locale

2009-01-11 Thread Devrim GÜNDÜZ
On Sun, 2009-01-11 at 11:46 -0500, Tom Lane wrote: > If we try to fix those cases I think we should try to fix Turkish i > as well ... but I concur that first requires determining if it's > behaving wrong or not. Devrim, or someone? What exactly do you want to see? Regards, -- Devrim GÜNDÜZ, R

Re: [HACKERS] posix_fadvise v22

2009-01-11 Thread Robert Haas
> * As coded, it generates prefetch bursts that are much too large and too > widely spaced to be effective, not to mention that they entirely > ignore the effective_io_concurrency control knob as well as the order > in which the pages will actually be needed. I wonder now whether > Robert's inabil

Re: [HACKERS] foreign_data test fails with non-C locale

2009-01-11 Thread Devrim GÜNDÜZ
On Sun, 2009-01-11 at 12:54 +0200, Peter Eisentraut wrote: > The "Turkish i" failures are in the tsearch tests. I'm not completely > comfortable that it's doing the right thing there. AFAIK, ISO-8859-9 is broken in a way, and the Turkish maintainers are not interested in fixing them -- they ask u

Re: [HACKERS] Recovery Test Framework

2009-01-11 Thread Robert Haas
On Sun, Jan 11, 2009 at 12:07 PM, Tom Lane wrote: > Simon Riggs writes: >> Recovery doesn't have a test framework as yet. I would like to add one >> for this release, especially since we have so much recovery-related code >> being added to the release (and manual testing is so time consuming). >

Re: [HACKERS] posix_fadvise v22

2009-01-11 Thread Tom Lane
"Robert Haas" writes: > OK, here's an update of Greg's patch with the runtime configure test > ripped out, some minor documentation tweaks, and a few unnecessary > whitespace diff hunks quashed. I think this is about ready for > committer review. I've started to look through this, and the only p

Re: [HACKERS] pgsql: Re-enable the old code in xlog.c that tried to use

2009-01-11 Thread Gregory Stark
t...@postgresql.org (Tom Lane) writes: > Log Message: > --- > Re-enable the old code in xlog.c that tried to use posix_fadvise(), so that > we can get some buildfarm feedback about whether that function is still > problematic. (Note that the planned async-preread patch will not really >

Re: [HACKERS] Recovery Test Framework

2009-01-11 Thread Tom Lane
Simon Riggs writes: > Recovery doesn't have a test framework as yet. I would like to add one > for this release, especially since we have so much recovery-related code > being added to the release (and manual testing is so time consuming). I've been thinking for some time that putting replication

Re: [HACKERS] foreign_data test fails with non-C locale

2009-01-11 Thread Tom Lane
Peter Eisentraut writes: > This called for an extensive test ... :-) > My glibc installation supplies 668 locales (locale -a), which appear to > represent about 225 distinct language/country combinations. (The rest are > encoding variants.) > I ran the regression tests with all of them, and g

[HACKERS] Recovery Test Framework

2009-01-11 Thread Simon Riggs
Recovery doesn't have a test framework as yet. I would like to add one for this release, especially since we have so much recovery-related code being added to the release (and manual testing is so time consuming). Testing Hot Standby will also test sync rep, PITR etc, and could easily uncover a few

Re: [HACKERS] Synch Rep v5

2009-01-11 Thread Simon Riggs
On Sun, 2009-01-11 at 15:11 +0900, Fujii Masao wrote: > Yes, using semaphores for the communication is also my first approach. > The problem of this approach is that walsender cannot wait for both > signal from backends and the response from walreceiver concurrently, > because > wait-for-semaphor

Re: [HACKERS] Synch Rep v5

2009-01-11 Thread Simon Riggs
On Sun, 2009-01-11 at 17:19 +0900, Fujii Masao wrote: > Thanks for your comments! > > On Sat, Jan 10, 2009 at 10:36 PM, Simon Riggs wrote: > > I notice we use the same settings for keepalives. We may need that to be > > a second set of parameters. > > Or, we should make walreceiver execute "SE

Re: [HACKERS] Documenting pglesslog

2009-01-11 Thread Simon Riggs
On Sun, 2009-01-11 at 09:47 -0500, Bruce Momjian wrote: > Simon Riggs wrote: > > > > On Sat, 2009-01-10 at 23:38 -0500, Bruce Momjian wrote: > > > > > It is BSD licensed. I don't see any copyright issues: > > > > > A licence and copyright are different things. Why do we insist on > > changing

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-11 Thread Hiroshi Inoue
Hiroshi Inoue wrote: Bruce Momjian wrote: Hiroshi, is this patch still needed? Yes though it should be slightly changed now. *set lc_messages does not work* issue isn't directly related to this issue. Though I'm not sure how we can test it, I can provide test results like the attached one.

Re: [HACKERS] Documenting pglesslog

2009-01-11 Thread Bruce Momjian
Simon Riggs wrote: > > On Sat, 2009-01-10 at 23:38 -0500, Bruce Momjian wrote: > > > It is BSD licensed. I don't see any copyright issues: > > > > http://pglesslog.projects.postgresql.org/ > > A licence and copyright are different things. Why do we insist on > changing copyright on our cod

Re: [HACKERS] Time to finalize patches for 8.4 beta

2009-01-11 Thread Gianni Ciolli
Dear Josh, On Mon, Jan 05, 2009 at 05:12:27PM -0800, Josh Berkus wrote: > -- On-Disk Bitmap Index (Gianni says new patch in a week.) while we are still working on the issues raised on pgsql-hackers, at this point it looks like that we will not be able to resolve all of them in time for the 8.4 r

Re: [HACKERS] Hot standby, slot ids and stuff

2009-01-11 Thread Simon Riggs
On Sun, 2009-01-11 at 10:41 +0200, Heikki Linnakangas wrote: > Simon Riggs wrote: > > There's a confusion in the patch between top level xid and parent xid. > > The xl field is named parentxid but actually contains top level. That > > distinction is important because the code now uses the top leve

Re: [HACKERS] foreign_data test fails with non-C locale

2009-01-11 Thread Peter Eisentraut
On Friday 09 January 2009 18:24:55 Tom Lane wrote: > I don't think we are prepared to buy into a general policy that the > regression tests should pass in *any* locale; maintaining a large > number of variant expected-files isn't very practical. However, the > de facto policy is that we try to kee

Re: [HACKERS] Multiplexing SUGUSR1

2009-01-11 Thread Fujii Masao
Hi, On Thu, Jan 8, 2009 at 2:14 AM, Bruce Momjian wrote: > Greg Stark wrote: >> >> On 7 Jan 2009, at 09:47, Bruce Momjian wrote: >> >> > Heikki Linnakangas wrote: >> >> It's required by the sync replication patch, but has no value >> >> otherwise. >> > >> > Well, we have talked about allowing mo

Re: [HACKERS] Synch Rep v5

2009-01-11 Thread Fujii Masao
Hi, Thanks for your comments! On Sat, Jan 10, 2009 at 10:36 PM, Simon Riggs wrote: > I notice we use the same settings for keepalives. We may need that to be > a second set of parameters. Or, we should make walreceiver execute "SET tcp_keepalives_xxx TO yyy" before starting replication if such

Re: [HACKERS] Hot standby, slot ids and stuff

2009-01-11 Thread Heikki Linnakangas
Simon Riggs wrote: There's a confusion in the patch between top level xid and parent xid. The xl field is named parentxid but actually contains top level. That distinction is important because the code now uses the top level xid to locate the recovery proc, formerly the role of the slotid. True

Re: [HACKERS] Solve a problem of LC_TIME of windows.

2009-01-11 Thread Hiroshi Saito
Ops,my mistake in the mail thread.:-( sorry. === send the mistake other thread == Hi. My swift attack test was the MinGW environment. But, Inoue-san suggestion. 1. MinGW+gcc build HIROSHI=# set LC_TIME=Ja; SET HIROSHI=# select to_char(now(),'TMDay'); to_char - 日曜日 (1 行) HIROSHI=# s

Re: [HACKERS] Documenting pglesslog

2009-01-11 Thread Joshua D. Drake
On Sun, 2009-01-11 at 03:12 +, Simon Riggs wrote: > On Sat, 2009-01-10 at 21:09 -0500, Bruce Momjian wrote: > > > Comments? > > If this is for backpatching, it makes sense. We should at least wait > until sync rep is accepted or rejected and docs written. Why? Even if sync rep is accepted, p

Re: [HACKERS] foreign_data test fails with non-C locale

2009-01-11 Thread Peter Eisentraut
On Friday 09 January 2009 16:51:44 Peter Eisentraut wrote: > Heikki Linnakangas wrote: > > The foreign_data test case is failing when I run "make installcheck" > > against a server that's been initialized with a locale other than C > > (en_GB.UTF-8). > > I have removed one of the differences but ca

Re: [HACKERS] Documenting pglesslog

2009-01-11 Thread Simon Riggs
On Sat, 2009-01-10 at 23:38 -0500, Bruce Momjian wrote: > It is BSD licensed. I don't see any copyright issues: > > http://pglesslog.projects.postgresql.org/ A licence and copyright are different things. Why do we insist on changing copyright on our code if it is unimportant? -- Simon