Hi Peter,
I'm reviewing this patch as part of CommitFest 2011-01.
On Fri, Jan 14, 2011 at 11:41:46PM +0200, Peter Eisentraut wrote:
> I've been going over this patch with a fine-tooth comb for the last two
> weeks, fixed some small bugs, added comments, made initdb a little
> friendlier, but no s
On Sat, Jan 29, 2011 at 6:02 AM, Heikki Linnakangas
wrote:
> On 27.01.2011 06:44, Fujii Masao wrote:
>>
>> + XLByteToSeg(endptr, endlogid, endlogseg);
>>
>> + /* Have we reached our stop position yet? */
>> + if (logid> endlogid ||
>> +
On Thu, Jan 27, 2011 at 09:18:23AM -0800, Jeff Davis wrote:
> On Tue, 2011-01-25 at 05:57 -0500, Dan Ports wrote:
> > This summary is right on. I would add one additional detail or
> > clarification to the last point, which is that rather than checking for
> > a cycle, we're checking for a transact
Magnus Hagander wrote:
> I just tried doing pg_upgrade on a database when logged in as user
> "mha" rather than "postgres" on my system. And it failed. Even though
> the db was initialized with superuser "mha". The reason for this was
> that pg_upgrade tried to connect to the database "mha" (hardco
Itagaki,
* Itagaki Takahiro (itagaki.takah...@gmail.com) wrote:
> Discussions
> * How about "csvlog_fields" rather than "log_csv_fields"?
> Since we have variables with syslog_ prefix, csvlog_ prefix
> seems to be better.
Sure, not a big deal, to be honest, as long as we can actuall
The people who write my paychecks have insisted on me chunking out
some items which are part of our long-term plan besides the one I've
been focusing on lately. Most of it isn't of interest to anyone
outside Wisconsin Courts, but this piece might be; so I'm posting it
and putting onto the first 9.
On 01/28/2011 05:34 PM, Tom Lane wrote:
Andrew Dunstan writes:
On 01/28/2011 03:11 PM, Tom Lane wrote:
Are any of them substantive, or are they all about %m ?
[andrew@aurelia ]$ grep 'warning.*format' frogmouth-make*.log | sed
's/.*warning:/warning:/' | sort | uniq -c
I'd say a lot of tho
> When that was fixed, I realized the psql command to create the
> datanbases connect to database "template1" only to immediately switch
> to database "postgres", which also seems rather pointless.
>
> Attach patch makes it connect to the "postgres" database instead of
> $USER, and then also chan
On 01/28/2011 02:39 PM, Peter Eisentraut wrote:
On fre, 2011-01-28 at 14:12 -0500, Andrew Dunstan wrote:
We have had format warnings in mingw builds for years, and it doesn't
look like we're ever going to do anything about them. Can we just add
-Wno-format to the CFLAGS for Mingw and be done w
Andrew Dunstan writes:
> On 01/28/2011 03:11 PM, Tom Lane wrote:
>> Are any of them substantive, or are they all about %m ?
> [andrew@aurelia ]$ grep 'warning.*format' frogmouth-make*.log | sed
> 's/.*warning:/warning:/' | sort | uniq -c
I'd say a lot of those probably need attention. It migh
On 01/28/2011 03:11 PM, Tom Lane wrote:
Andrew Dunstan writes:
We have had format warnings in mingw builds for years, and it doesn't
look like we're ever going to do anything about them. Can we just add
-Wno-format to the CFLAGS for Mingw and be done with them?
Are any of them substantive, o
On Thu, Jan 27, 2011 at 03:38, Alexey Klyukin wrote:
> Hi,
>
> On Jan 27, 2011, at 9:31 AM, Alex Hunsaker wrote:
>
>> Find attached v3 of the patch. changes include:
>> - fix deep recursion due to accidental reversal of check in
>> encode_array_literal
>> - add proper support for stringifying co
I just tried doing pg_upgrade on a database when logged in as user
"mha" rather than "postgres" on my system. And it failed. Even though
the db was initialized with superuser "mha". The reason for this was
that pg_upgrade tried to connect to the database "mha" (hardcoded to
be the db username), and
On 28 January 2011 20:28, Thom Brown wrote:
> On 28 January 2011 07:45, Jeff Davis wrote:
>> Updated patch.
>>
>> Changes:
>>
>> * Documentation for operators/functions
>> * a comprehensive set of operators and functions
>> * BTree opclass
>> * Hash opclass
>> * built-in range types:
>> -
On Fri, Jan 28, 2011 at 01:52:32PM -0500, Robert Haas wrote:
> On Wed, Jan 26, 2011 at 6:06 PM, Tom Lane wrote:
> > I'm not sure how important that concern is though, because it's hard to
> > see how any such change wouldn't break existing cast implementation
> > functions anyway. ?If the API for
On 27.01.2011 06:44, Fujii Masao wrote:
+ XLByteToSeg(endptr, endlogid, endlogseg);
+ /* Have we reached our stop position yet? */
+ if (logid> endlogid ||
+ (logid == endlogid&& logseg>= endlogseg))
+
On Fri, Jan 28, 2011 at 21:04, Robert Haas wrote:
> On Sat, Jan 22, 2011 at 9:11 PM, Robert Haas wrote:
>> It seems no one wants to put any further effort into this problem. Bummer.
>
> Since no one has felt the need to dispute the above statement in the
> last 6 days, it seems clear to mark thi
On Thu, Jan 13, 2011 at 23:58, Alvaro Herrera
wrote:
> It goes like this: instead of acquiring a shared lock on the involved
> tuple, we only acquire a "key lock", that is, something that prevents
> the tuple from going away entirely but not from updating fields that are
> not covered by any uniqu
On Fri, Jan 28, 2011 at 3:08 PM, Tom Lane wrote:
> Robert Haas writes:
>> Any substantive comments, besides the obvious "this is not 9.1 material"?
>
> Now that I've absorbed a bit more caffeine, let's see if I can think
> straight this time.
>
> General principle you want to assert: any WAL entr
On 28 January 2011 07:45, Jeff Davis wrote:
> Updated patch.
>
> Changes:
>
> * Documentation for operators/functions
> * a comprehensive set of operators and functions
> * BTree opclass
> * Hash opclass
> * built-in range types:
> - PERIOD (timestamp)
> - PERIODTZ (timestamptz)
> -
pg...@j-davis.com (Jeff Davis) writes:
> On Fri, 2011-01-28 at 09:17 -0800, David Fetter wrote:
>> For consistency, and in order not to continue our atrocious naming
>> tradition, I'd like to propose that the above be named timestamprange
>> (tsrange for short) and timestamptzrange (tstzrange for
Andrew Dunstan writes:
> We have had format warnings in mingw builds for years, and it doesn't
> look like we're ever going to do anything about them. Can we just add
> -Wno-format to the CFLAGS for Mingw and be done with them?
Are any of them substantive, or are they all about %m ?
Robert Haas writes:
> Any substantive comments, besides the obvious "this is not 9.1 material"?
Now that I've absorbed a bit more caffeine, let's see if I can think
straight this time.
General principle you want to assert: any WAL entry that merely results
in setting a deterministic field to a d
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/28/2011 23:23, Andrew Dunstan wrote:
>
>
> On 01/28/2011 08:09 AM, JonY wrote:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> On 1/28/2011 18:19, Andrew Dunstan wrote:
configure:7071: checking for zic
configure:7104: result:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/28/2011 18:19, Andrew Dunstan wrote:
>> configure:7071: checking for zic
>> configure:7104: result: no
>> configure:7113: error:
>> When cross-compiling, either use the option --with-system-tzdata to use
>> existing time-zone data, or set the envi
On fre, 2011-01-28 at 14:12 -0500, Andrew Dunstan wrote:
> We have had format warnings in mingw builds for years, and it doesn't
> look like we're ever going to do anything about them. Can we just add
> -Wno-format to the CFLAGS for Mingw and be done with them?
I wasn't aware of this issue, but
2011/1/28 Robert Haas :
> On Tue, Jan 25, 2011 at 11:29 AM, Pavel Stehule
> wrote:
>> variant a) my first patch - detoast on first usage with avoiding to
>> useless detoast checking
>> variant b) my first patch - detoast on first usage without avoiding to
>> useless detoast checking
>>
>> time fo
We have had format warnings in mingw builds for years, and it doesn't
look like we're ever going to do anything about them. Can we just add
-Wno-format to the CFLAGS for Mingw and be done with them?
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Fri, Jan 28, 2011 at 1:42 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Fri, Jan 28, 2011 at 10:13 AM, Tom Lane wrote:
>>> Say what? A heap deletion compacts the page --- it will certainly fail
>>> badly on torn-page.
>
>> What do you mean by "compacts the page"? I would interpret that to
On Tue, Jan 25, 2011 at 11:29 AM, Pavel Stehule wrote:
> variant a) my first patch - detoast on first usage with avoiding to
> useless detoast checking
> variant b) my first patch - detoast on first usage without avoiding to
> useless detoast checking
>
> time for 1 - about 300 ms, a is bout 1.5%
On Sat, Jan 22, 2011 at 9:11 PM, Robert Haas wrote:
> It seems no one wants to put any further effort into this problem. Bummer.
Since no one has felt the need to dispute the above statement in the
last 6 days, it seems clear to mark this Returned with Feedback, which
I have now done.
--
Rober
On Wed, Jan 26, 2011 at 6:06 PM, Tom Lane wrote:
> I'm not sure how important that concern is though, because it's hard to
> see how any such change wouldn't break existing cast implementation
> functions anyway. If the API for length-coercing cast functions
> changes, breaking their helper funct
Robert Haas writes:
> On Fri, Jan 28, 2011 at 10:13 AM, Tom Lane wrote:
>> Say what? A heap deletion compacts the page --- it will certainly fail
>> badly on torn-page.
> What do you mean by "compacts the page"? I would interpret that to
> mean "reclaims the space formerly used by the tuple be
On Jan 28, 2011, at 9:48 AM, Jeff Davis wrote:
> On Fri, 2011-01-28 at 09:17 -0800, David Fetter wrote:
>> For consistency, and in order not to continue our atrocious naming
>> tradition, I'd like to propose that the above be named timestamprange
>> (tsrange for short) and timestamptzrange (tstzra
On Fri, Jan 28, 2011 at 10:13 AM, Tom Lane wrote:
> Robert Haas writes:
>> I was thinking about full-page writes again tonight. I'm still
>> wondering about the feasibility of getting rid of full-page writes for
>> certain operations. We can do this, I think, in any case where we can
>> convinc
Jeff Davis writes:
> On Fri, 2011-01-28 at 09:17 -0800, David Fetter wrote:
>> For consistency, and in order not to continue our atrocious naming
>> tradition, I'd like to propose that the above be named timestamprange
>> (tsrange for short) and timestamptzrange (tstzrange for short).
> No real o
On Fri, 2011-01-28 at 09:17 -0800, David Fetter wrote:
> For consistency, and in order not to continue our atrocious naming
> tradition, I'd like to propose that the above be named timestamprange
> (tsrange for short) and timestamptzrange (tstzrange for short).
No real objection, but I'd like to s
On Thu, Jan 27, 2011 at 11:45:30PM -0800, Jeff Davis wrote:
> Updated patch.
>
> Changes:
>
> * Documentation for operators/functions
> * a comprehensive set of operators and functions
> * BTree opclass
Yay!
> * Hash opclass
> * built-in range types:
> - PERIOD (timestamp)
> -
On Tue, 2011-01-25 at 15:22 -0600, Kevin Grittner wrote:
> Jeff Davis wrote:
>
> > I think just annotating RWConflict.in/outLink and
> > PredTranList.available/activeList with the types of things they
> > hold would be a help.
> >
> > Also, you say something about RWConflict and "when the struc
I did s/failover/promote. Here is the updated patch.
>>>
>>> I rebased the patch to current git master.
>>
>> I'm thinking about implementing a function which does a promotion for
>> the standby. It will make pgpool lot easier to control the promotion
>> since it allow to fire the promotion op
Robert Haas writes:
> On Fri, Jan 28, 2011 at 3:40 AM, Tatsuo Ishii wrote:
Agreed. I submitted the patch before, but I forgot to update it
and add it to CF.
http://archives.postgresql.org/message-id/aanlktimuhbxbum+zlkaex3adqseimue3xb4ww1qts...@mail.gmail.com
>>
>> Great!
> I hat
On 01/28/2011 08:09 AM, JonY wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/28/2011 18:19, Andrew Dunstan wrote:
configure:7071: checking for zic
configure:7104: result: no
configure:7113: error:
When cross-compiling, either use the option --with-system-tzdata to use
existing time-
Robert Haas writes:
> I was thinking about full-page writes again tonight. I'm still
> wondering about the feasibility of getting rid of full-page writes for
> certain operations. We can do this, I think, in any case where we can
> convince ourselves that if the original operation, or a redo of
2011-01-27 16:24 keltezéssel, Tom Lane írta:
> Boszormenyi Zoltan writes:
>> I get reproducible "make -j2" compile error in ecpg/pgtypeslib.
> FWIW, I can't reproduce that at all, either at -j2 or -j4, on either
> Fedora 13 or Fedora 14.
>
> regards, tom lane
FWIW, I run "ma
On Fri, Jan 28, 2011 at 3:40 AM, Tatsuo Ishii wrote:
>> On Fri, Jan 28, 2011 at 4:57 PM, Magnus Hagander wrote:
>>> On Fri, Jan 28, 2011 at 08:44, Tatsuo Ishii wrote:
>> I did s/failover/promote. Here is the updated patch.
>
> I rebased the patch to current git master.
I'm
On 01/27/2011 10:51 PM, Xiaobo Gu wrote:
On Fri, Jan 28, 2011 at 11:44 AM, Andrew Dunstan wrote:
>
>
> On 01/27/2011 10:37 PM, Xiaobo Gu wrote:
>>
>> --with-system-tzdata=/usr/share/zoneinfo
>
> Why on earth are you doing this on Windows? That's crazy. Did you run "make
> check"? You sh
> On Fri, Jan 28, 2011 at 4:57 PM, Magnus Hagander wrote:
>> On Fri, Jan 28, 2011 at 08:44, Tatsuo Ishii wrote:
> I did s/failover/promote. Here is the updated patch.
I rebased the patch to current git master.
>>>
>>> I'm thinking about implementing a function which does a promotion
On Fri, Jan 28, 2011 at 4:57 PM, Magnus Hagander wrote:
> On Fri, Jan 28, 2011 at 08:44, Tatsuo Ishii wrote:
I did s/failover/promote. Here is the updated patch.
>>>
>>> I rebased the patch to current git master.
>>
>> I'm thinking about implementing a function which does a promotion for
>>
On 1/23/2011 4:24 AM, Robert Haas wrote:
On Thu, Jan 20, 2011 at 5:22 AM, Marko Tiikkaja
wrote:
On 2011-01-17 9:28 AM +0200, Itagaki Takahiro wrote:
== Coding ==
I expect documentation will come soon.
I'm sorry about this, I have been occupied with other stuff. I'm going to
work on this to
> On Fri, Jan 28, 2011 at 08:44, Tatsuo Ishii wrote:
I did s/failover/promote. Here is the updated patch.
>>>
>>> I rebased the patch to current git master.
>>
>> I'm thinking about implementing a function which does a promotion for
>> the standby. It will make pgpool lot easier to control th
50 matches
Mail list logo
