Re: [HACKERS] SECURITY LABEL on shared database object

2011-07-02 Thread Kohei KaiGai
2011/7/2 Tom Lane t...@sss.pgh.pa.us: Kohei KaiGai kai...@kaigai.gr.jp writes: The origin of matter is, as you mentioned, collation to be used for system catalog scan when we reference it via syscache. So, the following chunk should be added, as I did in the userspace access vector patch -

Re: [HACKERS] Parameterized aggregate subquery (was: Pull up aggregate subquery)

2011-07-02 Thread Hitoshi Harada
2011/6/29 Yeb Havinga yebhavi...@gmail.com: On 2011-06-17 09:54, Hitoshi Harada wrote: While reviewing the gist/box patch, I found some planner APIs that can replace parts in my patch. Also, comments in includes wasn't updated appropriately. Revised patch attached. Hello Hitoshi-san, I

Re: [HACKERS] Parameterized aggregate subquery (was: Pull up aggregate subquery)

2011-07-02 Thread Hitoshi Harada
2011/7/2 Hitoshi Harada umi.tan...@gmail.com: 2011/6/29 Yeb Havinga yebhavi...@gmail.com: On 2011-06-17 09:54, Hitoshi Harada wrote: While reviewing the gist/box patch, I found some planner APIs that can replace parts in my patch. Also, comments in includes wasn't updated appropriately.

[HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-07-02 Thread Craig Ringer
Hi I'm getting set up to test your VS 2010 support patches. Sorry it's taken me so long - work decided to take this opportunity to become ... rather hectic. I'd appreciate it if you'd post the config.pl you're building with, mainly so I can see what libraries and optional features you are

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-07-02 Thread Kohei KaiGai
The attached patch re-defines pg_seclabel.provider as NameData, instead of Text, and revert changes of catcache.c about collations; to keep consistency with the security label support on shared objects. All the format changes are hidden by (Get|Set)SecurityLabel(), so no need to change on the

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-02 Thread Kohei KaiGai
I was referring to this paragraph: ?On the technical side, I am pretty doubtful that the approach of adding a ?nestlevel to FuncExpr and RelOptInfo is the right way to go. ?I believe we ?have existing code (to handle left joins) that prevents quals from being ?pushed down too far by

[HACKERS] Re: pg_terminate_backend and pg_cancel_backend by not administrator user

2011-07-02 Thread Noah Misch
On Fri, Jul 01, 2011 at 07:31:30PM +0200, Torello Querci wrote: 2011/6/2 Noah Misch n...@leadboat.com: Having thought about this some more, I do now see a risk. ?Currently, a SECURITY DEFINER function (actually any function, but that's where it matters) can trap query_canceled. ?By

Re: [HACKERS] time-delayed standbys

2011-07-02 Thread Simon Riggs
On Thu, Jun 30, 2011 at 6:25 PM, Robert Haas robertmh...@gmail.com wrote: I think the time problems are more complex than said. The patch relies upon transaction completion times, but not all WAL records have a time attached to them. Plus you only used commits anyway, not sure why. For the

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-02 Thread Noah Misch
On Sat, Jul 02, 2011 at 12:48:32PM +0200, Kohei KaiGai wrote: Let's see. ?Every qual list will have some depth d such that all quals having depth = d are security-relevant, and all others are not security-relevant. (This does not hold for all means of identifying security-relevant quals,

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-02 Thread Andres Freund
On Saturday, July 02, 2011 06:10:43 AM Tom Lane wrote: I wouldn't have a problem with establishing a convention that we write credits in commit messages in a more standardized way, ie put something like Author: Joe Blow j...@blow.nom in the body of the commit message. However, the points that

[HACKERS] clean.pl on Windows fails to remove flex output

2011-07-02 Thread Craig Ringer
Hi folks I've noticed while testing the VC 2010 patches that clean.pl in src/tools/msvc doesn't remove files generated by flex. I landed up with a broken configuration while testing my x64 builds that caused the creation of zero-size outputs for bootscanner.c etc. These weren't re-generated

Re: [HACKERS] clean.pl on Windows fails to remove flex output

2011-07-02 Thread Magnus Hagander
On Sat, Jul 2, 2011 at 17:51, Craig Ringer cr...@postnewspapers.com.au wrote: Hi folks I've noticed while testing the VC 2010 patches that clean.pl in src/tools/msvc doesn't remove files generated by flex. I landed up with a broken configuration while testing my x64 builds that caused the

Re: [HACKERS] clean.pl on Windows fails to remove flex output

2011-07-02 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Sat, Jul 2, 2011 at 17:51, Craig Ringer cr...@postnewspapers.com.au wrote: I've noticed while testing the VC 2010 patches that clean.pl in src/tools/msvc doesn't remove files generated by flex. clean.pl? I don't even have that file, I only have

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-02 Thread Kohei KaiGai
BTW, regarding to the statement support for security barrier views, the following syntax might be more consistent with existing ones: CREATE VIEW view_name WITH ( param [=value]) AS query ... ; rather than CREATE SECURITY VIEW view_name AS query ...; Any comments? 2011/7/2 Noah Misch

Re: Optimizing pg_trgm makesign() (was Re: [HACKERS] WIP: Fast GiST index build)

2011-07-02 Thread Tom Lane
I wrote: I tweaked the patch a bit further (don't pessimize the boundary case where there's exactly 4n+1 trigrams, avoid forcing trg1 into memory, improve the comment) and attach that version below. This is a little bit faster but I still wonder if it's worth the price of adding an obscure

Re: Optimizing pg_trgm makesign() (was Re: [HACKERS] WIP: Fast GiST index build)

2011-07-02 Thread Heikki Linnakangas
On 02.07.2011 21:07, Tom Lane wrote: I wrote: I tweaked the patch a bit further (don't pessimize the boundary case where there's exactly 4n+1 trigrams, avoid forcing trg1 into memory, improve the comment) and attach that version below. This is a little bit faster but I still wonder if it's

Re: Optimizing pg_trgm makesign() (was Re: [HACKERS] WIP: Fast GiST index build)

2011-07-02 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Ah, that opens the door to do something I considered earlier but rejected because of alignment: instead of three 32-bit word fetches, we could fetch one 64-bit word and 32-bit word. Might shave a few more cycles... Hm ... I

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-02 Thread Robert Haas
On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: BTW, regarding to the statement support for security barrier views, the following syntax might be more consistent with existing ones:  CREATE VIEW view_name WITH ( param [=value]) AS query ... ; rather than  CREATE

Re: [HACKERS] Deriving release notes from git commit messages

2011-07-02 Thread Robert Haas
On Sat, Jul 2, 2011 at 10:19 AM, Andres Freund and...@anarazel.de wrote: On Saturday, July 02, 2011 06:10:43 AM Tom Lane wrote: I wouldn't have a problem with establishing a convention that we write credits in commit messages in a more standardized way, ie put something like Author: Joe Blow

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: BTW, regarding to the statement support for security barrier views, the following syntax might be more consistent with existing ones: CREATE VIEW view_name WITH ( param [=value])

Re: [HACKERS] plpython thinks it's hooked into make distprep, but not so much

2011-07-02 Thread Tom Lane
I wrote: I noticed while wrapping 9.1beta2 that plpython tries to build a file spiexceptions.h to be included in the tarballs, but no such file is actually appearing therein. The reason is that src/pl/Makefile doesn't recurse into the plpython subdirectory unless with_python is set. Which it

[HACKERS] merge pg_proc and pg_operator?

2011-07-02 Thread Peter Eisentraut
This thought reemerged in me during the recent discussion of the regular expression matching operators: A lot of things could be better if pg_proc and pg_operator were merged together. Most importantly, operator optimization information could be attached to procedures, so developers and users

Re: [HACKERS] merge pg_proc and pg_operator?

2011-07-02 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: This thought reemerged in me during the recent discussion of the regular expression matching operators: A lot of things could be better if pg_proc and pg_operator were merged together. Like what? I think this would result in a huge amount of code churn

Re: [HACKERS] merge pg_proc and pg_operator?

2011-07-02 Thread Robert Haas
On Sat, Jul 2, 2011 at 5:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: This thought reemerged in me during the recent discussion of the regular expression matching operators: A lot of things could be better if pg_proc and pg_operator were merged together.

Re: [HACKERS] merge pg_proc and pg_operator?

2011-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sat, Jul 2, 2011 at 5:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: Most importantly, operator optimization information could be attached to procedures, We should definitely do that someday, but there are far

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-07-02 Thread Josh Kupershmidt
On Wed, Jun 29, 2011 at 12:15 PM, Merlin Moncure mmonc...@gmail.com wrote: Patch applies clean, does what it is supposed to do, and matches other conventions in describe.c  Passing to committer.   pg_comments may be a better way to go, but that is a problem for another day... Thanks for the

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-02 Thread Robert Haas
On Sat, Jul 2, 2011 at 3:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: BTW, regarding to the statement support for security barrier views, the following syntax might be more consistent

Re: [HACKERS] clean.pl on Windows fails to remove flex output

2011-07-02 Thread Craig Ringer
On 2/07/2011 11:54 PM, Magnus Hagander wrote: On Sat, Jul 2, 2011 at 17:51, Craig Ringercr...@postnewspapers.com.au wrote: Hi folks I've noticed while testing the VC 2010 patches that clean.pl in src/tools/msvc doesn't remove files generated by flex. I landed up with a broken configuration

Re: [HACKERS] libpq SSL with non-blocking sockets

2011-07-02 Thread Steve Singer
On 11-06-28 02:14 PM, Martin Pihlak wrote: Thanks for the review! I have since simplified the patch to assume that partial SSL writes are disabled -- according to SSL_write(3) this is the default behaviour. Now the SSL retry buffer only holds the data to be retried, the remainder is moved to the

[HACKERS] plpgsql extension install nitpick

2011-07-02 Thread Josh Kupershmidt
Hi all, I noticed that the plpgsql extension gets installed with an extension comment of 'PL/pgSQL procedural language', which comes from plpgsql.control. That seems fine and dandy, but take a look at the following query (modified from psql's \dL query): SELECT l.lanname AS Name,

Re: [HACKERS] plpgsql extension install nitpick

2011-07-02 Thread Tom Lane
Josh Kupershmidt schmi...@gmail.com writes: [ plpgsql's comment is now attached to the extension, not the PL itself ] So, basically, I would like to have that comment show up for the first query. I imagine this could be fixed quite easily by adding: COMMENT ON PROCEDURAL LANGUAGE plpgsql IS

Re: [HACKERS] plpgsql extension install nitpick

2011-07-02 Thread Josh Kupershmidt
On Sat, Jul 2, 2011 at 11:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Kupershmidt schmi...@gmail.com writes: [ plpgsql's comment is now attached to the extension, not the PL itself ] So, basically, I would like to have that comment show up for the first query. I imagine this could be fixed

[HACKERS] `make world` exit code

2011-07-02 Thread David E. Wheeler
Hackers, I'm building a new server using 9.1beta2. My build script includes these two line: make world -j3 || exit $? make install-world || exit $? Much to my annoyance, `make world` seems to succeed, but the script exits with no error message. So the second line never executes. I