Re: [HACKERS] issue with smlar exension and gist index creation (9.2Beta1)

2012-06-06 Thread mark
-Original Message- From: Tom Lane [mailto:t...@sss.pgh.pa.us] Sent: Tuesday, June 05, 2012 9:22 PM To: mark Cc: 'pgsql-hackers' Subject: Re: [HACKERS] issue with smlar exension and gist index creation (9.2Beta1) mark dvlh...@gmail.com writes: I am playing around with 9.2Beta1

Re: [HACKERS] Inconsistency in libpq connection parameters, and extension thereof

2012-06-06 Thread Magnus Hagander
On Wed, Jun 6, 2012 at 4:38 AM, Daniel Farina dan...@heroku.com wrote: On Tue, Jun 5, 2012 at 6:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Daniel Farina dan...@heroku.com writes: If that is the case, is there a convention we can use to separate the parts of the connection string (in both

[HACKERS] ExecStoreTuple going into infinite loop

2012-06-06 Thread Atri Sharma
Hi all, I am trying to build and store multiple tuples.The code is: ExecClearTuple(slot); /The code for fetching the data from which tuple will be formed../ for(;xy;x++){ tuple = BuildTupleFromCStrings(TupleDescGetAttInMetadata(node-ss.ss_currentRelation-rd_att), values); ExecStoreTuple(tuple,

Re: [HACKERS] Interrupting long external library calls

2012-06-06 Thread Sandro Santilli
FYI, I finally committed the code installing a signal handler in PostGIS, using the pqsignal function: https://trac.osgeo.org/postgis/changeset/9850 It is currently only used to interrupt GEOS calls, but the idea is that it could eventually also be used to interrupt other library calls having

Re: [HACKERS] 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile

2012-06-06 Thread Sergey Koposov
Hi, On Mon, 4 Jun 2012, Ants Aasma wrote: On Mon, Jun 4, 2012 at 7:44 PM, Merlin Moncure mmonc...@gmail.com wrote: I tried to keep it simple at first to find an answer to the question if it's even worth trying before expending large effort on it. If anyone with a multisocket machine would chip

Re: [HACKERS] ExecStoreTuple going into infinite loop

2012-06-06 Thread Merlin Moncure
On Wed, Jun 6, 2012 at 5:36 AM, Atri Sharma atri.j...@gmail.com wrote: Hi all, I am trying to build and store multiple tuples.The code is: ExecClearTuple(slot); /The code for fetching the data from which tuple will be formed../ for(;xy;x++){ tuple =

[HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Honza Horak
Hi, before I ask the main question, just a little background for one issue we're currently having in Fedora 17: PrivateTmp is a systemd's feature, which allows to have private /tmp directory for services, which in turn means that such services aren't able to access systems's /tmp directory.

Re: [HACKERS] ExecStoreTuple going into infinite loop

2012-06-06 Thread Tom Lane
Atri Sharma atri.j...@gmail.com writes: Hi all, I am trying to build and store multiple tuples.The code is: ExecClearTuple(slot); /The code for fetching the data from which tuple will be formed../ for(;xy;x++){ tuple =

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Florian Pflug
On Jun6, 2012, at 15:50 , Honza Horak wrote: before I ask the main question, just a little background for one issue we're currently having in Fedora 17: PrivateTmp is a systemd's feature, which allows to have private /tmp directory for services, which in turn means that such services

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Tom Lane
Florian Pflug f...@phlo.org writes: Couldn't you simply tell postgres to put it's socket in, say, /var/run, and create a symlink to that socket in the global /tmp directory? FYI, this proposal emerged out of a discussion between Honza and myself. Use a symlink was my first idea too, but on

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Andres Freund
On Wednesday, June 06, 2012 04:38:42 PM Tom Lane wrote: Florian Pflug f...@phlo.org writes: If we're going to have this at all, we should go all the way and support an arbitrary number of sockets. Well, that's what I wanted to discuss before Honza starts coding. It's not obvious that

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié jun 06 10:38:42 -0400 2012: Florian Pflug f...@phlo.org writes: Couldn't you simply tell postgres to put it's socket in, say, /var/run, and create a symlink to that socket in the global /tmp directory? FYI, this proposal emerged out of a discussion

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Honza Horak
On 06/06/2012 04:50 PM, Andres Freund wrote: On Wednesday, June 06, 2012 04:38:42 PM Tom Lane wrote: Florian Pflugf...@phlo.org writes: If we're going to have this at all, we should go all the way and support an arbitrary number of sockets. Well, that's what I wanted to discuss before

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of mié jun 06 10:38:42 -0400 2012: (BTW, we would probably just adopt the Debian solution if we were sure there were no non-libpq clients out there; but we aren't.) Maybe this is a good time to make the

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Tom Lane
Honza Horak hho...@redhat.com writes: On 06/06/2012 04:50 PM, Andres Freund wrote: On Wednesday, June 06, 2012 04:38:42 PM Tom Lane wrote: Florian Pflugf...@phlo.org writes: If we're going to have this at all, we should go all the way and support an arbitrary number of sockets. Well,

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Roger Leigh
On Wed, Jun 06, 2012 at 11:32:45AM -0400, Tom Lane wrote: I had forgotten that conversation, but it does seem like there is interest in this type of configuration. Can anybody confirm that dropping a socket into a chroot or jail would actually work, ie make it possible to connect from inside

Re: [HACKERS] Inconsistency in libpq connection parameters, and extension thereof

2012-06-06 Thread Daniel Farina
On Wed, Jun 6, 2012 at 1:09 AM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jun 6, 2012 at 4:38 AM, Daniel Farina dan...@heroku.com wrote: On Tue, Jun 5, 2012 at 6:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Daniel Farina dan...@heroku.com writes: If that is the case, is there a

Re: [HACKERS] page is not marked all-visible warning in regression tests

2012-06-06 Thread Andres Freund
On Tuesday, June 05, 2012 04:18:44 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On Tuesday, June 05, 2012 03:32:08 PM Tom Lane wrote: I got this last night in a perfectly standard build of HEAD: + WARNING: page is not marked all-visible but visibility map bit is set in

Re: [HACKERS] Ability to listen on two unix sockets

2012-06-06 Thread Robert Haas
On Wed, Jun 6, 2012 at 10:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: Well, that's what I wanted to discuss before Honza starts coding. It's not obvious that there are any use-cases for more than two. It's also not clear whether there is any value in supporting run-time rather than build-time

Re: [HACKERS] incorrect handling of the timeout in pg_receivexlog

2012-06-06 Thread Fujii Masao
On Tue, Jun 5, 2012 at 11:42 PM, Magnus Hagander mag...@hagander.net wrote: Works for me. We still need a (reworked) patch, though, right? We just move where the move between seconds and milliseconds happens? Attached is the updated version of the patch. I definitely don't think we need

Re: [HACKERS] page is not marked all-visible warning in regression tests

2012-06-06 Thread Robert Haas
On Wed, Jun 6, 2012 at 1:46 PM, Andres Freund and...@2ndquadrant.com wrote: On a cursory lock it might just be a race condition in vacuumlazy.c:lazy_scan_heap. If scan_all is set, which it has to be for the warning to be visible, all_visible_according_to_vm is determined before we loop over

Re: [HACKERS] pg_receivexlog and feedback message

2012-06-06 Thread Fujii Masao
On Tue, Jun 5, 2012 at 11:44 PM, Magnus Hagander mag...@hagander.net wrote: On Tue, Jun 5, 2012 at 4:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 5, 2012 at 9:53 PM, Magnus Hagander mag...@hagander.net wrote: Right now, pg_receivexlog sets:                        replymsg-write

[HACKERS] creating objects in pg_catalog

2012-06-06 Thread Robert Haas
Right now, you can't directly create a relation (table, index, composite type) in the pg_catalog schema, but you can create a non-relation (function, domain, etc.) in the pg_catalog schema. Furthermore, you can create a table in some other schema and then move it into the pg_catalog schema using

Re: [HACKERS] \conninfo and SSL

2012-06-06 Thread Robert Haas
On Sun, Jun 3, 2012 at 5:30 AM, Alastair Turner b...@ctrlf5.co.za wrote: A one-line change adds the SSL info on its own line like -- You are connected to database scratch as user scratch on host 127.0.0.1 at port 5432. SSL connection (cipher: DHE-RSA-AES256-SHA, bits: 256) -- Does

Re: [HACKERS] pg_receivexlog and feedback message

2012-06-06 Thread Robert Haas
On Tue, Jun 5, 2012 at 10:44 AM, Magnus Hagander mag...@hagander.net wrote: On Tue, Jun 5, 2012 at 4:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 5, 2012 at 9:53 PM, Magnus Hagander mag...@hagander.net wrote: Right now, pg_receivexlog sets:                        replymsg-write

Re: [HACKERS] 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile

2012-06-06 Thread Ants Aasma
On Wed, Jun 6, 2012 at 2:27 PM, Sergey Koposov kopo...@ast.cam.ac.uk wrote: I've quickly tested your lockfree-getbuffer.patch patch with the test case you provided and I barely see any improvement (2% at max) https://docs.google.com/open?id=0B7koR68V2nM1QVBxWGpZdW4wd0U tested with 24 core (48

Re: [HACKERS] page is not marked all-visible warning in regression tests

2012-06-06 Thread Andres Freund
On Wednesday, June 06, 2012 08:19:15 PM Robert Haas wrote: On Wed, Jun 6, 2012 at 1:46 PM, Andres Freund and...@2ndquadrant.com wrote: On a cursory lock it might just be a race condition in vacuumlazy.c:lazy_scan_heap. If scan_all is set, which it has to be for the warning to be visible,

Re: [HACKERS] 9.3: load path to mitigate load penalty for checksums

2012-06-06 Thread Robert Haas
On Mon, Jun 4, 2012 at 9:26 PM, Jeff Davis pg...@j-davis.com wrote: Thoughts? Simon already proposed a way of doing this that doesn't require explicit user action, which seems preferable to a method that does require explicit user action, even though it's a little harder to implement. His idea

[HACKERS] Avoiding adjacent checkpoint records

2012-06-06 Thread Tom Lane
In commit 18fb9d8d21a28caddb72c7ffbdd7b96d52ff9724, Simon modified the rule for when to skip checkpoints on the grounds that not enough activity has happened since the last one. However, that commit left the comment block about it in a nonsensical state: * If this isn't a shutdown or forced

Re: [HACKERS] WalSndWakeup() and synchronous_commit=off

2012-06-06 Thread Andres Freund
On Tuesday, May 29, 2012 08:42:43 PM Andres Freund wrote: Hi, On Monday, May 28, 2012 07:11:53 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: Does anybody have a better idea than to either call WalSndWakeup() at essentially the wrong places or calling it inside a

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-06-06 Thread Robert Haas
On Wed, Jun 6, 2012 at 3:08 PM, Tom Lane t...@sss.pgh.pa.us wrote: In commit 18fb9d8d21a28caddb72c7ffbdd7b96d52ff9724, Simon modified the rule for when to skip checkpoints on the grounds that not enough activity has happened since the last one.  However, that commit left the comment block

Re: [HACKERS] 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile

2012-06-06 Thread Sergey Koposov
On Wed, 6 Jun 2012, Ants Aasma wrote: On Wed, Jun 6, 2012 at 2:27 PM, Sergey Koposov kopo...@ast.cam.ac.uk wrote: I've quickly tested your lockfree-getbuffer.patch patch with the test case you provided and I barely see any improvement (2% at max)

Re: [HACKERS] \conninfo and SSL

2012-06-06 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié jun 06 14:45:46 -0400 2012: On Sun, Jun 3, 2012 at 5:30 AM, Alastair Turner b...@ctrlf5.co.za wrote: A one-line change adds the SSL info on its own line like -- You are connected to database scratch as user scratch on host 127.0.0.1 at

Re: [HACKERS] pg_receivexlog and feedback message

2012-06-06 Thread Magnus Hagander
On Wed, Jun 6, 2012 at 8:26 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 5, 2012 at 11:44 PM, Magnus Hagander mag...@hagander.net wrote: On Tue, Jun 5, 2012 at 4:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 5, 2012 at 9:53 PM, Magnus Hagander mag...@hagander.net

Re: [HACKERS] Inconsistency in libpq connection parameters, and extension thereof

2012-06-06 Thread Magnus Hagander
On Wed, Jun 6, 2012 at 6:58 PM, Daniel Farina dan...@heroku.com wrote: On Wed, Jun 6, 2012 at 1:09 AM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jun 6, 2012 at 4:38 AM, Daniel Farina dan...@heroku.com wrote: On Tue, Jun 5, 2012 at 6:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Daniel

Re: [HACKERS] Btree or not btree? That is the question

2012-06-06 Thread Greg Sabino Mullane
On Mon, Jun 04, 2012 at 02:09:44PM -0400, Tom Lane wrote: Greg Sabino Mullane g...@endpoint.com writes: We have a 8.3.18 system (yes, the same one from the previous thread, finally upgraded!) that gave us this error yesterday: ERROR: index pg_class_oid_index is not a btree That means

Re: [HACKERS] Inconsistency in libpq connection parameters, and extension thereof

2012-06-06 Thread Robert Haas
On Wed, Jun 6, 2012 at 4:08 PM, Magnus Hagander mag...@hagander.net wrote: However, not throwing errors on the URL syntax should be considered a bug, I think. +1. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing

Re: [HACKERS] 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile

2012-06-06 Thread Merlin Moncure
On Wed, Jun 6, 2012 at 2:53 PM, Sergey Koposov kopo...@ast.cam.ac.uk wrote: On Wed, 6 Jun 2012, Ants Aasma wrote: On Wed, Jun 6, 2012 at 2:27 PM, Sergey Koposov kopo...@ast.cam.ac.uk wrote: I've quickly tested your lockfree-getbuffer.patch patch with the test case you provided and I barely

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-06-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Wed, Jun 6, 2012 at 3:08 PM, Tom Lane t...@sss.pgh.pa.us wrote: In commit 18fb9d8d21a28caddb72c7ffbdd7b96d52ff9724, Simon modified the rule for when to skip checkpoints on the grounds that not enough activity has happened since the last one. IIRC,

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-06-06 Thread Robert Haas
On Wed, Jun 6, 2012 at 4:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: I felt (and still feel) that this was misguided. Looking at it again, I'm inclined to agree.  The behavior was entirely correct up until somebody decided to emit a continuing stream of XLOG_RUNNING_XACTS WAL records even when

Re: [HACKERS] creating objects in pg_catalog

2012-06-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Right now, you can't directly create a relation (table, index, composite type) in the pg_catalog schema, but you can create a non-relation (function, domain, etc.) in the pg_catalog schema. Surely this is true only for superusers. Superusers can do

Re: [HACKERS] 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile

2012-06-06 Thread Sergey Koposov
On Wed, 6 Jun 2012, Merlin Moncure wrote: I think this is the expected result. In the single user case the spinklock never spins and only has to make the cpu-locking cache instructions once. can we see results @24 threads? Here https://docs.google.com/open?id=0B7koR68V2nM1NDJHLUhNSS0zbUk

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-06-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Wed, Jun 6, 2012 at 4:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: I felt (and still feel) that this was misguided. Looking at it again, I'm inclined to agree.  The behavior was entirely correct up until somebody decided to emit a continuing stream of

Re: [HACKERS] creating objects in pg_catalog

2012-06-06 Thread Robert Haas
On Wed, Jun 6, 2012 at 4:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Right now, you can't directly create a relation (table, index, composite type) in the pg_catalog schema, but you can create a non-relation (function, domain, etc.) in the pg_catalog

Re: [HACKERS] creating objects in pg_catalog

2012-06-06 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: rhaas=# create table pg_catalog.tom (a int); ERROR: permission denied to create pg_catalog.tom The offending error check is in heap_create(), and based on what you're saying here it seems like we should just rip it out. Hmm. Yeah, it seems like the

Re: [HACKERS] Inconsistency in libpq connection parameters, and extension thereof

2012-06-06 Thread Daniel Farina
On Wed, Jun 6, 2012 at 1:13 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jun 6, 2012 at 4:08 PM, Magnus Hagander mag...@hagander.net wrote: However, not throwing errors on the URL syntax should be considered a bug, I think. +1. +1 Here's a patch that just makes the thing an error.

Re: [HACKERS] pg_receivexlog and feedback message

2012-06-06 Thread Fujii Masao
On Thu, Jun 7, 2012 at 5:05 AM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jun 6, 2012 at 8:26 PM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 5, 2012 at 11:44 PM, Magnus Hagander mag...@hagander.net wrote: On Tue, Jun 5, 2012 at 4:42 PM, Fujii Masao masao.fu...@gmail.com

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-06-06 Thread Tom Lane
I wrote: Actually, it looks like there is an extremely simple way to handle this, which is to move the call of LogStandbySnapshot (which generates the WAL record in question) to before the checkpoint's REDO pointer is set, but after we have decided that we need a checkpoint. On further

Re: [HACKERS] 9.3: load path to mitigate load penalty for checksums

2012-06-06 Thread Noah Misch
On Wed, Jun 06, 2012 at 03:08:05PM -0400, Robert Haas wrote: On Mon, Jun 4, 2012 at 9:26 PM, Jeff Davis pg...@j-davis.com wrote: Thoughts? Simon already proposed a way of doing this that doesn't require explicit user action, which seems preferable to a method that does require explicit

Re: [HACKERS] 9.3: load path to mitigate load penalty for checksums

2012-06-06 Thread Jeff Davis
On Wed, 2012-06-06 at 15:08 -0400, Robert Haas wrote: On Mon, Jun 4, 2012 at 9:26 PM, Jeff Davis pg...@j-davis.com wrote: Thoughts? Simon already proposed a way of doing this that doesn't require explicit user action, which seems preferable to a method that does require explicit user

Re: [HACKERS] Time for pgindent run?

2012-06-06 Thread Robert Haas
On Tue, Jun 5, 2012 at 10:25 AM, Bruce Momjian br...@momjian.us wrote: On Tue, Jun 05, 2012 at 10:21:14AM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Is everyone ready for me to run pgindent?  We are nearing the first commit-fest (June 15) and will have to branch the git

Re: [HACKERS] 9.3: load path to mitigate load penalty for checksums

2012-06-06 Thread Noah Misch
On Mon, Jun 04, 2012 at 06:26:04PM -0700, Jeff Davis wrote: I propose a special user-initiated loading mode at the table granularity. During this time, readers must ignore PD_ALL_VISIBLE, HEAP_XMIN_COMMITTED, and the visibility map entirely. However, writers may set all of those bits before

Re: [HACKERS] Early hint bit setting

2012-06-06 Thread Jim Nasby
On 5/30/12 4:42 PM, Ants Aasma wrote: I was thinking about what is the earliest time where we could set hint bits. This would be just after the commit has been made visible. Except that's only true when there are no other transactions running. That's been one of the big sticking points about

Re: [HACKERS] How could we make it simple to access the log as a table?

2012-06-06 Thread Jim Nasby
On 5/28/12 2:55 PM, Robert Haas wrote: As far as CSV goes, I think the biggest deficiency is that there's a mismatch between the way that log files are typically named (e.g. one per day, or one per hour) and the way that a CSV foreign table is created (you've got to point it at one particular

[HACKERS] Could we replace SysV semaphores with latches?

2012-06-06 Thread Tom Lane
There has been regular griping in this list about our dependence on SysV shared memory, but not so much about SysV semaphores, even though the latter cause their fair share of issues; as seen for example in buildfarm member spoonbill's recent string of failures: creating template1 database in