Re: [HACKERS] Adding optionally commit number in PG_VERSION_STR

On Wed, July 17, 2013 05:27, Tom Lane wrote: > Michael Paquier writes: >> It happens that I work occasionally on multiple builds based on FWIW, I've been doing this for while: where $project is mostly the patchname, $commit_hash is extracted like this: commit_hash=$( cd /home/aardvark/pg_stuf

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

>>> To clarify what state this is all in: Fabien's latest >>> pgbench-throttle-v15.patch is the ready for a committer version. The >>> last two revisions are just tweaking the comments at this point, and >>> his version is more correct than my last one. >> >> Got it. I will take care of this. > >

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

To clarify what state this is all in: Fabien's latest pgbench-throttle-v15.patch is the ready for a committer version. The last two revisions are just tweaking the comments at this point, and his version is more correct than my last one. Got it. I will take care of this. Please find attache

Re: [HACKERS] A general Q about index

On 07/16/2013 11:09 PM, soroosh sardari wrote: > > Actually I mean the index in the source code, I want to know how index > is used in the backend for > execution of some query. > sorry my question is a bit ambiguous, > I start to read "src/backend/access/index/genam.c", and I think maybe > this

Re: [HACKERS] A general Q about index

On Tue, Jul 16, 2013 at 7:00 PM, David Johnston wrote: > David Johnston wrote > > > > soroosh sardari wrote > >> Hi > >> > >> I want to know how an index is created and used. > >> actually if you can show to me a simple start point, it would be great. > >> > >> Regards, > >> Soroosh Sardari > > I

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

On Tue, Jul 16, 2013 at 9:17 PM, Greg Smith wrote: > On 7/16/13 12:46 PM, Ants Aasma wrote: > >> Spread checkpoints sprinkles the writes out over a long >> period and the general tuning advice is to heavily bound the amount of >> memory the OS willing to keep dirty. > > > That's arguing that you c

Re: [HACKERS] Adding optionally commit number in PG_VERSION_STR

Michael Paquier writes: > It happens that I work occasionally on multiple builds based on > different stable branches at the same time to check fixes that need to > be backpatched, and I tend to easily lose track on which version the > build I created is based on (Duh!). There is of course the ver

Re: [HACKERS] Listen/notify across clusters

On 07/15/2013 04:10 PM, Greg Jaskiewicz wrote: In terms of features, apart from separating LISTEN so that it can be actually used on Standbys, wouldn't it be a matter of including the notifications in the WAL stream, as simple packets ? This would guarantee same behaviour as on the master. I

[HACKERS] Adding optionally commit number in PG_VERSION_STR

Hi all, It happens that I work occasionally on multiple builds based on different stable branches at the same time to check fixes that need to be backpatched, and I tend to easily lose track on which version the build I created is based on (Duh!). There is of course the version number up to the 3r

Re: [HACKERS] Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]

On Mon, Jul 15, 2013 at 11:43:04AM -0700, David Fetter wrote: > On Sun, Jul 14, 2013 at 10:15:12PM -0400, Noah Misch wrote: > > See attached patch revisions. The first patch edits > > find_minmax_aggs_walker() > > per my comments just now. The second is an update of your FILTER patch with > > th

Re: [HACKERS] findDependentObjects() mutual exclusion vs. MVCC catalog scans

On Tue, Jul 16, 2013 at 11:27:02AM -0400, Robert Haas wrote: > I recommend reworking the header comment to avoid mention of > SnapshotNow, since if we get rid of SnapshotNow, the reference might > not be too clear to far-future hackers. > > + /* > + * For a scan using a non-MVCC snapshot

Re: [HACKERS] SSL renegotiation

On Tue, Jul 16, 2013 at 10:41:44AM -0700, David Fetter wrote: > On Fri, Jul 12, 2013 at 08:51:52PM -0400, Noah Misch wrote: > > Agreed. The OpenSSL Project last applied a security fix to 0.9.6 > > over eight years ago. Compatibility with 0.9.6 has zero or negative > > value. > > You've made a pe

Re: [HACKERS] XLogInsert scaling, revisited

On Tue, Jul 16, 2013 at 2:24 AM, Fujii Masao wrote: > On Mon, Jul 8, 2013 at 6:16 PM, Heikki Linnakangas > wrote: >> Ok, I've committed this patch now. Finally, phew! > > I found that this patch causes the assertion failure. When I set up simple > replication environment and promoted the standby

[HACKERS] [9.4 CF 1]SDO: Patches awaiting Author

Hackers, The following patches were "Waiting on Author" as of today. As such, most have been marked "returned with feedback". Authors are encouraged to update their patches and submit to the next Commitfest. There are a few exceptions to "Returned with feedback", though: Could Not Determine St

Re: [Review] Re: [HACKERS] minor patch submission: CREATE CAST ... AS EXPLICIT

On 07/16/2013 03:12 PM, Tom Lane wrote: > Josh Berkus writes: >> On 07/09/2013 01:10 AM, Fabien COELHO wrote: Where are we with this patch? Fabien, are you going to submit an updated version which addresses the objections, or should I mark it Returned With Feedback? > >>> There is

[HACKERS] [9.4 CF 1] SDO: Patches for Review

Hackers, As the Commitfest is past deadline, here is the disposition of 15 patches which were still marked "Needs Review": Needs Review The following patches have not had even one substantial review. Please someone pick them up and review them ASAP: - Row-Level Security - KaiGai K

Re: [Review] Re: [HACKERS] minor patch submission: CREATE CAST ... AS EXPLICIT

Josh Berkus writes: > On 07/09/2013 01:10 AM, Fabien COELHO wrote: >>> Where are we with this patch? Fabien, are you going to submit an >>> updated version which addresses the objections, or should I mark it >>> Returned With Feedback? >> There is no need for an updated patch. I addressed the ob

Re: [Review] Re: [HACKERS] minor patch submission: CREATE CAST ... AS EXPLICIT

On 07/09/2013 01:10 AM, Fabien COELHO wrote: >> Where are we with this patch? Fabien, are you going to submit an >> updated version which addresses the objections, or should I mark it >> Returned With Feedback? > > There is no need for an updated patch. I addressed the objections with > words, no

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

Josh Berkus writes: > On 07/08/2013 04:59 PM, Tom Lane wrote: >> FWIW, I think that's exactly what I did in the preliminary 9.3 patch >> that I committed to pg_filedump a few weeks ago. Could you take a look >> at what's there now and see if that's what you meant? > So, is this getting committed

Re: [HACKERS] Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

On 07/11/2013 09:28 AM, Greg Stark wrote: > Neither of these address Tom's concerns about API changes and future > flexibility. I was assigned this patch in the rreviewers list and my > inclination would be to take it but I wasn't about to > overrule Tom. If he says he's ok with it then I'm fine go

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

On 07/08/2013 04:59 PM, Tom Lane wrote: > Alvaro Herrera writes: >> Well, Tom opined in >> http://www.postgresql.org/message-id/23249.1370878...@sss.pgh.pa.us that >> the current patch is okay. I have a mild opinion that it should instead >> print only SHR_LOCK when both bits are set, and one of

Re: [HACKERS] Proposal - Support for National Characters functionality

On Mon, Jul 15, 2013 at 05:11:40PM +0900, Tatsuo Ishii wrote: > > Does support for alternative multi-byte encodings have something to do > > with the Han unification controversy? I don't know terribly much about > > this, so apologies if that's just wrong. > > There's a famous problem regarding co

Re: [HACKERS] pg_memory_barrier() doesn't compile, let alone work, for me

On Sun, Jul 14, 2013 at 09:26:38PM -0400, Robert Haas wrote: > I'm pretty sure we've got latent memory-ordering risks in our existing > code which we just haven't detected and fixed yet. Consider, for > example, this exciting code from GetNewTransactionId: > > mypr

Re: [HACKERS] Differences in WHERE clause of SELECT

Robert Haas wrote: > We can certainly continue to play whack-a-mole and dream up a new > solution every time a really intolerable variant of this problem comes > up.  But that doesn't seem good to me.  It means that every case > behaves a little different from every other case, and the whole thin

Re: [HACKERS] review: Non-recursive processing of AND/OR lists

Hello 2013/7/15 Gurjeet Singh : > On Sun, Jul 14, 2013 at 8:27 PM, Robert Haas wrote: >> >> On Wed, Jul 10, 2013 at 9:02 PM, Josh Berkus wrote: >> >> I think it's a waste of code to try to handle bushy trees. A list is >> >> not a particularly efficient representation of the pending list; this

Re: [HACKERS] Proposal: template-ify (binary) extensions

On Tue, Jul 16, 2013 at 3:14 PM, Markus Wanner wrote: > But okay, you're saying we *have* and *want* a guarantee that even a > superuser cannot execute arbitrary native code via libpq (at least in > default installs w/o extensions). Yes, that's a good way of summarizing my position. I think I'd

Re: [HACKERS] Differences in WHERE clause of SELECT

On Tue, Jul 16, 2013 at 2:58 PM, Merlin Moncure wrote: > On Tue, Jul 16, 2013 at 12:58 PM, Robert Haas wrote: >> PostgreSQL requires more casts that any other mainstream database >> system on the planet, and it's one of the biggest barriers to >> migrating from other database systems to PostgreSQ

Re: [HACKERS] Proposal: template-ify (binary) extensions

On 07/16/2013 01:27 AM, Robert Haas wrote: > Andres points out that you can install adminpack to obtain > local filesystem access, and that is true. But the system > administrator can also refuse to allow adminpack, and/or use selinux > or other mechanisms to prevent the postgres binary from writi

Re: [HACKERS] Differences in WHERE clause of SELECT

On Tue, Jul 16, 2013 at 12:58 PM, Robert Haas wrote: > PostgreSQL requires more casts that any other mainstream database > system on the planet, and it's one of the biggest barriers to > migrating from other database systems to PostgreSQL. I understand > that there is a consensus in this forum to

Re: [HACKERS] A general Q about index

On Tue, Jul 16, 2013 at 7:00 PM, David Johnston wrote: > David Johnston wrote > > > > soroosh sardari wrote > >> Hi > >> > >> I want to know how an index is created and used. > >> actually if you can show to me a simple start point, it would be great. > >> > >> Regards, > >> Soroosh Sardari > > I

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

On 7/16/13 12:46 PM, Ants Aasma wrote: Spread checkpoints sprinkles the writes out over a long period and the general tuning advice is to heavily bound the amount of memory the OS willing to keep dirty. That's arguing that you can make this feature be useful if you tune in a particular way.

Re: [HACKERS] Differences in WHERE clause of SELECT

On Tue, Jul 16, 2013 at 12:05 PM, Tom Lane wrote: > I don't agree with this opinion. I know. > '1' + '2' might be claimed to have > only one plausible meaning as well, but that doesn't mean that we should > accept it. That example clearly has multiple sensible interpretations, because surely we

Re: [HACKERS] SSL renegotiation

On Fri, Jul 12, 2013 at 08:51:52PM -0400, Noah Misch wrote: > On Fri, Jul 12, 2013 at 04:32:52PM -0400, Alvaro Herrera wrote: > > Now, should we support the 0.9.6-and-earlier mechanism? My > > inclination is no; even RHEL 3, the oldest supported Linux > > distribution, uses 0.9.7 (Heck, even Red H

Re: [HACKERS] findDependentObjects() mutual exclusion vs. MVCC catalog scans

On Tue, Jul 16, 2013 at 05:56:10PM +0200, Andres Freund wrote: > On 2013-07-16 09:50:07 -0400, Noah Misch wrote: > > With "\c", in general, you may end up executing commands under the new > > session > > before the old backend has finished exiting. For this test case > > specifically, > > the tw

Re: [HACKERS] dynamic background workers

On Wed, Jul 3, 2013 at 11:15 AM, Alvaro Herrera wrote: > Andres Freund escribió: >> Just as a datapoint, if you benchmark the numbers of forks that can be >> performed by a single process (i.e. postmaster) the number is easily in >> the 10s of thousands. Now forking that much has some scalability

Re: [HACKERS] Differences in WHERE clause of SELECT

On Tue, Jul 16, 2013 at 4:40 PM, Robert Haas wrote: > But '1' LIKE 1 is not ambiguous What about '1' LIKE 01 ? What do people who write this actually expect LIKE to do? I gather they're actually treating it as a synonym for =? -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

On Jul 14, 2013 9:46 PM, "Greg Smith" wrote: > I updated and re-reviewed that in 2011: > http://www.postgresql.org/message-id/4d31ae64.3000...@2ndquadrant.com and > commented on why I think the improvement was difficult to reproduce back > then. The improvement didn't follow for me either. It

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013/7/15 Andrew Dunstan : > > On 07/14/2013 12:28 AM, Pavel Stehule wrote: >> >> Hello >> >> 2013/7/14 Andrew Dunstan : >>> >>> On 06/29/2013 03:29 PM, Pavel Stehule wrote: >>> >>> >>> 5. This patch has user visibility, i.e. now we are throwing an error when user only sa

Re: [HACKERS] Differences in WHERE clause of SELECT

Robert Haas writes: > I continue to be of the opinion that our behavior in this area is > bone-headed. It's reasonable to reject integer = character varying on > the basis that we don't know whether integer or character varying > comparison semantics are wanted, and the two might give different >

Re: [HACKERS] SSL renegotiation

On Fri, Jul 12, 2013 at 8:51 PM, Noah Misch wrote: > On Fri, Jul 12, 2013 at 04:32:52PM -0400, Alvaro Herrera wrote: >> Now, should we support the 0.9.6-and-earlier mechanism? My inclination >> is no; even RHEL 3, the oldest supported Linux distribution, uses 0.9.7 >> (Heck, even Red Hat Linux 9,

Re: [HACKERS] findDependentObjects() mutual exclusion vs. MVCC catalog scans

On 2013-07-16 09:50:07 -0400, Noah Misch wrote: > With "\c", in general, you may end up executing commands under the new session > before the old backend has finished exiting. For this test case specifically, > the two backends' attempts to drop table "t" regularly overlap. The old > backend woul

Re: [HACKERS] Differences in WHERE clause of SELECT

On Tue, Jul 9, 2013 at 7:12 PM, Josh Berkus wrote: > Like uses the operator class "text_pattern_ops" which doesn't include an > implict cast. This is wrong. Casts are associated with data types, not operator classes. > For one thing, the implicit cast is from text --> > integer, not the other w

Re: [HACKERS] make dist error

On 7/16/13 10:03 AM, Andrew Dunstan wrote: > Incidentally, the buildfarm animal guaibasaurus builds "make dist" every > build, via a bespoke buildfarm module. See for example > , > so we

Re: [HACKERS] findDependentObjects() mutual exclusion vs. MVCC catalog scans

Robert Haas writes: > On Tue, Jul 16, 2013 at 9:50 AM, Noah Misch wrote: >> Let's fix this by having systable_recheck_tuple() acquire a fresh catalog >> MVCC >> snapshot and recheck against that. I believe it would also be fully safe to >> use SnapshotNow here; however, I'm assuming we would ot

Re: [HACKERS] findDependentObjects() mutual exclusion vs. MVCC catalog scans

On Tue, Jul 16, 2013 at 9:50 AM, Noah Misch wrote: > Consider this sequence of commands: > > create type rowtype as (c int, d int); > create temp table t of rowtype; > \c - > drop type rowtype cascade; > > Since the switch to MVCC catalog scans, it exhibits the following error abou

Re: [HACKERS] A general Q about index

David Johnston wrote > > soroosh sardari wrote >> Hi >> >> I want to know how an index is created and used. >> actually if you can show to me a simple start point, it would be great. >> >> Regards, >> Soroosh Sardari > In the documentation there is a table of contents and listed on that table >

Re: [HACKERS] A general Q about index

soroosh sardari wrote > Hi > > I want to know how an index is created and used. > actually if you can show to me a simple start point, it would be great. > > Regards, > Soroosh Sardari In the documentation there is a table of contents and listed on that table is a section named "Indexes". David

Re: [HACKERS] make dist error

On 07/16/2013 09:53 AM, Andrew Dunstan wrote: On 07/16/2013 02:53 AM, Tatsuo Ishii wrote: I'm getting errors while executing "make dist" on git master head. $ make dist make dist rm -rf postgresql-9.4devel* =install= for x in `cd . && find . \( -name CVS -prune \) -o \( -name .git -prune \)

Re: [HACKERS] make dist error

> It's working for me: > >... >/bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel >gzip --best -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.gz >bzip2 -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.bz2 >rm -rf postgresql-9.4devel > > It looks like your source

Re: [HACKERS] make dist error

On 07/16/2013 02:53 AM, Tatsuo Ishii wrote: I'm getting errors while executing "make dist" on git master head. $ make dist make dist rm -rf postgresql-9.4devel* =install= for x in `cd . && find . \( -name CVS -prune \) -o \( -name .git -prune \) -o -print`; do \ file=`expr X$x : 'X\.

[HACKERS] findDependentObjects() mutual exclusion vs. MVCC catalog scans

Consider this sequence of commands: create type rowtype as (c int, d int); create temp table t of rowtype; \c - drop type rowtype cascade; Since the switch to MVCC catalog scans, it exhibits the following error about 10% of the time on my system: CREATE TYPE CREATE TABLE You are

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

On Sun, Jul 7, 2013 at 4:34 PM, Andres Freund wrote: > On 2013-07-07 15:43:17 -0400, Tom Lane wrote: >> Andres Freund writes: >> > 3b) Add catcache 'filter' that ensures the cache stays unique and use >> > that for the mapping >> >> > I slightly prefer 3b) because it's smaller, what's your op

[HACKERS] A general Q about index

Hi I want to know how an index is created and used. actually if you can show to me a simple start point, it would be great. Regards, Soroosh Sardari

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

Hi Satoshi, I spent some time on the revised version on the patch(pgstattuple_regclass_v2.diff) and here are my comments. .) Patch get applies cleanly on PG master branch .) Successful build and database creation .) Basic test coverage included in the patch .) make check running cleanly Basicall

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

> To clarify what state this is all in: Fabien's latest > pgbench-throttle-v15.patch is the ready for a committer version. The > last two revisions are just tweaking the comments at this point, and > his version is more correct than my last one. Got it. I will take care of this. -- Tatsuo Ishii S

Re: [HACKERS] Add visibility map information to pg_freespace.

(2013/07/09 19:55), Kyotaro HORIGUCHI wrote: Hello, I've brought visibilitymap extentions for pg_freespacemap and pgstattuple. At Mon, 08 Jul 2013 16:59:05 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20130708.165905.118860769.horiguchi.kyot...@lab.ntt.co.jp> I'll come again wi