Re: [HACKERS] equalTupleDescs() ignores ccvalid/ccnoinherit

2014-03-23 Thread Noah Misch
On Fri, Mar 21, 2014 at 06:59:05PM +, Simon Riggs wrote: On 21 March 2014 18:26, Robert Haas robertmh...@gmail.com wrote: Given the minor symptoms in released versions, I lean against a back-patch. FWIW, I'd lean toward a back-patch. It's probably not a big deal either way, but I

Re: [HACKERS] Triggers on foreign tables

2014-03-23 Thread Noah Misch
On Tue, Mar 18, 2014 at 09:31:06AM +0100, Ronan Dunklau wrote: Le mardi 18 mars 2014 03:54:19 Kouhei Kaigai a écrit : (1) To acquire the old tuple for UPDATE/DELETE operations, the patch closely parallels our handling for INSTEAD OF triggers on views. It adds a wholerow resjunk

Re: [HACKERS] jsonb status

2014-03-23 Thread Oleg Bartunov
It's easy to add support of other operations to hash_ops, so it will be on par with default GIN opclass, at the price of bigger size. We can add it later to contrib/jsonbext. I'm mostly worrying about changing semantics of scalar. On Sun, Mar 23, 2014 at 4:27 AM, Peter Geoghegan

Re: Fwd: [HACKERS] Proposal: variant of regclass

2014-03-23 Thread Marti Raudsepp
On Sun, Mar 23, 2014 at 7:57 AM, Amit Kapila amit.kapil...@gmail.com wrote: Anyone has any objection for this behaviour difference between usage of ::regclass and to_regclass()? No, I think that makes a lot of sense given the behavior -- if the object is not there, to_regclass() just returns

Re: [HACKERS] jsonb status

2014-03-23 Thread Bruce Momjian
On Sun, Mar 23, 2014 at 12:32:45PM +0400, Oleg Bartunov wrote: It's easy to add support of other operations to hash_ops, so it will be on par with default GIN opclass, at the price of bigger size. We can add it later to contrib/jsonbext. I'm mostly worrying about changing semantics of

Re: [HACKERS] Review: plpgsql.extra_warnings, plpgsql.extra_errors

2014-03-23 Thread Pavel Stehule
Review shadow_v6 patch Hello I did a recheck a newest version of this patch: 1. There is a wide agreement on implemented feature - nothing changed from previous review - it is not necessary comment it again. 2. v6 patch: patching cleanly, compilation without errors and warnings, all regress

Re: [HACKERS] Review: plpgsql.extra_warnings, plpgsql.extra_errors

2014-03-23 Thread Pavel Stehule
2014-03-23 15:14 GMT+01:00 Pavel Stehule pavel.steh...@gmail.com: Review shadow_v6 patch Hello I did a recheck a newest version of this patch: 1. There is a wide agreement on implemented feature - nothing changed from previous review - it is not necessary comment it again. 2. v6 patch:

Re: [HACKERS] Review: plpgsql.extra_warnings, plpgsql.extra_errors

2014-03-23 Thread Petr Jelinek
On 23/03/14 15:14, Pavel Stehule wrote: Review shadow_v6 patch I have only one objection - What I remember - more usual is using a list instead a bitmap for these purposes - typical is DefElem struct. Isn't it better? To me it seemed that for similar use cases (list of boolean options) the

Re: [HACKERS] psql blows up on BOM character sequence

2014-03-23 Thread Guillaume Lelarge
On Sat, 2014-03-22 at 11:23 -0500, Jim Nasby wrote: On 3/21/14, 8:13 PM, David E. Wheeler wrote: On Mar 21, 2014, at 2:16 PM, Andrew Dunstan and...@dunslane.net wrote: Surely if it were really a major annoyance, someone would have sent code to fix it during the last 4 years and more

Re: [HACKERS] Useless Replica Identity: NOTHING noise from psql \d

2014-03-23 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Is this the patch you had in mind? I kept the pg_catalog filter. Do we want to always show the replica identity line for \d+? Doesn't seem like a great idea to remove the filter tests for replident values and then not fix the display code to cope with

Re: [HACKERS] psql blows up on BOM character sequence

2014-03-23 Thread David E. Wheeler
On Mar 23, 2014, at 8:03, Guillaume Lelarge guilla...@lelarge.info wrote: Just a quick comment on this. Yes, pgAdmin always added a BOM in every SQL files it wrote. From http://stackoverflow.com/questions/2223882/whats-different-between-utf-8-and-utf-8-without-bom: According to the Unicode

Re: [HACKERS] jsonb and nested hstore

2014-03-23 Thread Tomas Vondra
On 21.3.2014 08:23, Peter Geoghegan wrote: On Thu, Mar 13, 2014 at 3:39 PM, Peter Geoghegan p...@heroku.com wrote: On Thu, Mar 13, 2014 at 2:21 AM, Greg Stark st...@mit.edu wrote: It does sound like the main question here is which opclass should be the default. From the discussion there's a

Re: [HACKERS] Review: plpgsql.extra_warnings, plpgsql.extra_errors

2014-03-23 Thread Pavel Stehule
2014-03-23 15:53 GMT+01:00 Petr Jelinek p...@2ndquadrant.com: On 23/03/14 15:14, Pavel Stehule wrote: Review shadow_v6 patch I have only one objection - What I remember - more usual is using a list instead a bitmap for these purposes - typical is DefElem struct. Isn't it better? To

Re: [HACKERS] jsonb and nested hstore

2014-03-23 Thread Peter Geoghegan
On Sun, Mar 23, 2014 at 11:10 AM, Tomas Vondra t...@fuzzy.cz wrote: Keeping jsonb_ops as the default seems better / safer to me. That's what I did. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-23 Thread Noah Misch
On Thu, Mar 06, 2014 at 11:52:22PM -0500, Noah Misch wrote: On Thu, Mar 06, 2014 at 12:44:34PM -0500, Tom Lane wrote: I'm inclined to suggest that we should put the socket under $CWD by default, but provide some way for the user to override that choice. If they want to put it in /tmp, it's

Re: [HACKERS] Securing make check (CVE-2014-0067)

2014-03-23 Thread Noah Misch
On Sun, Mar 23, 2014 at 07:04:20PM -0400, Noah Misch wrote: On Thu, Mar 06, 2014 at 11:52:22PM -0500, Noah Misch wrote: On Thu, Mar 06, 2014 at 12:44:34PM -0500, Tom Lane wrote: I'm inclined to suggest that we should put the socket under $CWD by default, but provide some way for the user

Re: [HACKERS] inherit support for foreign tables

2014-03-23 Thread Etsuro Fujita
(2014/03/20 21:59), Etsuro Fujita wrote: Here is a simple example for the case where the use_remote_estimate option is true: Sorry, I incorrectly wrote it. The following example is for the case where the option is *false*, as you see. # On mydatabase mydatabase=# CREATE TABLE mytable (id

Re: [HACKERS] Minimum supported version of Python?

2014-03-23 Thread Tom Lane
I wrote: Well ... [2.3] passes in C locale, anyway. 9.1 appears to have a problem if using UTF8 encoding: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedogdt=2014-03-19%2017%3A00%3A48 Some bisection tests say that it started failing after commit

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-23 Thread Wang, Jing
On Thursday, 20 March 2014 2:45 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Mar 19, 2014 at 6:25 AM, Wang, Jing ji...@fast.au.fujitsu.com wrote: On Friday, 14 March 2014 2:42 PM, Amit Kapila amit.kapil...@gmail.com wrote: I think it might be okay to even change this API to return