Re: [HACKERS] 9.5: Better memory accounting, towards memory-bounded HashAgg

2014-08-20 Thread Jeff Davis
On Tue, 2014-08-19 at 12:54 +0200, Tomas Vondra wrote: The use-case for this is tracking a chosen subtree of contexts - e.g. aggcontext and below, so I'd expect the tracked subtrees to be relatively shallow. Am I right? Right. My fear is that by removing the inheritance bit, we'll hurt cases

Re: [HACKERS] Trove with PostgreSQL-XC

2014-08-20 Thread Mark Kirkwood
On 19/08/14 23:14, Vivek Singh Raghuwanshi wrote: Hi All, Please let me know is that possible to use Openstack Trove with Postgres-XC. With instances and Baremetal (after Juno Release). I Know it is possible to use other medium like MySQL or PostgreSQL, but i am not sure about XC. AFAIK [1],

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-08-20 Thread Dilip kumar
15 July 2014 19:29 Amit Kapila Wrote, Implementation details: --- 1. This feature is implemented only for tar format in windows as native windows utilites are not able to create symlinks while extracting files from tar (It might be possible to create symlinks if

Re: [HACKERS] KNN searches support for SP-GiST [GSOC'14]

2014-08-20 Thread Heikki Linnakangas
On 08/20/2014 03:35 AM, Vladislav Sterzhanov wrote: Hi there, pg-Hackers! Here I go with the patch which brings up the possibility to perform nearest-neighbour searches on SP-GiSTs (as of now includes implementation for quad and kd trees). Pre-reviewed by my GSoC mentor Alexander Korotkov.

[HACKERS] August commitfest

2014-08-20 Thread Heikki Linnakangas
Per the schedule agreed on in the Developer Meeting in Ottawa, the August commitfest began five days ago. We don't seem to have a commitfest manager, and the commitfest has so far failed to manage itself. To get things going, I'm picking up the Commitfest Manager Mace I found from behind the

Re: [HACKERS] August commitfest

2014-08-20 Thread David Rowley
On Wed, Aug 20, 2014 at 7:17 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Per the schedule agreed on in the Developer Meeting in Ottawa, the August commitfest began five days ago. We don't seem to have a commitfest manager, and the commitfest has so far failed to manage itself. To

Re: [HACKERS] New Model For Role Attributes and Fine Grained Permssions

2014-08-20 Thread Heikki Linnakangas
On 08/19/2014 04:27 AM, Brightwell, Adam wrote: Hi All, This is a proof-of-concept patch for a new model around role attributes and fine grained permissions meant to alleviate the current over dependence on superuser. Hmm. How does this get us any closer to fine-grained permissions? I guess

Re: [HACKERS] August commitfest

2014-08-20 Thread Heikki Linnakangas
On 08/20/2014 10:42 AM, David Rowley wrote: On Wed, Aug 20, 2014 at 7:17 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Per the schedule agreed on in the Developer Meeting in Ottawa, the August commitfest began five days ago. We don't seem to have a commitfest manager, and the

Re: [HACKERS] [PATCH] introduce XLogLockBlockRangeForCleanup()

2014-08-20 Thread Heikki Linnakangas
On 07/07/2014 11:46 AM, Abhijit Menon-Sen wrote: At 2014-07-07 14:02:15 +0530, amit.khande...@enterprisedb.com wrote: Other than some minor comments as mentioned below, I don't have any more issues, it looks all good. Thank you. (Updated patch attached.) I don't think the new

Re: [HACKERS] August commitfest

2014-08-20 Thread Heikki Linnakangas
I have cleaned up the Commitfest of patches that have been in Waiting for Author state for weeks or more. I believe the list is now an accurate representation of the actual state of the patches. Patch authors - Please check if a patch of yours is in Waiting for Author state. It

Re: [HACKERS] [PATCH] Fix search_path default value separator.

2014-08-20 Thread Heikki Linnakangas
On 08/15/2014 04:58 PM, Bruce Momjian wrote: On Fri, Aug 15, 2014 at 10:40:59PM +0900, Fujii Masao wrote: Heh. I'm not particularly averse to changing this, but I guess I don't see any particular benefit of changing it either. Either comma or comma-space is a legal separator, so why worry

Re: [HACKERS] better atomics - v0.5

2014-08-20 Thread Heikki Linnakangas
Hi Andres, Are you planning to continue working on this? Summarizing the discussion so far: * Robert listed a bunch of little cleanup tasks (http://www.postgresql.org/message-id/ca+tgmozshvvqjakul6p3kdvzvpibtgkzoti3m+fvvjg5v+x...@mail.gmail.com). Amit posted yet more detailed commends. *

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-08-20 Thread Heikki Linnakangas
On 07/25/2014 07:10 PM, Alexey Klyukin wrote: Greetings, I'd like to propose a patch for checking subject alternative names entry in the SSL certificate for DNS names during SSL authentication. Thanks! I just ran into this missing feature last week, while working on my SSL test suite. So +1

Re: Compute attr_needed for child relations (was Re: [HACKERS] inherit support for foreign tables)

2014-08-20 Thread Etsuro Fujita
Hi Ashutish, (2014/08/14 22:30), Ashutosh Bapat wrote: On Thu, Aug 14, 2014 at 10:05 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp mailto:fujita.ets...@lab.ntt.co.jp wrote: (2014/08/08 18:51), Etsuro Fujita wrote: (2014/06/30 22:48), Tom Lane wrote: I wonder whether it isn't

Re: [HACKERS] better atomics - v0.5

2014-08-20 Thread Andres Freund
Hi, On 2014-08-20 12:43:05 +0300, Heikki Linnakangas wrote: Are you planning to continue working on this? Yes, I am! I've recently been on holiday and now I'm busy with catching up with everything that has happened since. I hope to have a next version ready early next week. Greetings, Andres

Re: [HACKERS] inherit support for foreign tables

2014-08-20 Thread Etsuro Fujita
Hi Noah, Thank you for the review! (2014/07/02 11:23), Noah Misch wrote: On Fri, Jun 20, 2014 at 05:04:06PM +0900, Kyotaro HORIGUCHI wrote: Attached is the rebased patch of v11 up to the current master. I've been studying this patch. SELECT FOR UPDATE on the inheritance parent fails with a

Re: [HACKERS] August commitfest

2014-08-20 Thread Etsuro Fujita
Hi Heikki, (2014/08/20 17:50), Heikki Linnakangas wrote: I have cleaned up the Commitfest of patches that have been in Waiting for Author state for weeks or more. I believe the list is now an accurate representation of the actual state of the patches. Thank you for the work! I chaged the

Re: [HACKERS] add line number as prompt option to psql

2014-08-20 Thread Jeevan Chalke
Hi, I have reviewed this: I have initialize cur_lineno to UINTMAX - 2. And then observed following behaviour to check wrap-around. postgres=# \set PROMPT1 '%/[%l]%R%# ' postgres[18446744073709551613]=# \set PROMPT2 '%/[%l]%R%# ' postgres[18446744073709551613]=# select

Re: [HACKERS] tweaking NTUP_PER_BUCKET

2014-08-20 Thread Heikki Linnakangas
On 07/20/2014 07:17 PM, Tomas Vondra wrote: On 19.7.2014 20:24, Tomas Vondra wrote: On 13.7.2014 21:32, Tomas Vondra wrote: The current patch only implemnents this for tuples in the main hash table, not for skew buckets. I plan to do that, but it will require separate chunks for each skew

Re: [HACKERS] Hokey wrong versions of libpq in apt.postgresql.org

2014-08-20 Thread Greg Stark
On Sat, Aug 9, 2014 at 2:23 AM, Tom Lane t...@sss.pgh.pa.us wrote: If the Debian guidelines think that only SO major version need be considered, they're wrong, at least for the way we've been treating that. The Debian approach is that you should have precisely one installed copy of a library

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-20 Thread Heikki Linnakangas
I think this has had enough review for a WIP patch. I'm marking this as Returned with Feedback in the commitfest because: * should use LSNs instead of a md5 * this doesn't do anything useful on its own, hence would need to see the whole solution before committing * not clear how this would be

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Greg Stark
On Tue, Aug 19, 2014 at 10:42 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Is there a way to create a link to a file which only exists as an open file descriptor? If there was, you could create a temp file, open an fd, then delete the file. That would remove the issue with files being

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Greg Stark
c.f.: O_TMPFILE (since Linux 3.11) Create an unnamed temporary file. The pathname argument specifies a directory; an unnamed inode will be created in that directory's filesystem. Anything written to the resulting file will be lost

Re: [HACKERS] tweaking NTUP_PER_BUCKET

2014-08-20 Thread Tomas Vondra
On 20 Srpen 2014, 14:05, Heikki Linnakangas wrote: On 07/20/2014 07:17 PM, Tomas Vondra wrote: On 19.7.2014 20:24, Tomas Vondra wrote: On 13.7.2014 21:32, Tomas Vondra wrote: The current patch only implemnents this for tuples in the main hash table, not for skew buckets. I plan to do that,

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Alvaro Herrera
Greg Stark wrote: char path[PATH_MAX]; fd = open(/path/to/dir, O_TMPFILE | O_RDWR, S_IRUSR | S_IWUSR); /* File I/O on 'fd'... */ snprintf(path, PATH_MAX, /proc/self/fd/%d,

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Andres Freund
On 2014-08-19 17:42:06 -0400, Alvaro Herrera wrote: MauMau wrote: With that said, copying to a temporary file like dest.tmp and renaming it to dest sounds worthwhile even as a basic copy utility. I want to avoid copying to a temporary file with a fixed name like _copy.tmp, because some

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Alvaro Herrera
Andres Freund wrote: On 2014-08-19 17:42:06 -0400, Alvaro Herrera wrote: MauMau wrote: With that said, copying to a temporary file like dest.tmp and renaming it to dest sounds worthwhile even as a basic copy utility. I want to avoid copying to a temporary file with a fixed name

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Greg Stark
On Wed, Aug 20, 2014 at 2:27 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Hmm, the real trick here is linkat(... /proc/self/foobar), not the O_TMPFILE: you can have an open file descriptor to an invisible file simply by creating a normal file and unlinking it. I looked at linkat()

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Andres Freund
On 2014-08-20 09:50:56 -0400, Alvaro Herrera wrote: Andres Freund wrote: On 2014-08-19 17:42:06 -0400, Alvaro Herrera wrote: MauMau wrote: With that said, copying to a temporary file like dest.tmp and renaming it to dest sounds worthwhile even as a basic copy utility. I want

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Alvaro Herrera
Greg Stark wrote: On Wed, Aug 20, 2014 at 2:27 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Hmm, the real trick here is linkat(... /proc/self/foobar), not the O_TMPFILE: you can have an open file descriptor to an invisible file simply by creating a normal file and unlinking it. I

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-08-20 09:50:56 -0400, Alvaro Herrera wrote: Andres Freund wrote: Isn't this a solution looking for a problem? We're using tempfiles in dozens of other places and I really don't see why this is the place to stop doing so. Just copy to

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Andres Freund
On 2014-08-20 10:19:33 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-20 09:50:56 -0400, Alvaro Herrera wrote: Andres Freund wrote: Isn't this a solution looking for a problem? We're using tempfiles in dozens of other places and I really don't see why this

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-08-20 Thread Amit Kapila
On Wed, Aug 20, 2014 at 12:12 PM, Dilip kumar dilip.ku...@huawei.com wrote: I have reviewed the patch and did not find any major comments. Thanks for the review. There are some comments I would like to share with you 1. Rebase the patch to current GIT head. Done. 2. +

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-08-20 10:19:33 -0400, Tom Lane wrote: Alternatively, you could use the process PID as part of the temp file name; which is probably a good idea anyway. I think that's actually worse, because nothing will clean up those unless you

Re: [HACKERS] jsonb format is pessimal for toast compression

2014-08-20 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: On 08/15/2014 04:19 PM, Tom Lane wrote: Personally I'd prefer to go to the all-lengths approach, but a large part of that comes from a subjective assessment that the hybrid approach is too messy. Others might well disagree. ... So, that extraction test

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-20 Thread Thom Brown
On 17 August 2014 21:45, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Mon, Jul 28, 2014 at 2:24 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Mon, Jul 28, 2014 at 1:41 PM, Christoph Berg c...@df7cb.de wrote: Re: Fabrízio de Royes Mello 2014-07-28

[HACKERS] Patching for increasing the number of columns

2014-08-20 Thread Mayeul Kauffmann
Hello, I am trying to patch the server source to increase the number of columns above 1600. I'm not planning to commit this but as suggested elsewhere [1], someone might suggest a configure option based on this. I came up with a patch which seems to work (see below), but 3 of the 136 tests

Re: [HACKERS] Patch status: delta relations in AFTER triggers

2014-08-20 Thread David Fetter
On Wed, Aug 20, 2014 at 07:29:39AM -0700, Kevin Grittner wrote: Heikki Linnakangas hlinnakan...@vmware.com wrote: What's the status of the delta relations in AFTER triggers patch? I saw you had a lively discussion with Amit in the last two weeks, but I couldn't tell if it's still Needs

Re: [HACKERS] Patching for increasing the number of columns

2014-08-20 Thread Tom Lane
Mayeul Kauffmann mayeul.kauffm...@free.fr writes: I am trying to patch the server source to increase the number of columns above 1600. I'm not planning to commit this but as suggested elsewhere [1], someone might suggest a configure option based on this. I came up with a patch which seems to

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-20 Thread Fabrízio de Royes Mello
On Wed, Aug 20, 2014 at 12:35 PM, Thom Brown t...@linux.com wrote: Hi Fabrizio, + This form changes the table persistence type from unlogged to permanent or + from unlogged to permanent (see xref linkend=SQL-CREATETABLE-UNLOGGED). Shouldn't this read unlogged to permanent or from

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-20 Thread Robert Haas
On Mon, Aug 18, 2014 at 11:02 AM, Baker, Keith [OCDUS Non-JJ] kbak...@its.jnj.com wrote: My proof of concept code (steps a though e below) avoided any reading or writing to the pipe (and associated handling of SIGPIPE), it just relied on postmaster open of PIPE with ENXIO to indicate all is

Re: [HACKERS] Patching for increasing the number of columns

2014-08-20 Thread Mayeul Kauffmann
Tom wrote: You would have to show us the actual failure diffs to get much useful comment, but in general increasing the size of tuple headers could easily lead to changes in plan choices Thank you Tom. So there is some hope! In effect the query plan is different for the join and the view

Re: [HACKERS] Patch status: delta relations in AFTER triggers

2014-08-20 Thread Kevin Grittner
David Fetter da...@fetter.org wrote: On Wed, Aug 20, 2014 at 07:29:39AM -0700, Kevin Grittner wrote: The patch that David offered to use the tuplestores in C should probably be updated to show both direct use based on what is in TriggerData and SPI use.  I will leave that to David to

Re: [HACKERS] Patch status: delta relations in AFTER triggers

2014-08-20 Thread David Fetter
On Wed, Aug 20, 2014 at 09:59:11AM -0700, Kevin Grittner wrote: David Fetter da...@fetter.org wrote: On Wed, Aug 20, 2014 at 07:29:39AM -0700, Kevin Grittner wrote: The patch that David offered to use the tuplestores in C should probably be updated to show both direct use based on what is

Re: [HACKERS] Patching for increasing the number of columns

2014-08-20 Thread Tom Lane
Mayeul Kauffmann mayeul.kauffm...@free.fr writes: Tom wrote: You would have to show us the actual failure diffs to get much useful comment, but in general increasing the size of tuple headers could easily lead to changes in plan choices Thank you Tom. So there is some hope! In effect the

Re: [HACKERS] After switching primary server while using replication slot.

2014-08-20 Thread Robert Haas
On Tue, Aug 19, 2014 at 6:25 AM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 18, 2014 at 11:16 PM, Sawada Masahiko sawada.m...@gmail.com wrote: Hi all, After switching primary serer while using repliaction slot, the standby server will not able to connect new primary server.

Re: [HACKERS] failures on barnacle (CLOBBER_CACHE_RECURSIVELY) because of memory leaks

2014-08-20 Thread Tomas Vondra
Hi, On 13.8.2014 19:17, Tomas Vondra wrote: On 13.8.2014 17:52, Tom Lane wrote: * I'm a bit dubious about testing -DRANDOMIZE_ALLOCATED_MEMORY in the same build as -DCLOBBER_CACHE_RECURSIVELY, because each of these is darned expensive and it's not clear you'd learn anything by running them

Re: [HACKERS] 9.5: Memory-bounded HashAgg

2014-08-20 Thread Robert Haas
On Sun, Aug 17, 2014 at 1:17 PM, Tomas Vondra t...@fuzzy.cz wrote: Being able to batch inner and outer relations in a matching way is certainly one of the reasons why hashjoin uses that particular scheme. There are other reasons, though - for example being able to answer 'Does this group

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-08-20 Thread Robert Haas
On Tue, Aug 19, 2014 at 7:08 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Aug 15, 2014 at 12:55 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Aug 11, 2014 at 12:59 AM, Amit Kapila amit.kapil...@gmail.com wrote: 1. +Number of parallel connections to perform the

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-20 Thread Baker, Keith [OCDUS Non-JJ]
Robert and Tom, Sorry for any confusion, I will try to clarify. Here is progression of events as I recall them: - My Initial QNX 6.5 port proposal lacked a robust replacement for the existing System V shared memory locking mechanism, a show stopper. - Robert proposed a nice set of possible

Re: [HACKERS] jsonb format is pessimal for toast compression

2014-08-20 Thread Josh Berkus
On 08/20/2014 08:29 AM, Tom Lane wrote: Since it's looking like this might be the direction we want to go, I took the time to flesh out my proof-of-concept patch. The attached version takes care of cosmetic issues (like fixing the comments), and includes code to avoid O(N^2) penalties in

Re: [HACKERS] jsonb format is pessimal for toast compression

2014-08-20 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: This means we need a beta3, no? If we change the on-disk format, I'd say so. So we don't want to wait around too long before deciding. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Patching for increasing the number of columns

2014-08-20 Thread Mayeul Kauffmann
On 20/08/14 18:17, Tom Lane wrote: Hm. I think the without_oid test is not showing that anything is broken; The other tests aren't showing any functional issue either AFAICS. Thanks a lot Tom! That's very helpful. I have written more details and some basic SQL tests in the wiki of the

Re: [HACKERS] Verbose output of pg_dump not show schema name

2014-08-20 Thread Fabrízio de Royes Mello
On Wed, Aug 20, 2014 at 2:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: I had a look at this patch, and here are a couple of comments: 1) Depending on how ArchiveEntry is called to register an object to dump, namespace may be NULL, but it is not the case namespace-dobj.name, so you

[HACKERS] documentation update for doc/src/sgml/func.sgml

2014-08-20 Thread Andreas 'ads' Scherbaum
Hi, attached is a small patch which updates doc/src/sgml/func.sgml. The change explains that functions like round() and others might behave different depending on your operating system (because of rint(3)) and that this is according to an IEEE standard. It also points out that #.5 is not

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-20 Thread Alvaro Herrera
Baker, Keith [OCDUS Non-JJ] wrote: Please let me know if more discussion is required, or if it would be reasonable for me (or someone else of your choosing) to work on the coding effort (perhaps targeted for 9.5?) If on the other hand it has been decided that a QNX port is not in the cards,

Re: [HACKERS] jsonb format is pessimal for toast compression

2014-08-20 Thread Josh Berkus
On 08/20/2014 08:29 AM, Tom Lane wrote: Josh Berkus j...@agliodbs.com writes: On 08/15/2014 04:19 PM, Tom Lane wrote: Personally I'd prefer to go to the all-lengths approach, but a large part of that comes from a subjective assessment that the hybrid approach is too messy. Others might well

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-20 Thread Baker, Keith [OCDUS Non-JJ]
Alvaro, Thanks for your interest and questions. At this point I have created a proof-of-concept QNX 6.5 port which appears to work on the surface (passes regression tests), but needs to be deemed production-quality. To work around lack of SA_RESTART, I added QNX-specific retry macros to port.h

Re: [HACKERS] jsonb format is pessimal for toast compression

2014-08-20 Thread Arthur Silva
What data are you using right now Josh? There's the github archive http://www.githubarchive.org/ Here's some sample data https://gist.github.com/igrigorik/2017462 -- Arthur Silva On Wed, Aug 20, 2014 at 6:09 PM, Josh Berkus j...@agliodbs.com wrote: On 08/20/2014 08:29 AM, Tom Lane wrote:

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Bruce Momjian
On Wed, Aug 20, 2014 at 10:36:40AM -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-20 10:19:33 -0400, Tom Lane wrote: Alternatively, you could use the process PID as part of the temp file name; which is probably a good idea anyway. I think that's actually

Re: [HACKERS] [patch] pg_copy - a command for reliable WAL archiving

2014-08-20 Thread Andres Freund
On 2014-08-20 18:58:05 -0400, Bruce Momjian wrote: On Wed, Aug 20, 2014 at 10:36:40AM -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-08-20 10:19:33 -0400, Tom Lane wrote: Alternatively, you could use the process PID as part of the temp file name; which is

Re: [HACKERS] Minmax indexes

2014-08-20 Thread Alvaro Herrera
Alvaro Herrera wrote: So here's v16, rebased on top of 9bac66020. As far as I am concerned, this is the last version before I start renaming everything to BRIN and then commit. FWIW in case you or others have interest, here's the diff between your patch and v16. Also, for illustrative

Re: [HACKERS] Verbose output of pg_dump not show schema name

2014-08-20 Thread Michael Paquier
On Thu, Aug 21, 2014 at 5:11 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: I just change if (tbinfo-dobj.namespace != NULL) to if (tbinfo-dobj.namespace). Fine for me. I am marking this patch as ready for committer. -- Michael -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-20 Thread Bruce Momjian
On Mon, Aug 18, 2014 at 04:05:07PM +0300, Heikki Linnakangas wrote: But more to the point, I thought the consensus was to use the highest LSN of all the blocks in the file, no? That's essentially free to calculate (if you have to read all the data anyway), and isn't vulnerable to collisions.

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-20 Thread Andres Freund
Hi, On 2014-08-20 21:21:41 +, Baker, Keith [OCDUS Non-JJ] wrote: To work around lack of SA_RESTART, I added QNX-specific retry macros to port.h With these macros in place make check runs cleanly (fails in many place without them). +#if defined(__QNX__) +/* QNX does not support

Re: [HACKERS] [PATCH] Incremental backup: add backup profile to base backup

2014-08-20 Thread Claudio Freire
On Wed, Aug 20, 2014 at 8:24 PM, Bruce Momjian br...@momjian.us wrote: On Mon, Aug 18, 2014 at 04:05:07PM +0300, Heikki Linnakangas wrote: But more to the point, I thought the consensus was to use the highest LSN of all the blocks in the file, no? That's essentially free to calculate (if you

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-20 Thread Andres Freund
On 2014-07-25 18:29:53 -0400, Tom Lane wrote: * QNX lacks sigaction SA_RESTART: I modified src/include/port.h to define macros to retry system calls upon EINTR (open,read,write,...) when compiled on QNX That's pretty scary too. For one thing, such macros would affect every

Re: [HACKERS] Verbose output of pg_dump not show schema name

2014-08-20 Thread Fabrízio de Royes Mello
On Wed, Aug 20, 2014 at 8:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Aug 21, 2014 at 5:11 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: I just change if (tbinfo-dobj.namespace != NULL) to if (tbinfo-dobj.namespace). Fine for me. I am marking this patch as

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-20 Thread Bruce Momjian
On Tue, Aug 19, 2014 at 03:26:56PM -0400, Stephen Frost wrote: I think there's been some improvement since I last had to go through the pain of setting this all up, and some of it is undoubtably OpenSSL's fault, but there's definitely quite a bit more we could be doing to make SSL support

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-20 Thread Bruce Momjian
On Tue, Aug 19, 2014 at 03:47:17PM -0400, Stephen Frost wrote: * Robert Haas (robertmh...@gmail.com) wrote: BTW, if we're beating on libpq, I wonder if we shouldn't consider bumping the soversion at some point. I mean, I know that we technically don't need to do that if we're only *adding*

Re: [HACKERS] add line number as prompt option to psql

2014-08-20 Thread Sawada Masahiko
On Wed, Aug 20, 2014 at 9:00 PM, Jeevan Chalke jeevan.cha...@enterprisedb.com wrote: Hi, I have reviewed this: I have initialize cur_lineno to UINTMAX - 2. And then observed following behaviour to check wrap-around. postgres=# \set PROMPT1 '%/[%l]%R%# ' postgres[18446744073709551613]=#

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-08-20 Thread Amit Kapila
On Thu, Aug 21, 2014 at 12:04 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Aug 19, 2014 at 7:08 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Aug 15, 2014 at 12:55 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Aug 11, 2014 at 12:59 AM, Amit Kapila

Re: Compute attr_needed for child relations (was Re: [HACKERS] inherit support for foreign tables)

2014-08-20 Thread Ashutosh Bapat
On Wed, Aug 20, 2014 at 3:25 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Hi Ashutish, (2014/08/14 22:30), Ashutosh Bapat wrote: On Thu, Aug 14, 2014 at 10:05 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp mailto:fujita.ets...@lab.ntt.co.jp wrote: (2014/08/08 18:51), Etsuro

Re: [HACKERS] Support for N synchronous standby servers

2014-08-20 Thread Michael Paquier
On Fri, Aug 15, 2014 at 9:28 PM, Fujii Masao masao.fu...@gmail.com wrote: You added check_synchronous_standby_num() as the GUC check function for synchronous_standby_num, and checked that there. But that seems to be wrong. You can easily see the following error messages even if

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-20 Thread furuyao
When replication slot is not specified in pg_receivexlog, the flush location in the feedback message always indicates invalid. So there seems to be no need to send the feedback as soon as fsync is issued, in that case. How should this option work when replication slot is not specified?