Re: [HACKERS] New Event Trigger: table_rewrite

2014-11-16 Thread Simon Riggs
On 16 November 2014 06:59, Michael Paquier michael.paqu...@gmail.com wrote: Note that this patch has been submitted but there have been no real discussion around it.. This seems a bit too fast to commit it, no? Committing uncontentious patches at the end of the commitfest seems normal, no? --

Re: [HACKERS] New Event Trigger: table_rewrite

2014-11-16 Thread Simon Riggs
On 16 November 2014 06:59, Michael Paquier michael.paqu...@gmail.com wrote: 1) This patch is authorizing VACUUM and CLUSTER to use the event triggers ddl_command_start and ddl_command_end, but aren't those commands actually not DDLs but control commands? I could go either way on that. I'm

Re: [HACKERS] Review of Refactoring code for sync node detection

2014-11-16 Thread Simon Riggs
On 31 October 2014 00:27, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Oct 31, 2014 at 6:59 AM, Jim Nasby jim.na...@bluetreble.com wrote: If we stick with this version I'd argue it makes more sense to just stick the sync_node = and priority = statements into the if block and ditch

Re: [HACKERS] Review of Refactoring code for sync node detection

2014-11-16 Thread Michael Paquier
Thanks for the comments! On Sun, Nov 16, 2014 at 8:32 PM, Simon Riggs si...@2ndquadrant.com wrote: On 31 October 2014 00:27, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Oct 31, 2014 at 6:59 AM, Jim Nasby jim.na...@bluetreble.com wrote: If we stick with this version I'd argue it

Re: [HACKERS] Failback to old master

2014-11-16 Thread didier
Hi, On Sat, Nov 15, 2014 at 5:31 PM, Maeldron T. maeld...@gmail.com wrote: A safely shut down master (-m fast is safe) can be safely restarted as a slave to the newly promoted master. Fast shutdown shuts down all normal connections, does a shutdown checkpoint and then waits for this

Re: [HACKERS] alternative model for handling locking in parallel groups

2014-11-16 Thread Robert Haas
On Fri, Nov 14, 2014 at 12:03 PM, Andres Freund and...@2ndquadrant.com wrote: Note that you'd definitely not want to do this naively - currently there's baked in assumptions into the vaccum code that only one backend is doing parts of it. I think there's Did something you intended get left

Re: [HACKERS] Failback to old master

2014-11-16 Thread Maeldron T.
On 16/11/14 13:13, didier wrote: I think you have to add recovery_target_timeline = '2' in recovery.conf with '2' being the new primary timeline . cf http://www.postgresql.org/docs/9.4/static/recovery-target-settings.html Thank you. Based on the link I have added: recovery_target_timeline =

Re: [HACKERS] Index scan optimization

2014-11-16 Thread Simon Riggs
On 30 October 2014 08:43, Haribabu Kommi kommi.harib...@gmail.com wrote: I marked the patch as ready for committer. This looks very interesting. The value of the patch seems to come from skipping costly checks. Your performance test has a leading VARCHAR column, so in that specific case

Re: [HACKERS] Order of views in stats docs

2014-11-16 Thread Magnus Hagander
On Sun, Nov 9, 2014 at 3:46 PM, Magnus Hagander mag...@hagander.net wrote: On Thu, Nov 6, 2014 at 3:01 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/6/14 6:16 AM, Magnus Hagander wrote: Another thought I had in that case is maybe we need to break out the pg_stat_activity and

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-11-16 Thread Christian Ullrich
* Alvaro Herrera wrote: Michael Paquier wrote: Btw, perhaps this diff should be pushed as a different patch as this is a rather different thing: - if (heapRelation-rd_rel-relpersistence == RELPERSISTENCE_UNLOGGED + if (indexRelation-rd_rel-relpersistence ==

Re: [HACKERS] logical decoding - reading a user catalog table

2014-11-16 Thread Steve Singer
On 11/13/2014 02:44 PM, Andres Freund wrote: Hi Steve, If it still happens, could you send me instructions of how to reproduce the problem after cloning the necessary source repositories? It's quite hard to validate a possible fix otherwise. 1. Install PG 9.4 2. Perform an initdb

Re: [HACKERS] printing table in asciidoc with psql

2014-11-16 Thread Pavel Stehule
Hi 2014-11-07 22:37 GMT+01:00 Alvaro Herrera alvhe...@2ndquadrant.com: I did \o /tmp/tst, then \dS create table eh | oh (); \dS and then filtered the output file to HTML. The CREATE TABLE tag ended up in the same line as the title of the following table. I think there's a newline is

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

2014-11-16 Thread Fujii Masao
On Sat, Nov 15, 2014 at 9:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Nov 15, 2014 at 3:42 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-11-15 03:25:16 +0900, Fujii Masao wrote: On Fri, Nov 14, 2014 at 7:22 PM, furu...@pm.nttdata.co.jp wrote: pg_ctl stop does't

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-11-16 Thread Dilip kumar
On 13 November 2014 15:35 Amit Kapila Wrote, As mentioned by you offlist that you are not able reproduce this issue, I have tried again and what I observe is that I am able to reproduce it only on *release* build and some cases work without this issue as well, example: ./vacuumdb

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

2014-11-16 Thread Michael Paquier
On Mon, Nov 17, 2014 at 10:02 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Nov 15, 2014 at 9:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: Yep, sounds a good thing to do if master requested answer from the client in the keepalive message. Something like the patch attached

Re: [HACKERS] BRIN indexes - TRAP: BadArgument

2014-11-16 Thread Amit Kapila
On Sat, Nov 8, 2014 at 1:26 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I just pushed this, after some more minor tweaks. Thanks, and please do continue testing! Few typo's and few questions 1. * range. Need to an extra flag in mmtuples for that. */ Datum