Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Alexander Korotkov
On Fri, May 15, 2015 at 2:30 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 02:28 AM, Heikki Linnakangas wrote: I think this is now ready for committing, but I'm pretty tired now so I'll read through this one more time in the morning, so that I won't wake up to a red buildfarm.

[HACKERS] log bloating with shortlife bgworkers?

2015-05-15 Thread Pavel Stehule
Hi I am planning to use short living bg workers. I was little bit surprised so any start and finish does entry in log. Is there any plan to decrease a log level for these purposes? Regards Pavel

Re: [HACKERS] multivariate statistics / patch v6

2015-05-15 Thread Kyotaro HORIGUCHI
Hello, At Thu, 14 May 2015 12:35:50 +0200, Tomas Vondra tomas.von...@2ndquadrant.com wrote in 55547a86.8020...@2ndquadrant.com On 05/13/15 10:31, Kyotaro HORIGUCHI wrote: Hello, this might be somewhat out of place but strongly related to this patch so I'll propose this here. This is a

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-15 Thread Shigeru Hanada
2015-05-15 8:43 GMT+09:00 Kouhei Kaigai kai...@ak.jp.nec.com: Regarding of FDW, as Hanada-san mentioned, I'm uncertain whether similar feature is also needed because its join-pushdown feature scan on the result-set of remotely joined relations, thus no need to have local child Path nodes. So,

Re: [HACKERS] Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-05-15 Thread Amit Kapila
On Thu, May 14, 2015 at 10:29 PM, Andrew Dunstan and...@dunslane.net wrote: On 05/14/2015 10:52 AM, Robert Haas wrote: On Thu, May 14, 2015 at 12:12 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, May 14, 2015 at 2:10 AM, Andrew Dunstan and...@dunslane.net wrote: How about if we

[HACKERS] Minor improvements to alter_foreign_table.sgml

2015-05-15 Thread Etsuro Fujita
Hi, Here is a patch to improve the ALTER FOREIGN TABLE documentation a bit: (1) fix markup for ADD table_constraint [ NOT VALID ] and (2) remove an unnecessary comma from an example query. Best regards, Etsuro Fujita diff --git a/doc/src/sgml/ref/alter_foreign_table.sgml

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-15 Thread Fujii Masao
On Thu, May 14, 2015 at 4:30 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, May 14, 2015 at 9:58 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, May 13, 2015 at 8:25 PM, Sawada Masahiko sawada.m...@gmail.com wrote: The v15 patch emits a line for each table when reindexing

Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Alexander Korotkov
On Fri, May 15, 2015 at 2:48 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 11:31 AM, Alexander Korotkov wrote: On Fri, May 15, 2015 at 2:30 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 02:28 AM, Heikki Linnakangas wrote: I think this is now ready for

Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Heikki Linnakangas
On 05/15/2015 11:31 AM, Alexander Korotkov wrote: On Fri, May 15, 2015 at 2:30 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 02:28 AM, Heikki Linnakangas wrote: I think this is now ready for committing, but I'm pretty tired now so I'll read through this one more time in the

Re: [HACKERS] Patch for bug #12845 (GB18030 encoding)

2015-05-15 Thread Arjen Nienhuis
On Thu, May 14, 2015 at 11:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Robert Haas robertmh...@gmail.com writes: On Wed, May 6, 2015 at 11:13 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Maybe not, but at the very least we should consider getting it fixed in 9.5 rather than

[HACKERS] Support for N synchronous standby servers - take 2

2015-05-15 Thread Beena Emerson
There was a discussion on support for N synchronous standby servers started by Michael. Refer http://archives.postgresql.org/message-id/cab7npqr9c84ig0zuvhmqamq53vqsd4rc82vyci4dr27pvof...@mail.gmail.com . The use of hooks and dedicated language was suggested, however, it seemed to be an overkill

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-05-15 Thread Michael Paquier
On Fri, May 15, 2015 at 8:55 PM, Beena Emerson memissemer...@gmail.com wrote: There was a discussion on support for N synchronous standby servers started by Michael. Refer http://archives.postgresql.org/message-id/cab7npqr9c84ig0zuvhmqamq53vqsd4rc82vyci4dr27pvof...@mail.gmail.com . The use of

Re: [HACKERS] feature freeze and beta schedule

2015-05-15 Thread Simon Riggs
On 1 May 2015 at 18:05, Simon Riggs si...@2ndquadrant.com wrote: * TABLESAMPLE clause Doesn't seem very far from being done. Some questions about including (or not) DDL and contrib modules seem to remain. Will commit this soon OK, completely happy with this now and will commit

[HACKERS] Re: [COMMITTERS] pgsql: Allow GiST distance function to return merely a lower-bound.

2015-05-15 Thread Heikki Linnakangas
On 05/15/2015 03:17 PM, Heikki Linnakangas wrote: On 05/15/2015 03:05 PM, Fujii Masao wrote: Seems this patch causes the regression test of pg_trgm fail. The regression diff that I got is: *** /home/postgres/pgsql/head/contrib/pg_trgm/expected/pg_trgm.out 2013-07-23 16:46:22.212488785 +0900

[HACKERS] 9.5 open items

2015-05-15 Thread Bruce Momjian
I have processed all the open email items I can through mid-March, though I do have two pg_upgrade fixes pending application today. I will continue processing doc fixes and major bug fixes for 9.5, but everything else I do will be for 9.6. -- Bruce Momjian br...@momjian.us

Re: [HACKERS] best place for rtree strategy numbers

2015-05-15 Thread Tom Lane
Alvaro Herrera alvaro.herr...@2ndquadrant.com writes: So here's a patch for this. Looks reasonable to me (though I only eyeballed it, not tested). Do we want to push this into 9.5, or wait for 9.6? regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-15 Thread Fujii Masao
On Sun, May 10, 2015 at 2:23 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Sat, May 9, 2015 at 4:26 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Fri, May 8, 2015 at 4:23 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, May 7, 2015 at 7:55 PM,

Re: [HACKERS] ERROR: cannot GetMultiXactIdMembers() during recovery

2015-05-15 Thread Marko Tiikkaja
Hi hackers, Any chance to get this fixed in time for 9.1.16? .m -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-05-15 Thread Stephen Frost
* Haribabu Kommi (kommi.harib...@gmail.com) wrote: On Tue, May 5, 2015 at 6:48 AM, Peter Eisentraut pete...@gmx.net wrote: On 5/1/15 12:33 PM, Andres Freund wrote: On 2015-04-08 19:19:29 +0100, Greg Stark wrote: I'm not sure what the best way to handle the hand-off from patch contribution

Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Bruce Momjian
On Fri, May 15, 2015 at 02:48:29PM +0300, Heikki Linnakangas wrote: On 05/15/2015 11:31 AM, Alexander Korotkov wrote: On Fri, May 15, 2015 at 2:30 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 02:28 AM, Heikki Linnakangas wrote: I think this is now ready for committing, but

Re: [HACKERS] Changes to backup.sgml

2015-05-15 Thread Bruce Momjian
On Fri, May 15, 2015 at 08:15:51AM -0700, Joshua Drake wrote: On 05/15/2015 07:42 AM, Bruce Momjian wrote: 3. Push the rsync paragraph (and edit where appropriate) within the continuous archiving section. 3a. Add information about robocopy (windows rsync) Oh, yes, we should

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Andres Freund
On 2015-05-14 23:28:33 +0200, Andres Freund wrote: I've removed the use of GroupedVars and Andrew is right now working on structural changes. I'm not ready at this point to make a judgement. Andrew worked really hard and addressed the voiced concerns with the way chaining was done. In my last

Re: [HACKERS] i feel like compelled !

2015-05-15 Thread Robert Haas
On Wed, May 13, 2015 at 7:05 PM, Gianni nasus.maxi...@gmail.com wrote: Oh well... then, THANKS GUYS!!! I'm not the original poster, btw. I felt a bit 'abandoned' a while back, since I started using Interbase/Firebird since, like, ~2000. But since Firebird never really took off, I felt I had

[HACKERS] WALWriteLock contention

2015-05-15 Thread Robert Haas
WALWriteLock contention is measurable on some workloads. In studying the problem briefly, a couple of questions emerged: 1. Doesn't it suck to rewrite an entire 8kB block every time, instead of only the new bytes (and maybe a few bytes following that to spoil any old data that might be there)?

Re: [HACKERS] Changes to backup.sgml

2015-05-15 Thread Joshua D. Drake
On 05/15/2015 07:42 AM, Bruce Momjian wrote: 3. Push the rsync paragraph (and edit where appropriate) within the continuous archiving section. 3a. Add information about robocopy (windows rsync) Oh, yes, we should mention robocopy. I had never heard of that. 4. Move continuous

Re: [HACKERS] Patch for bug #12845 (GB18030 encoding)

2015-05-15 Thread Arjen Nienhuis
On Fri, May 15, 2015 at 4:10 PM, Tom Lane t...@sss.pgh.pa.us wrote: Arjen Nienhuis a.g.nienh...@gmail.com writes: GB18030 is a special case, because it's a full mapping of all unicode characters, and most of it is algorithmically defined. True. This makes UtfToLocal a bad choice to

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Joshua D. Drake
On 05/15/2015 12:32 PM, Josh Berkus wrote: Note that I am not proposing a general delay in feature freeze. I am specifically proposing an additional week for Grouping Sets and *only* for Grouping Sets. Core is in charge of releases. I believe like the other semi and formal organizations

Re: [HACKERS] brin regression test intermittent failures

2015-05-15 Thread Alvaro Herrera
Andrew Dunstan wrote: There's something odd about the brin regression tests. They seem to generate intermittent failures, which suggests some sort of race condition or ordering failure. See for example http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=fulmardt=2015-05-15%2001%3A02%3A28

Re: [HACKERS] WALWriteLock contention

2015-05-15 Thread Jeff Janes
On Fri, May 15, 2015 at 9:06 AM, Robert Haas robertmh...@gmail.com wrote: WALWriteLock contention is measurable on some workloads. In studying the problem briefly, a couple of questions emerged: ... 2. I don't really understand why WALWriteLock is set up to prohibit two backends from

[HACKERS] brin regression test intermittent failures

2015-05-15 Thread Andrew Dunstan
There's something odd about the brin regression tests. They seem to generate intermittent failures, which suggests some sort of race condition or ordering failure. See for example http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=fulmardt=2015-05-15%2001%3A02%3A28 and

Re: [HACKERS] brin regression test intermittent failures

2015-05-15 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Tom Lane wrote: Just from reading the documentation, couldn't the symptom we're seeing arise from autovacuum having hit the table right before brin_summarize_new_values got called? Well, I added a autovacuum_enabled=off to that table recently

Re: [HACKERS] brin regression test intermittent failures

2015-05-15 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Andrew Dunstan wrote: There's something odd about the brin regression tests. They seem to generate intermittent failures, which suggests some sort of race condition or ordering failure. See for example

Re: [HACKERS] brin regression test intermittent failures

2015-05-15 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Andrew Dunstan wrote: There's something odd about the brin regression tests. They seem to generate intermittent failures, which suggests some sort of race condition or ordering failure. See for example

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Andrew Dunstan
On 05/15/2015 04:35 PM, Robert Haas wrote: I guess JDBC has the same problem as Perl and JavaScript here: ? signals a bind variable. The next question is, why isn't there some escaping mechanism for that, like writing ?? or \? or something? FTR, Perl's DBD::Pg lets you do this:

Re: [HACKERS] i feel like compelled !

2015-05-15 Thread Jim Nasby
On 5/13/15 6:05 PM, Gianni wrote: What I really liked about Firebird, and then Postgres made me feel right at home, was standards-compliance with SQL and great feature set. I find myself most-often-than-not guessing how something ought to work in Postgres, based on past experiences, and finding

Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Jim Nasby
On 5/14/15 6:30 PM, Heikki Linnakangas wrote: On 05/15/2015 02:28 AM, Heikki Linnakangas wrote: I think this is now ready for committing, but I'm pretty tired now so I'll read through this one more time in the morning, so that I won't wake up to a red buildfarm. If anyone feels motivated to

Re: [HACKERS] trust authentication behavior

2015-05-15 Thread Kohei KaiGai
2015-05-16 5:13 GMT+09:00 Robert Haas robertmh...@gmail.com: On Thu, May 14, 2015 at 3:52 PM, David G. Johnston david.g.johns...@gmail.com wrote: On Thu, May 14, 2015 at 12:22 PM, Denis Kirjanov k...@itsirius.su wrote: Yeah, but the idea is to do that without the pg_hba.conf You may want to

Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Alexander Korotkov
On Fri, May 15, 2015 at 2:49 PM, Alexander Korotkov aekorot...@gmail.com wrote: On Fri, May 15, 2015 at 2:48 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 11:31 AM, Alexander Korotkov wrote: On Fri, May 15, 2015 at 2:30 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Jim Nasby
On 5/13/15 7:46 PM, Kouhei Kaigai wrote: * ctidscan as an example of custom-scan This basically hasn't gotten any attention, which may mean nobody cares enough to justify putting it in the tree. We need to either push it to next CF or reject altogether. Agreed. I was fine with never

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Jim Nasby
On 5/14/15 5:48 PM, Tom Lane wrote: True, but I have problems with leaders acting in a way that is unfair to those with less power. Have you considered how demoralizing it is to work in an unfair environment? Unfairness happens, but as leaders, we are supposed to try to avoid it, not cause it.

Re: [HACKERS] Patch for bug #12845 (GB18030 encoding)

2015-05-15 Thread Tom Lane
Arjen Nienhuis a.g.nienh...@gmail.com writes: GB18030 is a special case, because it's a full mapping of all unicode characters, and most of it is algorithmically defined. True. This makes UtfToLocal a bad choice to implement it. I disagree with that conclusion. There are still 3+

Re: [HACKERS] best place for rtree strategy numbers

2015-05-15 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvaro.herr...@2ndquadrant.com writes: So here's a patch for this. Looks reasonable to me (though I only eyeballed it, not tested). Do we want to push this into 9.5, or wait for 9.6? My intention is to push this now, before pushing brin inclusion. --

Re: [HACKERS] Changes to backup.sgml

2015-05-15 Thread Bruce Momjian
On Thu, May 14, 2015 at 09:53:01AM -0700, Joshua Drake wrote: -hackers, After my brain flatulence last week on backups, I decided to read the docs again. There are some improvements that I would like to make and wanted some feedback: 1. File System Level Backup The section should be

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Andres Freund
On 2015-05-13 11:38:27 -0400, Tom Lane wrote: Looking at what remains open in the current commitfest: As of now the remaining items !bugfix entries are: * GIN fillfactor I'd like to put this one on Heikki's plate as well, since he's touched the GIN code more than anyone else lately. While

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-05-15 Thread Haribabu Kommi
On Fri, May 15, 2015 at 11:24 PM, Stephen Frost sfr...@snowman.net wrote: * Haribabu Kommi (kommi.harib...@gmail.com) wrote: On Tue, May 5, 2015 at 6:48 AM, Peter Eisentraut pete...@gmx.net wrote: It still looks quite dubious to me. The more I test this, the more fond I grow of the idea of

Re: [HACKERS] Final Patch for GROUPING SETS

2015-05-15 Thread Andres Freund
On 2015-05-16 00:06:12 +0200, Andres Freund wrote: Andrew (and I) have been working on this since. Here's the updated and rebased patch. It misses a decent commit message and another beautification readthrough. I've spent the last hour going through the thing again and all I hit was a

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Michael Paquier
On Sat, May 16, 2015 at 11:00 AM, Andres Freund wrote: On 2015-05-13 11:38:27 -0400, Tom Lane wrote: * GIN fillfactor I'd like to put this one on Heikki's plate as well, since he's touched the GIN code more than anyone else lately. While sad, I think this is going to have to be moved.

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Tom Lane
Andres Freund and...@anarazel.de writes: I think we can close the commitfest now? Moving these three entries to the next one? Yeah, I don't think any of the remaining entries are committable. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Josh Berkus
On 05/14/2015 03:58 PM, Bruce Momjian wrote: On Thu, May 14, 2015 at 06:57:24PM -0400, Tom Lane wrote: Stephen Frost sfr...@snowman.net writes: * Bruce Momjian (br...@momjian.us) wrote: I will call for a vote that the freeze deadline be changed if this patch is rejected to due to time. I

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-05-15 Thread Josh Berkus
On 05/15/2015 11:30 AM, Robert Haas wrote: Once we enter beta (or even feature freeze), it's too late to whack around the algorithm heavily. We're pretty much committed to releasing and supporting whatever we have got at that point. I guess we could revert it if it doesn't work out, but

Re: [HACKERS] broken documentation: BackgroundWorkerInitializeConnection(NULL, NULL);

2015-05-15 Thread Robert Haas
On Thu, May 14, 2015 at 8:25 AM, Pavel Stehule pavel.steh...@gmail.com wrote: The documentation (or this feature) is broken still If dbname is NULL or dboid is InvalidOid, the session is not connected to any particular database, but shared catalogs can be accessed. If username is NULL or

Re: [HACKERS] WALWriteLock contention

2015-05-15 Thread Joshua D. Drake
On 05/15/2015 09:06 AM, Robert Haas wrote: 2. I don't really understand why WALWriteLock is set up to prohibit two backends from flushing WAL at the same time. That seems unnecessary. Suppose we've got two backends that flush WAL one after the other. Assume (as is not unlikely) that the

Re: [HACKERS] ERROR: cannot GetMultiXactIdMembers() during recovery

2015-05-15 Thread Simon Riggs
On 15 May 2015 at 19:03, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Andres Freund wrote: Alternatively we could make MultiXactIdIsRunning() return false 9.3 when in recovery. I think that'd end up fixing things, but it seems awfully fragile to me. Hm, why fragile? It seems a

Re: [HACKERS] WALWriteLock contention

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 1:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: WALWriteLock contention is measurable on some workloads. In studying the problem briefly, a couple of questions emerged: 1. Doesn't it suck to rewrite an entire 8kB block every time,

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-05-15 Thread Robert Haas
On Wed, May 13, 2015 at 5:07 PM, Jeff Janes jeff.ja...@gmail.com wrote: With the warning it is very hard to correlate the discrepancy you do see with which column is causing it, as the warnings don't include table or column names (Assuming of course that you run it on a substantial

Re: [HACKERS] Changes to backup.sgml

2015-05-15 Thread Robert Haas
On Thu, May 14, 2015 at 12:53 PM, Joshua D. Drake j...@commandprompt.com wrote: 1. File System Level Backup The section should be a note within the larger document. It is largely a legacy section from before 8.3. I agree. I think this section is just plain weird at this point. Most people

Re: [HACKERS] Disabling trust/ident authentication configure option

2015-05-15 Thread Volker Aßmann
Yes, I'd like to know if Alvaros suggestion would in deed achieve consensus (possibly with Andrews addition). It looks like the most general solution but might be some work using autoconf ... Best regards, Volker On Wed, May 13, 2015 at 2:18 PM, Robert Haas robertmh...@gmail.com wrote: On

Re: [HACKERS] ERROR: cannot GetMultiXactIdMembers() during recovery

2015-05-15 Thread Alvaro Herrera
Andres Freund wrote: Alternatively we could make MultiXactIdIsRunning() return false 9.3 when in recovery. I think that'd end up fixing things, but it seems awfully fragile to me. Hm, why fragile? It seems a pretty decent answer -- pre-9.3, it's not possible for a tuple to be locked in

Re: [HACKERS] Missing importing option of postgres_fdw

2015-05-15 Thread Robert Haas
On Thu, May 14, 2015 at 6:37 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: On second thought, I noticed that as for this option, we cannot live without allowing IMPORT FOREIGN SCHEMA to return ALTER FOREIGN TABLE statements because we cannot declare the convalidated information in the

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 3:35 PM, Josh Berkus j...@agliodbs.com wrote: On 05/15/2015 11:30 AM, Robert Haas wrote: Once we enter beta (or even feature freeze), it's too late to whack around the algorithm heavily. We're pretty much committed to releasing and supporting whatever we have got at

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-05-15 Thread Josh Berkus
On 05/15/2015 12:58 PM, Robert Haas wrote: On Fri, May 15, 2015 at 3:35 PM, Josh Berkus j...@agliodbs.com wrote: On 05/15/2015 11:30 AM, Robert Haas wrote: Once we enter beta (or even feature freeze), it's too late to whack around the algorithm heavily. We're pretty much committed to

Re: [HACKERS] broken documentation: BackgroundWorkerInitializeConnection(NULL, NULL);

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 4:07 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Robert Haas wrote: On Fri, May 15, 2015 at 3:53 PM, Robert Haas robertmh...@gmail.com wrote: The test code I used to verify that this works is also attached. If there are no objections, I will commit and

Re: [HACKERS] trust authentication behavior

2015-05-15 Thread Robert Haas
On Thu, May 14, 2015 at 3:52 PM, David G. Johnston david.g.johns...@gmail.com wrote: On Thu, May 14, 2015 at 12:22 PM, Denis Kirjanov k...@itsirius.su wrote: Yeah, but the idea is to do that without the pg_hba.conf You may want to try describing the problem and not just ask if the chosen

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Dave Cramer
Not sure what the point of this is: as you indicated the ship has sailed so to speak Dave Cramer dave.cramer(at)credativ(dot)ca http://www.credativ.ca On 15 May 2015 at 15:14, Bruno Harbulot br...@distributedmatter.net wrote: Hello, I've been trying to use the new JSONB format using JDBC,

Re: [HACKERS] broken documentation: BackgroundWorkerInitializeConnection(NULL, NULL);

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 4:15 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Really? I was thinking of the test code as throwaway. I just wanted to fix the bug. Oh, that's fine then. I thought you wanted to push it. Nah, sorry, I shoulda been more clear about that. That was just so I

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 4:13 PM, Dave Cramer p...@fastcrypt.com wrote: Not sure what the point of this is: as you indicated the ship has sailed so to speak Well, if we were to agree this was a problem, we could introduce new, less-problematic operator names and then eventually deprecate the old

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Michael Meskes
As far, as I can tell, question mark operators are also incompatible with PostgreSQL's ECPG when using dynamic SQL. http://www.postgresql.org/docs/current/static/ecpg-dynamic.html (I'm pasting an example at the end of this message, tried with a PostgreSQL 9.4 server.) Indeed it is. The

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Dave Cramer
On 15 May 2015 at 16:41, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:38 PM, Dave Cramer p...@fastcrypt.com wrote: I don't really want to take a violently strong position on this without understanding what's really going on here. Well our solution was to use ?? but

Re: [HACKERS] broken documentation: BackgroundWorkerInitializeConnection(NULL, NULL);

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 3:53 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, May 14, 2015 at 8:25 AM, Pavel Stehule pavel.steh...@gmail.com wrote: The documentation (or this feature) is broken still If dbname is NULL or dboid is InvalidOid, the session is not connected to any

Re: [HACKERS] Patch for bug #12845 (GB18030 encoding)

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 3:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: However, I'm not that excited about changing it. We have not heard field complaints about these converters being too slow. What's more, there doesn't seem to be any practical way to apply the same idea to the other

Re: [HACKERS] broken documentation: BackgroundWorkerInitializeConnection(NULL, NULL);

2015-05-15 Thread Alvaro Herrera
Robert Haas wrote: On Fri, May 15, 2015 at 3:53 PM, Robert Haas robertmh...@gmail.com wrote: The test code I used to verify that this works is also attached. If there are no objections, I will commit and back-patch. Oops. Really attached this time. We have spi_worker in

Re: [HACKERS] log bloating with shortlife bgworkers?

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 2:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: I am planning to use short living bg workers. I was little bit surprised so any start and finish does entry in log. Is there any plan to decrease a log level for these purposes? Parallel query is going to hit that

Re: [HACKERS] broken documentation: BackgroundWorkerInitializeConnection(NULL, NULL);

2015-05-15 Thread Alvaro Herrera
Robert Haas wrote: On Fri, May 15, 2015 at 4:07 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Robert Haas wrote: On Fri, May 15, 2015 at 3:53 PM, Robert Haas robertmh...@gmail.com wrote: The test code I used to verify that this works is also attached. If there are no

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Dave Cramer
On 15 May 2015 at 16:21, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:13 PM, Dave Cramer p...@fastcrypt.com wrote: Not sure what the point of this is: as you indicated the ship has sailed so to speak Well, if we were to agree this was a problem, we could introduce

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 4:23 PM, Dave Cramer p...@fastcrypt.com wrote: Well, if we were to agree this was a problem, we could introduce new, less-problematic operator names and then eventually deprecate the old ones. Personally, it wouldn't take a lot to convince me that if a certain set of

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Dave Cramer
On 15 May 2015 at 16:35, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:23 PM, Dave Cramer p...@fastcrypt.com wrote: Well, if we were to agree this was a problem, we could introduce new, less-problematic operator names and then eventually deprecate the old ones.

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Robert Haas
On Fri, May 15, 2015 at 4:38 PM, Dave Cramer p...@fastcrypt.com wrote: I don't really want to take a violently strong position on this without understanding what's really going on here. Well our solution was to use ?? but that does mean we have to do some extra parsing which in a perfect

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Dave Cramer
On 15 May 2015 at 16:44, Dave Cramer p...@fastcrypt.com wrote: On 15 May 2015 at 16:41, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:38 PM, Dave Cramer p...@fastcrypt.com wrote: I don't really want to take a violently strong position on this without understanding

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Bruno Harbulot
On Fri, May 15, 2015 at 9:41 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:38 PM, Dave Cramer p...@fastcrypt.com wrote: I don't really want to take a violently strong position on this without understanding what's really going on here. Well our solution was to use

Re: [HACKERS] Minor improvement to create_foreign_table.sgml

2015-05-15 Thread Robert Haas
On Thu, May 14, 2015 at 4:07 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: The attached patch adds missing NO INHERIT to the CHECK clause in the synopsis section in the reference page on CREATE FOREIGN TABLE. Good catch. Committed. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Patch for bug #12845 (GB18030 encoding)

2015-05-15 Thread Tom Lane
Arjen Nienhuis a.g.nienh...@gmail.com writes: On Fri, May 15, 2015 at 4:10 PM, Tom Lane t...@sss.pgh.pa.us wrote: According to that, about half of the characters below U+ can be processed via linear conversions, so I think we ought to save table space by doing that. However, the remaining

[HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Bruno Harbulot
Hello, I've been trying to use the new JSONB format using JDBC, and ran into trouble with the question mark operators (?, ?| and ?). I realise there has already been a discussion about this (actually, it was about hstore, not jsonb, but that's more or less the same problem): -

Re: [HACKERS] WALWriteLock contention

2015-05-15 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: WALWriteLock contention is measurable on some workloads. In studying the problem briefly, a couple of questions emerged: 1. Doesn't it suck to rewrite an entire 8kB block every time, instead of only the new bytes (and maybe a few bytes following that

Re: [HACKERS] multivariate statistics / patch v6

2015-05-15 Thread Tomas Vondra
Hello, On 05/15/15 08:29, Kyotaro HORIGUCHI wrote: Hello, Regarding the functional dependencies - you're right there's room for improvement. For example it only works with dependencies between pairs of columns, not multi-column dependencies. Is this what you mean by incomplete? No, It

Re: [HACKERS] multivariate statistics / patch v6

2015-05-15 Thread Tomas Vondra
Hello, On 05/15/15 08:29, Kyotaro HORIGUCHI wrote: Hello, At Thu, 14 May 2015 12:35:50 +0200, Tomas Vondra tomas.von...@2ndquadrant.com wrote in 55547a86.8020...@2ndquadrant.com ... Regarding the functional dependencies - you're right there's room for improvement. For example it only works

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-15 Thread Andres Freund
On 2015-05-15 18:00:49 +0200, Andres Freund wrote: On 2015-05-14 23:28:33 +0200, Andres Freund wrote: I've removed the use of GroupedVars and Andrew is right now working on structural changes. I'm not ready at this point to make a judgement. Andrew worked really hard and addressed the

Re: [HACKERS] Changes to backup.sgml

2015-05-15 Thread Joshua D. Drake
On 05/15/2015 10:03 AM, Robert Haas wrote: On Thu, May 14, 2015 at 12:53 PM, Joshua D. Drake j...@commandprompt.com wrote: 1. File System Level Backup The section should be a note within the larger document. It is largely a legacy section from before 8.3. I agree. I think this section is

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread David G. Johnston
On Fri, May 15, 2015 at 1:45 PM, Dave Cramer p...@fastcrypt.com wrote: On 15 May 2015 at 16:44, Dave Cramer p...@fastcrypt.com wrote: On 15 May 2015 at 16:41, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:38 PM, Dave Cramer p...@fastcrypt.com wrote: I don't really

Re: [HACKERS] BRIN range operator class

2015-05-15 Thread Alvaro Herrera
Emre Hasegeli wrote: I pushed patches 04 and 07, as well as adopting some of the changes to the regression test in 06. I'm afraid I caused a bit of merge pain for you -- sorry about that. No problem. I rebased the remaining ones. Thanks, pushed. There was a proposed change by Emre to

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Kevin Grittner
Bruno Harbulot br...@distributedmatter.net wrote: On Fri, May 15, 2015 at 9:41 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 4:38 PM, Dave Cramer p...@fastcrypt.com wrote: Well our solution was to use ?? but that does mean we have to do some extra parsing which in a

Re: [HACKERS] Problems with question marks in operators (JDBC, ECPG, ...)

2015-05-15 Thread Tom Lane
Bruno Harbulot br...@distributedmatter.net writes: That said, I'd still suggest providing new operators and deprecating the ones containing a question mark if possible. (There are 8 distinct operator names like this: ?-, ?, ?, ?#, ?||, ?-|, ?| and ?.) There are more in contrib ...