Re: [HACKERS] Odd system-column handling in postgres_fdw join pushdown patch

On Tue, Mar 22, 2016 at 8:03 AM, Etsuro Fujita wrote: > On 2016/03/19 4:51, Robert Haas wrote: > >> On Thu, Mar 17, 2016 at 7:00 AM, Etsuro Fujita >> wrote: >> >>> So, I'd like to propose: (1) when tableoids are >>> requested from the

Re: [HACKERS] multivariate statistics v14

On Sun, Mar 20, 2016 at 4:34 PM, Tomas Vondra wrote: > > > D'oh. Thanks for reporting. Attached is v16, hopefully fixing the few > remaining whitespace issues. Hi Tomas, I'm trying out v16 against a common problem, where postgresql thinks it is likely top stop

Re: [HACKERS] Parallel Aggregate

Good news! On Tuesday, 22 March 2016, David Rowley wrote: > On 22 March 2016 at 02:35, Robert Haas > wrote: > > I have committed this after changing some of the comments. > > > > There might still be bugs ... but I don't see

Re: [HACKERS] parallel aggregation - Numeric is unsupported?

2016-03-22 6:28 GMT+01:00 David Rowley : > > On 22/03/2016 5:24 pm, "Pavel Stehule" wrote: > > > > Hi > > > > is it expected in this moment? > > > > > > Table "public.foo" > > Column │ Type │ Modifiers > >

Re: [HACKERS] parallel aggregation - Numeric is unsupported?

On 22/03/2016 5:24 pm, "Pavel Stehule" wrote: > > Hi > > is it expected in this moment? > > > Table "public.foo" > Column │ Type │ Modifiers > ╪═╪═══ > a │ integer │ > > postgres=# \d foo2 > Table "public.foo2" > Column │

Re: [HACKERS] parallel aggregation - Numeric is unsupported?

On 22/03/2016 5:24 pm, "Pavel Stehule" wrote: > > Hi > > is it expected in this moment? > > > Table "public.foo" > Column │ Type │ Modifiers > ╪═╪═══ > a │ integer │ > > postgres=# \d foo2 > Table "public.foo2" > Column │

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

2016-03-22 6:06 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > I can live with SELECT fx(x). It is little bit dangerous, but this risk > can > > be easy detected by plpgsql_check. > > Dangerous how? > I afraid of useless and forgotten call of

Re: [HACKERS] OOM in libpq and infinite loop with getCopyStart()

On Tue, Mar 22, 2016 at 9:46 AM, Tom Lane wrote: > > Amit Kapila writes: > > On Mon, Mar 21, 2016 at 10:13 PM, Robert Haas wrote: > >> It is very difficult to believe that this is a good idea: > >> > >> ---

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

Pavel Stehule writes: > I can live with SELECT fx(x). It is little bit dangerous, but this risk can > be easy detected by plpgsql_check. Dangerous how? >> So, I'm -1 on not having any keyword at all. I have no objection >> to Merlin's proposal though. I agree that

Re: [HACKERS] Identifying a message in emit_log_hook.

I found that this has been commited. Thank you for committing this, Simon. regards, At Tue, 15 Mar 2016 12:22:05 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20160315.122205.08265186.horiguchi.kyot...@lab.ntt.co.jp> > Thnak you for scooping up

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

On Tue, Mar 22, 2016 at 12:31 PM, Dilip Kumar wrote: > ! pg_atomic_write_u32(>state, state); > } while (!StartBufferIO(bufHdr, true)); > > Better Write some comment, about we clearing the BM_LOCKED from stage > directly and need not to call UnlockBufHdr explicitly. >

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

On Tue, Mar 22, 2016 at 9:13 AM, Haribabu Kommi wrote: > > On Tue, Mar 22, 2016 at 2:19 PM, Amit Kapila wrote: > > On Mon, Mar 21, 2016 at 6:16 PM, Haribabu Kommi < kommi.harib...@gmail.com> > > wrote: > >> > >> On Mon, Mar 14, 2016 at 4:51 PM,

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618

On 21 March 2016 at 20:46, Haribabu Kommi wrote: > > No. Not as local service. The user should be the new standard user > that is created > in the system. > Which was done how, exactly? Commands run? Steps taken? PostgreSQL drops privileges once it starts, so it's

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

On Sun, Mar 20, 2016 at 4:10 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > Actually, we behave like old code and do such modifications without > increasing number of atomic operations. We can just calculate new value of > state (including unset of BM_LOCKED flag) and write it to

[HACKERS] parallel aggregation - Numeric is unsupported?

Hi is it expected in this moment? Table "public.foo" Column │ Type │ Modifiers ╪═╪═══ a │ integer │ postgres=# \d foo2 Table "public.foo2" Column │ Type │ Modifiers ╪═╪═══ a │ numeric │ postgres=# explain select

Re: [HACKERS] OOM in libpq and infinite loop with getCopyStart()

Amit Kapila writes: > On Mon, Mar 21, 2016 at 10:13 PM, Robert Haas wrote: >> It is very difficult to believe that this is a good idea: >> >> --- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c >> +++

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

2016-03-21 23:49 GMT+01:00 Tom Lane : > Jim Nasby writes: > > On 3/21/16 5:03 PM, Merlin Moncure wrote: > >> in Oracle, you'd simply do: > >> LogIt('I did something'); > > > It would be *great* if we could support that in plpgsql. > > FWIW, I'm

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

2016-03-21 23:26 GMT+01:00 Jim Nasby : > On 3/21/16 5:03 PM, Merlin Moncure wrote: > >> in Oracle, you'd simply do: >> LogIt('I did something'); >> > > It would be *great* if we could support that in plpgsql. > > I'm not sure what Oracle does for SELECT statements

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

2016-03-21 23:03 GMT+01:00 Merlin Moncure : > On Mon, Mar 21, 2016 at 4:13 PM, Pavel Stehule > wrote: > > Hi > > > > 2016-03-21 21:24 GMT+01:00 Merlin Moncure : > >> > >> Patch is trivial (see below), discussion is not :-). > >> >

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

On Mon, Mar 21, 2016 at 3:38 PM, Stephen Frost wrote: >> Basically, unlike with the similar nbtinsert.c code, we're checking >> someone else's tuple in the speculative insertion >> check_exclusion_or_unique_constraint() case that was changed (or it's >> an exclusion

Re: [HACKERS] OOM in libpq and infinite loop with getCopyStart()

On Mon, Mar 21, 2016 at 10:13 PM, Robert Haas wrote: > > On Tue, Mar 1, 2016 at 12:38 AM, Michael Paquier > wrote: > > Thoughts? I have registered that in the CF app, and a patch is attached. > > It is very difficult to believe that this is a

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

On Tue, Mar 22, 2016 at 2:19 PM, Amit Kapila wrote: > On Mon, Mar 21, 2016 at 6:16 PM, Haribabu Kommi > wrote: >> >> On Mon, Mar 14, 2016 at 4:51 PM, Amit Kapila >> wrote: >> >> Operating system - windows 7 >> >> Binary

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

On Mon, Mar 21, 2016 at 6:16 PM, Haribabu Kommi wrote: > > On Mon, Mar 14, 2016 at 4:51 PM, Amit Kapila wrote: > >> Operating system - windows 7 > >> Binary - PostgreSQL 9.5 (This doesn't matter, 9.4+ can produce the > >> problem) > >> > >> 1.

Re: [HACKERS] Odd system-column handling in postgres_fdw join pushdown patch

On 2016/03/19 4:51, Robert Haas wrote: On Thu, Mar 17, 2016 at 7:00 AM, Etsuro Fujita wrote: So, I'd like to propose: (1) when tableoids are requested from the remote server, postgres_fdw sets valid values for them locally, instead (core should support that?)

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

On 2016/03/19 3:30, Robert Haas wrote: On Fri, Mar 18, 2016 at 5:15 AM, Etsuro Fujita wrote: Attached is the updated version of the patch. Committed. Thank you. Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Declarative partitioning

On 2016/03/22 4:55, Robert Haas wrote: > So, the last patch on this thread was posted on February 17th, and the > CF entry was marked Waiting on Author on March 2nd. Even if we had a > new patch in hand at this point, I don't think there's any real chance > of being able to get this done for 9.6;

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

On Monday, March 21, 2016, Tom Lane wrote: > "David G. Johnston" > writes: > > On Monday, March 21, 2016, Tom Lane > > wrote: > >> What about just discarding the old format entirely, and printing one

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

On Tue, Mar 22, 2016 at 6:25 AM, Tom Lane wrote: > If I don't hear objections PDQ, I'm going to update the docs and commit > it like that. Thanks! -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

> On 22 Mar 2016, at 01:47, Jim Nasby wrote: > > On 3/21/16 11:57 AM, Teodor Sigaev wrote: >> A and B are points of intersection of lines. So, box PBCAis a bounding >> box for points contained in 3-rd (see labeling above). For example X >> labeled point is not a

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

At 2016-03-21 15:43:09 -0400, robertmh...@gmail.com wrote: > > I also think we should allow a function to depend on multiple > extensions, as Alvaro mentions downthread. I'm working on an updated patch, will post shortly. -- Abhijit -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

On Mon, Mar 21, 2016 at 6:49 PM, Tom Lane wrote: > So, I'm -1 on not having any keyword at all. I have no objection > to Merlin's proposal though. I agree that PERFORM is starting to > look a bit silly, since it doesn't play with WITH for instance. Yeah, I think requiring

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

On Mon, Mar 21, 2016 at 5:49 PM, Tom Lane wrote: > So, I'm -1 on not having any keyword at all. I have no objection > to Merlin's proposal though. I agree that PERFORM is starting to > look a bit silly, since it doesn't play with WITH for instance. All right -- I'll submit

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

Jim Nasby writes: > On 3/21/16 5:03 PM, Merlin Moncure wrote: >> in Oracle, you'd simply do: >> LogIt('I did something'); > It would be *great* if we could support that in plpgsql. FWIW, I'm hesitant to just start accepting that syntax as if it were an equivalent to

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

On 3/21/16 11:57 AM, Teodor Sigaev wrote: A and B are points of intersection of lines. So, box PBCAis a bounding box for points contained in 3-rd (see labeling above). For example X labeled point is not a descendace of child node with centroid C because it must be in branch of 1-st quad of

Re: [HACKERS] Minor bug affecting ON CONFLICT lock wait log messages

Peter, * Peter Geoghegan (p...@heroku.com) wrote: > Thinking about this again, I think we should use > XLTW_InsertIndexUnique after all. The resemblance of the > check_exclusion_or_unique_constraint() code to the nbtinsert.c code > seems only superficial on second thought. So, I propose fixing

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

On 3/21/16 5:03 PM, Merlin Moncure wrote: in Oracle, you'd simply do: LogIt('I did something'); It would be *great* if we could support that in plpgsql. I'm not sure what Oracle does for SELECT statements without INTO/BULK UPDATE. I'm not really inclined to care -- I'm really curious to see

Re: [HACKERS] WIP: Access method extendability

Alexander Korotkov wrote: > Hi! > > Thank you for review! So. Before this version of the patch was posted in Nov 4th 2015, both Tom and Heikki had said essentially "CREATE ACCESS METHOD is worthless, let's pursue this stuff without those commands".

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

On Mon, Mar 21, 2016 at 4:13 PM, Pavel Stehule wrote: > Hi > > 2016-03-21 21:24 GMT+01:00 Merlin Moncure : >> >> Patch is trivial (see below), discussion is not :-). >> >> I see no useful reason to require INTO when returning data with >> SELECT.

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

> On 21 Mar 2016, at 22:38, Kevin Grittner wrote: > > On Mon, Mar 21, 2016 at 11:57 AM, Teodor Sigaev wrote: > >>> I couldn't get the term 4D point. Maybe it means that we are >>> using box datatype as the prefix, but we are not treating them >>> as

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

Tom Lane wrote: > "David G. Johnston" writes: > > On Monday, March 21, 2016, Tom Lane wrote: > >> What about just discarding the old format entirely, and printing one of > >> these two things: > >> > >> Timestamp (every Ns) > >> > >> User Given

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

"David G. Johnston" writes: > On Monday, March 21, 2016, Tom Lane wrote: >> What about just discarding the old format entirely, and printing one of >> these two things: >> >> Timestamp (every Ns) >> >> User Given Title Timestamp (every Ns) >

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

So I looked into this, and found that persuading psql to let backslash commands cross line boundaries is a much bigger deal than just fixing the lexer. The problem is that MainLoop would need to grow an understanding of having received only a partial backslash command and needing to go back to

Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

Hi 2016-03-21 21:24 GMT+01:00 Merlin Moncure : > Patch is trivial (see below), discussion is not :-). > > I see no useful reason to require INTO when returning data with > SELECT. However, requiring queries to indicate not needing data via > PERFORM causes some annoyances: >

[HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

Patch is trivial (see below), discussion is not :-). I see no useful reason to require INTO when returning data with SELECT. However, requiring queries to indicate not needing data via PERFORM causes some annoyances: *) converting routines back and forth between pl/pgsql and pl/sql requires

Re: [HACKERS] snapshot too old, configured by time

Thanks to all for the feedback; I will try to respond later this week. First I'm trying to get my reviews for other patches posted. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Declarative partitioning

On 21 March 2016 at 19:55, Robert Haas wrote: > On Wed, Mar 16, 2016 at 10:49 AM, Alexander Korotkov > wrote: > >> > I'd like to validate that this development plan doesn't overlaps with > >> > your > >> > plans. If out plans are not

Re: [HACKERS] Declarative partitioning

On Wed, Mar 16, 2016 at 10:49 AM, Alexander Korotkov wrote: >> > I'd like to validate that this development plan doesn't overlaps with >> > your >> > plans. If out plans are not overlapping then let's accept this plan of >> > work >> > for 9.7. >> >> It looks OK to me.

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

Robert Haas writes: > Mmph. I just don't see any benefit in being able to start a command > in the middle of a line. I agree that there's no functional benefit; it's a matter of consistency. In particular, psql has always allowed you to write multiple SQL commands per

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

On Mon, Mar 21, 2016 at 3:42 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Mar 21, 2016 at 3:01 PM, Tom Lane wrote: >>> Um, why exactly? That psql behavior is of really ancient standing, and >>> we have not had complaints

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

On Mon, Mar 21, 2016 at 7:19 AM, Abhijit Menon-Sen wrote: > At 2016-03-21 13:04:33 +0300, a.korot...@postgrespro.ru wrote: >> >> I'm not sure why we want to make new dependency type by ALTER FUNCTION >> command, not ALTER EXTENSION? > > It's a matter of semantics. It means

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

Robert Haas writes: > On Mon, Mar 21, 2016 at 3:01 PM, Tom Lane wrote: >> Um, why exactly? That psql behavior is of really ancient standing, and >> we have not had complaints about it. > I think that's mostly because the psql metacommands are

Re: [HACKERS] Choosing parallel_degree

On 21/03/2016 05:18, James Sewell wrote: > OK cool, thanks. > > Can we remove the minimum size limit when the per table degree setting > is applied? > > This would help for tables with 2 - 1000 pages combined with a high CPU > cost aggregate. > Attached v4 implements that. It also makes sure

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

On Mon, Mar 21, 2016 at 11:57 AM, Teodor Sigaev wrote: >> I couldn't get the term 4D point. Maybe it means that we are >> using box datatype as the prefix, but we are not treating them >> as boxes. > > exactly, we treat boxes as 4-dimentional points. I'm not entirely sure I

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

On Mon, Mar 21, 2016 at 3:01 PM, Tom Lane wrote: >> Wait, was it really? I'd been thinking it was mostly to continue >> queries, not metacommands, but maybe I missed the boat. > > Nah, you're right, it was about continuing queries. Still, we've had > complaints about the

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

On Monday, March 21, 2016, Tom Lane wrote: > "David G. Johnston" > writes: > > I'll admit it's awkward because it's abbreviated but if someone enters > > \watch 5 and then sees (5s) in the title I think they can put two and two > >

Re: [HACKERS] snapshot too old, configured by time

On 17 March 2016 at 21:15, Kevin Grittner wrote: > New patch just to merge in recent commits -- it was starting to > show some bit-rot. Tests folded in with main patch. In session 1, I've run: # begin transaction isolation level repeatable read ; BEGIN *# declare stuff

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

Alvaro Herrera writes: > (I'll also use this opportunity to complain again about not being able > to use floating point sleep time.) That's not unreasonable either, though it seems like material for a separate patch. regards, tom lane -- Sent

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

"David G. Johnston" writes: > I'll admit it's awkward because it's abbreviated but if someone enters > \watch 5 and then sees (5s) in the title I think they can put two and two > together. Where I find this to be awkward is that the format is randomly different

Re: [HACKERS] Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

Chapman Flack writes: > On 03/21/2016 10:21 AM, Aleksander Alekseev wrote: >> Well in this case here is a patch that fixes "use of uninitialized >> value" reports by MemorySanitizer I managed to catch so far. > I'm new here so someone more experienced would have to weigh

Re: [HACKERS] pgbench - allow backslash-continuations in custom scripts

Robert Haas writes: > On Sun, Mar 20, 2016 at 1:07 PM, Tom Lane wrote: >> This solves the problem of allowing SQL commands in scripts to span >> lines, ... > Excellent. >> but it doesn't do anything about backslash commands, which was >> the original

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

David G. Johnston wrote: > Tom doesn't care enough to veto and you don't really care... > > I'll admit it's awkward because it's abbreviated but if someone enters > \watch 5 and then sees (5s) in the title I think they can put two and two > together. > > If the watched query takes a long to

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

On Monday, March 21, 2016, Robert Haas wrote: > On Mon, Mar 21, 2016 at 2:09 PM, David G. Johnston > > wrote: > > On Monday, March 21, 2016, Tom Lane > > wrote: > >> "David G. Johnston"

Re: [HACKERS] Performance degradation in commit ac1d794

On Mon, Mar 21, 2016 at 6:09 PM, Andres Freund wrote: > On 2016-03-21 11:52:43 +1300, Thomas Munro wrote: >> * I would be interested in writing a kqueue implementation of this for >> *BSD (and MacOSX?) at some point if someone doesn't beat me to it. > > I hoped that somebody

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

Ok, I added a reference to the commitfest entry from this wiki page, and a note about partial 9.5 backporting. Please split the patch into one part for backporting and one part for master-only and post both patches, clearly indicating which is which. Attached are the full patch for head and

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

On Mon, Mar 21, 2016 at 2:09 PM, David G. Johnston wrote: > On Monday, March 21, 2016, Tom Lane wrote: >> "David G. Johnston" writes: >> > I'd rather not omit sleep but removing "Watch every" is fine (preferred >> >

Re: [HACKERS] Parallel Aggregate

On 22 March 2016 at 02:35, Robert Haas wrote: > I have committed this after changing some of the comments. > > There might still be bugs ... but I don't see them. And the speedups > look very impressive. > > Really nice work, David. Thanks for that, and thank you for

Re: [HACKERS] Request - repeat value of \pset title during \watch interations

On Monday, March 21, 2016, Tom Lane wrote: > "David G. Johnston" > writes: > > I'd rather not omit sleep but removing "Watch every" is fine (preferred > > actually), so: > > Title Is Here Mon Mar 21 15:05:06 2016 (5s) > > Meh ...

Re: [HACKERS] checkpointer continuous flushing

Hi, I've repeated the tests, but this time logged details for 5% of the transaction (instead of aggregating the data for each second). I've also made the tests shorter - just 12 hours instead of 24, to reduce the time needed to complete the benchmark. Overall, this means ~300M transactions

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

"David G. Johnston" writes: > I'd rather not omit sleep but removing "Watch every" is fine (preferred > actually), so: > Title Is Here Mon Mar 21 15:05:06 2016 (5s) Meh ... seems a bit awkward to me. Couldn't you include " (5s)" in the title, if you want that

Re: [HACKERS] jsonb array-style subscription

On 3/20/16 2:29 PM, Dmitry Dolgov wrote: > Do you have an updated patch ready? No, I'm afraid it will not be ready for Monday. I have marked this "returned with feedback". Please feel free to submit a reworked patch for 9.7! -- -David da...@pgmasters.net -- Sent via pgsql-hackers

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

On Mon, Mar 21, 2016 at 10:14 AM, Tom Lane wrote: > Robert Haas writes: > > Well, the title isn't normally centered, but yeah, that is odd. Yeah, > > that is odd. Come to think of it, I think I might have expected the > > title to appear *above*

Re: [HACKERS] Proposal: Generic WAL logical messages

Just noticed there is missing symlink in the pg_xlogdump. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services >From f47730e5e8ef5797c7595aafcbf8cff3b375d0ad Mon Sep 17 00:00:00 2001 From: Petr Jelinek

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

Robert Haas writes: > Well, the title isn't normally centered, but yeah, that is odd. Yeah, > that is odd. Come to think of it, I think I might have expected the > title to appear *above* "Watch every %s", not below it. That might > decrease the oddness. AFAICS, it

Re: [HACKERS] Speedup twophase transactions

On 03/18/2016 12:50 PM, Stas Kelvich wrote: On 11 Mar 2016, at 19:41, Jesper Pedersen wrote: Thanks for review, Jesper. Some comments: * The patch needs a rebase against the latest TwoPhaseFileHeader change Done. * Rework the check.sh script into a TAP test

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

+ *implementation of quad-4d tree over boxes for SP-GiST. Isn't the whole thing actually 3D? No. The idea if this work is a representation of 2d box as 4d point. Quad means quadrant of 2d plane. Originally such kind of tree was developed for 2d point, and each node of tree splits plane on

Re: [HACKERS] WIP: Covering + unique indexes.

19.03.2016 08:00, Peter Geoghegan: On Fri, Mar 18, 2016 at 5:15 AM, David Steele wrote: It looks like this patch should be marked "needs review" and I have done so. Uh, no it shouldn't. I've posted an extensive review on the original design thread. See CF entry:

Re: [HACKERS] OOM in libpq and infinite loop with getCopyStart()

On Tue, Mar 1, 2016 at 12:38 AM, Michael Paquier wrote: > Thoughts? I have registered that in the CF app, and a patch is attached. It is very difficult to believe that this is a good idea: --- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c +++

Re: [HACKERS] Combining Aggregates

On 20 March 2016 at 16:48, David Rowley wrote: > I've attached another series of patches: > > 0001: This is the latest Parallel Aggregate Patch, not intended for > review here, but is required for the remaining patches. This patch has > changed quite a bit from the

Re: [HACKERS] proposal: PL/Pythonu - function ereport

On Wed, Mar 2, 2016 at 12:01 AM, Pavel Stehule wrote: >> I see the pfree you added isn't allowed on a NULL pointer but as far >> as I see message is guaranteed not to be NULL as dgettext never >> returns NULL. >> >> I'll mark this Ready for Committer. > > Thank you very

Re: [HACKERS] Combining Aggregates

On Sat, Mar 19, 2016 at 11:48 PM, David Rowley wrote: > 0002: Adds serial/de-serial function support to CREATE AGGREGATE, > contains minor fix-ups from last version. This looks pretty good, but don't build_aggregate_serialfn_expr and build_aggregate_deserialfn_expr

[HACKERS] BRIN is missing in multicolumn indexes documentation

Hello, the http://www.postgresql.org/docs/9.5/static/indexes-multicolumn.html page doesn't mention BRIN support, but according to the http://www.postgresql.org/docs/9.5/static/sql-createindex.html it is supported in multicolumn setup. The attached patch (git diff against master branch) fixes the

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

Robert Haas wrote: > On Sun, Mar 20, 2016 at 5:27 PM, Pavel Stehule > wrote: > > From my perspective, it is ready for commiter. Daniel solved the most big > > issues. > > OK, so that brings us back to: is there any committer who likes this > enough to want to look at

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

Abhijit Menon-Sen wrote: > + else if (strcmp(defel->defname, "extdepend") == 0) > + { > + if (*extdepend_item) > + goto duplicate_error; > + > + *extdepend_item = defel; > + } > else > return false; > I'm not sure I

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

On Sun, Mar 20, 2016 at 5:27 PM, Pavel Stehule wrote: > From my perspective, it is ready for commiter. Daniel solved the most big > issues. OK, so that brings us back to: is there any committer who likes this enough to want to look at committing it? My view hasn't

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

On Mon, Mar 21, 2016 at 11:17 AM, David G. Johnston wrote: >> And does everybody agree that this is a desirable change? > > Adding the title is desirable. While I'm inclined to bike-shed this > anything that gets it in I can live with and so I'm content letting the >

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

On Mon, Mar 21, 2016 at 8:03 AM, Robert Haas wrote: > On Sun, Mar 20, 2016 at 9:31 AM, Michael Paquier > wrote: > > And the patch attached gives the following output: > > With title: > > =# \watch 1 > > Watch every 1sSun Mar 20 22:28:38 2016

Re: [HACKERS] Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

> I'm new here so someone more experienced would have to weigh in, > but I would wonder a couple of things: > > a. whether a braced struct assignment is supported in every >C compiler that PostgreSQL still intends to support > > b. whether such a struct assignment is guaranteed to initialize

Re: [HACKERS] Proposal: Generic WAL logical messages

On 18 March 2016 at 20:36, Artur Zakirov wrote: > On 17.03.2016 15:42, Craig Ringer wrote: > >> >> >> Would you mind sharing the plugin here? I could add it to >> src/test/modules and add some t/ tests so it runs under the TAP test >> framework. >> >> >> -- >> Craig

Re: [HACKERS] [GENERAL] Request - repeat value of \pset title during \watch interations

On Sun, Mar 20, 2016 at 9:31 AM, Michael Paquier wrote: > And the patch attached gives the following output: > With title: > =# \watch 1 > Watch every 1sSun Mar 20 22:28:38 2016 > popo > a > --- > 1 > (1 row) > > And without title: > Watch every 1sSun Mar 20

Re: [HACKERS] [COMMITTERS] pgsql: Support parallel aggregation.

#woopwoop! :-D great work, all! On Mon, Mar 21, 2016 at 3:43 PM, Simon Riggs wrote: > On 21 March 2016 at 14:35, David Fetter wrote: > >> On Mon, Mar 21, 2016 at 01:33:28PM +, Robert Haas wrote: >> > Support parallel aggregation. >> >> ...and there

Re: [HACKERS] max_parallel_degree context level

On Sun, Mar 20, 2016 at 3:01 AM, David Rowley wrote: > On 12 February 2016 at 04:55, Robert Haas wrote: >> On Thu, Feb 11, 2016 at 10:32 AM, Simon Riggs wrote: >>> Is it slower if you request N workers, yet only 1 is

Re: [HACKERS] [COMMITTERS] pgsql: Support parallel aggregation.

On 21 March 2016 at 14:35, David Fetter wrote: > On Mon, Mar 21, 2016 at 01:33:28PM +, Robert Haas wrote: > > Support parallel aggregation. > > ...and there was much rejoicing! > +1 Well done all. -- Simon Riggshttp://www.2ndQuadrant.com/

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

On Sat, Mar 19, 2016 at 3:28 PM, Fabien COELHO wrote: >>> Thanks for the pointer. However, I do not have "editor priviledge" on >>> this >>> wiki, maybe Tomas has? >> >> I gave you editor privs now, but since it's in 9.5 I guess it needs to >> be on the bug tracker (Except,

Re: [HACKERS] [COMMITTERS] pgsql: Support parallel aggregation.

On Mon, Mar 21, 2016 at 10:35 AM, David Fetter wrote: > On Mon, Mar 21, 2016 at 01:33:28PM +, Robert Haas wrote: >> Support parallel aggregation. > > ...and there was much rejoicing! I know *I* am! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] [COMMITTERS] pgsql: Support parallel aggregation.

On Mon, Mar 21, 2016 at 01:33:28PM +, Robert Haas wrote: > Support parallel aggregation. ...and there was much rejoicing! Cheers, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP:

Re: [HACKERS] Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

On 03/21/2016 10:21 AM, Aleksander Alekseev wrote: > Well in this case here is a patch that fixes "use of uninitialized > value" reports by MemorySanitizer I managed to catch so far. I'm new here so someone more experienced would have to weigh in, but I would wonder a couple of things: a.

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

Thanks Michael for looking into this. > In get_useful_ecs_for_relation, it seems to me that this assertion > should be removed and replaces by an actual check because even if > right_ec and left_ec are initialized, we cannot be sure that ec_relids > contains the relations specified: >

Re: [HACKERS] Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

> Well, the documentation already says to avoid it: > > http://www.postgresql.org/docs/current/static/xfunc-c.html > >Another important point is to avoid leaving any uninitialized >bits within data type values; for example, take care to zero out >any alignment padding bytes that

Re: [HACKERS] Proposal: Generic WAL logical messages

Hi, thanks for review. On 17/03/16 13:36, Tomas Vondra wrote: Hi, a few comments about the last version of the patch: 1) LogicalDecodeMessageCB Do we actually need the 'transactional' parameter here? I mean, having the 'txn' should be enough, as transactional = (txt != NULL)

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

On Sat, Mar 19, 2016 at 8:30 AM, Michael Paquier wrote: >> Doing that with the >> level of detail and care that it seems to me to require seems like an >> almost-impossible task. Most of the major features I've committed >> this CommitFest are patches where I've

  1   2   >