Re: [HACKERS] Combining Aggregates

2016-03-20 Thread Haribabu Kommi
On Sun, Mar 20, 2016 at 2:23 PM, David Rowley wrote: > > I've had a look over this. I had to first base it on the 0005 patch, > as it seemed like the pg_aggregate.h changes didn't include the > serialfn and deserialfn changes, and an OID was being consumed by >

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-03-20 Thread Haribabu Kommi
On Fri, Mar 18, 2016 at 7:46 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Fri, Mar 18, 2016 at 7:53 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Mar 17, 2016 at 6:56 PM, Shulgin, Oleksandr >> <oleksandr.shul..

Re: [HACKERS] Parallel Aggregate

2016-03-19 Thread Haribabu Kommi
On Thu, Mar 17, 2016 at 2:13 PM, James Sewell wrote: > > Hi again, > > This is probably me missing something, but is there a reason parallel > aggregate doesn't seem to ever create append nodes containing Index scans? > > SET random_page_cost TO 0.2; > SET

Re: [HACKERS] Combining Aggregates

2016-03-19 Thread Haribabu Kommi
On Wed, Mar 16, 2016 at 10:08 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 16 March 2016 at 23:54, Haribabu Kommi <kommi.harib...@gmail.com> wrote: >> On Wed, Mar 16, 2016 at 8:34 AM, David Rowley >> <david.row...@2ndquadrant.com> wrote: >>

Re: [HACKERS] Combining Aggregates

2016-03-19 Thread Haribabu Kommi
On Thu, Mar 17, 2016 at 10:59 PM, Tomas Vondra wrote: > Hi, > > On 03/17/2016 12:53 PM, David Rowley wrote: >> > ... >> >> >> I just had a quick skim over the patch and noticed the naming >> convention you're using for the combine function is *_pl, and you have >>

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-03-19 Thread Haribabu Kommi
On Wed, Mar 16, 2016 at 9:49 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Tue, Mar 15, 2016 at 7:23 PM, David Steele <da...@pgmasters.net> wrote: >> >> On 3/3/16 12:16 AM, Haribabu Kommi wrote: >> > On Fri, Feb 5, 2016 at 2:29 PM, Haribabu

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-03-18 Thread Haribabu Kommi
On Thu, Mar 17, 2016 at 6:56 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Thu, Mar 17, 2016 at 2:12 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Wed, Mar 16, 2016 at 9:49 PM, Shulgin, Oleksandr >> <oleksandr.shul...@zal

Re: [HACKERS] Combining Aggregates

2016-03-16 Thread Haribabu Kommi
On Wed, Mar 16, 2016 at 8:34 AM, David Rowley wrote: > On 16 March 2016 at 06:39, Tomas Vondra wrote: >> After looking at the parallel aggregate patch, I also looked at this one, as >> it's naturally related. Sadly I haven't found any

Re: [HACKERS] Parallel Aggregate

2016-03-13 Thread Haribabu Kommi
On Mon, Mar 14, 2016 at 8:44 AM, David Rowley wrote: > On 12 March 2016 at 16:31, David Rowley wrote: >> I've attached an updated patch which is based on commit 7087166, >> things are really changing fast in the grouping path area at

Re: [HACKERS] pam auth - add rhost item

2016-03-12 Thread Haribabu Kommi
On Sun, Mar 13, 2016 at 8:07 AM, Grzegorz Sampolski wrote: > Hi. > Thank you for improve documentation and yes I'm fine with this chages. Thanks. changed the patch status as ready for committer. Regards, Hari Babu Fujitsu Australia -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pam auth - add rhost item

2016-03-12 Thread Haribabu Kommi
On Fri, Mar 11, 2016 at 12:11 AM, Grzegorz Sampolski wrote: > Hi. > In attchment new patch with updated documentation and with small change > to coding style as you suggested. Thanks for the update. Here I attached updated patch with additional documentation changes, If you

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-11 Thread Haribabu Kommi
On Fri, Mar 11, 2016 at 11:15 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Mar 11, 2016 at 5:21 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Fri, Mar 11, 2016 at 12:00 AM, Amit Kapila <amit.kapil...@gmail.com> >> wro

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-11 Thread Haribabu Kommi
On Fri, Mar 11, 2016 at 12:00 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Mar 9, 2016 at 5:46 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> On Wed, Mar 9, 2016 at 10:06 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >> &

Re: [HACKERS] Parallel Aggregate

2016-03-09 Thread Haribabu Kommi
On Mon, Mar 7, 2016 at 4:39 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: >> 2. Temporary fix for float aggregate types in _equalAggref because of >> a change in aggtype to trans type, otherwise the parallel

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-09 Thread Haribabu Kommi
On Thu, Mar 10, 2016 at 5:30 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Mar 9, 2016 at 7:16 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> On Wed, Mar 9, 2016 at 10:06 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >>> On Wed,

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-09 Thread Haribabu Kommi
On Wed, Mar 9, 2016 at 10:06 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Mar 9, 2016 at 11:46 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> >> I tried replacing the random() with PostmaterRandom() for a test and it >> work

Re: [HACKERS] pam auth - add rhost item

2016-03-08 Thread Haribabu Kommi
On Tue, Mar 8, 2016 at 10:43 PM, Grzegorz Sampolski wrote: > Hi Hari. > To use pam modules you can use whatever backend authentication method > you want. > > This is example configuration: > > Install this library https://github.com/pam-pgsql/pam-pgsql > Create some example

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-08 Thread Haribabu Kommi
On Sun, Oct 18, 2015 at 1:03 AM, Tom Lane wrote: > Amit Kapila writes: >> On Sat, Oct 17, 2015 at 12:07 AM, Robert Haas wrote: >>> Maybe we need to be using PostmasterRandom() rather than random() for >>> the control segment

Re: [HACKERS] pam auth - add rhost item

2016-03-07 Thread Haribabu Kommi
On Tue, Dec 29, 2015 at 10:46 AM, Grzegorz Sampolski wrote: > Hi. > I thought link on commitfest to github url was sufficient. > Sorry. Attached new patch. I reviewed and tested the patch. With the addition of new RHOST member to the passed items in the PAM authentication

Re: [HACKERS] Parallel Aggregate

2016-03-06 Thread Haribabu Kommi
On Sun, Mar 6, 2016 at 10:21 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Pending: > 1. Explain plan needs to be corrected for parallel grouping similar like > parallel aggregate. Here I attached update patch with further changes, 1. Explain plan changes for pa

Re: [HACKERS] Parallel Aggregate

2016-03-06 Thread Haribabu Kommi
On Fri, Mar 4, 2016 at 3:00 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 17 February 2016 at 17:50, Haribabu Kommi <kommi.harib...@gmail.com> wrote: >> Here I attached a draft patch based on previous discussions. It still needs >> better comments and o

Re: [HACKERS] ExecGather() + nworkers

2016-03-04 Thread Haribabu Kommi
On Fri, Mar 4, 2016 at 10:33 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Mar 4, 2016 at 11:57 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Wed, Jan 13, 2016 at 7:19 PM, Amit Kapila <amit.kapil...@gmail.com> >&g

Re: [HACKERS] ExecGather() + nworkers

2016-03-03 Thread Haribabu Kommi
On Wed, Jan 13, 2016 at 7:19 PM, Amit Kapila wrote: > On Mon, Jan 11, 2016 at 9:16 AM, Amit Kapila > wrote: >> On Mon, Jan 11, 2016 at 3:14 AM, Peter Geoghegan wrote: >> > >> > On Sun, Jan 10, 2016 at 9:13 AM, Robert Haas

Re: [HACKERS] Incorrect error message in InitializeSessionUserId

2016-03-03 Thread Haribabu Kommi
On Wed, Mar 2, 2016 at 12:21 AM, Dmitriy Sarafannikov wrote: > Hi all, > > I have found incorrect error message in InitializeSessionUserId function > if you try to connect to database by role Oid (for example > BackgroundWorkerInitializeConnectionByOid). > If role have no

Re: [HACKERS] On columnar storage (2)

2016-03-03 Thread Haribabu Kommi
On Thu, Mar 3, 2016 at 7:46 PM, Bert wrote: > > Thank you for the performance test. But please not that the patch is 'thrown > away', and will be totally rewritten. I have no idea of the status of the > second / third attempt however. > However, what is interesting is that for

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-03-02 Thread Haribabu Kommi
On Fri, Feb 5, 2016 at 2:29 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > >This patch needs to be applied on top discard_hba_and_ident_cxt patch >that is posted earlier. Here I attached a re-based patch to the latest head with inclusion of discard_hba_ident_cxt patch fo

Re: [HACKERS] On columnar storage (2)

2016-03-02 Thread Haribabu Kommi
On Mon, Feb 1, 2016 at 12:11 AM, Alvaro Herrera wrote: > So we discussed some of this stuff during the developer meeting in > Brussels and the main conclusion is that we're going to split this up in > multiple independently useful pieces, and write up the general roadmap

Re: [HACKERS] Parallel Aggregate

2016-02-16 Thread Haribabu Kommi
On Sat, Feb 13, 2016 at 3:51 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Sun, Feb 7, 2016 at 8:21 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote:future. >> Here I attached updated patch with the corrections. > > So, what about the main patch, for par

Re: [HACKERS] Parallel Aggregate

2016-02-08 Thread Haribabu Kommi
On Mon, Feb 8, 2016 at 9:01 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Jan 21, 2016 at 11:25 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> [ new patch ] > > This patch contains a number of irrelevant hunks that really ought not > to

Re: [HACKERS] backpatch for REL9_4_STABLE of commit 40482e606733675eb9e5b2f7221186cf81352da1

2016-02-08 Thread Haribabu Kommi
On Mon, Feb 8, 2016 at 8:20 PM, Huong Dangminh wrote: > Hi, > > I think this fixed is also required for REL9_4_STABLE. > Please confirm the attached patch. Yes, this fix was missed for 9.4 stable branch during back patch and it is available on all other supported

Re: [HACKERS] Combining Aggregates

2016-02-07 Thread Haribabu Kommi
On Thu, Jan 21, 2016 at 3:42 PM, David Rowley wrote: > On 21 January 2016 at 08:06, Robert Haas wrote: >> >> On Wed, Jan 20, 2016 at 7:38 AM, David Rowley >> wrote: >> > Agreed. So I've attached a version of the

Re: [HACKERS] Parallel Aggregate

2016-02-07 Thread Haribabu Kommi
On Mon, Feb 8, 2016 at 2:00 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Sun, Jan 24, 2016 at 7:56 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> On Sat, Jan 23, 2016 at 12:59 PM, Haribabu Kommi >> <kommi.harib...@gmail.com> wrot

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-02-04 Thread Haribabu Kommi
On Tue, Feb 2, 2016 at 8:57 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Haribabu Kommi wrote: > >> Hi, Do you have any further comments on the patch that needs to be >> taken care? > > I do. I think the jsonb functions you added should be added to one

Re: [HACKERS] Parallel Aggregate

2016-01-24 Thread Haribabu Kommi
On Sat, Jan 23, 2016 at 12:59 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Here I attached updated patch with additional combine function for > two stage aggregates also. A wrong combine function was added in pg_aggregate.h in the earlier patch that leading to

Re: [HACKERS] Parallel Aggregate

2016-01-22 Thread Haribabu Kommi
On Fri, Jan 22, 2016 at 10:13 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 22 January 2016 at 17:25, Haribabu Kommi <kommi.harib...@gmail.com> wrote: >> Along with these changes, I added a float8 combine function to see >> how it works under parallel ag

Re: [HACKERS] Combining Aggregates

2016-01-21 Thread Haribabu Kommi
On Thu, Jan 21, 2016 at 3:52 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 21 January 2016 at 15:53, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Jan 21, 2016 at 1:33 PM, Haribabu Kommi >> <kommi.harib...@gmail.com> wrot

Re: [HACKERS] Parallel Aggregate

2016-01-21 Thread Haribabu Kommi
On Fri, Jan 22, 2016 at 7:44 AM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 21 January 2016 at 18:26, Haribabu Kommi <kommi.harib...@gmail.com> wrote: >> Here I attached update parallel aggregate patch on top of recent commits >> of combine aggregate and pa

Re: [HACKERS] Parallel Aggregate

2016-01-20 Thread Haribabu Kommi
On Thu, Dec 24, 2015 at 5:12 AM, Robert Haas wrote: > On Mon, Dec 21, 2015 at 6:38 PM, David Rowley > wrote: >> On 22 December 2015 at 04:16, Paul Ramsey wrote: >>> >>> Shouldn’t parallel aggregate come into play

Re: [HACKERS] Combining Aggregates

2016-01-20 Thread Haribabu Kommi
On Thu, Jan 21, 2016 at 12:32 PM, David Rowley wrote: > On 21 January 2016 at 04:59, Robert Haas wrote: >> >> On Wed, Jan 20, 2016 at 7:53 AM, David Rowley >> wrote: >> > On 21 January 2016 at 01:44, Robert Haas

Re: [HACKERS] Combining Aggregates

2016-01-20 Thread Haribabu Kommi
On Thu, Jan 21, 2016 at 1:33 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Here I attached updated patch of parallel aggregate based on the latest > changes in master. Still it lack of cost comparison of normal aggregate to > parallel aggregate because of dif

Re: [HACKERS] Combining Aggregates

2016-01-18 Thread Haribabu Kommi
On Mon, Jan 18, 2016 at 10:32 PM, David Rowley wrote: > On 18 January 2016 at 16:44, Robert Haas wrote: >> >> On Sun, Jan 17, 2016 at 9:26 PM, David Rowley >> wrote: >> > hmm, so wouldn't that mean that the

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-01-17 Thread Haribabu Kommi
On Thu, Dec 31, 2015 at 10:47 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > On Wed, Dec 30, 2015 at 9:48 PM, Shulgin, Oleksandr > <oleksandr.shul...@zalando.de> wrote: >> On Wed, Dec 30, 2015 at 4:31 AM, Haribabu Kommi <kommi.harib...@gmail.com> >&

Re: [HACKERS] Combining Aggregates

2016-01-17 Thread Haribabu Kommi
On Sat, Jan 16, 2016 at 12:00 PM, David Rowley wrote: > On 16 January 2016 at 03:03, Robert Haas wrote: >> >> On Tue, Dec 29, 2015 at 7:39 PM, David Rowley >> wrote: >> >> No, the idea I had in mind was to allow

Re: [HACKERS] Combining Aggregates

2016-01-14 Thread Haribabu Kommi
On Fri, Jan 15, 2016 at 3:34 PM, David Rowley wrote: > On 8 January 2016 at 22:43, David Rowley > wrote: >> >> I've attached some re-based patched on current master. This is just to fix >> a duplicate OID problem. >> > > I've attached

Re: [HACKERS] Weighted Stats

2016-01-07 Thread Haribabu Kommi
On Mon, Dec 21, 2015 at 1:50 PM, David Fetter wrote: > On Sun, Dec 20, 2015 at 06:13:33PM -0600, Jim Nasby wrote: >> On 11/2/15 5:46 PM, David Fetter wrote: >> >I'd like to add weighted statistics to PostgreSQL >> >> Anything happen with this? If community isn't interested, ISTM

Re: [HACKERS] Function and view to retrieve WAL receiver status

2016-01-06 Thread Haribabu Kommi
On Wed, Jan 6, 2016 at 8:00 PM, Michael Paquier wrote: > On Wed, Jan 6, 2016 at 3:04 PM, Michael Paquier > wrote: >> Attached is an updated patch. > > Forgot to update rules.out... Thanks for the update. Patch looks good to me. I marked it

Re: [HACKERS] Multi-tenancy with RLS

2016-01-06 Thread Haribabu Kommi
On Thu, Jan 7, 2016 at 2:29 PM, Stephen Frost wrote: > Robert, > > * Robert Haas (robertmh...@gmail.com) wrote: > >> Apart from the issue of whether this is doomed for some architectural >> reason, it is not entirely clear to me that there's any consensus that >> we want this.

Re: [HACKERS] Function and view to retrieve WAL receiver status

2016-01-05 Thread Haribabu Kommi
On Sat, Dec 19, 2015 at 12:54 AM, Michael Paquier wrote: > On Fri, Dec 18, 2015 at 8:39 AM, Robert Haas wrote: >> On Mon, Dec 14, 2015 at 7:23 PM, Michael Paquier >> wrote: >>> On Tue, Dec 15, 2015 at 5:27 AM, Gurjeet

Re: [HACKERS] Function and view to retrieve WAL receiver status

2016-01-05 Thread Haribabu Kommi
On Tue, Jan 5, 2016 at 10:24 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jan 5, 2016 at 7:49 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> On Sat, Dec 19, 2015 at 12:54 AM, Michael Paquier >> <michael.paqu...@gmail.com> wrote:

Re: [HACKERS] Multi-tenancy with RLS

2016-01-04 Thread Haribabu Kommi
On Mon, Jan 4, 2016 at 8:34 PM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2016/01/04 14:43, Haribabu Kommi wrote: >>> >>> Here I attached new series of patches with a slightly different approach. >>> Instead of creating the policies o

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-30 Thread Haribabu Kommi
On Wed, Dec 30, 2015 at 9:48 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Wed, Dec 30, 2015 at 4:31 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> >> Adding quotes to pg_hba_lookup function makes it different from othe

Re: [HACKERS] Multi-tenancy with RLS

2015-12-29 Thread Haribabu Kommi
On Thu, Dec 17, 2015 at 12:46 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Rebased patch is attached as it is having an OID conflict with the > latest set of changes > in the master branch. Here I attached new series of patches with a slightly different approach. Inst

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-29 Thread Haribabu Kommi
On Wed, Dec 30, 2015 at 1:07 AM, Shulgin, Oleksandr wrote: > > This is close enough, but what I actually mean by "a callback" is more or > less like the attached version. Thanks for the changes. > While at it, I've also added some trivial code to preserve keyword

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-28 Thread Haribabu Kommi
On Mon, Dec 28, 2015 at 9:09 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Thu, Dec 24, 2015 at 5:16 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Dec 24, 2015 at 2:37 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >&

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-23 Thread Haribabu Kommi
On Wed, Dec 23, 2015 at 8:54 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Wed, Dec 16, 2015 at 9:33 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> >> Function is changed to accept default values. >> >> Ap

Re: [HACKERS] Combining Aggregates

2015-12-23 Thread Haribabu Kommi
On Wed, Dec 23, 2015 at 7:50 PM, David Rowley wrote: > One other part that I'm not too sure on how to deal with is how to set the > data type for the Aggrefs when we're not performing finalization on the > aggregate node. The return type for the Aggref in this case

Re: [HACKERS] Combining Aggregates

2015-12-23 Thread Haribabu Kommi
On Thu, Dec 24, 2015 at 1:12 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 24 December 2015 at 13:55, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Wed, Dec 23, 2015 at 7:50 PM, David Rowley >> <david.row...@2ndquadrant.com> w

Re: [HACKERS] Combining Aggregates

2015-12-23 Thread Haribabu Kommi
On Wed, Dec 23, 2015 at 7:50 PM, David Rowley wrote: > This is just my serial format that I've come up with for NumericAggState, > which is basically: "N sumX maxScale maxScaleCount NaNcount". Perhaps we can > come up with something better, maybe just packing the

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-23 Thread Haribabu Kommi
On Thu, Dec 24, 2015 at 2:37 AM, Tom Lane wrote: > "Shulgin, Oleksandr" writes: >> 1. Have you considered re-loading the HBA file upon call to this function >> in a local context instead of keeping it in the backends memory? > > Aside from the

Re: [HACKERS] Parallel Aggregate

2015-12-21 Thread Haribabu Kommi
On Tue, Dec 22, 2015 at 2:16 AM, Paul Ramsey wrote: > Shouldn’t parallel aggregate come into play regardless of scan selectivity? > I know in PostGIS land there’s a lot of stuff like: > > SELECT ST_Union(geom) FROM t GROUP BY areacode; > > Basically, in the BI case,

Re: [HACKERS] Parallel Aggregate

2015-12-21 Thread Haribabu Kommi
On Mon, Dec 21, 2015 at 6:48 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 21 December 2015 at 17:23, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> >> Attached latest performance report. Parallel aggregate is having some >> overh

Re: [HACKERS] Multi-tenancy with RLS

2015-12-16 Thread Haribabu Kommi
Rebased patch is attached as it is having an OID conflict with the latest set of changes in the master branch. Regards, Hari Babu Fujitsu Australia 4_database_catalog_tenancy_v3.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-16 Thread Haribabu Kommi
On Wed, Dec 16, 2015 at 8:19 AM, Tomas Vondra wrote: > Hi, > > I've reviewed the patch today, after re-reading the whole discussion. Thanks for the review. > The one unsolved issue is what to do with 1e24cf64. My understanding is that > the current patch still

Re: [HACKERS] Parallel Aggregate

2015-12-15 Thread Haribabu Kommi
On Tue, Dec 15, 2015 at 8:04 AM, Paul Ramsey wrote: > But the run dies. > > NOTICE: SRID value -32897 converted to the officially unknown SRID value 0 > ERROR: Unknown geometry type: 2139062143 - Invalid type > > From the message it looks like geometry gets corrupted

Re: [HACKERS] Parallel Aggregate

2015-12-13 Thread Haribabu Kommi
On Fri, Dec 11, 2015 at 5:42 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > 3. Performance test to observe the effect of parallel aggregate. Here I attached the performance test report of parallel aggregate. Summary of the result is: 1. Parallel aggregate is not giving any im

Re: [HACKERS] Parallel Aggregate

2015-12-12 Thread Haribabu Kommi
On Sat, Dec 12, 2015 at 8:42 AM, David Rowley wrote: > On 12 December 2015 at 04:00, Robert Haas wrote: >> >> I'd like to commit David Rowley's patch from the other thread first, >> and then deal with this one afterwards. The only thing I

Re: [HACKERS] Parallel Aggregate

2015-12-10 Thread Haribabu Kommi
On Thu, Dec 3, 2015 at 6:06 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 3 December 2015 at 19:24, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Dec 3, 2015 at 4:18 PM, David Rowley >> <david.row...@2ndquadrant.com> wr

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-09 Thread Haribabu Kommi
On Wed, Dec 9, 2015 at 5:31 PM, Amit Kapila wrote: > > Another bigger issue I see in the above part of code is that it doesn't > seem to be safe to call load_hba() at that place in PostgresMain() as > currently load_hba() is using a context created from PostmasterContext

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-09 Thread Haribabu Kommi
On Thu, Dec 10, 2015 at 4:22 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Haribabu Kommi wrote: > >> Reverting the context release patch is already provided in the first >> mail of this >> thread [1]. Forgot to mention about the same in further mails. >&g

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-09 Thread Haribabu Kommi
On Thu, Dec 10, 2015 at 2:29 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Thu, Dec 10, 2015 at 6:46 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Dec 10, 2015 at 4:22 AM, Alvaro Herrera >> <alvhe...@2ndquadran

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-09 Thread Haribabu Kommi
On Thu, Dec 10, 2015 at 4:33 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Thu, Dec 10, 2015 at 9:51 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Dec 10, 2015 at 2:29 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-08 Thread Haribabu Kommi
On Wed, Dec 9, 2015 at 2:36 AM, Amit Kapila wrote: > > Few assorted comments: Thanks for the review. > 1. > + /* > + * SQL-accessible SRF to return all the settings from the pg_hba.conf > + * file. > + */ > + Datum > + pg_hba_lookup_2args(PG_FUNCTION_ARGS) > + { > +

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-07 Thread Haribabu Kommi
On Sat, Dec 5, 2015 at 3:31 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Haribabu Kommi wrote: > >> How about as follows? >> >> postgres=# select * from pg_hba_lookup('all','all','::1'); >> line_number | type | database | user | address | hos

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-03 Thread Haribabu Kommi
On Fri, Dec 4, 2015 at 7:45 AM, Pavel Stehule wrote: > > > this tracing can be implemented to main pg_hba processing. When you are > connect from some specific client - and you can see, why you cannot to > connect to Postgres The trace messages that are going to print

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-03 Thread Haribabu Kommi
On Fri, Dec 4, 2015 at 8:05 AM, Alvaro Herrera wrote: >> >> Here I attached the patch with the suggested changes. >> >> Along with line number, I kept the options column also with authentication >> >> options as a jsonb datatype. >> >> >> >> Example output: >> >> >> >>

Re: [HACKERS] Parallel Aggregate

2015-12-02 Thread Haribabu Kommi
On Thu, Dec 3, 2015 at 4:18 PM, David Rowley wrote: > > Hi, > > I just wanted to cross post here to mark that I've posted an updated patch > for combining aggregate states: >

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-12-02 Thread Haribabu Kommi
On Wed, Nov 25, 2015 at 7:18 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote: > > > 2015-11-25 8:05 GMT+01:00 Haribabu Kommi <kommi.harib...@gmail.com>: >> >> >> Thanks. Here I attached the poc patch that returns authentication method >> of

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-11-24 Thread Haribabu Kommi
On Tue, Nov 17, 2015 at 9:37 AM, Peter Eisentraut <pete...@gmx.net> wrote: > On 11/16/15 2:37 AM, Haribabu Kommi wrote: >> On Mon, Nov 16, 2015 at 2:30 PM, Peter Eisentraut <pete...@gmx.net> wrote: >>> On 7/21/15 5:15 AM, Haribabu Kommi wrote: >>>> With

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-17 Thread Haribabu Kommi
On Wed, Nov 18, 2015 at 6:02 AM, Robert Haas wrote: > On Mon, Nov 16, 2015 at 4:27 AM, Marti Raudsepp wrote: >> Thank you so much for the review and patch update. I should have done that >> myself, but I've been really busy for the last few weeks. :( > >

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-15 Thread Haribabu Kommi
On Thu, Nov 5, 2015 at 10:20 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > On Tue, Sep 29, 2015 at 12:17 AM, Marti Raudsepp <ma...@juffo.org> wrote: >> Hi list >> >> The attached patch changes the behavior of multiple ALTER x SET SCHEMA >> commands,

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-11-15 Thread Haribabu Kommi
On Mon, Nov 16, 2015 at 2:30 PM, Peter Eisentraut <pete...@gmx.net> wrote: > On 7/21/15 5:15 AM, Haribabu Kommi wrote: >> With the output of this view, administrator can identify the lines >> that are matching for the given >> criteria easily without going through the f

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-05 Thread Haribabu Kommi
On Tue, Sep 29, 2015 at 12:17 AM, Marti Raudsepp wrote: > Hi list > > The attached patch changes the behavior of multiple ALTER x SET SCHEMA > commands, to skip, rather than fail, when the old and new schema is > the same. > > The advantage is that it's now easier to write DDL

Re: [HACKERS] NOTIFY in Background Worker

2015-11-05 Thread Haribabu Kommi
On Fri, Nov 6, 2015 at 4:57 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Nov 5, 2015 at 12:34 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> I marked this patch as ready for committer. > > The patch says: > > If a background work

Re: [HACKERS] NOTIFY in Background Worker

2015-11-04 Thread Haribabu Kommi
On Sat, Aug 29, 2015 at 12:55 PM, Thomas Munro wrote: > On Sat, Aug 29, 2015 at 9:03 AM, Thomas Munro > wrote: >> >> On Fri, Aug 28, 2015 at 10:30 PM, jacques klein >> wrote: >>> >>> Hello, >>> >>> I

Re: [HACKERS] Parallel Seq Scan

2015-11-04 Thread Haribabu Kommi
On Tue, Nov 3, 2015 at 9:41 PM, Amit Kapila wrote: > On Fri, Oct 23, 2015 at 4:41 PM, Amit Kapila > wrote: >> >> On Fri, Oct 23, 2015 at 10:33 AM, Robert Haas >> wrote: > > Please find the rebased partial seq scan patch

Re: [HACKERS] NOTIFY in Background Worker

2015-11-02 Thread Haribabu Kommi
On Sat, Aug 29, 2015 at 12:55 PM, Thomas Munro wrote: > On Sat, Aug 29, 2015 at 9:03 AM, Thomas Munro > wrote: >> >> On Fri, Aug 28, 2015 at 10:30 PM, jacques klein >> wrote: >>> >>> Hello, >>> >>> I

[HACKERS] security_barrier view option type mistake in create view document

2015-10-28 Thread Haribabu Kommi
The security_barrier view option is classified as string in the create view documentation. But it is actually a boolean. The type is mentioned correctly in alter view. Here I attached the patch with the correction. -security_barrier (string) +security_barrier (boolean) Regards,

Re: [HACKERS] Multi-tenancy with RLS

2015-10-26 Thread Haribabu Kommi
On Wed, Oct 21, 2015 at 2:42 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Pending items: > 1. Need to add some more tests to verify all database catalog tables. > 2. Documentation changes for database catalog tenancy. Here I attached the updated database-catalog-security

Re: [HACKERS] On columnar storage (2)

2015-10-21 Thread Haribabu Kommi
On Tue, Sep 1, 2015 at 8:53 AM, Alvaro Herrera wrote: > As discussed in > https://www.postgresql.org/message-id/20150611230316.gm133...@postgresql.org > we've been working on implementing columnar storage for Postgres. > Here's some initial code to show our general idea,

Re: [HACKERS] Multi-tenancy with RLS

2015-10-20 Thread Haribabu Kommi
On Sat, Oct 10, 2015 at 1:54 AM, Stephen Frost <sfr...@snowman.net> wrote: > * Haribabu Kommi (kommi.harib...@gmail.com) wrote: >> On Fri, Oct 9, 2015 at 2:04 PM, Stephen Frost <sfr...@snowman.net> wrote: >> > * Robert Haas (robertmh...@gmail.com) wrote: >>

Re: [HACKERS] Parallel Seq Scan

2015-10-15 Thread Haribabu Kommi
On Thu, Oct 15, 2015 at 6:32 PM, Amit Kapila wrote: > On Wed, Oct 14, 2015 at 3:29 AM, Robert Haas wrote: > I think this got messed up while rebasing on top of Gather node > changes, but nonetheless, I have changed it such that PartialSeqScan >

Re: [HACKERS] Parallel Seq Scan

2015-10-15 Thread Haribabu Kommi
On Fri, Oct 16, 2015 at 2:10 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > On Thu, Oct 15, 2015 at 11:45 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Thu, Oct 15, 2015 at 5:39 PM, Haribabu Kommi <kommi.harib...@gmail.com> >> wrote: >>> &

Re: [HACKERS] Parallel Seq Scan

2015-10-15 Thread Haribabu Kommi
On Thu, Oct 15, 2015 at 11:45 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Thu, Oct 15, 2015 at 5:39 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> >> >> On Thu, Oct 15, 2015 at 6:32 PM, Amit Kapila <amit.kapil...@gmail.com>

Re: [HACKERS] Parallel Aggregate

2015-10-13 Thread Haribabu Kommi
On Tue, Oct 13, 2015 at 5:53 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 13 October 2015 at 17:09, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Tue, Oct 13, 2015 at 12:14 PM, Robert Haas <robertmh...@gmail.com> >> wrote

Re: [HACKERS] Parallel Seq Scan

2015-10-12 Thread Haribabu Kommi
On Mon, Oct 5, 2015 at 11:20 PM, Amit Kapila wrote: > For now, I have fixed this by not preserving the startblock incase of rescan > for parallel scan. Note that, I have created a separate patch > (parallel_seqscan_heaprescan_v1.patch) for support of rescan (for parallel

Re: [HACKERS] Parallel Aggregate

2015-10-12 Thread Haribabu Kommi
On Tue, Oct 13, 2015 at 12:14 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Sun, Oct 11, 2015 at 10:07 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> Parallel aggregate is the feature doing the aggregation job parallel >> with the help of Gather

[HACKERS] Parallel Aggregate

2015-10-11 Thread Haribabu Kommi
Parallel aggregate is the feature doing the aggregation job parallel with the help of Gather and partial seq scan nodes. The following is the basic overview of the parallel aggregate changes. Decision phase: Based on the following conditions, the parallel aggregate plan is generated. - check

Re: [HACKERS] Parallel Aggregate

2015-10-11 Thread Haribabu Kommi
On Mon, Oct 12, 2015 at 2:25 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 12 October 2015 at 15:07, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> - check whether the aggregate supports parallelism or not. >> >> As for firs

Re: [HACKERS] RLS bug in expanding security quals

2015-10-08 Thread Haribabu Kommi
On Fri, Oct 9, 2015 at 3:50 AM, Dean Rasheed wrote: > On 8 October 2015 at 15:05, Dean Rasheed wrote: >> Attached is a simple patch that appears to work, but it needs more >> testing (and some regression tests). >> > > Here's an updated patch

Re: [HACKERS] removing set_latch_on_sigusr1

2015-10-08 Thread Haribabu Kommi
On Fri, Oct 9, 2015 at 2:41 AM, Robert Haas wrote: > > As it happens, the TupleQueueFunnelNext function I recently committed > has such a hazard, which I failed to spot during review and testing. > If people don't like this, I can instead cause that function to set > the

<    1   2   3   4   5   6   >