Re: [HACKERS] Grouping Sets

2011-09-19 Thread Joshua Tolley
st bet is probably to get the code from approximately the date of the patch. As far as I know it hasn't been touched in a while, and didn't work well back when it was being actively developed. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com pgpeMKakIJ2SX.p

Re: [HACKERS] SSI, simplified

2011-01-25 Thread Joshua Tolley
On Sun, Jan 23, 2011 at 07:48:04PM -0600, Kevin Grittner wrote: > http://www.xtranormal.com/watch/8285377/?listid=20642536 I foresee a whole new set of animated postgres tutorials... -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digi

Re: [HACKERS] Patch to add a primary key using an existing index

2011-01-25 Thread Joshua Tolley
reverses the effects of ADD CONSTRAINT might be surprised. > Comments? So you'd manually create an index, attach it to a constraint, drop the constraint, and find that the index had disappeared? ISTM since you created the index explicitly, you should have to drop it explicitly as well. -- Jo

Re: [HACKERS] Sync Rep Design

2010-12-30 Thread Joshua Tolley
that currently, even without replication, #2 can happen. For what little it's worth, I vote for this option, because it's a problem that can already happen (as opposed to adding an entirely new type of problem to the mix). -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] proposal : cross-column stats

2010-12-13 Thread Joshua Tolley
s "...WHERE foo > 4 AND foo > 5". -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] pg_execute_from_file review

2010-11-29 Thread Joshua Tolley
ich would be fairly clear and nicely > > symmetrical. > > +1, but I think "query" is also a noise word here. > Why not just "pg_execute_file" and "pg_execute_string"? > > regards, tom lane While we're bikeshedding, and since I star

Re: [HACKERS] pg_execute_from_file review

2010-11-25 Thread Joshua Tolley
On Thu, Nov 25, 2010 at 10:24:51PM +0100, Dimitri Fontaine wrote: > Joshua Tolley writes: > > I've just looked at pg_execute_from_file[1]. The idea here is to execute all > > the SQL commands in a given file. My comments: > > Thanks for your review. Please find atta

[HACKERS] pg_execute_from_file review

2010-11-24 Thread Joshua Tolley
I'd ask. * In the snippet below, it seems best just to use palloc0(): query_string = (char *)palloc((fsize+1)*sizeof(char)); memset(query_string, 0, fsize+1); * Shouldn't it include SPI_push() and SPI_pop()? [1] http://archives.postgresql.org/message-id/m262wf6fnz@2ndquad

Re: [HACKERS] Synchronous replication - patch status inquiry

2010-09-02 Thread Joshua Tolley
t; discussion. Oracle provides this, among other possible configurations; perhaps that's why it came up earlier. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] grouping sets - updated patch

2010-08-09 Thread Joshua Tolley
aven't made it through the last version much, but I'll poke through this instead. I have a few days of family business coming up, and might be unrespondive during that time. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] GROUPING SETS revisited

2010-08-06 Thread Joshua Tolley
point, but it hasn't been implemented yet (or no one has figured out how to do it)? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] GROUPING SETS revisited

2010-08-05 Thread Joshua Tolley
On Thu, Aug 05, 2010 at 04:46:51PM +0200, Pavel Stehule wrote: > So Joshua, can you look on code? Sure... thanks :) -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] GROUPING SETS revisited

2010-08-04 Thread Joshua Tolley
*can* edit comments/docs :) -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] GROUPING SETS revisited

2010-08-04 Thread Joshua Tolley
#x27;s useful, but it seems that since Pavel's code is due to appear sometime in the foreseeable future, there's not much point in my doing that. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] GROUPING SETS revisited

2010-08-03 Thread Joshua Tolley
from that also enclosed. > Yeah, I seem to have done a poor job of producing the patch based on the repository I was working from. That said, it seems Pavel's working actively on a patch anyway, so perhaps my updating the old one isn't all that worthwhile. Pavel, is your code somewhere that we can get to it? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

[HACKERS] GROUPING SETS revisited

2010-08-02 Thread Joshua Tolley
hackers/2009-05/msg00700.php -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com diff --git a/src/backend/parser/Makefile b/src/backend/parser/Makefile index a8f4c07..fb248a6 100644 *** a/src/backend/parser/Makefile --- b/src/backend/parser/Makefile *** override CPP

Re: [HACKERS] Synchronous replication

2010-07-27 Thread Joshua Tolley
On Tue, Jul 27, 2010 at 10:53:45PM +0900, Fujii Masao wrote: > On Tue, Jul 27, 2010 at 10:12 PM, Joshua Tolley wrote: > > My concern is that in a quorum system, if the quorum number is less than the > > total number of replicas, there's no way to know *which* replicas composed

Re: [HACKERS] Synchronous replication

2010-07-27 Thread Joshua Tolley
On Tue, Jul 27, 2010 at 01:41:10PM +0900, Fujii Masao wrote: > On Tue, Jul 27, 2010 at 12:36 PM, Joshua Tolley wrote: > > Perhaps I'm hijacking the wrong thread for this, but I wonder if the quorum > > idea is really the best thing for us. I've been thinking about Oracl

Re: [HACKERS] Synchronous replication

2010-07-26 Thread Joshua Tolley
cases. [1] http://download.oracle.com/docs/cd/B28359_01/server.111/b28294/protection.htm#SBYDB02000 alternatively, http://is.gd/dLkq4 -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] cross column correlation revisted

2010-07-15 Thread Joshua Tolley
t; one side question: does anybody happen to know how this is one in oracle or > db2? Neither appear to handle multi-column statistics in any form. [1] http://download.oracle.com/docs/cd/B13789_01/appdev.101/b10802/d_stats.htm [2] http://www.ibm.com/developerworks/data/library/techarticle/dm-060

Re: [HACKERS] cross column correlation revisted

2010-07-14 Thread Joshua Tolley
ven sufficiently effective to merit the increased code size and complexity, we can consider expanding it to joined relations. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] cross column correlation revisted

2010-07-14 Thread Joshua Tolley
es are in analyze.c; no user-visible changes have been introduced. For that matter, there aren't any changes yet actually to use the values once calculated (more unresolved questions get in the way there), but it's a start. [1] http://en.wikipedia.org/wiki/Copula_(statistics)

[HACKERS] Out of date comment in xlogutils.c

2010-07-08 Thread Joshua Tolley
al reasons, instead of a ReadBufferMode argument, this only -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] [PATCH] Add _PG_init to PL language handler documentation

2010-06-09 Thread Joshua Tolley
On Tue, Jun 08, 2010 at 04:18:08PM -0400, Robert Haas wrote: > On Wed, May 26, 2010 at 11:24 PM, Joshua Tolley wrote: > > On Wed, May 26, 2010 at 03:47:25PM -0400, Robert Haas wrote: > >> On Tue, May 25, 2010 at 4:34 AM, Jonathan Leto wrote: > >> > This tiny

Re: [HACKERS] [PATCH] Add _PG_init to PL language handler documentation

2010-05-26 Thread Joshua Tolley
ented. +1. How about the attached (which, incidentally, tested successfully on my box, because I've managed to achieve doc building nirvana through blindly flailing about until it worked...)? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com diff --git a/doc/src/sgml/plha

Re: [HACKERS] Specification for Trusted PLs?

2010-05-21 Thread Joshua Tolley
On Fri, May 21, 2010 at 2:04 PM, Tom Lane wrote: > Joshua Tolley writes: >> Agreed. As long as a trusted language can do things outside the >> database only by going through a database and calling some function to >> which the user has rights, in an untrusted language, that

Re: [HACKERS] Specification for Trusted PLs?

2010-05-21 Thread Joshua Tolley
aunch_missiles() would have a function in an untrusted language to do it, but there's no reason an untrusted language shouldn't be able to say "SELECT launch_missiles()". -- Joshua Tolley / eggyknap End Point Corporation -- Sent via pgsql-hackers mailing list (pgsql-hackers@po

[HACKERS] wal_level and continuous archiving documentation

2010-05-13 Thread Joshua Tolley
hese statements, WAL would not contain enough information for archive recovery." ISTM wal_archive should make an appearance where the docs bring up archive_mode and archive_command, to say "wal_level must be set to 'archive' or 'hot_standby'", so all requir

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-08 Thread Joshua Tolley
her it's disallowed by lack of a rule, or by existence of a "reject" rule, or by something else entirely. As long as the message isn't clearly wrong in the "reject" case, as it is now. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] machine-readable pg_controldata?

2010-03-04 Thread Joshua Tolley
just haven't gotten around to writing it. But +1 from me, FWIW. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] knngist patch support

2010-02-13 Thread Joshua Tolley
archSysCache et al. to SearchSysCache1, etc.? It seems to me that requires changes to all kinds of software without any real need. The four lines of PL/LOLCODE that inspired this thought aren't themselves a great burden, but when combined with everyone else using SearchSysCache already... -- Josh

Re: [HACKERS] Making pg_config and pg_controldata output available via SQL

2010-02-03 Thread Joshua Tolley
On Wed, Feb 03, 2010 at 02:32:47PM -0500, Tom Lane wrote: > Joshua Tolley writes: > > I'd really like to see the data from pg_config and pg_controldata available > > through SQL, such as by adding output to pg_show_all_settings(), or adding > > new > > SRFs name

[HACKERS] Making pg_config and pg_controldata output available via SQL

2010-02-03 Thread Joshua Tolley
e? In particular it's useful to be able to find $libdir without requiring pg_config, as some packagers tend not to include it in anything put the -dev packages, but all those settings seem useful to have on hand, and in at least most cases shouldn't be tough to expose via SQL. Comments? -

Re: [HACKERS] development setup and libdir

2010-01-30 Thread Joshua Tolley
s one (or two or fifty or so) where you > *will* need it. Not just debug information (the --enable-debug flag to the configure script), but also --enable-cassert, --enable-depend, and/or others you're likely to want to use during development. -- Joshua Tolley / eggyknap End Point Co

Re: [HACKERS] per-user pg_service.conf

2010-01-13 Thread Joshua Tolley
me. I was similarly surprised to learn the same thing recently, but admit I didn't take the time see how easily it could be changed. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

[HACKERS] Hot standby documentation

2010-01-07 Thread Joshua Tolley
-availability.html -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] Time to run initdb is mostly figure-out-the-timezone work

2009-12-18 Thread Joshua Tolley
r. > I have the exact same issue: For whatever it's worth, I get it too, on Ubuntu 9.04... ~4s without TZ vs. ~1.8s with TZ. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] Need a mentor, and a project.

2009-12-07 Thread Joshua Tolley
hat consensus early on, rather than after you've written a lot of code. The keyword "proposal" might be a useful search term when digging in the -hackers archives for historical examples. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] PL/Python array support

2009-12-02 Thread Joshua Tolley
On Fri, Nov 20, 2009 at 12:00:24AM +0200, Peter Eisentraut wrote: > On fre, 2009-11-13 at 18:46 +0300, Teodor Sigaev wrote: > > CREATE OR REPLACE FUNCTION incr(stuff int[]) RETURNS int[] AS $$ > > for x in stuff: > > yield x+1 > > $$ > > LANGUAGE 'plpythonu'; > > > > # select incr(ARRAY[1,2,3

Re: [HACKERS] PL/Python array support

2009-12-01 Thread Joshua Tolley
j...@josh*# create function return_arr() returns int[] as $$ return (1, 2, 3, 4, 5) $$ language plpythonu; CREATE FUNCTION 5432 j...@josh*# select return_arr(); return_arr - {1,2,3,4,5} (1 row) 5432 j...@josh*# select * from return_set(); return_set ---- 1 2

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-29 Thread Joshua Tolley
On Sat, Nov 28, 2009 at 10:15:40PM -0500, Tom Lane wrote: > Joshua Tolley writes: > > Makes sense on both counts. Thanks for the help. How does the attached look? > > Applied with minor corrections, mainly around the state save/restore > logic. I also put in some code to f

Re: [HACKERS] Application name patch - v4

2009-11-28 Thread Joshua Tolley
acket then this wouldn't > be a problem, but we are far from being able to do that. Nothing I've written uses RESET ALL, but if it did, I expect it would be because whatever the connection was being used for in the past differs substantially from whatever I plan to use it for in

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-19 Thread Joshua Tolley
n both counts. Thanks for the help. How does the attached look? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com diff --git a/doc/src/sgml/plperl.sgml b/doc/src/sgml/plperl.sgml index 49631f2..ebcb608 100644 *** a/doc/src/sgml/plperl.sgml --- b/doc/src/sgml/plperl.s

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-17 Thread Joshua Tolley
_call_perl_func should be cast to void to avoid a >> possible compiler warning (although It doesn't emit one on my system): >> >> (void) plperl_call_perl_func(&desc, &fake_fcinfo); > > Right. I don't get the warning either, and didn't realize it could

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-17 Thread Joshua Tolley
On Wed, Nov 18, 2009 at 09:35:35AM +1100, Brendan Jurd wrote: > 2009/11/17 Joshua Tolley : > > On Sun, Nov 15, 2009 at 12:10:33PM +1100, Brendan Jurd wrote: > >> I noticed that there was a fairly large amount of bogus/inconsistent > >> whitespace > ... > > >

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-16 Thread Joshua Tolley
PL/Perl mention used the same term. I can accept that argument. The attached patch modifies the documentation, and fixes another inconsistency I found. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com diff --git a/doc/src/sgml/plperl.sgml b/doc/src/sgml/plperl.sgml i

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-12 Thread Joshua Tolley
On Fri, Nov 06, 2009 at 09:53:20PM -0500, Andrew Dunstan wrote: > Joshua Tolley wrote: >> I looked through the >> regression tests and didn't find any that used plperl -- should we add one >> for >> this (or for this and all kinds of other stuff)? Is there

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-09 Thread Joshua Tolley
On Fri, Nov 06, 2009 at 09:53:20PM -0500, Andrew Dunstan wrote: > > > Joshua Tolley wrote: >> I looked through the >> regression tests and didn't find any that used plperl -- should we add one >> for >> this (or for this and all kinds of other stuff)? Is

Re: [HACKERS] plperl and inline functions -- first draft

2009-11-05 Thread Joshua Tolley
On Thu, Nov 05, 2009 at 05:51:45PM -0500, Andrew Dunstan wrote: > Joshua Tolley wrote: >> I've been trying to make pl/perl support 8.5's inline functions, with the >> attached patch. > > Wow, this is the second time this week that people have produced patches >

[HACKERS] plperl and inline functions -- first draft

2009-11-05 Thread Joshua Tolley
lperl's trusted interpreter initialization works, and have simply copied what looked like important stuff from the original plperl call handler. I tested with this to prove it: DO $$ qx{touch test.txt}; $$ language plperl; This works both with plperl and plperlu. Hints, anyone? Comment

Re: [HACKERS] Feature Suggestion: PL/Js

2009-10-07 Thread Joshua Tolley
On Wed, Oct 07, 2009 at 11:29:15AM -0400, Alvaro Herrera wrote: > Joshua Tolley escribió: > > On Wed, Oct 07, 2009 at 10:22:02AM -0400, Alvaro Herrera wrote: > > > Kiswono Prayogo escribió: > > > > by using latest v8 engine from google, is it possible to build PL/Js

Re: [HACKERS] Feature Suggestion: PL/Js

2009-10-07 Thread Joshua Tolley
think Josh Tolley has some slides on how we built PL/LOLCODE that > could prove useful. Said slides are available here: http://www.pgcon.org/2009/schedule/events/159.en.html I hope they can be useful. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] WIP - syslogger infrastructure changes

2009-09-26 Thread Joshua Tolley
rainstorm It doesn't have anything linking to it right now, which might be a bad thing. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] syslog_line_prefix

2009-09-25 Thread Joshua Tolley
On Fri, Sep 25, 2009 at 05:04:45PM -0400, Robert Haas wrote: > On Fri, Sep 25, 2009 at 4:58 PM, Joshua Tolley wrote: > > On Fri, Sep 25, 2009 at 03:19:36PM -0400, Tom Lane wrote: > >> However, I don't think I actually believe the premise of this patch, > >> which

Re: [HACKERS] syslog_line_prefix

2009-09-25 Thread Joshua Tolley
On Fri, Sep 25, 2009 at 05:04:45PM -0400, Robert Haas wrote: > On Fri, Sep 25, 2009 at 4:58 PM, Joshua Tolley wrote: > > On Fri, Sep 25, 2009 at 03:19:36PM -0400, Tom Lane wrote: > >> However, I don't think I actually believe the premise of this patch, > >> which

Re: [HACKERS] syslog_line_prefix

2009-09-25 Thread Joshua Tolley
logger know things about the log messages it gets (rather than just having an opaque string), and route messages various places, accordingly. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] syslog_line_prefix

2009-09-25 Thread Joshua Tolley
These two logs need not necessarily contain the same information. Loads of people seem to want to be able to have separate per-database log files, which something like this could also allow. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] Feedback on getting rid of VACUUM FULL

2009-09-17 Thread Joshua Tolley
s get moved > per call. Presumably this couldn't easily be an upper bound on the time spent moving tuples, rather than an upper bound on the number of tuples moved? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] WIP: generalized index constraints

2009-09-15 Thread Joshua Tolley
e that was adequately short-and-sweet, and still conveyed the idea of both "operator" and "index", which seems important so as to designate between these and the constraints we've had all along. Perhaps "indexed operator constraints"? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] WIP: generalized index constraints

2009-09-15 Thread Joshua Tolley
(2), (3); j...@josh*# insert into a values (8), (3), (4); ERROR: duplicate key value violates unique constraint "a_unique" DETAIL: Key (a)=(3) already exists. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] autovacuum_max_workers docs

2009-09-13 Thread Joshua Tolley
On Sun, Sep 13, 2009 at 10:54:21PM +0300, Peter Eisentraut wrote: > On fre, 2009-09-11 at 07:39 -0600, Joshua Tolley wrote: > While your discovery is accurate and the change makes it consistent with > other similar parameters, note that the previous wording is also > completely co

[HACKERS] autovacuum_max_workers docs

2009-09-11 Thread Joshua Tolley
parameter can only be set at server start. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] Implementation of GROUPING SETS (T431: Extended grouping capabilities)

2009-09-02 Thread Joshua Tolley
certainly wouldn't bother trying to implement it. It's very helpful that you've let us know you're not working on it. That way Pavel, if he finds he has time and interest, or someone else, can work on it without fear of conflicting with what you're doing. Thanks fo

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Joshua Tolley
we can't start it earlier. +1 from me, too, under the same condition. Since logging in really interesting ways depends on a separate process, any logging before then will be "abnormal", and any logs we create will probably show up in a relatively unexpected place. The Principle of L

Re: [HACKERS] "Hot standby"?

2009-08-12 Thread Joshua Tolley
ibed them upthread. Cold > means it's on the shelf. Warm means it's plugged in, but you have to > have to do something to get it going. Hot means it just takes over > when needed. After all this, perhaps we can at least conclude that calling it "cold", "warm", o

Re: [HACKERS] Review: Patch for contains/overlap of polygons

2009-08-09 Thread Joshua Tolley
but it might be over-engineering. Those particular section > headers might not be applicable to someone else's review. I've just added a link to this email to the "Reviewing a Patch" wiki page (http://wiki.postgresql.org/wiki/Reviewing_a_Patch). Do with it as you see fit :) -- Jo

Re: [HACKERS] [PATCH] DefaultACLs

2009-08-04 Thread Joshua Tolley
On Tue, Aug 04, 2009 at 01:28:00PM -0400, Stephen Frost wrote: > Thanks to Joshua, there weren't really many changes I found for the > docs. Here they are anyway: Yay, I was useful! :) > How about: > > Replaces current privileges with the default privileges, as set using > , for > this object t

Re: [HACKERS] ALTER TABLE ... ALTER COLUMN ... SET DISTINCT

2009-08-02 Thread Joshua Tolley
COLUMN SET STATISTICS NDISTINCT ? > > I don't want to add a new keyword, but "SET STATISTICS DISTINCT" would > be an easy change. Comments? +1 -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-25 Thread Joshua Tolley
On Sat, Jul 25, 2009 at 08:41:12PM -0400, Robert Haas wrote: > On Sat, Jul 25, 2009 at 8:39 PM, Joshua Tolley wrote: > > On Sun, Jul 19, 2009 at 06:13:32PM +0200, Petr Jelinek wrote: > >> while writing some basic docs I found bug in dependency handling when > >> do

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-25 Thread Joshua Tolley
27;d completely forgotten to look at the docs. I've made a few changes based solely on my opinions of what sounds better and what's more consistent with the existing documentation. Do with them as you see fit. :) -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.co

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-25 Thread Joshua Tolley
On Sat, Jul 25, 2009 at 03:50:06PM -0400, Andrew Dunstan wrote: > Joshua Tolley wrote: >> I figured as much. I can't seem to get past this, despite a make distclean. >> Suggestions, anyone? >> > try a fresh checkout and reapply the patch? [ a couple git clean, git res

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-25 Thread Joshua Tolley
On Sat, Jul 25, 2009 at 11:14:19AM +0200, Petr Jelinek wrote: > Joshua Tolley wrote: >> Am I the only one that gets this on make check, with this version (from >> src/test/regress/log/initdb.log): >> >> selecting default shared_buffers ... 32MB >> creating confi

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-24 Thread Joshua Tolley
y exists child process exited with exit code 1 initdb: data directory "/home/josh/devel/pgsrc/pg85/src/test/regress/./tmp_check/data" not removed at user's request -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] When is a record NULL?

2009-07-24 Thread Joshua Tolley
NULL? (From Tom): > This is per SQL standard. IS NULL is true if *all* the record's > > fields are null; IS NOT NULL is true if *none* of them are. > -- Joshua Tolley / eg

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Joshua Tolley
re as to whether Josh Tolley is still conducting a > more in-depth review. Josh? Yes, I am, but if you've read this far you know that already :) -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-17 Thread Joshua Tolley
ad to be kept in sync, but I'm not sure that's much of an issue in reality, given how unlikely it is that schema object types to which default ACLs should apply are likely to be added or removed. I don't know how patches that require catalog version changes are generally handled; sho

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-17 Thread Joshua Tolley
icolon on line 1608. I fixed it in my version, and it applied cleanly to head (with some offset hunks in gram.y). I've not yet finished building and testing; results to follow later. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] [PATCH] [v8.5] Security checks on largeobjects

2009-07-15 Thread Joshua Tolley
anks for letting me know; I hope a solution to the problems you've brought up is forthcoming. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

[HACKERS] git.postgresql.org vs. REL8_1_STABLE

2009-07-10 Thread Joshua Tolley
rc' make: *** [all] Error 2 Indeed, src/include/nodes has no tidbitmap.h file (it shows up in REL8_2_STABLE). -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] [pgsql-www] commitfest.postgresql.org

2009-07-09 Thread Joshua Tolley
On Thu, Jul 09, 2009 at 02:35:04PM -0300, Dickson S. Guedes wrote: > This could help, maybe with a RSS in that (like in git). +1 for the RSS feed, if only because I think it sounds neat :) -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Descript

Re: [HACKERS] *_collapse_limit, geqo_threshold

2009-07-08 Thread Joshua Tolley
plans are, in reality, less stable than than usual planner? Certainly on paper it appears they could be, but the mailing lists are full of emails about "this query's plan changed and performance suddenly tanked; how do I fix it?" so I'm unconvinced this is a problem unique to GEQO. Which in turn boils down to "we need real world data to look at". -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] First CommitFest: July 15th

2009-07-07 Thread Joshua Tolley
On Thu, Jul 02, 2009 at 03:42:56PM +0100, Dave Page wrote: > On Thu, Jul 2, 2009 at 3:22 PM, Joshua Tolley wrote: > > On Thu, Jul 02, 2009 at 08:41:27AM +0100, Dave Page wrote: > >> As far as I'm aware, there's been no code > >> review yet either, which wou

Re: [HACKERS] First CommitFest: July 15th

2009-07-02 Thread Joshua Tolley
On Thu, Jul 02, 2009 at 03:42:56PM +0100, Dave Page wrote: > On Thu, Jul 2, 2009 at 3:22 PM, Joshua Tolley wrote: > > On Thu, Jul 02, 2009 at 08:41:27AM +0100, Dave Page wrote: > >> As far as I'm aware, there's been no code > >> review yet either, which wou

Re: [HACKERS] First CommitFest: July 15th

2009-07-02 Thread Joshua Tolley
would be willing to do so again, if it would be useful. -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com signature.asc Description: Digital signature

Re: [HACKERS] 8.5 development schedule

2009-07-01 Thread Joshua Tolley
patch or two that interested me. > If a hamster > and an elephant are trying to sit on the same bench, the hamster does > not want the elephant to assert that he is a hamster; he wants the > elephant to announce his choice of seat prior to putting his bottom in Thanks, Robert -- thi

Re: [HACKERS] Multi-Dimensional Histograms

2009-06-29 Thread Joshua Tolley
On Mon, Jun 29, 2009 at 10:22:15PM -0400, Robert Haas wrote: > I'm finding myself unable to follow all the terminology on this thead. > What's dimension reduction? For instance, ask a bunch of people a bunch of survey questions, in hopes of predicting some value (for instance, whether or not the

Re: [HACKERS] Query progress indication - an implementation

2009-06-29 Thread Joshua Tolley
On Mon, Jun 29, 2009 at 02:07:23PM -0400, Tom Lane wrote: > Josh Berkus writes: > > So, while an actual % completed indicator would be perfect, a "query > > steps completed, current step =" would still be very useful and a large > > improvement over what we have now. > > I think this is pretty

Re: [HACKERS] explain analyze rows=%.0f

2009-05-28 Thread Joshua Tolley
On Thu, May 28, 2009 at 11:12:42PM -0400, Robert Haas wrote: > On Thu, May 28, 2009 at 11:00 PM, Euler Taveira de Oliveira > > Don't you think is too strange having, for example, 6.67 rows? > > No stranger than having it say 7 when it's really not. Actually mine > mostly come out 1 when the real

Re: [HACKERS] Dtrace probes documentation

2009-05-28 Thread Joshua Tolley
On Thu, May 28, 2009 at 06:28:14PM -0400, Tom Lane wrote: > Joshua Tolley writes: > > The dtrace probes documentation [1] spells each probe name with dashes > > ("transaction-start", "transaction-commit", etc.). Yet as far as I can see, > > dtrace onl

[HACKERS] Dtrace probes documentation

2009-05-28 Thread Joshua Tolley
The dtrace probes documentation [1] spells each probe name with dashes ("transaction-start", "transaction-commit", etc.). Yet as far as I can see, dtrace only works if you spell the probe names with double underscores ("transaction__start", "transaction__commit", etc.). Why the discrepancy? Obvious

Re: [HACKERS] generic options for explain

2009-05-26 Thread Joshua Tolley
On Tue, May 26, 2009 at 09:55:55AM -0400, Dave Page wrote: > from the pgAdmin perspective. We > already use libxml2, but JSON would introduce another dependency for > us. ...and using XML introduces a dependency for those that apps that don't already use some XML parser. I realize that since the p

Re: [HACKERS] generic options for explain

2009-05-25 Thread Joshua Tolley
On Mon, May 25, 2009 at 11:22:24AM -0400, Tom Lane wrote: > Joshua Tolley writes: > > I'm not sure I see why it would be less flexible. I'm imagining we define > > some > > record type, and a function that returns a set of those records. > > I'm unim

Re: [HACKERS] generic options for explain

2009-05-25 Thread Joshua Tolley
On Mon, May 25, 2009 at 10:55:48AM -0400, Tom Lane wrote: > Joshua Tolley writes: > > The Oracle version, as it fills the table of explain results, gives > > each number an id and the id of its parent row, which behavior we > > could presumably copy. I'm definitely kee

Re: [HACKERS] generic options for explain

2009-05-25 Thread Joshua Tolley
On Mon, May 25, 2009 at 07:14:56AM -0400, Robert Haas wrote: > Many people who responded to this > thread were fine with the idea of some sort of options syntax, but we > had at least four different proposals for how to implement it: > > Robert Haas: EXPLAIN (foo 'bar', baz 'bletch', ...) query >

Re: [HACKERS] generic options for explain

2009-05-24 Thread Joshua Tolley
On Sun, May 24, 2009 at 06:53:29PM -0400, Tom Lane wrote: > Greg Smith writes: > > On Sun, 24 May 2009, Pavel Stehule wrote: > >> we should have a secondary function explain_query(query_string, > >> option) that returns setof some. > > > +1. The incremental approach here should first be adding f

Re: [HACKERS] generic options for explain

2009-05-24 Thread Joshua Tolley
On Sun, May 24, 2009 at 11:57:13AM -0400, Andrew Dunstan wrote: > > > Robert Haas wrote: EXPLAIN ('hash_detail', 'on') query... >> >> Oops, I should have written EXPLAIN (hash_detail 'on') query... can't >> follow my own syntax. >> >> >>> I am sorry - this is really strange synt

Re: [HACKERS] Implementation of GROUPING SETS (T431: Extended grouping capabilities)

2009-05-13 Thread Joshua Tolley
On Wed, May 13, 2009 at 06:29:41AM +0200, Pavel Stehule wrote: > 2009/5/13 Joshua Tolley : > > On Tue, May 12, 2009 at 11:20:14PM +0200, Pavel Stehule wrote: > >> this patch has some bugs but it is good prototype (it's more stable > >> than old patch): > > &

Re: [HACKERS] Implementation of GROUPING SETS (T431: Extended grouping capabilities)

2009-05-12 Thread Joshua Tolley
On Tue, May 12, 2009 at 11:20:14PM +0200, Pavel Stehule wrote: > this patch has some bugs but it is good prototype (it's more stable > than old patch): I'm not sure if you're at the point that you're interested in bug reports, but here's something that didn't behave as expected: 5432 j...@josh*#

Re: [HACKERS] ALTER TABLE ... ALTER COLUMN ... SET DISTINCT

2009-05-04 Thread Joshua Tolley
On Mon, May 04, 2009 at 10:13:31PM -0400, Robert Haas wrote: > + own analysis indicates otherwie). When set to a negative value, which s/otherwie/otherwise A question: why does attdistinct become entry #5 instead of going at the end? I assume it's because the order here controls the col

[HACKERS] Lifetime of FmgrInfo

2009-04-16 Thread Joshua Tolley
I was browsing PL/pgSQL source, and saw this line (pl_comp.c:151): function = (PLpgSQL_function *) fcinfo->flinfo->fn_extra It then does some work to determine whether the result in "function" is valid or not. So I got to wondering, what's the lifetime of the FunctionCallInfoinfo object passed to

  1   2   >