On Mon, Nov 6, 2017 at 5:00 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Magnus Hagander <mag...@hagander.net> writes:
> > On Mon, Nov 6, 2017 at 4:46 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> >> Hm, around here it's no match -> spam bucket. But in a
On Mon, Nov 6, 2017 at 4:46 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Magnus Hagander <mag...@hagander.net> writes:
> > On Mon, Nov 6, 2017 at 4:40 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> >> I suggest doing that the other way 'round. Otherwise, the email
&
e where email ends up in
the *inbox* after the migration, not the bitbucket. That's the default
action in most peoples MUAs when their rules no longer match...
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
mportant to know for somebody writing an external tool for it.
It also seems the list in the documentation is not in sync with the code.
AFAICT docs are not mentioning the current_logfile. This seems to be a miss
in 19dc233c32f ?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.ha
s. Confusingly enough, START_STREAMING is what's returned by
START_REPLICATION.
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Mon, Oct 30, 2017 at 3:49 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp>
wrote:
> Here is a patch to fix a typo in a comment in partition.c:
> s/specificiation/specification/.
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.
handling hung sessions. I've cleaned up for now and it seems to be working
again, and we'll do some more digging into what actually was the root
cause.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
end admin requests. This happens now
and then, and will get released from the moderation queue quickly I'm sure
:)
Long term we'll be getting rid of those filters, but they're there for a
while longer.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.r
t seem worth it.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Thu, Oct 19, 2017 at 12:05 PM, Masahiko Sawada <sawada.m...@gmail.com>
wrote:
> Hi,
>
> Attached a patch for $subject.
>
> s/RAIDUS/RADIUS/
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https:/
on parameter target_session_attrs,
does it not? We don't reroute active connections based on it, and we're not
smart enough to do anything beyond "try them one by one until you reach the
one with the correct attributes", but the basic functionality is there.
Basically what we already have fulfill
st
made it a bit more ugly. Once the caches expire I believe sorting should be
correct.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
nt exactly this.
You could argue the same thing for example for memory parameters and such.
We have no permissions at all when it comes to userset gucs today -- and of
course, if something should be added about this, it should be done in a way
that works for all the userset variables, not just search_pa
ditionally are, but maybe that's too much to ask.
>
Whether that's traditionally or not very much depends on which part of the
world you are in, I believe. Let's try to avoid going down that rabbithole
:)
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Tue, Oct 3, 2017 at 3:51 PM, Stephen Frost <sfr...@snowman.net> wrote:
> Tom,
>
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
> > Magnus Hagander <mag...@hagander.net> writes:
> > > On Tue, Oct 3, 2017 at 6:33 AM, Tom Lane <t...@sss.pgh.pa.us> wrot
uot; ... but that seems messy and unreliable,
> so I'm not sure it would really add any security.
>
No that's horrible. If it's unreliable, it doesn't provide any actual
benefit. We have a history of that in our default being prefer instead of
allow, but we definitely shouldn't make tha
rk fine that
time.
Most operations people already deal with a lot of such parameters changing
around. I'm sure most of them would be more than happy with an improvement,
even if it's not mathematically perfect.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&
speak. Is it
> nice?
>
I believe it's usually referred to as "localhost"?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
onwards, at least to
> support logical replication).
>
> But what about earlier versions? Any chance it could be backported
> down to 9.4? If that would be acceptable, I could probably help/do that...
The likelihood is zero if you mean backported into core of earlier versions.
If you mean backported as a standalone extension that could be installed on
a previous version, probably. I'm not sure if it relies on any internals
not present before that would make it harder, but it would probably at
least be possible.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Tue, Sep 26, 2017 at 7:42 AM, Alvaro Hernandez <a...@ongres.com> wrote:
>
>
> On 25/09/17 22:13, Magnus Hagander wrote:
>
> On Mon, Sep 25, 2017 at 8:20 PM, Alvaro Hernandez <a...@ongres.com> wrote:
>
>>
>>
>> On 25/09/17 20:18, Andres Freund wr
e will accept it as such, and that's good enough.
>
Historically the fact that we have been pickier than many of the "someone
big":s is exactly how we ended up with the codebase and relative stability
we have today.
Just because someone is big doesn't mean they know what's right. In fact,
m
to the backup software to store
> the necessary information and create the file for use during recovery).
>
Actally, it was deprecated already in 9.6, not just 10.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
t; bug. But instead of just not showing the query when the backend is
> idle, I'd change the display for that case to:
>
> DETAIL: Failed process was idle; last query was: %s
>
> Or something like that. I guess we'd need another case for a backend
> that crashed without ever run
On Tue, Sep 12, 2017 at 7:35 PM, Jeff Janes <jeff.ja...@gmail.com> wrote:
> On Wed, Sep 6, 2017 at 2:50 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org>
> wrote:
>
>> Magnus Hagander wrote:
>> > On Mon, Sep 4, 2017 at 3:21 PM, Jeff Janes <jeff.ja...@gmail.com
memory is relatively fresh.
>
> I've been in a situation which keeps me from doing development recently,
> but I think I can gradually rejoin the community activity soon.
>
>
Hi!
It's my plan to get to this patch during this commitfest. I've been
travelling for open and some 24/7 wor
On Wed, Sep 6, 2017 at 11:50 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org>
wrote:
> Magnus Hagander wrote:
> > On Mon, Sep 4, 2017 at 3:21 PM, Jeff Janes <jeff.ja...@gmail.com> wrote:
>
> > > Should the parent process of pg_basebackup be made to respond to
> SI
e two confused
:) Based on the feedback of that one, have you done any performance checks?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
good to
confirm that.
And thanks for running the benchmark, saved me some time!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
gresql.conf as well?
It will still be a mess though -- documentation, and tutorials around and
whatnot, will be dependent on library. But I'm not sure we can really get
around that.
Do we have some examples of how other products that support multiple
libraries do to handle this?
>
> I don't se
but we should react. And we should then exit the main process with
an error before actually streaming everything.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
. But a
sentence/paragraph saying that there are third party replication solutions
that can solve the problem, along with linking to the page with the list,
perhaps?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Sun, Sep 3, 2017 at 12:20 AM, Robert Haas <robertmh...@gmail.com> wrote:
> On Fri, Sep 1, 2017 at 11:30 PM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
> > On 8/31/17 08:19, Magnus Hagander wrote:
> >> Rebased. Now named pg_advance_replica
On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson <dan...@yesql.se> wrote:
> > On 03 Sep 2017, at 19:33, Magnus Hagander <mag...@hagander.net> wrote:
> >
> > On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson <dan...@yesql.se
> <mailto:dan...@yesql.se&
he original idea behind the gitlink field was to link to a git repo/branch
representing the patch, for people who preferred to publish full branches
for those that want it.
This has been done for a grand total of 43 patches throughout (out of a
total of 1231).
Not sure if that's enough to say "let's not repurpose it"?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Fri, Sep 1, 2017 at 6:44 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Magnus Hagander <mag...@hagander.net> writes:
> > On Fri, Sep 1, 2017 at 6:00 PM, Greg Stark <st...@mit.edu> wrote:
> >> So what happens now with these messages? My understanding is that
&g
On Fri, Sep 1, 2017 at 6:00 PM, Greg Stark <st...@mit.edu> wrote:
> On 31 August 2017 at 13:49, Tom Lane <t...@sss.pgh.pa.us> wrote:
> > Magnus Hagander <mag...@hagander.net> writes:
> >> On Thu, Aug 31, 2017 at 2:34 PM, Tom Lane <t...@sss.pgh.pa.us> wrot
On Thu, Aug 31, 2017 at 2:34 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Magnus Hagander <mag...@hagander.net> writes:
> > My understanding is that the main reason for this is that we cannot
> change
> > logging_collector without restarting postmaster, whereas we
updated and rebased patch.
Rebased. Now named pg_advance_replication_slot. ERROR on logical slots.
Forward only.
I think that, in the end, covered all the comments?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http:/
I
haven't figured out how to pass the original stderr down to the syslogger.
I'm sure there are also many other smaller issues around it, but I wanted
to get the discussion done before I spend the time to go through those.
Thoughts?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://
lying variable, one in
>XBLOCKS one in bytes. I'd rather just have the byte variant.
>
I'd say we definitely want the "user interface" to be in
bytes(/mbytes/gbytes etc). We used to have that in segments and it was
quite confusing for a lot of new uers, and seemed very silly...
Als
Ha, that's interesting.
Should be fixed now, please try again.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
hat part was indeed fairly easy.
I got stalled when I feature-crept myself by realizing I wanted it
snapshotted to WAL so it could fix the PITR and replication issues. And
then properly bogged down when I realized that on the standby I'd want
*both* the stats from the standby (while it's running) a
;
+1 for waiting until v11 with it.
We have plenty enough other things that could end up needing a quick
post-release-release, and those are things that have received at least
somem testing...
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Mon, Jul 17, 2017 at 6:47 PM, Mark Cave-Ayland <
mark.cave-ayl...@ilande.co.uk> wrote:
> On 17/07/17 13:09, Magnus Hagander wrote:
>
> Hi Magnus,
>
> Great to hear from you! It has definitely been a while...
>
Indeed. You should spend more time on these lists :P
On Mon, Jul 17, 2017 at 1:23 AM, Stephen Frost <sfr...@snowman.net> wrote:
>
> * Magnus Hagander (mag...@hagander.net) wrote:
> > On Sun, Jul 16, 2017 at 11:05 PM, Stephen Frost <sfr...@snowman.net>
> wrote:
> > > I'd suggest that we try to unde
On Sun, Jul 16, 2017 at 7:58 PM, Mark Cave-Ayland <
mark.cave-ayl...@ilande.co.uk> wrote:
> On 16/07/17 00:08, Thomas Munro wrote:
>
> > On Fri, Jul 14, 2017 at 11:04 PM, Magnus Hagander <mag...@hagander.net>
> wrote:
> >> On Thu, Jul 13, 2017 at 9
On Sun, Jul 16, 2017 at 11:05 PM, Stephen Frost <sfr...@snowman.net> wrote:
> Magnus, all,
>
> * Magnus Hagander (mag...@hagander.net) wrote:
> > (FWIW, a workaround I've applied more than once to this in AD
> environments
> > (where kerberos for one reason or othe
On Sun, Jul 16, 2017 at 1:08 AM, Thomas Munro <thomas.mu...@enterprisedb.com
> wrote:
> On Fri, Jul 14, 2017 at 11:04 PM, Magnus Hagander <mag...@hagander.net>
> wrote:
> > On Thu, Jul 13, 2017 at 9:31 AM, Thomas Munro
> > <thomas.mu...@ent
applied more than once to this in AD environments
(where kerberos for one reason or other can't be done, sorry Stephen) is to
set up a RADIUS server and use that one as a "middle man". But it would be
much better if we could do it natively)
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Jul 10, 2017 16:08, "Tom Lane" wrote:
Noah Misch writes:
> On Mon, Jun 05, 2017 at 09:56:33AM -0400, Tom Lane wrote:
>> Yeah, being able to reproduce the problem reliably enough to say whether
>> it's fixed or not is definitely the sticking point here.
committer will care about that. Or not. For now I am just
> adding that in the CF.
>
I agree that this should be fixed.
I wonder if we should actually just remove the second message? AFAICT no
other tools log that information. Is there any particular reason why we
want that logg
changing xlog to wal.
>
> Attached patch fixes this.
>
Yeah, both a typo and a missing user :)
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Thu, Jun 22, 2017 at 6:22 PM, Masahiko Sawada <sawada.m...@gmail.com>
wrote:
> On Thu, Jun 22, 2017 at 10:36 PM, Magnus Hagander <mag...@hagander.net>
> wrote:
> >
> >
> > On Thu, Jun 22, 2017 at 10:12 AM, Masahiko Sawada <sawada.m...@gmail.com
>
; Attached patch for $subject.
> >>
> >> s/opreator/operator/
> >
> > fixed
> >
>
> Thank you!
> I found another one.
>
> s/retrived/retrieved/
>
>
Thanks, applied.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
can raise an error when pg_stop_backup with
> wait_for_archive = true is executed on the standby. Attached patch
> change it so that.
>
Wouldn't it be better to make it *work*? If you have archive_mode=always,
it makes sense to want to wait on the standby as well, does it not?
--
Magnus Hagander
Me: ht
On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud <julien.rouh...@dalibo.com>
wrote:
> Patch attached.
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
isn't referred, but I can't get too excited about that.
Thus, patch applied as-is - thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Sat, Jun 17, 2017 at 8:55 AM, Daniel Gustafsson <dan...@yesql.se> wrote:
> Spotted one “paramter” typo and git grep found two more, patch attached
> with
> s/paramter/parameter/ for these.
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www
e dbname@server
seems a more logical choice than username@server.
TBH, so maybe I'm misunderstanding the original issue?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
ix in PG10.
>
+1. I definitely think it would be a bad idea to put in what basically
looks like a workaround into 10, since the new feature was added there. I'd
rather have the fix for pg_stat_activity.
We used to keep our query state as a text field and that was a bad idea for
many r
On Mon, Jun 5, 2017 at 1:35 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Mon, Jun 5, 2017 at 4:58 PM, Magnus Hagander <mag...@hagander.net>
> wrote:
> > On Mon, Jun 5, 2017 at 1:16 PM, Amit Kapila <amit.kapil...@gmail.com>
> wrote:
> >>
> &
to mapping executables though, like DLL and EXE. Not
mapping of data segments.
It does randomize the entire location of the heap, in which case it might
also change. But not for the individual block.
But in neither of those cases does it help to retry without restarting the
process, bec
e.
> + * Initialize the attribute options cache.
> */
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Fri, Jun 2, 2017 at 7:32 AM, Masahiko Sawada <sawada.m...@gmail.com>
wrote:
> Hi,
>
> While reading predicate lock source code, I found a comment typo in
> predicate.c file.
> Attached patch fixes it.
>
> s/scrach/scratch/
>
Applied, thanks.
--
Magnus Hagander
On Wed, May 31, 2017 at 8:18 PM, Andres Freund <and...@anarazel.de> wrote:
> On 2017-05-31 18:22:18 +0200, Magnus Hagander wrote:
> > However, the client can't access the pid of the server as it is now,
> > and its the client that has to create the name.
>
> I don't
On Wed, May 31, 2017 at 12:20 AM, Ludovic Vaugeois-Pepin <
ludovi...@gmail.com> wrote:
> On Tue, May 30, 2017 at 9:32 PM, Magnus Hagander <mag...@hagander.net>
> wrote:
> > On Tue, May 30, 2017 at 9:14 PM, Ludovic Vaugeois-Pepin
> > <ludovi...@gmail.com> w
this, getting it out of the
> way. We're
> > > already unlikely to reach 10.0 without bumping catversion, but if we
> otherwise
> > > did, releasing 10.0 with a 10beta1 catversion would have negative
> value.
> >
> > I'm not really for doing it that way, but I
On Mon, May 29, 2017 at 4:04 PM, Masahiko Sawada <sawada.m...@gmail.com>
wrote:
> Hi,
>
> Attached for $subject.
>
> s/Expession/Expression/
>
Thanks, applied!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https:/
given the difficulty in reliably reproducing the problem etc, I think it's
a good idea to give it some proper real world experience in 10 first.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Mon, May 22, 2017 at 3:36 AM, Masahiko Sawada
wrote:
> Hi,
>
> Attached patch for $subject.
>
> s/curent/current/
>
>
Applied, thanks!
//Magnus
but still. It
certainly makes the code completely unreadable. And since any program using
it should figure out pretty quickly that it's not working if they us the
wrong casing...
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
ybe "10beta1"
> > should be "10.beta1".
>
> That's not a naming format I've ever seen.
>
> I think the current format is fine.
>
>
+1. I have also never seen that one, and think the current one is good.
--
Magnus Hagander
Me: https://www.hagander.net/ <
ics inside a backend (which tables have been accessed, number of
reads etc),and this seems like it could be used for that as well.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Mon, May 15, 2017 at 7:02 AM, Michael Paquier <michael.paqu...@gmail.com>
wrote:
> Hi all,
>
> Found $subject while working on the area. A patch is attached.
> Thanks,
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
reaks with "patch
unexpectedly ends in middle of line patch: Only garbage was found in
the patch input.". But I can just copy/paste it manually :)
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Fri, May 5, 2017 at 10:19 AM, Aleksander Alekseev <
a.aleks...@postgrespro.ru> wrote:
> Hi Heikki,
>
> > psql: SCRAM authentication requires libpq version 10 or above
>
> Sounds good.
>
>
+1.
--
Magnus Hagander
Me: https://www.hagander.net/ <http:
t. But I'm pretty sure the suggestion does not include removing the
"password" authentication type, that one will still exist. This is just
about password *storage*.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Thu, May 4, 2017 at 2:42 PM, Craig Ringer <cr...@2ndquadrant.com> wrote:
> On 4 May 2017 at 20:05, Magnus Hagander <mag...@hagander.net> wrote:
> > PFA a patch that adds a new function, pg_move_replication_slot, that
> makes
> > it possible to move the location
.
(Obviously this is intended for 11, as we're well into the freeze for 10.
Just to be clear. so I'll go add itto the summer commitfest)
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
diff
On Wed, May 3, 2017 at 4:18 PM, Michael Banck <michael.ba...@credativ.de>
wrote:
> Hi,
>
> On Tue, May 02, 2017 at 11:13:58AM +0200, Magnus Hagander wrote:
> > Looks good to me as well. Applied, with only a minor further docs
> addition
> > saying that this i
ing in time.
It might make sense to ping other "major drivers" people as well -- such as
maybe npgsql. What else?
A good approach might be to change the default now, before beta. Then if
drivers don't change, or if we get a lot of pushback from beta testers, we
change it back before
On Wed, May 3, 2017 at 2:25 PM, Michael Paquier <michael.paqu...@gmail.com>
wrote:
> On Wed, May 3, 2017 at 8:38 PM, Magnus Hagander <mag...@hagander.net>
> wrote:
> > On Wed, May 3, 2017 at 1:31 PM, Heikki Linnakangas <hlinn...@iki.fi>
> wrote:
> >>
+1, even though it's not strictly speaking a bugfix to go in a backpatch, I
think it will help enough users that it's worth doing. And I can't see how
it could possibly be unsafe...
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
e error message you get in libpq, and possibly some of the
other most common drivers.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
and the changes to use it in
> psql and createuser. This closes the open issue with \password.
If we're basically just telling people to call SHOW manually, we might as
well do it in the default case. I think the wording you put into the docs
there is good, as it tells people exactly what happens and
main it in the perl code.
>
> >
> > Thanks, I attached the update patch.
>
> So it looks good to me.
>
Looks good to me as well. Applied, with only a minor further docs addition
saying that this is the default also on the high availability page. And per
the comments from Michael, I did not include the change to PostgresNode.pm.
Thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
ould change that.
I wonder if we should also consider changing the standby error message to
be a WARNING instead of an ERROR. So that if you try to start up a standby
with hot_standby=on but master with wal_level=replica it would turn into a
cold standby.
We should change the default independently
Tell people to use the new function going forward.
>
> +1. I never much liked that magic behavior of PQescapeString, and don't
> think we should replicate it elsewhere, so I definitely don't like (C).
> And I don't think we can do (B) because that will break the functionality
> alto
onality but under a differet name.
Like just "hashed" or something, which would mean md5-or-scram?
> In any case, I think we would probably still need more fine-grained
> control, too, so we would still need to have "scram-sha-256" as a method
> you can specify directly in pg_hba.conf. So I consider this as a separate,
> new, feature that we can add in the future, if it seems worth the effort.
>
Yes, I think wherever we go we don't want to loose the fine-grained
control. But some people will be happier for not having to use it.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
ed that they seemed unnecessarily manual. +1 for
> simplifying.
>
Seems reasonable, +1 for simplifications.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Fri, Apr 14, 2017 at 9:36 PM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 4/14/17 14:45, Magnus Hagander wrote:
> > Attached is a patch that can be applied to pgweb which should fix
> all of
> > this.
> >
> >
> >
&g
, I believe using lowercase is more or
less the convention on Windows for this.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
is to conditionally inject additional CSS
> to be _more_ specific than the first CSS and set the font-size to a
> simple '1em' so the first CSS is not called twice. I don't think
> 'important!' is necessary but it would be good to test this.
>
> Attached is a patch that can be applied to pgweb which should fix all of
> this.
>
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Thu, Apr 13, 2017 at 9:13 PM, Bruce Momjian <br...@momjian.us> wrote:
> On Thu, Apr 13, 2017 at 09:02:27PM +0200, Magnus Hagander wrote:
> > On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut <
> > peter.eisentr...@2ndquadrant.com> wrote:
> >
> >
hind
> by a CIC failure
> - analyzing tables that lack (full?) statistics
> - triggering heap scans to reclaim HEAP_MOVED_* bits, if we have that
> kind of thing someday
>
>
I agree it makes a lot of sense to have a separate tool that can do these
things, and that pg_upgrade ca
On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 4/10/17 11:30, Magnus Hagander wrote:
> > After you've run pg_upgrade, you have to loop through all your databases
> > and do an "ALTER EXTENSION abc UPDAT
On Thu, Apr 13, 2017 at 2:40 AM, Andres Freund <and...@anarazel.de> wrote:
> On 2017-04-12 20:15:52 -0400, Peter Eisentraut wrote:
> > On 4/11/17 05:15, Magnus Hagander wrote:
> > > Is there a particular reason we don't have a function to *set* the
> > > restart
On Wed, Apr 12, 2017 at 2:36 PM, Robert Haas <robertmh...@gmail.com> wrote:
> On Tue, Apr 11, 2017 at 4:05 AM, Magnus Hagander <mag...@hagander.net>
> wrote:
> > On Tue, Apr 11, 2017 at 3:26 AM, Michael Paquier <
> michael.paqu...@gmail.com> wrote:
> >&g
On Tue, Apr 11, 2017 at 6:51 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Magnus Hagander <mag...@hagander.net> writes:
> > Something like the attached?
>
> Not sure about
>
> + * All methods that have a failure path will set errno on failure.
>
> Given t
On Tue, Apr 11, 2017 at 4:30 PM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 4/11/17 08:49, Magnus Hagander wrote:
> > At the risk of being proven wrong again, won't this affect tags in
> > the old documentation as well? And if so, is that something
1 - 100 of 4943 matches
Mail list logo