Re: [HACKERS] UPDATE of partition key

TO p VALUES('t', 10); SELECT tableoid::regclass,oid,a FROM p; tableoid | oid | a --+---+--- p_true | 16792 | t (1 row) UPDATE p SET a = 'f'; -- partition-key-UPDATE (oid has changed (it probably shouldn't have)) SELECT tableoid::regclass,oid,a FROM p; tableoid | oid | a --

Re: [HACKERS] PATCH: psql tab completion for SELECT

> > postgres=# select str > string_to_array( strip(strpos( Neat! Please add this to the upcoming (2018-01) commitfest at https://commitfest.postgresql.org/ Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remem

[HACKERS] No mention of CREATE STATISTICS in event trigger docs

A patch to fix this is attached. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services event_trigger_statistics_doc.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] path toward faster partition pruning

(~(bitmapword) 0) >> (BITS_PER_BITMAPWORD - (BITNUM(upper) - 1)); > = No objections here for making bms_add_range() perform better, but this is not going to work when lwordnum == uwordnum. You'd need to special case that. I didn't think it was worth the trouble, but maybe it is... I

Re: [HACKERS] path toward faster partition pruning

On 7 November 2017 at 01:52, David Rowley <david.row...@2ndquadrant.com> wrote: > Thanks. I'll look over it all again starting my Tuesday morning. (UTC+13) Hi Amit, I had another look over this today. Apologies if any of the review seems petty. Here goes: 1. If test seems to b

Re: [HACKERS] Exclude pg_internal.init from base backup

t; Changes made, moving to commit the attached patch. Thanks, Simon! This was on my to do list today -- glad I checked my email first. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] path toward faster partition pruning

On 7 November 2017 at 01:52, David Rowley <david.row...@2ndquadrant.com> wrote: > Thanks. I'll look over it all again starting my Tuesday morning. (UTC+13) I have a little more review to share: 1. Missing "in" in comment. Should be "mentioned in" * get_append_rel_

Re: [HACKERS] path toward faster partition pruning

, including the fix to make the new pruning > code handle Boolean partitioning. Thanks. I'll look over it all again starting my Tuesday morning. (UTC+13) -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- S

[HACKERS] Removing useless DISTINCT clauses

.git;a=commit;h=d4c3a156cb46dcd1f9f97a8011bd94c544079bb5 [2] https://www.postgresql.org/message-id/flat/CAKJS1f9q0j3BgMUsDbtf9%3DecfVLnqvkYB44MXj0gpVuamcN8Xw%40mail.gmail.com#CAKJS1f9q0j3BgMUsDbtf9=ecfvlnqvkyb44mxj0gpvuamcn...@mail.gmail.com -- David Rowley http://www.2ndQuadrant.c

Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning

On 6 November 2017 at 17:30, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/11/03 13:32, David Rowley wrote: >> On 31 October 2017 at 21:43, Amit Langote <langote_amit...@lab.ntt.co.jp> >> wrote: >> 1. This comment seem wrong. >&

Re: [HACKERS] path toward faster partition pruning

d to be allowed too. This works slightly differently. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http:/

Re: [HACKERS] path toward faster partition pruning

On 3 November 2017 at 17:32, David Rowley <david.row...@2ndquadrant.com> wrote: > 2. This code is way more complex than it needs to be. > > if (num_parts > 0) > { > int j; > > all_indexes = (int *) palloc(num_parts * sizeof(int)); > j = 0; > if (min_part_idx >

Re: [HACKERS] Skip unneeded temp file in 'make html'

On Fri, Nov 03, 2017 at 11:34:18AM -0400, Peter Eisentraut wrote: > On 11/2/17 22:07, David Fetter wrote: > > postgres.xml: $(srcdir)/postgres.sgml $(ALLSGML) > > - $(OSX) $(SPFLAGS) $(SGMLINCLUDE) -x lower $< >$@.tmp > > - $(call mangle-xml,book) > > + $(

Re: [HACKERS] ArrayLists instead of List (for some things)

On 3 November 2017 at 03:26, Craig Ringer <cr...@2ndquadrant.com> wrote: > On 2 November 2017 at 22:22, David Rowley <david.row...@2ndquadrant.com> > wrote: >> Maybe, but the new implementation is not going to do well with places >> where we perform lcons(). Proba

Re: [HACKERS] path toward faster partition pruning

s, -1, PARTITION_MAX_KEYS * sizeof(NullTestType *)); should be PARTITION_MAX_KEYS * sizeof(NullTestType). It might have worked on your machine if you're compiling as 32 bit. I'll continue on with the review in the next few days. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] path toward faster partition pruning

latest patches conflict with cf7ab13bf. Can you send patches rebased on current master? Thanks -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] Skip unneeded temp file in 'make html'

Folks, Please find attached a patch for $Subject. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate Don't make an unneeded temp file In passing, make a

Re: [HACKERS] ArrayLists instead of List (for some things)

On 3 November 2017 at 03:27, Stephen Frost <sfr...@snowman.net> wrote: > * David Rowley (david.row...@2ndquadrant.com) wrote: >> We could get around a few of these problems if Lists were implemented >> internally as arrays, however, arrays are pretty bad if we want to

Re: [HACKERS] ArrayLists instead of List (for some things)

On 3 November 2017 at 03:38, Tom Lane <t...@sss.pgh.pa.us> wrote: > David Rowley <david.row...@2ndquadrant.com> writes: >> On 3 November 2017 at 03:17, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> We've jacked up the List API and driven a new implementation undernea

Re: [HACKERS] ArrayLists instead of List (for some things)

(). Probably many of those places could be changed to lappend(), but I bet there's plenty that need prepend. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

[HACKERS] ArrayLists instead of List (for some things)

elcome, but I was too late to the commitfest, so there are other priorities. However, if you have a strong opinion, feel free to voice it. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services 0001-Basic-implementation-of-array-lists-AList.

Re: [HACKERS] Client Connection redirection support for PostgreSQL

I presume there's a good reason to reroute rather than serve these requests. > * For the new clients to the new server, the message flow will be based > on the routing list filed in the configuration. > This proposal is in very early stage, comments and feedback is very much &g

Re: [HACKERS] [PATCH] Add two-arg for of current_setting(NAME, FALLBACK)

> On Nov 1, 2017, at 1:02 PM, Nico Williams <n...@cryptonector.com> wrote: > > On Thu, Mar 19, 2015 at 05:41:02PM -0500, David Christensen wrote: >> The two-arg form of the current_setting() function will allow a >> fallback value to be returned instead of throwing

Re: [HACKERS] [PATCH] Add two-arg for of current_setting(NAME, FALLBACK)

On Thu, Mar 19, 2015 at 3:41 PM, David Christensen <da...@endpoint.com> wrote: > The two-arg form of the current_setting() function will allow a > fallback value to be returned instead of throwing an error when an > unknown GUC is provided. This would come in most useful when usin

[HACKERS] [PATCH] Add two-arg for of current_setting(NAME, FALLBACK)

The two-arg form of the current_setting() function will allow a fallback value to be returned instead of throwing an error when an unknown GUC is provided. This would come in most useful when using custom GUCs; e.g.: -- errors out if the 'foo.bar' setting is unset SELECT

[HACKERS] Removing LEFT JOINs in more cases

. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services 0001-Support-removing-LEFT-JOINs-with-DISTINCT-GROUP-BY.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make cha

Re: [HACKERS] Account for cost and selectivity of HAVING quals

ow must take on a new value to represent this. David J.​

Re: [HACKERS] PostgreSQL 10 parenthesized single-column updates can produce errors

onement is not strictly bad given the seeming frequency of the existing problematic syntax in the wild already. David J.

Re: [HACKERS] PostgreSQL 10 parenthesized single-column updates can produce errors

l as adding: ( column_name ) = ROW ( expression | DEFAULT ) If we revert 10 to the pre-10 behavior the existing syntax will work. David J.

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

On 10/30/17 6:36 AM, Michael Paquier wrote: > On Mon, Oct 30, 2017 at 10:15 AM, Chris Travers >> >> How does rep mgr or other programs using pg_rewind know what to exclude? > > Good question. Answers could come from folks such as David Steele > (pgBackRest) or Marco (bar

[HACKERS] Remove inbound links to sql-createuser

since we are indeed talking about LOGIN roles there but we are already pointing to sql-alterrole instead of sql-alteruser and so changing the create variation to point to sql-createrole seems warranted. Attached, and below. David J. diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client

Re: [HACKERS] Jsonb transform for pl/python

On Mon, Oct 30, 2017 at 11:15:00AM +0300, Anthony Bykov wrote: > On Sun, 29 Oct 2017 19:11:02 +0100 > David Fetter <da...@fetter.org> wrote: > > > Thanks for your hard work! > > > > Should there also be one for PL/Python3U? > > > > Best, > > Da

Re: [HACKERS] An unlikely() experiment

On 30 October 2017 at 22:44, Andres Freund <and...@anarazel.de> wrote: > On 2017-10-30 22:39:01 +1300, David Rowley wrote: >> Today I was thinking, to get around that issue, we might be able to >> generate another thin wrapper around elog_start() and mark that as >> __at

Re: [HACKERS] An unlikely() experiment

On 30 October 2017 at 22:34, Andres Freund <and...@anarazel.de> wrote: > Hi, > > On 2015-12-20 02:49:13 +1300, David Rowley wrote: >> Alternatively, if there was some way to mark the path as cold from within >> the path, rather than from the if() condition before the pat

Re: [HACKERS] Jsonb transform for pl/python

test" transforms incoming jsonb into python, > transforms it back into jsonb and returns it. > > create extension jsonb_plpython2u cascade; Thanks for your hard work! Should there also be one for PL/Python3U? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org

Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath

--+- a | integer | | | | plain | | b | integer | | | | plain | | Partition key: RANGE (a) Partitions: ab_p1 FOR VALUES FROM (1) TO (1), ab_p2 FOR VALUES FROM (1) TO (2) -- D

Re: [HACKERS] Timeline ID in backup_label file

information in a >> more understandable shape. Any opinions? > > Strong "yes" from me. +1 -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath

On 26 October 2017 at 23:42, Antonin Houska <a...@cybertec.at> wrote: > David Rowley <david.row...@2ndquadrant.com> wrote: > >> Method 1: >> >> In set_append_rel_size() detect when just a single subpath would be >> added to the Append path. > > I s

Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath

On 26 October 2017 at 23:30, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Oct 25, 2017 at 11:59 PM, David Rowley > <david.row...@2ndquadrant.com> wrote: >> As of today, because we include this needless [Merge]Append node, we >> cannot parallelise scans

[HACKERS] Removing [Merge]Append nodes which contain a single subpath

stgresql.org/message-id/CAKJS1f9UXdk6ZYyqbJnjFO9a9hyHKGW7B%3DZRh-rxy9qxfPA5Gw%40mail.gmail.com -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Cursor With_Hold Performance Workarounds/Optimization

they can get to. As to "crazy complicated calculations," this is what active databases are all about. SQL is Turing complete, so you really can do it. Would you want something that compiles from the user inputs to SQL? Might that have a more general utility? Best, David. -- David Fett

Re: [HACKERS] Cursor With_Hold Performance Workarounds/Optimization

es of committing at some higher frequency than the logical transaction. What other things did you try, and how did they fail? In particular, what happened when you used UPDATE table2 SET [things based on table1] FROM table1 [qualified] JOIN table2 ON ([conditions]) Best, David. -- David

Re: [HACKERS] Interest in a SECURITY DEFINER function current_user stack access mechanism?

On Wed, Oct 18, 2017 at 2:30 PM, Nico Williams <n...@cryptonector.com> wrote: > On Wed, Oct 18, 2017 at 02:13:29PM -0700, David G. Johnston wrote: > > > More useful than this, for me, would be a way to get the top-most user. > > > > That would be "session_user

Re: [HACKERS] Interest in a SECURITY DEFINER function current_user stack access mechanism?

On Wed, Oct 18, 2017 at 2:08 PM, Nico Williams <n...@cryptonector.com> wrote: > On Wed, Oct 18, 2017 at 01:43:30PM -0700, David G. Johnston wrote: > > More useful than this, for me, would be a way to get the top-most user. > > ​That would be "session_user"?​ >

Re: [HACKERS] Interest in a SECURITY DEFINER function current_user stack access mechanism?

here seems, at first glance, to be over-complicating things. David J.

[HACKERS] A handful of typos in allpaths.c

A small patch to fix these is attached. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services allpath_typos_fix.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

[HACKERS] v10 telease note for pg_basebackup refers to old --xlog-method argument

/--wal-method default to stream. An option value none has been added to reproduce the old behavior. The pg_basebackup option -x has been removed (instead, use -X fetch). Also attached. David J. diff --git a/doc/src/sgml/release-10.sgml b/doc/src/sgml/release-10.sgml index

Re: [HACKERS] Extended statistics is not working on Vars hidden under a RelabelType

On 15 October 2017 at 06:49, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Oct 13, 2017 at 4:49 PM, David Rowley > <david.row...@2ndquadrant.com> wrote: >> tps = 8282.481310 (including connections establishing) >> tps = 8282.750821 (excluding connections

Re: [HACKERS] Discussion on missing optimizations

Perhaps I missed some? It looks like there's plenty we could do in there, just nobody seems interested enough to go and do it, everyone who cares about performance is too busy trying to make execution run faster. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development,

Re: [HACKERS] Extended statistics is not working on Vars hidden under a RelabelType

On 14 October 2017 at 09:04, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Oct 9, 2017 at 11:03 PM, David Rowley > <david.row...@2ndquadrant.com> wrote: >> -- Unpatched >> Planning time: 0.184 ms >> Execution time: 105.878 ms >> >> -- Patche

Re: [HACKERS] Partition-wise aggregation/grouping

On 13 October 2017 at 19:36, Jeevan Chalke <jeevan.cha...@enterprisedb.com> wrote: > I have tried exactly same tests to get to this factor on my local developer > machine. And with parallelism enabled I got this number as 7.9. However, if > I disable the parallelism (and I be

Re: [HACKERS] Aggregate transition state merging vs. hypothetical set functions

On 13 October 2017 at 12:41, Tom Lane <t...@sss.pgh.pa.us> wrote: > David Rowley <david.row...@2ndquadrant.com> writes: >> If the user defines their normal aggregate as not safe for merging, >> then surely it'll not be suitable to be used as a window function >>

Re: [HACKERS] Aggregate transition state merging vs. hypothetical set functions

ggregates or for all? If the user defines their normal aggregate as not safe for merging, then surely it'll not be suitable to be used as a window function either, since the final function will also be called there multiple times per state. -- David Rowley http://www.2ndQuadrant.

Re: [HACKERS] Extended statistics is not working on Vars hidden under a RelabelType

On 13 October 2017 at 04:56, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > I pushed your original fix. Thanks for committing -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers

Re: [HACKERS] Discussion on missing optimizations

ecent percentage of SELECTs too. I had imagined this would be some backend local cache that saved MRU plans up to some size of memory defined by a GUC, where 0 would disable the feature. I never got any further than those thoughts. -- David Rowley http://www.2ndQuadrant.c

Re: [HACKERS] Extended statistics is not working on Vars hidden under a RelabelType

ame thing. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partition-wise aggregation/grouping

mn? 2.400209476818 (1 row) Maybe it's worth trying with different row counts to see if the additional cost is consistent, but it's probably not worth being too critical here. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Trainin

[HACKERS] Extended statistics is not working on Vars hidden under a RelabelType

8 rows) -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services allow_relabelled_vars_in_dependency_stats.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your su

Re: [HACKERS] Partition-wise aggregation/grouping

e's even a comment in create_append_path() which claims the zero cost is a bit optimistic. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

Re: [HACKERS] Discussion on missing optimizations

On 9 October 2017 at 17:41, David Rowley <david.row...@2ndquadrant.com> wrote: > Thoughts? Actually, I was a little inconsistent with my List NULL/NIL checks in that last one. I've attached an updated patch. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL De

Re: [HACKERS] Discussion on missing optimizations

ommon (at least in my world). Thoughts? -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services remove_left_join_distinct.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgres

Re: [HACKERS] Discussion on missing optimizations

pin and finding performance is not quite what they need. It's a bit sad that often the people with the loudest voices are always so fast to stomp on the ideas for improvements. It would be much nicer if you'd at least wait for benchmarks before shooting. -- David Rowley http://www.2

Re: [HACKERS] search path security issue?

On Thu, Oct 5, 2017 at 3:05 PM, Joshua D. Drake <j...@commandprompt.com> wrote: > On 10/05/2017 02:54 PM, David G. Johnston wrote: > >> On Thu, Oct 5, 2017 at 2:37 PM, Joshua D. Drake <j...@commandprompt.com >> <mailto:j...@commandprompt.com>>wrote: >

Re: [HACKERS] search path security issue?

efaults instead of forcing them to always change things on-the-fly or bug a DBA to change the default for them. David J. ​

Re: [HACKERS] JIT compiling - v4.0

s some JIT threshold GUC. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] generated columns

rated columns all of which are immutable to having at least one that's not. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider

Re: [HACKERS] Fwd: Have a problem with citext

On Oct 1, 2017, at 20:22, Robert Haas wrote: >> Are permissions correct in the citext extension? > > Not to be picky, but couldn't you investigate that a bit before posting here? Normally I would, but my attention is far from Postgres these days, sadly, and I tend to

[HACKERS] Fwd: Have a problem with citext

Hackers, Are permissions correct in the citext extension? Best, David > Begin forwarded message: > > From: Sadek Touati <bilal2del...@hotmail.com> > Subject: Have a problem with citext > Date: September 29, 2017 at 17:02:50 EDT > To: "da...@kineticode.com" &l

Re: [HACKERS] alter server for foreign table

re fungible than they were even 5 years back. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Pos

Re: [HACKERS] path toward faster partition pruning

and that would likely tidy it up a bit. The matching partition indexes could be returned as a Bitmapset, yet, I don't really see any code which handles adding the NULL and DEFAULT partition in get_rel_partitions() either, maybe I've just not looked hard enough yet... -- David Rowley

Re: [HACKERS] Multicolumn hash indexes

ing a half-baked job of this is probably within > reach. I'm uncertain about what it would take to bake it fully. To stretch this analogy too far, what other things could be built out of the bread this bakes? I'm guessing that at least non-hash multicolumn indexes would benefit. Expressional in

Re: [HACKERS] path toward faster partition pruning

tgresql.org/gitweb/?p=postgresql.git;a=commit;h=9140cf826 Yeah, I see 0001 conflicts with that. I'm going to set this to waiting on author while you're busy rebasing this. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent

Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?

On Sep 25, 2017, at 10:55, Andrew Dunstan <andrew.duns...@2ndquadrant.com> wrote: > Let's ask a couple of users who I think are or have been actually > hurting on this point. Christophe and David, any opinions? If I understand the issue correctly, I think I’d be fine with requiring

Re: [HACKERS] OpenFile() Permissions Refactor

On 9/23/17 10:22 AM, Peter Eisentraut wrote: > On 9/13/17 10:26, David Steele wrote: >> Here's a new patch based on your review. Where I had a question I made >> a choice as described below: > > I have committed the changes to the file APIs and a fix for the umask > sa

Re: [HACKERS] Varying results when using merge joins over postgres_fdw vs hash joins

t;. > Non-default collations go through strcoll_l(), which might not even > exist on a given platform. So they're entirely separate code paths. > > regards, tom lane > -- David Kohn | Data Engineer | MOAT 63 Madison Ave, 15th Floor, NYC

Re: [HACKERS] Show backtrace when tap tests fail

On 9/20/17 6:26 AM, Dagfinn Ilmari Mannsåker wrote: > Craig Ringer <cr...@2ndquadrant.com> writes: > >> On 20 September 2017 at 06:36, David Steele <da...@pgmasters.net> wrote: >> >>> >>> I just use: >>> >>> $SIG{__DIE__} = su

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

he expense of limited backward incompatibility. Arrays not considered; single-column composites might end up looking like scalars when presented to a (c) target. Hope this helps someone besides me understand the problem space. David J.

Re: [HACKERS] Show backtrace when tap tests fail

on Perls < 5.10, though. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

On Tue, Sep 19, 2017 at 2:12 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > "David G. Johnston" <david.g.johns...@gmail.com> writes: > > Actually, this does work, just not the way one would immediately expect. > > On closer inspection, what's actually happe

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

("(1,2)",) And so, yes, my thinking has a backward compatibility problem. But one that isn't fixable when constrained by backward compatibility - whether this patch goes in or not. David J.

Re: [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list

he-composite-variable-to-absorb-N-scalar-columns. If we change to considering exactly one output column for each target var this seems unnecessary. Then the one special case is today's single composite column target and multiple output columns. If there is only one select column it has to be composite. David J.

Re: [HACKERS] Creating backup history files for backups taken from standbys

On 9/18/17 7:26 PM, Michael Paquier wrote: > On Tue, Sep 19, 2017 at 8:14 AM, David Steele <da...@pgmasters.net> wrote: >> On 8/31/17 11:56 PM, Michael Paquier wrote: >>> Here is an updated patch with refreshed documentation, as a result of >>> 449338c which

Re: [HACKERS] Creating backup history files for backups taken from standbys

upBackupHistory() will immediately remove the history file when archive_mode != always so it seems useless to write it. On the other hand the code is a bit simpler this way. Thoughts? Regards, -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] [PATCH] Overestimated filter cost and its mitigation

subsets of clauses in a filter. I've taken the liberty of adding this to the upcoming commitfest. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail

Re: [HACKERS] Add Roman numeral conversion to to_number

al=%', i, rn, rn_val; > end if; > end loop; > raise notice 'Tested roman numerals 1..3999'; > end; > $$; > > It's a lot easier to maintain than separate selects. Why not just one SELECT, as in: SELECT i, to_char(i, 'rn'), to_number(to_char(i, 'rn'), 'rn'); FROM ge

Re: [HACKERS] [GENERAL] Remove useless joins (VARCHAR vs TEXT)

is being a bug. The attached fixes. (CC'd -hackers since we're starting to discuss code changes. Further discussion which includes -hackers should drop the general list) -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Servic

Re: [HACKERS] additional contrib test suites

4) as the test suite is not > portable. I'd prefer 5, but can go with 4. I get that users need to store their own passwords, but we have support for SHA1 via the crypto module which seems by far the better choice. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] path toward faster partition pruning

gt; partitions one-by-one. It's not fully cooked yet though. I'm interested in seeing improvements in this area, so I've put my name down to review this. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via

Re: [HACKERS] [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

e it in the face of objections. > > Add my +1 for changing this to the official tally. David J.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

is specific case, but that's my feeling on it. > I think we are being consistent as a project by enforcing strictness of input in this situation so I'll toss my +0.5/+1​ here as well. David J.

Re: [HACKERS] [POC] hash partitioning

magically when the partitioning scheme[1] is specified? In other words, do we have a good reason to have only some of the hash partitions so defined by default? Best, David. [1] For now, that's just the modulus, but the PoC included specifying hashing functions, so I assume other ways to specify the

Re: [HACKERS] additional contrib test suites

The docs say that, so OK, but is there anything else a user should be worried about? The rest looks good. I'll mark this "Ready for Committer" since I'm the only reviewer. I don't think anything you might add based on my comments above requires a re-review. As for testing on more platforms, send

Re: [HACKERS] generated columns

oject I would say it is worth it. So long as the expression on the normal columns was immutable, it's fit for an expressional index, as is any immutable function composed with it. What am I missing? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3

Re: [HACKERS] psql: new help related to variables are not too readable

in a new page). So I'll agree that in an absolute sense reading the whole of the content in its condensed form is more difficult than if there were blank lines in between each block, but usability for the intended purpose is better in the current form. David J.

Re: [HACKERS] OpenFile() Permissions Refactor

Hi Peter, Here's a new patch based on your review. Where I had a question I made a choice as described below: On 9/1/17 1:58 PM, David Steele wrote: > On 9/1/17 1:15 PM, Peter Eisentraut wrote: >> On 8/29/17 12:15, David Steele wrote: >> >> I wonder whether we even need

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

mething's going > to bite us. > Just throwing it ​out there but can we making putting SET inside a CTE work? David J.

Re: [HACKERS] Making clausesel.c Smarter

bably would see some resistance, so won't have time to look at this soon. If the possibility of this increasing planning time in corner cases is going to be a problem, then it might be best to return this with feedback for now and I'll resubmit if I get time later in the cycle. --

Re: [HACKERS] CSV Logging questions

an that the > timestamps would be in sync and we could probably eliminate the > occurrences of the wrong format appearing in the wrong logs. +1 for making the emitters all work off the same source. Any idea how much work we're talking about to do these things? Best, David. -- David Fetter <

Re: [HACKERS] GnuTLS support

st move the library-specific > tests to their own file and mark it as skipped at the start of the file > when a different library is detected. This seems like a much smarter and more reliable way to test. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone:

[HACKERS] Exclude pg_internal.init from base backup

this to the 2017-11 CF. Thanks, -- -David da...@pgmasters.net diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml index 95aeb35507..c3e6c30eba 100644 --- a/doc/src/sgml/backup.sgml +++ b/doc/src/sgml/backup.sgml @@ -1130,6 +1130,12 @@ SELECT pg_stop_backup

  1   2   3   4   5   6   7   8   9   10   >