On Mon, 2008-12-15 at 17:10 -0500, Bruce Momjian wrote:
> >
> > Why no backpatch to 8.3? Seems like a clear bugfix to me.
>
> I knew that was going to be asked.
8.3 is really where this is needed. 8.4 has almost no need of this.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Train
Tom Lane wrote:
> "Heikki Linnakangas" writes:
> > Martin Zaun wrote:
> >> With these avenues to be explored, can the pg_standby patch on the
> >> CommitFest wiki be moved to the "Returned with Feedback" section?
>
> > Yes, I think we can conclude that we don't want this patch as it is.
> > Inst
Magnus Hagander wrote:
> Bruce Momjian wrote:
> > Martin Zaun wrote:
> >> 4. Issue: missing break in switch, silent override of '-l' argument?
> >>
> >> This behaviour has been in there before and is not addresses by the
> >> patch: The user-selected Win32 "mklink" command mode is never applied
> >
Since this patch was rejected, I have added the attached documentation
to pg_standby to mention the sleep() we do.
---
Martin Zaun wrote:
>
> Below my comments on the CommitFest patch:
>pg_standby minor changes for Wind
Bruce Momjian wrote:
> Martin Zaun wrote:
>> 4. Issue: missing break in switch, silent override of '-l' argument?
>>
>> This behaviour has been in there before and is not addresses by the
>> patch: The user-selected Win32 "mklink" command mode is never applied
>> due to a missing 'break' in Customi
Martin Zaun wrote:
> 4. Issue: missing break in switch, silent override of '-l' argument?
>
> This behaviour has been in there before and is not addresses by the
> patch: The user-selected Win32 "mklink" command mode is never applied
> due to a missing 'break' in CustomizableInitialize():
>
>
I have a fairly large TODO list, and Simon has thrown in the towel (and
I imagine he also has a large TODO list).
anyone else want to step in?
cheers
andrew
Bruce Momjian wrote:
Have we made any progress on this, namely better documentation and
removing the Win32 delay code?
Have we made any progress on this, namely better documentation and
removing the Win32 delay code?
---
Andrew Dunstan wrote:
>
>
> Simon Riggs wrote:
> > Well, this is a strange conclusion, leaving me slightly bemused.
> >
Simon Riggs wrote:
Well, this is a strange conclusion, leaving me slightly bemused.
The discussion between Andrew and I at PGcon concluded that we would
* document which other tools to use
* remove the delay
Now we have rejected the patch which does that, but then re-requested
the exact same
On Thu, 2008-07-31 at 12:32 -0400, Tom Lane wrote:
> "Heikki Linnakangas" <[EMAIL PROTECTED]> writes:
> > Martin Zaun wrote:
> >> With these avenues to be explored, can the pg_standby patch on the
> >> CommitFest wiki be moved to the "Returned with Feedback" section?
>
> > Yes, I think we can con
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes:
> Martin Zaun wrote:
>> With these avenues to be explored, can the pg_standby patch on the
>> CommitFest wiki be moved to the "Returned with Feedback" section?
> Yes, I think we can conclude that we don't want this patch as it is.
> Instead, we wan
Martin Zaun wrote:
Heikki Linnakangas wrote:
Andrew Dunstan wrote:
Greg Smith wrote:
On Wed, 23 Jul 2008, Kevin Grittner wrote:
I've been working on an improved archive_command shell script that I
expect to submit for comments and potential inclusion in the
documentation as a better base fo
Heikki Linnakangas wrote:
Andrew Dunstan wrote:
Greg Smith wrote:
On Wed, 23 Jul 2008, Kevin Grittner wrote:
I've been working on an improved archive_command shell script that I
expect to submit for comments and potential inclusion in the
documentation as a better base for other people to bu
Andrew Dunstan wrote:
Greg Smith wrote:
On Wed, 23 Jul 2008, Kevin Grittner wrote:
In our scripts we handle this by copying to a temp directory on the
same mount point as the archive directory and doing a mv to the
archive location when the copy is successfully completed. I think
that this e
Greg Smith wrote:
On Wed, 23 Jul 2008, Kevin Grittner wrote:
In our scripts we handle this by copying to a temp directory on the
same mount point as the archive directory and doing a mv to the
archive location when the copy is successfully completed. I think
that this even works on Windows. C
On Wed, 23 Jul 2008, Kevin Grittner wrote:
In our scripts we handle this by copying to a temp directory on the
same mount point as the archive directory and doing a mv to the
archive location when the copy is successfully completed. I think
that this even works on Windows. Could that just be d
Andrew Dunstan wrote:
Heikki Linnakangas wrote:
Andrew Dunstan wrote:
- or maybe provide a .bat file or perl script that would work as na
archive_command on Windows.
We're not talking about archive_command. We're talking about the thing
that copies files to the directory that pg_standby
Heikki Linnakangas wrote:
Andrew Dunstan wrote:
- or maybe provide a .bat file or perl script that would work as na
archive_command on Windows.
We're not talking about archive_command. We're talking about the thing
that copies files to the directory that pg_standby polls.
Er, that's wha
Andrew Dunstan wrote:
Kevin Grittner wrote:
"Heikki Linnakangas" <[EMAIL PROTECTED]> wrote:
We really need a more reliable way of detecting that a file has been
fully copied.
In our scripts we handle this by copying to a temp directory on the
same mount point as the archive dire
On Fri, 2008-07-25 at 16:58 -0400, Tom Lane wrote:
> Simon Riggs <[EMAIL PROTECTED]> writes:
> > On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote:
> >> I thought the latest conclusion was that changing the behavior of
> >> pg_standby itself wouldn't address the problem anyway, and that what we
>
Simon Riggs <[EMAIL PROTECTED]> writes:
> On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote:
>> I thought the latest conclusion was that changing the behavior of
>> pg_standby itself wouldn't address the problem anyway, and that what we
>> need is just a docs patch recommending that people use safe
On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote:
> Simon Riggs <[EMAIL PROTECTED]> writes:
> > On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
> >> reviewing your patch
>
> > Current status is this:
> > * My understanding is that Dave and Andrew (and therefore Simon) think
> > the approa
Simon Riggs <[EMAIL PROTECTED]> writes:
> On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
>> reviewing your patch
> Current status is this:
> * My understanding is that Dave and Andrew (and therefore Simon) think
> the approach proposed here is an acceptable one. Heikki disagrees and
> want
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
> reviewing your patch
Current status is this:
* My understanding is that Dave and Andrew (and therefore Simon) think
the approach proposed here is an acceptable one. Heikki disagrees and
wants different approach. Perhaps I misunderstand.
On Wed, 2008-07-23 at 21:38 +0300, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
> >> 8. Unresolved question of implementing now/later a "cp" replacement
> >
> > The patch implements what's been agreed.
> >
> > I'm not rewriting "cp", f
Kevin Grittner wrote:
"Heikki Linnakangas" <[EMAIL PROTECTED]> wrote:
We really need a more reliable way of detecting that a file has been
fully copied.
In our scripts we handle this by copying to a temp directory on the
same mount point as the archive director
>>> "Heikki Linnakangas" <[EMAIL PROTECTED]> wrote:
> We really need a more reliable way of detecting that a file has been
> fully copied.
In our scripts we handle this by copying to a temp directory on the
same mount point as the archive directory and doing a mv to the
archive location when
Simon Riggs wrote:
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
8. Unresolved question of implementing now/later a "cp" replacement
The patch implements what's been agreed.
I'm not rewriting "cp", for reasons already discussed.
Not a comment to you Martin, but it's fairly clear th
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
> 1. Issues with applying the patch to CVS HEAD:
For me, the patch applies cleanly to CVS HEAD.
I do notice that there are two files "standby.sgml" and
"pgstandby.sgml". I can't see where "standby.sgml" comes from, but I
haven't created it;
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote:
> 1. Issues with applying the patch to CVS HEAD:
Sounds awful. Thanks for the review, will fix.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
--
Sent via pgsql-hackers mailing list (pgsql-hackers
Below my comments on the CommitFest patch:
pg_standby minor changes for Windows
Simon, I'm sorry you got me, a Postgres newbie, signed up for
reviewing your patch ;)
To start with, I'm not quite sure of the status of this patch
since Bruce's last comment on the -patches alias:
Bruce Momjian
31 matches
Mail list logo