Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Fujii Masao
On Thu, Jan 7, 2010 at 1:51 AM, Tom Lane t...@sss.pgh.pa.us wrote: This strikes me as a completely bad idea.  We need get no farther than the point that it assumes nobody can have a database named replication Though I might misunderstand your point. My proposal would force the users who have a

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Magnus Hagander
On Thu, Jan 7, 2010 at 07:19, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jan 6, 2010 at 11:11 PM, Magnus Hagander mag...@hagander.net wrote: I haven't read up on the rest of the patch, but where do we put the rest of the information about the replication master? Like which IP and port to

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Magnus Hagander
On Thu, Jan 7, 2010 at 09:26, Fujii Masao masao.fu...@gmail.com wrote: The same problem also exists in pg_hba.conf. It's because I introduced new keyword replication in pg_hba.conf to authenticate the standby server. This restriction is not acceptable? If so, I'd need to consider an

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Fujii Masao
On Thu, Jan 7, 2010 at 5:44 PM, Magnus Hagander mag...@hagander.net wrote: Such information are supplied in the parameter 'primary_conninfo' of recovery.conf. For example;    primary_conninfo = 'host=192.168.1.50 port=5432 user=foo' So the password can just go there, no? Yeah, the password

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Fujii Masao
On Thu, Jan 7, 2010 at 5:46 PM, Magnus Hagander mag...@hagander.net wrote: However, wouldn't it make more logical sense to replace host/hostssl with replication/replicationssl rather than overload the database field? Seems good. How about the following formats? replication user

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Heikki Linnakangas
Fujii Masao wrote: On Thu, Jan 7, 2010 at 5:44 PM, Magnus Hagander mag...@hagander.net wrote: Such information are supplied in the parameter 'primary_conninfo' of recovery.conf. For example; primary_conninfo = 'host=192.168.1.50 port=5432 user=foo' So the password can just go there, no?

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Heikki Linnakangas
Tom Lane wrote: Fujii Masao masao.fu...@gmail.com writes: The attached patch supports new keyword 'replication' on .pgpass file. This keyword is used to specify the password for the standby server to connect to the primary server. This strikes me as a completely bad idea. We need get no

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Heikki Linnakangas
Magnus Hagander wrote: However, wouldn't it make more logical sense to replace host/hostssl with replication/replicationssl rather than overload the database field? It makes more sense to me to overload the database field. When you connect for replication, you're not connecting to any

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Magnus Hagander
On Thu, Jan 7, 2010 at 10:21, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jan 7, 2010 at 5:46 PM, Magnus Hagander mag...@hagander.net wrote: However, wouldn't it make more logical sense to replace host/hostssl with replication/replicationssl rather than overload the database field?

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Magnus Hagander
On Thu, Jan 7, 2010 at 13:34, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Fujii Masao wrote: On Thu, Jan 7, 2010 at 5:44 PM, Magnus Hagander mag...@hagander.net wrote: Such information are supplied in the parameter 'primary_conninfo' of recovery.conf. For example;    

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Thu, Jan 7, 2010 at 5:46 PM, Magnus Hagander mag...@hagander.net wrote: However, wouldn't it make more logical sense to replace host/hostssl with replication/replicationssl rather than overload the database field? Seems good. How about the

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-07 Thread Heikki Linnakangas
Tom Lane wrote: I'm getting more and more confused here. I thought we were talking about client-side .pgpass. This seems to be talking about pg_hba.conf. Yeah, the topic was covertly changed. It seems we have consensus to not change .pgpass, and to leave pg_hba.conf as it is now in the patch

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-06 Thread Alvaro Herrera
Fujii Masao escribió: On Sat, Dec 26, 2009 at 10:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Dec 25, 2009 at 9:56 PM, Andrew Dunstan and...@dunslane.net wrote: I don't see the use case for it - .pgpass is for single users, not a whole cluster. And it does support wildcards,

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-06 Thread Magnus Hagander
On Wed, Jan 6, 2010 at 15:02, Alvaro Herrera alvhe...@commandprompt.com wrote: Fujii Masao escribió: On Sat, Dec 26, 2009 at 10:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Dec 25, 2009 at 9:56 PM, Andrew Dunstan and...@dunslane.net wrote: I don't see the use case for it -

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-06 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: The attached patch supports new keyword 'replication' on .pgpass file. This keyword is used to specify the password for the standby server to connect to the primary server. This strikes me as a completely bad idea. We need get no farther than the

Re: [HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-06 Thread Fujii Masao
On Wed, Jan 6, 2010 at 11:11 PM, Magnus Hagander mag...@hagander.net wrote: I haven't read up on the rest of the patch, but where do we put the rest of the information about the replication master? Like which IP and port to connect to? Perhaps it could/should go there? Such information are

[HACKERS] 'replication' keyword on .pgpass (Streaming Replication)

2010-01-05 Thread Fujii Masao
On Sat, Dec 26, 2009 at 10:55 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Dec 25, 2009 at 9:56 PM, Andrew Dunstan and...@dunslane.net wrote: I don't see the use case for it - .pgpass is for single users, not a whole cluster. And it does support wildcards, which takes care of the 'all'