Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-13 Thread Abhijit Menon-Sen
At 2013-07-12 16:25:14 -0700, jeff.ja...@gmail.com wrote: I think the reviewer of a performance patch should do some independent testing of the performance, to replicate the author's numbers; and hopefully with a few different scenarios. You're quite right. I apologise for being lazy; doubly

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-13 Thread Abhijit Menon-Sen
At 2013-07-13 14:19:23 +0530, a...@2ndquadrant.com wrote: The timings above are with both xid_in_snapshot_cache.v1.patch and cache_TransactionIdInProgress.v2.patch applied For anyone who wants to try to reproduce the results, here's the patch I used, which is both patches above plus some typo

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-12 Thread Abhijit Menon-Sen
At 2013-07-11 17:47:58 -0700, j...@agliodbs.com wrote: So, where are we with this patch, then? It's ready for committer. -- Abhijit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-12 Thread Jeff Janes
On Wed, Jul 10, 2013 at 10:09 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: At 2013-07-10 09:47:34 -0700, j...@agliodbs.com wrote: Due to the apparent lack of performance testing, I'm setting this back to needs review. The original submission (i.e. the message linked from the CF page)

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-11 Thread Josh Berkus
On 07/10/2013 10:09 PM, Abhijit Menon-Sen wrote: At 2013-07-10 09:47:34 -0700, j...@agliodbs.com wrote: Due to the apparent lack of performance testing, I'm setting this back to needs review. The original submission (i.e. the message linked from the CF page) includes test results that

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-10 Thread Josh Berkus
On 07/08/2013 10:11 AM, Josh Berkus wrote: On 06/23/2013 09:43 PM, Abhijit Menon-Sen wrote: (Cc: to pgsql-performance dropped, pgsql-hackers added.) At 2013-05-06 09:14:01 +0100, si...@2ndquadrant.com wrote: New version of patch attached which fixes a few bugs. I read the patch, but only

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-10 Thread Abhijit Menon-Sen
At 2013-07-10 09:47:34 -0700, j...@agliodbs.com wrote: Due to the apparent lack of performance testing, I'm setting this back to needs review. The original submission (i.e. the message linked from the CF page) includes test results that showed a clear performance improvement. Here's an

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-07-08 Thread Josh Berkus
On 06/23/2013 09:43 PM, Abhijit Menon-Sen wrote: (Cc: to pgsql-performance dropped, pgsql-hackers added.) At 2013-05-06 09:14:01 +0100, si...@2ndquadrant.com wrote: New version of patch attached which fixes a few bugs. I read the patch, but only skimmed the earlier discussion about it. In

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-06-23 Thread Abhijit Menon-Sen
(Cc: to pgsql-performance dropped, pgsql-hackers added.) At 2013-05-06 09:14:01 +0100, si...@2ndquadrant.com wrote: New version of patch attached which fixes a few bugs. I read the patch, but only skimmed the earlier discussion about it. In isolation, I can say that the patch applies cleanly