[HACKERS] Another pgindent gripe

2014-02-13 Thread Tom Lane
I noticed that current pgindent wants to do this to a recently-added comment in psql/copy.c: *** handleCopyIn(PGconn *conn, FILE *copystr *** 627,633 /* * This code erroneously assumes '\.' on a

Re: [HACKERS] Another pgindent gripe

2014-02-13 Thread Bruce Momjian
On Thu, Feb 13, 2014 at 06:14:17PM -0500, Tom Lane wrote: I noticed that current pgindent wants to do this to a recently-added comment in psql/copy.c: *** handleCopyIn(PGconn *conn, FILE *copystr *** 627,633 /*

Re: [HACKERS] Another pgindent gripe

2005-11-10 Thread Bruce Momjian
Conway Cc: Bruce Momjian; Hackers Subject: Re: [HACKERS] Another pgindent gripe Neil Conway [EMAIL PROTECTED] writes: On a related note, most of these changes are completely bogus: http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_e xe c.c.diff?r1=1.152;r2

[HACKERS] Another pgindent gripe

2005-11-07 Thread Alvaro Herrera
Hi, I have another gripe regarding pgindent. Why does it change indenting of function declarations? An example is at the end. I think it may be thinking that declarations should be aligned using 8-spaces tabs. Can this be corrected? It annoyed me just now, because I'm adjusting my vacuum

Re: [HACKERS] Another pgindent gripe

2005-11-07 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: I have another gripe regarding pgindent. Why does it change indenting of function declarations? What it's doing is indenting the additional lines in the same way as they'd be indented in the function definition, that is static void foo(int p1, int

Re: [HACKERS] Another pgindent gripe

2005-11-07 Thread Neil Conway
On Mon, 2005-07-11 at 09:19 -0300, Alvaro Herrera wrote: I have another gripe regarding pgindent. Why does it change indenting of function declarations? On a related note, most of these changes are completely bogus:

Re: [HACKERS] Another pgindent gripe

2005-11-07 Thread Kevin Grittner
Where someone is doing real work and pgindent creates so many cosmetic changes for the current CVS repository, would it be feasible to first commit a whitespace only noop revision, so that real changes can be easily identified. I have seen this approach work well for others. -Kevin Neil

Re: [HACKERS] Another pgindent gripe

2005-11-07 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On a related note, most of these changes are completely bogus: http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c.diff?r1=1.152;r2=1.153 Oy vey! Why did it insert spaces after the stars in all those function declarations?

Re: [HACKERS] Another pgindent gripe

2005-11-07 Thread Chuck McDevitt
Lane Sent: Monday, November 07, 2005 8:19 AM To: Neil Conway Cc: Bruce Momjian; Hackers Subject: Re: [HACKERS] Another pgindent gripe Neil Conway [EMAIL PROTECTED] writes: On a related note, most of these changes are completely bogus: http://developer.postgresql.org/cvsweb.cgi/pgsql

[HACKERS] Another pgindent gripe

2001-06-04 Thread Tom Lane
Why does pgindent sometimes insert whitespace into the return type part of a function definition? Here's an example from the last pgindent run: RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/optimizer/plan/createplan.c,v retrieving revision 1.103 retrieving revision 1.104 diff -c