Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-04-06 Thread Ian Barwick
On 05/04/16 10:24, Peter Eisentraut wrote: > On 03/30/2016 09:15 PM, Ian Barwick wrote: >> Currently pg_create_physical_replication_slot() may refer to >> the deprecated wal_level setting "archive": > > I have fixed this in the most direct way, since there was some disagreement > about

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-04-04 Thread Peter Eisentraut
On 03/31/2016 10:18 AM, Alvaro Herrera wrote: I thought we had agreed that we weren't going to consider the wal_level values as a linear scale -- in other words, wordings such as "greater than FOO" are discouraged. That's always seemed a bit odd to me. I don't think there was any agreement

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-04-04 Thread Peter Eisentraut
On 03/30/2016 09:15 PM, Ian Barwick wrote: Currently pg_create_physical_replication_slot() may refer to the deprecated wal_level setting "archive": I have fixed this in the most direct way, since there was some disagreement about rewording. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-04-01 Thread Ian Barwick
On 16/04/01 8:15, Michael Paquier wrote: > On Thu, Mar 31, 2016 at 11:18 PM, Alvaro Herrera > wrote: >> Andres Freund wrote: >>> On 2016-03-31 10:15:21 +0900, Ian Barwick wrote: >> Patch changes the error message to: ERROR: replication slots can only be

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-03-31 Thread Michael Paquier
On Thu, Mar 31, 2016 at 11:18 PM, Alvaro Herrera wrote: > Andres Freund wrote: >> On 2016-03-31 10:15:21 +0900, Ian Barwick wrote: > >> > Patch changes the error message to: >> > >> > ERROR: replication slots can only be used if wal_level is "replica" or >> >

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-03-31 Thread Alvaro Herrera
Andres Freund wrote: > On 2016-03-31 10:15:21 +0900, Ian Barwick wrote: > > Patch changes the error message to: > > > > ERROR: replication slots can only be used if wal_level is "replica" or > > "logical" > > > > Explicitly naming the valid WAL levels matches the wording in the wal_level >

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-03-31 Thread Andres Freund
On 2016-03-31 10:15:21 +0900, Ian Barwick wrote: > Hi > > Currently pg_create_physical_replication_slot() may refer to > the deprecated wal_level setting "archive": > > postgres=# SHOW wal_level ; >wal_level > --- >minimal > (1 row) > > postgres=# SELECT

Re: [HACKERS] Correction for replication slot creation error message in 9.6

2016-03-30 Thread Michael Paquier
On Thu, Mar 31, 2016 at 10:15 AM, Ian Barwick wrote: > Currently pg_create_physical_replication_slot() may refer to > the deprecated wal_level setting "archive": (Adding Peter in CC who committed this patch). > Patch changes the error message to: > > ERROR: replication

[HACKERS] Correction for replication slot creation error message in 9.6

2016-03-30 Thread Ian Barwick
Hi Currently pg_create_physical_replication_slot() may refer to the deprecated wal_level setting "archive": postgres=# SHOW wal_level ; wal_level --- minimal (1 row) postgres=# SELECT pg_create_physical_replication_slot('some_slot'); ERROR: replication slots can only be