Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Michael Paquier
On Wed, Jan 27, 2016 at 11:41 AM, Fujii Masao wrote: > But ISTM that CREATE MATERIALIZED VIEW doesn't list > existing matviews yet. What's worse it lists existing *views*. Yep. > This happens because words_after_create mechanism doesn't support > the case where the keyword has more than one wor

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Fujii Masao
On Tue, Jan 26, 2016 at 11:49 PM, Kevin Grittner wrote: > On Tue, Jan 26, 2016 at 8:43 AM, Kevin Grittner wrote: > >> I will push something shortly with the >> improvements from both of you, plus a couple other MV tab >> completion issues I found in testing these patches. > > Done. But ISTM that

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Kevin Grittner
On Tue, Jan 26, 2016 at 8:43 AM, Kevin Grittner wrote: > I will push something shortly with the > improvements from both of you, plus a couple other MV tab > completion issues I found in testing these patches. Done. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL C

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Kevin Grittner
On Tue, Jan 26, 2016 at 8:24 AM, Fujii Masao wrote: > On Tue, Jan 26, 2016 at 11:08 PM, Fujii Masao wrote: >> While testing the patch, I found that >> REFRESH MATERIALIZED VIEW doesn't list the materialized views. > > This is not true. Sorry for the noise... But CREATE MATERIALIZED VIEW doesn

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Fujii Masao
On Tue, Jan 26, 2016 at 11:08 PM, Fujii Masao wrote: > On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier > wrote: >> On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada >> wrote: >>> Tab completion for REFRESH command is oddly with following scenario. >>> >>> =# REFRESH MATERIALIZED VIEW CONCURREN

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Fujii Masao
On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier wrote: > On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada > wrote: >> Tab completion for REFRESH command is oddly with following scenario. >> >> =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab] >> >> It shows only WITH DATA option without

Re: [HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Michael Paquier
On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada wrote: > Tab completion for REFRESH command is oddly with following scenario. > > =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab] > > It shows only WITH DATA option without WITH NO DATA option. > Attached patch improves tab completion for WI

[HACKERS] Improve tab completion for REFRESH MATERIALIZED VIEW

2016-01-26 Thread Masahiko Sawada
Hi all, Tab completion for REFRESH command is oddly with following scenario. =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab] It shows only WITH DATA option without WITH NO DATA option. Attached patch improves tab completion for WITH DATA/NO DATA option of REFRESH MATERIALIZED VIEW. Reg