Re: [HACKERS] Out of date comment in predicate.c

2017-08-23 Thread Peter Eisentraut
On 7/6/17 21:06, Thomas Munro wrote: > On Sat, Jul 1, 2017 at 6:38 AM, Peter Eisentraut > wrote: >> On 6/27/17 01:21, Thomas Munro wrote: >>> Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of >>> FirstPredicateLockMgrLock, but it's still referred to in a comment in >>> predicate.c where t

Re: [HACKERS] Out of date comment in predicate.c

2017-07-06 Thread Thomas Munro
On Sat, Jul 1, 2017 at 6:38 AM, Peter Eisentraut wrote: > On 6/27/17 01:21, Thomas Munro wrote: >> Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of >> FirstPredicateLockMgrLock, but it's still referred to in a comment in >> predicate.c where the locking protocol is documented. I think i

Re: [HACKERS] Out of date comment in predicate.c

2017-06-30 Thread Peter Eisentraut
On 6/27/17 01:21, Thomas Munro wrote: > Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of > FirstPredicateLockMgrLock, but it's still referred to in a comment in > predicate.c where the locking protocol is documented. I think it's > probably best to use the name of the macro that's usuall

[HACKERS] Out of date comment in predicate.c

2017-06-26 Thread Thomas Munro
Hi hackers, Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of FirstPredicateLockMgrLock, but it's still referred to in a comment in predicate.c where the locking protocol is documented. I think it's probably best to use the name of the macro that's usually used to access the lock array i