On Fri, Dec 12, 2014 at 10:19 AM, Simon Riggs wrote:
>
> On 11 December 2014 at 23:41, Michael Paquier
> wrote:
>
> > Glad that things are in order now. I have nothing else left to complain
> > about with this feature. Thanks.
>
> I think you've discovered a new meaning of Ready for Committer
>
Y
On 11 December 2014 at 23:41, Michael Paquier wrote:
> Glad that things are in order now. I have nothing else left to complain
> about with this feature. Thanks.
I think you've discovered a new meaning of Ready for Committer
--
Simon Riggs http://www.2ndQuadrant.com/
Postgr
On Fri, Dec 12, 2014 at 8:41 AM, Michael Paquier
wrote:
> On Fri, Dec 12, 2014 at 8:00 AM, Simon Riggs
> wrote:
>
>> Rather unluckily that seems to have coincided with Tom's changes, so
>> I've only added the bits that have nothing to do with Tom's changes -
>> all of which stand.
>>
> Glad that
On Fri, Dec 12, 2014 at 8:00 AM, Simon Riggs wrote:
> On 9 December 2014 at 12:21, Michael Paquier
> wrote:
> > On Tue, Dec 9, 2014 at 6:43 PM, Michael Paquier
> > wrote:
> >> OK. Perhaps that's not worth mentioning in the release notes, but some
> >> users may be used to the old behavior. What
On 9 December 2014 at 12:21, Michael Paquier wrote:
> On Tue, Dec 9, 2014 at 6:43 PM, Michael Paquier
> wrote:
>> OK. Perhaps that's not worth mentioning in the release notes, but some
>> users may be used to the old behavior. What about the other issues
>> (regression test for permissions incorr
On Wed, Dec 10, 2014 at 1:37 AM, Fabrízio de Royes Mello
wrote:
> On Tue, Dec 9, 2014 at 10:21 AM, Michael Paquier
> wrote:
>>
>> On Tue, Dec 9, 2014 at 6:43 PM, Michael Paquier
>> wrote:
>> > OK. Perhaps that's not worth mentioning in the release notes, but some
>> > users may be used to the ol
On Tue, Dec 9, 2014 at 10:21 AM, Michael Paquier
wrote:
>
> On Tue, Dec 9, 2014 at 6:43 PM, Michael Paquier
> wrote:
> > OK. Perhaps that's not worth mentioning in the release notes, but some
> > users may be used to the old behavior. What about the other issues
> > (regression test for permissio
On Tue, Dec 9, 2014 at 11:59 PM, Tom Lane wrote:
> Simon Riggs writes:
>> ISTM that REINDEX is not consistent with VACUUM, ANALYZE or CLUSTER in
>> the way it issues NOTICE messages.
>
>> I'm inclined to simply remove the NOTICE messages, except when a
>> REINDEX ... VERBOSE is requested.
>
> My
Simon Riggs writes:
> ISTM that REINDEX is not consistent with VACUUM, ANALYZE or CLUSTER in
> the way it issues NOTICE messages.
> I'm inclined to simply remove the NOTICE messages, except when a
> REINDEX ... VERBOSE is requested.
My recollection is that those other commands do issue messages
On Tue, Dec 9, 2014 at 6:43 PM, Michael Paquier
wrote:
> OK. Perhaps that's not worth mentioning in the release notes, but some
> users may be used to the old behavior. What about the other issues
> (regression test for permissions incorrect and matviews)?
Here is in any case an updated patch to f
On Tue, Dec 9, 2014 at 6:00 PM, Simon Riggs wrote:
> On 9 December 2014 at 17:17, Michael Paquier
> wrote:
>
>>> While re-looking at that. I just found that when selecting the
>>> relations that are reindexed for a schema we ignore materialized view
>>> as the key scan is only done using 'r' as
On Tuesday, December 9, 2014, Simon Riggs wrote:
> On 9 December 2014 at 17:17, Michael Paquier > wrote:
>
> >> While re-looking at that. I just found that when selecting the
> >> relations that are reindexed for a schema we ignore materialized view
> >> as the key scan is only done using 'r' as
On 9 December 2014 at 17:17, Michael Paquier wrote:
>> While re-looking at that. I just found that when selecting the
>> relations that are reindexed for a schema we ignore materialized view
>> as the key scan is only done using 'r' as relkind. The patch attached
>> fixes that.
> Here is an updat
On Tue, Dec 9, 2014 at 4:44 PM, Michael Paquier
wrote:
> On Tue, Dec 9, 2014 at 10:10 AM, Michael Paquier
> wrote:
>> On Tue, Dec 2, 2014 at 3:42 PM, Michael Paquier
>> wrote:
>>> Adding on top of that a couple of things cleaned up, like docs and
>>> typos, and I got the patch attached. Let's ha
On Tue, Dec 9, 2014 at 10:10 AM, Michael Paquier
wrote:
> On Tue, Dec 2, 2014 at 3:42 PM, Michael Paquier
> wrote:
>> Adding on top of that a couple of things cleaned up, like docs and
>> typos, and I got the patch attached. Let's have a committer have a
>> look a it now, I am marking that as "Re
On Tue, Dec 2, 2014 at 3:42 PM, Michael Paquier
wrote:
> Adding on top of that a couple of things cleaned up, like docs and
> typos, and I got the patch attached. Let's have a committer have a
> look a it now, I am marking that as "Ready for Committer".
For the archives, this has been committed as
On Mon, Dec 1, 2014 at 11:29 PM, Sawada Masahiko wrote:
> On Thu, Nov 27, 2014 at 11:43 PM, Michael Paquier
> wrote:
>> If you get that done, I'll have an extra look at it and then let's
>> have a committer look at it.
>
> Attached patch is latest version.
> I added new enum values like REINDEX_O
On Thu, Nov 27, 2014 at 11:43 PM, Michael Paquier
wrote:
> On Thu, Nov 27, 2014 at 8:18 PM, Sawada Masahiko
> wrote:
>> On Thu, Nov 27, 2014 at 1:07 PM, Michael Paquier
>> wrote:
>>> On Thu, Nov 27, 2014 at 12:55 AM, Sawada Masahiko
>>> wrote:
+1 to define new something object type and r
On Thu, Nov 27, 2014 at 8:18 PM, Sawada Masahiko wrote:
> On Thu, Nov 27, 2014 at 1:07 PM, Michael Paquier
> wrote:
>> On Thu, Nov 27, 2014 at 12:55 AM, Sawada Masahiko
>> wrote:
>>> +1 to define new something object type and remove do_user and do_system.
>>> But if we add OBJECT_SYSTEM to Obje
On Thu, Nov 27, 2014 at 1:07 PM, Michael Paquier
wrote:
> On Thu, Nov 27, 2014 at 12:55 AM, Sawada Masahiko
> wrote:
>> +1 to define new something object type and remove do_user and do_system.
>> But if we add OBJECT_SYSTEM to ObjectType data type,
>> system catalogs are OBJECT_SYSTEM as well as
On Thu, Nov 27, 2014 at 12:55 AM, Sawada Masahiko wrote:
> +1 to define new something object type and remove do_user and do_system.
> But if we add OBJECT_SYSTEM to ObjectType data type,
> system catalogs are OBJECT_SYSTEM as well as OBJECT_TABLE.
> It's a bit redundant?
Yes, kind of. That's a sup
On Wed, Nov 26, 2014 at 3:48 PM, Michael Paquier
wrote:
> On Wed, Nov 19, 2014 at 1:37 AM, Simon Riggs wrote:
>> On 23 October 2014 00:21, Alvaro Herrera wrote:
>>
Attached patch is latest version patch I modified above.
Also, I noticed I had forgotten to add the patch regarding docume
On Wed, Nov 19, 2014 at 1:37 AM, Simon Riggs wrote:
> On 23 October 2014 00:21, Alvaro Herrera wrote:
>
>>> Attached patch is latest version patch I modified above.
>>> Also, I noticed I had forgotten to add the patch regarding document of
>>> reindexdb.
>>
>> Please don't use pg_catalog in the r
On 23 October 2014 00:21, Alvaro Herrera wrote:
>> Attached patch is latest version patch I modified above.
>> Also, I noticed I had forgotten to add the patch regarding document of
>> reindexdb.
>
> Please don't use pg_catalog in the regression test. That way we will
> need to update the expect
On Thu, Nov 6, 2014 at 8:00 PM, Fujii Masao wrote:
> On Fri, Oct 24, 2014 at 3:41 AM, Fabrízio de Royes Mello
> wrote:
>> On Wed, Oct 22, 2014 at 9:21 PM, Alvaro Herrera
>> wrote:
>>>
>>> Sawada Masahiko wrote:
>>>
>>> > Thank you for reviewing.
>>> > I agree 2) - 5).
>>> > Attached patch is lat
On Fri, Oct 24, 2014 at 3:41 AM, Fabrízio de Royes Mello
wrote:
> On Wed, Oct 22, 2014 at 9:21 PM, Alvaro Herrera
> wrote:
>>
>> Sawada Masahiko wrote:
>>
>> > Thank you for reviewing.
>> > I agree 2) - 5).
>> > Attached patch is latest version patch I modified above.
>> > Also, I noticed I had f
On Wed, Oct 22, 2014 at 9:21 PM, Alvaro Herrera
wrote:
>
> Sawada Masahiko wrote:
>
> > Thank you for reviewing.
> > I agree 2) - 5).
> > Attached patch is latest version patch I modified above.
> > Also, I noticed I had forgotten to add the patch regarding document of
> > reindexdb.
>
> Please do
Sawada Masahiko wrote:
> Thank you for reviewing.
> I agree 2) - 5).
> Attached patch is latest version patch I modified above.
> Also, I noticed I had forgotten to add the patch regarding document of
> reindexdb.
Please don't use pg_catalog in the regression test. That way we will
need to updat
On Mon, Oct 20, 2014 at 11:24 AM, Sawada Masahiko
wrote:
>
> On Mon, Oct 20, 2014 at 9:41 AM, Fabrízio de Royes Mello
> wrote:
> >
> >
> > On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello
> > wrote:
> >>
> >>
> >> On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko
> >> wrote:
> >> >
> >>
On Mon, Oct 20, 2014 at 9:41 AM, Fabrízio de Royes Mello
wrote:
>
>
> On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello
> wrote:
>>
>>
>> On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko
>> wrote:
>> >
>> > On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello
>> > wrote:
>> > > On W
On Sun, Oct 19, 2014 at 10:37 PM, Fabrízio de Royes Mello <
fabriziome...@gmail.com> wrote:
>
>
> On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko
wrote:
> >
> > On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello
> > wrote:
> > > On Wed, Oct 15, 2014 at 11:41 AM, Sawada Masahiko <
sawada.m.
On Sun, Oct 19, 2014 at 1:02 PM, Sawada Masahiko
wrote:
>
> On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello
> wrote:
> > On Wed, Oct 15, 2014 at 11:41 AM, Sawada Masahiko
> > wrote:
> >>
> >> On Mon, Oct 13, 2014 at 11:16 PM, Robert Haas
> >> wrote:
> >> > On Sun, Oct 12, 2014 at 1:27
On Fri, Oct 17, 2014 at 4:32 AM, Fabrízio de Royes Mello
wrote:
> On Wed, Oct 15, 2014 at 11:41 AM, Sawada Masahiko
> wrote:
>>
>> On Mon, Oct 13, 2014 at 11:16 PM, Robert Haas
>> wrote:
>> > On Sun, Oct 12, 2014 at 1:27 PM, Stephen Frost
>> > wrote:
>> >> * Alvaro Herrera (alvhe...@2ndquadrant
On Wed, Oct 15, 2014 at 11:41 AM, Sawada Masahiko
wrote:
>
> On Mon, Oct 13, 2014 at 11:16 PM, Robert Haas
wrote:
> > On Sun, Oct 12, 2014 at 1:27 PM, Stephen Frost
wrote:
> >> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> >>> Sawada Masahiko wrote:
> >>> > Attached WIP patch adds new syn
On Mon, Oct 13, 2014 at 11:16 PM, Robert Haas wrote:
> On Sun, Oct 12, 2014 at 1:27 PM, Stephen Frost wrote:
>> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
>>> Sawada Masahiko wrote:
>>> > Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
>>> > all table of specified s
On Sun, Oct 12, 2014 at 1:27 PM, Stephen Frost wrote:
> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
>> Sawada Masahiko wrote:
>> > Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
>> > all table of specified schema.
>> > There are syntax dose reindexing specified index
On Mon, Oct 13, 2014 at 5:39 AM, Sawada Masahiko
wrote:
>
> On Mon, Oct 13, 2014 at 1:25 PM, Fabrízio de Royes Mello
> wrote:
> > On Sun, Oct 12, 2014 at 2:27 PM, Stephen Frost
wrote:
> >>
> >> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> >> > Sawada Masahiko wrote:
> >> > > Attached WIP
On Mon, Oct 13, 2014 at 1:25 PM, Fabrízio de Royes Mello
wrote:
> On Sun, Oct 12, 2014 at 2:27 PM, Stephen Frost wrote:
>>
>> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
>> > Sawada Masahiko wrote:
>> > > Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
>> > > all tab
On Sun, Oct 12, 2014 at 2:27 PM, Stephen Frost wrote:
>
> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> > Sawada Masahiko wrote:
> > > Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
> > > all table of specified schema.
> > > There are syntax dose reindexing specified
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> Sawada Masahiko wrote:
> > Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
> > all table of specified schema.
> > There are syntax dose reindexing specified index, per table and per
> > database,
> > but we can not do rein
Sawada Masahiko wrote:
> Hi all,
>
> Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
> all table of specified schema.
> There are syntax dose reindexing specified index, per table and per database,
> but we can not do reindexing per schema for now.
It seems doubtful that th
Hi all,
Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing
all table of specified schema.
There are syntax dose reindexing specified index, per table and per database,
but we can not do reindexing per schema for now.
So we must use reindexdb command if we want to do.
This new s
42 matches
Mail list logo
