Re: [HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-08-06 Thread Magnus Hagander
On Wed, Aug 5, 2009 at 16:53, Tom Lane wrote: > Magnus Hagander writes: But. I'll look into cleaning those up for HEAD anyway, but due to lack of reports I think we should skip backpatch. Reasonable? >>> >>> Fair enough. > >> Here's what I came up with. Seems ok? > > Works for me. Appli

Re: [HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-08-05 Thread Tom Lane
Magnus Hagander writes: >>> But. I'll look into cleaning those up for HEAD anyway, but due to lack >>> of reports I think we should skip backpatch. Reasonable? >> >> Fair enough. > Here's what I came up with. Seems ok? Works for me. regards, tom lane -- Sent via pgsql

Re: [HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-08-05 Thread Magnus Hagander
On Tue, Jul 28, 2009 at 15:45, Tom Lane wrote: > Magnus Hagander writes: >> On Mon, Jul 27, 2009 at 16:14, Tom Lane wrote: >>> I'm not really insisting on a redesign.  I'm talking about the places >>> where the code author appears not to have understood that ERROR means >>> FATAL, because the code

Re: [HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-07-28 Thread Tom Lane
Magnus Hagander writes: > On Mon, Jul 27, 2009 at 16:14, Tom Lane wrote: >> I'm not really insisting on a redesign.  I'm talking about the places >> where the code author appears not to have understood that ERROR means >> FATAL, because the code keeps plugging on after it anyway.  As far as >> I c

Re: [HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-07-28 Thread Magnus Hagander
On Mon, Jul 27, 2009 at 16:14, Tom Lane wrote: > Magnus Hagander writes: >> To fix that we'd just have to turn those functions all into returning >> boolean and log with LOG instead. AFAIK, we've had zero reports of >> this actually happening, so I'm not sure it's worth redesigning. >> Thoughts? >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-07-27 Thread Tom Lane
Magnus Hagander writes: > To fix that we'd just have to turn those functions all into returning > boolean and log with LOG instead. AFAIK, we've had zero reports of > this actually happening, so I'm not sure it's worth redesigning. > Thoughts? I'm not really insisting on a redesign. I'm talking

[HACKERS] Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

2009-07-27 Thread Magnus Hagander
On Sat, Jul 25, 2009 at 19:50, Tom Lane wrote: > m...@postgresql.org (Magnus Hagander) writes: >> Log Message: >> --- >> Reserve the shared memory region during backend startup on Windows, so >> that memory allocated by starting third party DLLs doesn't end up >> conflicting with it. > > I