Katherine Ward writes:
> A few of the identifier names used in postgres collide with WIN32 or MFC names.
Does Windows and/or MFC make any kind of statement about what kinds of
identifiers it reserves for its own use?
> b. GetUserName() => GetUserNameFromId()
> c. GetCurrentTime()
Thomas Lockhart <[EMAIL PROTECTED]> writes:
> Question to all: Any objection to postfix? If so, why?
Well, I suggested DTF_FOO by analogy to the DTK_FOO name set that appears
elsewhere in that same header. If you want to rename those to FOO_DTK
in parallel, I have no objection.
> IGNORE_TOK - H
> Christopher Kings-Lynne wrote:
> > It's more likely that your changes will go through if you just submit a
> > patch!
>
> I suggested to discuss it first, since it's IMHO more likely
> that the changes go through if they are commonly accepted in
> the first place.
Yep - sorry, di
> > "P" for "Parser".
> Oh, okay. I'm not intent on changing it, just was wondering what the
> motivation was. What do you think of changing all the token symbols to
> be FOO_P? (Or P_FOO, per your comment, but I'd just as soon leave alone
> the ones that already have a suffix.)
No problem her
Thomas Lockhart <[EMAIL PROTECTED]> writes:
>> I'm tempted to suggest that we should stick _P on *all* the lexer token
>> symbols, rather than having an inconsistent set of names where some of
>> them have _P and some do not. Or perhaps _T (for token) would be a more
>> sensible convention; I'm n
> >> 2. Add _P to the following lex/yacc tokens to avoid collisions
> >> CONST, CHAR, DELETE, FLOAT, GROUP, IN, OUT
> I'm tempted to suggest that we should stick _P on *all* the lexer token
> symbols, rather than having an inconsistent set of names where some of
> them have _P and some do not. O
n
> cvs diff -c
>
> Chris
>
> - Original Message -
> From: "Katherine Ward" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Thursday, May 30, 2002 2:33 PM
> Subject: [HACKERS] Small changes to facilitate Win32 port
>
>
> > Hi the
"Dann Corbit" <[EMAIL PROTECTED]> writes:
>> I'm tempted to suggest that we should stick _P on *all* the
>> lexer token
>> symbols, rather than having an inconsistent set of names where some of
>> them have _P and some do not. Or perhaps _T (for token)
>> would be a more
>> sensible convention;
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]]
> Sent: Thursday, May 30, 2002 3:25 PM
> To: Christopher Kings-Lynne
> Cc: Katherine Ward; Thomas Lockhart; [EMAIL PROTECTED]
> Subject: Re: [HACKERS] Small changes to facilitate Win32 port
>
>
&g
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes:
> It's more likely that your changes will go through if you just submit a
> patch!
I think the question was more directed at "do we like these names?",
which should certainly be asked before going to the trouble of making a
patch.
>> 2. Add
It's more likely that your changes will go through if you just submit a
patch!
cvs diff -c
Chris
- Original Message -
From: "Katherine Ward" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Thursday, May 30, 2002 2:33 PM
Subject: [HACKERS] Small changes to f
Hi there. I'm yet another developer working full-time on a native windows
port. I'm also working closely with Jan Wieck (next office). I know there is
a reluctance to modify the code base to support native win32, and I realize
that no decision has yet been made. However, ...
A few of the iden
12 matches
Mail list logo
