On Thu, Aug 28, 2014 at 12:55 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Wed, Aug 27, 2014 at 10:59 PM, Alvaro Herrera alvhe...@2ndquadrant.com
wrote:
Not necessarily, because it's harmless. It's there for purely
aesthetical reasons, so it's your choice whether to add it or not.
On Thu, Aug 28, 2014 at 4:20 PM, Fujii Masao masao.fu...@gmail.com wrote:
I don't have strong opinion about this. There are many tables which
regression test creates but doesn't drop. But if you strongly think that
the table must be dropped, I'm OK with that.
This remark is just to limit the
Michael Paquier wrote:
This remark is just to limit the amount of trash in the database used
for regression tests. But then if we'd remove everything we would lack
handy material for tests on utilities like database-wide thingies of
the type VACUUM, REINDEX, pg_dump, etc. And we can just drop
On Tue, Aug 26, 2014 at 3:27 AM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
On Thu, Aug 21, 2014 at 4:20 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
Looking at the patch, the parameter fillfactor in the category
RELOPT_KIND_HEAP (the first element in
Fujii Masao wrote:
On Tue, Aug 26, 2014 at 3:27 AM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
On Thu, Aug 21, 2014 at 4:20 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
Looking at the patch, the parameter fillfactor in the category
RELOPT_KIND_HEAP
On Wed, Aug 27, 2014 at 10:59 PM, Alvaro Herrera alvhe...@2ndquadrant.com
wrote:
Not necessarily, because it's harmless. It's there for purely
aesthetical reasons, so it's your choice whether to add it or not.
Having it there is slightly easier on somebody reading the code,
perhaps.
On my
On Thu, Aug 21, 2014 at 4:20 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Aug 8, 2014 at 12:32 PM, Fujii Masao masao.fu...@gmail.com wrote:
This is not user-friendly. I'd like to propose the attached patch which
introduces the infrastructure which allows us to specify the unit
Fujii Masao wrote:
On Thu, Aug 21, 2014 at 4:20 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
Looking at the patch, the parameter fillfactor in the category
RELOPT_KIND_HEAP (the first element in intRelOpts of reloptions.c) is
not updated with the new field. It is only a one-line
On Fri, Aug 8, 2014 at 12:32 PM, Fujii Masao masao.fu...@gmail.com wrote:
This is not user-friendly. I'd like to propose the attached patch which
introduces the infrastructure which allows us to specify the unit when
setting INTEGER storage parameter like autovacuum_vacuum_cost_delay.
Comment?
On 08/07/2014 08:32 PM, Fujii Masao wrote:
This is not user-friendly. I'd like to propose the attached patch which
introduces the infrastructure which allows us to specify the unit when
setting INTEGER storage parameter like autovacuum_vacuum_cost_delay.
Comment? Review?
No review, but thank
Hi,
We can specify the unit when setting autovacuum_vacuum_cost_delay
GUC as follows.
ALTER SYSTEM SET autovacuum_vacuum_cost_delay TO '80ms';
OTOH we cannot specify the unit when setting autovacuum_vacuum_cost_delay
as storage parameter as follows.
CREATE TABLE test (col1 int) WITH
Fujii Masao wrote:
Hi,
We can specify the unit when setting autovacuum_vacuum_cost_delay
GUC as follows.
ALTER SYSTEM SET autovacuum_vacuum_cost_delay TO '80ms';
OTOH we cannot specify the unit when setting autovacuum_vacuum_cost_delay
as storage parameter as follows.
CREATE
On Fri, Aug 8, 2014 at 12:56 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
Hi,
We can specify the unit when setting autovacuum_vacuum_cost_delay
GUC as follows.
ALTER SYSTEM SET autovacuum_vacuum_cost_delay TO '80ms';
OTOH we cannot specify the unit when
Fujii Masao wrote:
On Fri, Aug 8, 2014 at 12:56 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Hm, what's with the parse_int signature change and the hintmsg thing?
Is it just me or the patch is incomplete?
Sorry, probably I failed to see your point. You mean that the signature
of
On Fri, Aug 8, 2014 at 2:12 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
On Fri, Aug 8, 2014 at 12:56 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Hm, what's with the parse_int signature change and the hintmsg thing?
Is it just me or the patch is incomplete?
15 matches
Mail list logo
