Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Chuck McDevitt
, September 24, 2007 2:17 PM To: Magnus Hagander Cc: pgsql-hackers@postgresql.org Subject: RE: [HACKERS] Suggestion for MSVC build The right lib files to link readline are the .a ones... Like this: if ($solution-{options}-{readline}) { $psql-AddIncludeDir($solution

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Chuck McDevitt
' Subject: RE: [HACKERS] Suggestion for MSVC build Actually, the more I look at it, I realize it was correct before We want to link against readline.lib and history.lib, but the ones in the GnuWin32 distribution are broken. The .lib files are made from the .def files, which are supposed

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Dave Page
Chuck McDevitt wrote: Maybe I need to do some research on readline... this seems more complicated than I expected. Does no one else use readline on Windows? Is the Gnuwin32 readline a fraud? I just don't know. readline has never worked well on Windows which is why we don't use it with the

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Magnus Hagander
On Mon, Sep 24, 2007 at 01:33:33PM -0400, Chuck McDevitt wrote: Sorry, completion_matches hasn't existed in readline for a long time. You need to define: #define HAVE_RL_COMPLETION_APPEND_CHARACTER 1 #define HAVE_RL_COMPLETION_MATCHES 1 #define HAVE_RL_FILENAME_COMPLETION_FUNCTION 1

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Magnus Hagander
On Tue, Sep 25, 2007 at 02:58:54AM -0400, Chuck McDevitt wrote: Actually, the more I look at it, I realize it was correct before We want to link against readline.lib and history.lib, but the ones in the GnuWin32 distribution are broken. The .lib files are made from the .def files, which are

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Andrew Dunstan
Magnus Hagander wrote: Can you check if your manually linked version works in non-US locales? If you can't check, can you email me (offlist) with the binary (and the DLLs) and I can run a test here. If they *have* fixed the issue so it works in non-US locales, it's certainly worth expending

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Magnus Hagander
On Tue, Sep 25, 2007 at 06:09:36AM -0400, Andrew Dunstan wrote: Magnus Hagander wrote: Can you check if your manually linked version works in non-US locales? If you can't check, can you email me (offlist) with the binary (and the DLLs) and I can run a test here. If they *have* fixed the

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Chuck McDevitt
Many of us would like to see libedit ported to Windows too ;-) Yeah, it's on my (insanely long) TODO to look at sometime :-) //Magnus I've thought about working on a libedit port myself, but I don't see how that would help PostgreSQL unless the PostgreSQL community would be willing to

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Andrew Dunstan
Chuck McDevitt wrote: Many of us would like to see libedit ported to Windows too ;-) Yeah, it's on my (insanely long) TODO to look at sometime :-) //Magnus I've thought about working on a libedit port myself, but I don't see how that would help PostgreSQL unless the PostgreSQL

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Alvaro Herrera
Chuck McDevitt wrote: Many of us would like to see libedit ported to Windows too ;-) Yeah, it's on my (insanely long) TODO to look at sometime :-) //Magnus I've thought about working on a libedit port myself, but I don't see how that would help PostgreSQL unless the PostgreSQL

Re: [HACKERS] Suggestion for MSVC build

2007-09-25 Thread Magnus Hagander
Chuck McDevitt wrote: Many of us would like to see libedit ported to Windows too ;-) Yeah, it's on my (insanely long) TODO to look at sometime :-) //Magnus I've thought about working on a libedit port myself, but I don't see how that would help PostgreSQL unless the PostgreSQL community

Re: [HACKERS] Suggestion for MSVC build

2007-09-24 Thread Magnus Hagander
What version readline are you using? I tried with the latest download, and I get about 200 warnings like: 1.\src\bin\psql\tab-complete.c(600) : warning C4013: 'completion_matches' undef ined; assuming extern returning int 1.\src\bin\psql\tab-complete.c(600) : warning C4047: '=' : 'char **'

Re: [HACKERS] Suggestion for MSVC build

2007-09-24 Thread Chuck McDevitt
Hagander [mailto:[EMAIL PROTECTED] Sent: Monday, September 24, 2007 1:30 AM To: Chuck McDevitt Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Suggestion for MSVC build What version readline are you using? I tried with the latest download, and I get about 200 warnings like: 1.\src\bin

Re: [HACKERS] Suggestion for MSVC build

2007-09-24 Thread Chuck McDevitt
. -Original Message- From: Magnus Hagander [mailto:[EMAIL PROTECTED] Sent: Monday, September 24, 2007 1:30 AM To: Chuck McDevitt Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Suggestion for MSVC build What version readline are you using? I tried with the latest download

Re: [HACKERS] Suggestion for MSVC build

2007-09-24 Thread Chuck McDevitt
, 2007 1:30 AM To: Chuck McDevitt Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Suggestion for MSVC build What version readline are you using? I tried with the latest download, and I get about 200 warnings like: 1.\src\bin\psql\tab-complete.c(600) : warning C4013

[HACKERS] Suggestion for MSVC build

2007-09-23 Thread Chuck McDevitt
It seems like there isn't any good reason the perl scripts for the MSVC build don't support readline Readline for windows is available as part of the GnuWin32 project. http://gnuwin32.sourceforge.net/packages/readline.htm It normally installs to c:\Program Files\GnuWin32 I'd