On 08/16/2015 08:30 PM, Michael Paquier wrote:
On Mon, Aug 17, 2015 at 7:15 AM, Noah Misch wrote:
On Sun, Aug 16, 2015 at 05:08:56PM -0400, Andrew Dunstan wrote:
On 08/16/2015 02:23 PM, Noah Misch wrote:
-sub tapcheck
+sub tap_check
{
- InstallTemp();
+ die "Tap tests not enabled in c
On Mon, Aug 17, 2015 at 7:15 AM, Noah Misch wrote:
> On Sun, Aug 16, 2015 at 05:08:56PM -0400, Andrew Dunstan wrote:
>> On 08/16/2015 02:23 PM, Noah Misch wrote:
>> >>-sub tapcheck
>> >>+sub tap_check
>> >> {
>> >>- InstallTemp();
>> >>+ die "Tap tests not enabled in configuration"
>> >>+
On Sun, Aug 16, 2015 at 05:08:56PM -0400, Andrew Dunstan wrote:
> On 08/16/2015 02:23 PM, Noah Misch wrote:
> >>-sub tapcheck
> >>+sub tap_check
> >> {
> >>- InstallTemp();
> >>+ die "Tap tests not enabled in configuration"
> >>+ unless $config->{tap_tests};
> >I endorse Heikki's argument
On 08/16/2015 02:23 PM, Noah Misch wrote:
-sub tapcheck
+sub tap_check
{
- InstallTemp();
+ die "Tap tests not enabled in configuration"
+ unless $config->{tap_tests};
I endorse Heikki's argument for having omitted the configuration flag:
http://www.postgresql.org/message
On Fri, Aug 14, 2015 at 09:31:43AM -0400, Andrew Dunstan wrote:
> On 08/14/2015 09:27 AM, Andrew Dunstan wrote:
> >The code
> >is rearranged a little, and an incorrect piece of code setting
> >$ENV{PERL5LIB} is fixed (in the case where it was previously empty it
> >would have added a spurious ";" a
On 08/14/2015 09:27 AM, Andrew Dunstan wrote:
On 08/14/2015 03:32 AM, Noah Misch wrote:
On Thu, Aug 13, 2015 at 11:17:40AM -0400, Andrew Dunstan wrote:
here's what I propose.
This changes more than the tapcheck name and the suites it could
run. Would
you write up the changes you chose to
On 08/14/2015 03:32 AM, Noah Misch wrote:
On Thu, Aug 13, 2015 at 11:17:40AM -0400, Andrew Dunstan wrote:
here's what I propose.
This changes more than the tapcheck name and the suites it could run. Would
you write up the changes you chose to include? That will help guide review.
I don't
On Thu, Aug 13, 2015 at 11:17:40AM -0400, Andrew Dunstan wrote:
> here's what I propose.
This changes more than the tapcheck name and the suites it could run. Would
you write up the changes you chose to include? That will help guide review.
--
Sent via pgsql-hackers mailing list (pgsql-hacker
On Fri, Aug 14, 2015 at 1:18 AM, Andrew Dunstan wrote:
>
>
> On 08/13/2015 12:03 PM, Michael Paquier wrote:
>>
>> On Fri, Aug 14, 2015 at 12:17 AM, Andrew Dunstan wrote:
>>>
>>> here's what I propose.
>>
>> This patch does not take into account that there may be other code
>> paths than src/bin/ t
On 08/13/2015 12:03 PM, Michael Paquier wrote:
On Fri, Aug 14, 2015 at 12:17 AM, Andrew Dunstan wrote:
here's what I propose.
This patch does not take into account that there may be other code
paths than src/bin/ that may have TAP tests (see my pending patch to
test pg_dump with extensions in
On Fri, Aug 14, 2015 at 12:17 AM, Andrew Dunstan wrote:
> here's what I propose.
This patch does not take into account that there may be other code
paths than src/bin/ that may have TAP tests (see my pending patch to
test pg_dump with extensions including dumpable relations for
example). I guess t
On 08/01/2015 07:13 PM, Andrew Dunstan wrote:
On 08/01/2015 04:44 PM, Noah Misch wrote:
--enable-tap-tests is a reasonable configuration setting, because it's
about whether or not we have a TAP testing framework available, but I
think we should stop calling the bin tests "TAP tests" and we
On Sat, Aug 01, 2015 at 07:13:04PM -0400, Andrew Dunstan wrote:
> On 08/01/2015 04:44 PM, Noah Misch wrote:
> >>>--enable-tap-tests is a reasonable configuration setting, because it's
> >>>about whether or not we have a TAP testing framework available, but I
> >>>think we should stop calling the bi
On 08/01/2015 04:44 PM, Noah Misch wrote:
--enable-tap-tests is a reasonable configuration setting, because it's
about whether or not we have a TAP testing framework available, but I
think we should stop calling the bin tests "TAP tests" and we should
change the test name in vcregress.pl to a
On Thu, Jul 30, 2015 at 07:54:27PM -0400, Andrew Dunstan wrote:
> On 07/30/2015 12:40 PM, Andrew Dunstan wrote:
> >We should describe test sets by what they test, not by how they test. TAP
I agree with that philosophy. I also respect the practicality of grouping by
test harness as a shorthand. T
On 07/30/2015 12:40 PM, Andrew Dunstan wrote:
We should describe test sets by what they test, not by how they test.
TAP is a testing tool/protocol. The current set of tests we have test
the programs in src/bin, and we should really name the test set by a
name that reflects that, rather than
We should describe test sets by what they test, not by how they test.
TAP is a testing tool/protocol. The current set of tests we have test
the programs in src/bin, and we should really name the test set by a
name that reflects that, rather than the fact that we are using TAP
tools to run the
17 matches
Mail list logo
