Re: [HACKERS] Unnecessary #include in objectaddress.h?

2015-07-20 Thread Adam Brightwell
> I wondered whether to bother about this kind of thing for a while. It > doesn't have any practical impact immediately, because obviously > pg_list.h is still included indirectly by objectaddress.h (via lock.h in > this case IIRC). If we made some restructuring that caused the other > header not

Re: [HACKERS] Unnecessary #include in objectaddress.h?

2015-07-20 Thread Alvaro Herrera
Adam Brightwell wrote: > All, > > While looking at the include dependency graph for objectaddress.h: > > http://doxygen.postgresql.org/objectaddress_8h.html > > I saw that pg_list.h is both included and inherited (through multiple > paths) by objectaddress.h. Perhaps this doesn't matter, but I

[HACKERS] Unnecessary #include in objectaddress.h?

2015-07-20 Thread Adam Brightwell
All, While looking at the include dependency graph for objectaddress.h: http://doxygen.postgresql.org/objectaddress_8h.html I saw that pg_list.h is both included and inherited (through multiple paths) by objectaddress.h. Perhaps this doesn't matter, but I thought I would at least bring it up an