Re: [HACKERS] fixing pg_ctl with relative paths

2014-01-28 Thread Bruce Momjian
On Mon, Jul 1, 2013 at 08:10:14PM -0400, Josh Kupershmidt wrote: > On Thu, Jun 27, 2013 at 11:47 AM, Fujii Masao wrote: > > On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt > > wrote: > >> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao > >> wrote: > >>> Though this is a corner case, the patc

Re: [HACKERS] fixing pg_ctl with relative paths

2013-07-01 Thread Josh Kupershmidt
On Thu, Jun 27, 2013 at 11:47 AM, Fujii Masao wrote: > On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt wrote: >> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao wrote: >>> Though this is a corner case, the patch doesn't seem to handle properly the >>> case >>> where "-D" appears as other optio

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-27 Thread Fujii Masao
On Fri, Jun 28, 2013 at 12:47 AM, Fujii Masao wrote: > > Another corner case is, for example, pg_ctl -D test1 -o "-D test2", > that is, multiple -D specifications appear in the command-line. The patch handles this case properly. Sorry for noise.. Regards, -- Fujii Masao -- Sent via pgs

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-27 Thread Fujii Masao
On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt wrote: > On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao wrote: >> On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu wrote: >>> On June 26, 2013 5:02 AM Josh Kupershmidt wrote: Thanks for the feedback. Attached is a rebased version of the patch with

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-26 Thread Josh Kupershmidt
On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao wrote: > On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu wrote: >> On June 26, 2013 5:02 AM Josh Kupershmidt wrote: >>>Thanks for the feedback. Attached is a rebased version of the patch with >> the two small issues noted fixed. > > The following descripti

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-26 Thread Fujii Masao
On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu wrote: > On June 26, 2013 5:02 AM Josh Kupershmidt wrote: >>Thanks for the feedback. Attached is a rebased version of the patch with > the two small issues noted fixed. The following description in the document of pg_ctl needs to be modified? restar

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-25 Thread Hari Babu
On June 26, 2013 5:02 AM Josh Kupershmidt wrote: >Thanks for the feedback. Attached is a rebased version of the patch with the two small issues noted fixed. Patch is good, I marked the patch as ready for committer. Regards, Hari babu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-25 Thread Josh Kupershmidt
On Tue, Jun 25, 2013 at 2:28 AM, Hari Babu wrote: > Please find the review of the patch. Thank you for reviewing! > Code Review: > > +if (orig_post_opts) { > +post_opts = strip_datadirs(orig_post_opts); > +} > > No need of "{}" as the only one statement block is present in t

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-24 Thread Hari Babu
On January 23, 2013 9:13 AM Josh Kupershmidt wrote: >There have been some complaints[1][2] in the past about pg_ctl not playing nice with relative path specifications for the datadir. Here's a concise illustration: > > $ mkdir /tmp/mydata/ && initdb /tmp/mydata/ > $ cd /tmp/ > $ pg_ctl -D ./myda

[HACKERS] fixing pg_ctl with relative paths

2013-01-22 Thread Josh Kupershmidt
There have been some complaints[1][2] in the past about pg_ctl not playing nice with relative path specifications for the datadir. Here's a concise illustration: $ mkdir /tmp/mydata/ && initdb /tmp/mydata/ $ cd /tmp/ $ pg_ctl -D ./mydata/ start $ cd / $ pg_ctl -D /tmp/mydata/ restart IM