On Mon, Jul 1, 2013 at 08:10:14PM -0400, Josh Kupershmidt wrote:
> On Thu, Jun 27, 2013 at 11:47 AM, Fujii Masao wrote:
> > On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt
> > wrote:
> >> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao
> >> wrote:
> >>> Though this is a corner case, the patc
On Thu, Jun 27, 2013 at 11:47 AM, Fujii Masao wrote:
> On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt wrote:
>> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao wrote:
>>> Though this is a corner case, the patch doesn't seem to handle properly the
>>> case
>>> where "-D" appears as other optio
On Fri, Jun 28, 2013 at 12:47 AM, Fujii Masao wrote:
>
> Another corner case is, for example, pg_ctl -D test1 -o "-D test2",
> that is, multiple -D specifications appear in the command-line.
The patch handles this case properly. Sorry for noise..
Regards,
--
Fujii Masao
--
Sent via pgs
On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt wrote:
> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao wrote:
>> On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu wrote:
>>> On June 26, 2013 5:02 AM Josh Kupershmidt wrote:
Thanks for the feedback. Attached is a rebased version of the patch with
On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao wrote:
> On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu wrote:
>> On June 26, 2013 5:02 AM Josh Kupershmidt wrote:
>>>Thanks for the feedback. Attached is a rebased version of the patch with
>> the two small issues noted fixed.
>
> The following descripti
On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu wrote:
> On June 26, 2013 5:02 AM Josh Kupershmidt wrote:
>>Thanks for the feedback. Attached is a rebased version of the patch with
> the two small issues noted fixed.
The following description in the document of pg_ctl needs to be modified?
restar
On June 26, 2013 5:02 AM Josh Kupershmidt wrote:
>Thanks for the feedback. Attached is a rebased version of the patch with
the two small issues noted fixed.
Patch is good, I marked the patch as ready for committer.
Regards,
Hari babu
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postg
On Tue, Jun 25, 2013 at 2:28 AM, Hari Babu wrote:
> Please find the review of the patch.
Thank you for reviewing!
> Code Review:
>
> +if (orig_post_opts) {
> +post_opts = strip_datadirs(orig_post_opts);
> +}
>
> No need of "{}" as the only one statement block is present in t
On January 23, 2013 9:13 AM Josh Kupershmidt wrote:
>There have been some complaints[1][2] in the past about pg_ctl not playing
nice with relative path specifications for the datadir. Here's a concise
illustration:
>
> $ mkdir /tmp/mydata/ && initdb /tmp/mydata/
> $ cd /tmp/
> $ pg_ctl -D ./myda
There have been some complaints[1][2] in the past about pg_ctl not
playing nice with relative path specifications for the datadir. Here's
a concise illustration:
$ mkdir /tmp/mydata/ && initdb /tmp/mydata/
$ cd /tmp/
$ pg_ctl -D ./mydata/ start
$ cd /
$ pg_ctl -D /tmp/mydata/ restart
IM
10 matches
Mail list logo