Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-17 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: Peter Eisentraut wrote: Tom Lane wrote: Is this acceptable to everyone? We could name the option -u/--upgrade-compatible. If the switch is specifically for pg_upgrade

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-16 Thread Bruce Momjian
Peter Eisentraut wrote: Tom Lane wrote: Is this acceptable to everyone? We could name the option -u/--upgrade-compatible. If the switch is specifically for pg_upgrade support (enabling this as well as any other hacks we find necessary), which seems like a good idea, then don't chew

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-13 Thread Peter Eisentraut
Tom Lane wrote: Is this acceptable to everyone? We could name the option -u/--upgrade-compatible. If the switch is specifically for pg_upgrade support (enabling this as well as any other hacks we find necessary), which seems like a good idea, then don't chew up a short option letter for it.

[HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Bruce Momjian
bruce wrote: Peter Eisentraut wrote: Bruce Momjian wrote: Now that pg_migrator is BSD licensed, and already in C, I am going to spend my time trying to improve pg_migrator for 8.4: http://pgfoundry.org/projects/pg-migrator/ What is the plan now? Get pg_upgrade working, get

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I can think of three possible solutions, all involve recreating and dropping the dropped column in the new schema: (4) add a switch to pg_dump to include dropped columns in its schema output and then drop them. This seems far more maintainable than

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I can think of three possible solutions, all involve recreating and dropping the dropped column in the new schema: (4) add a switch to pg_dump to include dropped columns in its schema output and then drop them. This seems far more

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Tom Lane wrote: (4) add a switch to pg_dump to include dropped columns in its schema output and then drop them. This seems far more maintainable than writing separate code that tries to parse the output. I assume I would also drop the column in the

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Joshua D. Drake
On Thu, 2009-02-12 at 13:39 -0500, Tom Lane wrote: Right, that's what I meant --- do all the work within pg_dump. Is this acceptable to everyone? We could name the option -u/--upgrade-compatible. If the switch is specifically for pg_upgrade support (enabling this as well as any other

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: (4) add a switch to pg_dump to include dropped columns in its schema output and then drop them. This seems far more maintainable than writing separate code that tries to parse the output. I assume I would also

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Bruce Momjian
Joshua D. Drake wrote: On Thu, 2009-02-12 at 13:39 -0500, Tom Lane wrote: Right, that's what I meant --- do all the work within pg_dump. Is this acceptable to everyone? We could name the option -u/--upgrade-compatible. If the switch is specifically for pg_upgrade support

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On Thu, 2009-02-12 at 13:39 -0500, Tom Lane wrote: a long form only. And probably not even list it in the user documentation. Why wouldn't we want to list it? Because it's for internal use only. Although the effect we're discussing here is

Re: [HACKERS] pg_migrator and handling dropped columns

2009-02-12 Thread Bruce Momjian
Tom Lane wrote: Joshua D. Drake j...@commandprompt.com writes: On Thu, 2009-02-12 at 13:39 -0500, Tom Lane wrote: a long form only. And probably not even list it in the user documentation. Why wouldn't we want to list it? Because it's for internal use only. Although the effect