Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/04/2012 02:25 PM, Andrew Dunstan wrote: On 09/04/2012 10:42 AM, Alvaro Herrera wrote: Somehow the verbose reporting of user relation files being copied does not seem exceedingly useful; and I don't remember seeing that on Linux. Yeah, and it does something odd anyway when it's not

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/04/2012 10:42 AM, Alvaro Herrera wrote: Somehow the verbose reporting of user relation files being copied does not seem exceedingly useful; and I don't remember seeing that on Linux. Yeah, and it does something odd anyway when it's not writing to a terminal. Can we get rid of it, or

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/04/2012 11:21 AM, Tom Lane wrote: Andrew Dunstan writes: This is a test script, not what you should use in production. I don't see any reason why we shouldn't require Perl for running the standard test. But on the third hand ... we've taken pains to ensure that you don't *have* to have

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/04/2012 10:49 AM, Bruce Momjian wrote: On Tue, Sep 4, 2012 at 11:42:58AM -0300, Alvaro Herrera wrote: Excerpts from Andrew Dunstan's message of mar sep 04 01:16:39 -0300 2012: And here's the first Windows buildfarm check of pg_upgrade.

Re: [HACKERS] pg_upgrade del/rmdir path fix

Andrew Dunstan writes: > This is a test script, not what you should use in production. I don't > see any reason why we shouldn't require Perl for running the standard test. But on the third hand ... we've taken pains to ensure that you don't *have* to have Perl to build from a tarball, and I thi

Re: [HACKERS] pg_upgrade del/rmdir path fix

On Tue, Sep 4, 2012 at 11:12:52AM -0400, Andrew Dunstan wrote: > > On 09/04/2012 10:49 AM, Bruce Momjian wrote: > >On Tue, Sep 4, 2012 at 11:42:58AM -0300, Alvaro Herrera wrote: > >>Excerpts from Andrew Dunstan's message of mar sep 04 01:16:39 -0300 2012: > >> > >>>And here's the first Windows b

Re: [HACKERS] pg_upgrade del/rmdir path fix

Bruce Momjian writes: > On Tue, Sep 4, 2012 at 11:42:58AM -0300, Alvaro Herrera wrote: >> Who's going to work now on porting the shell script to Perl? ;-) > Well, we require Perl for development, but not for usage, at least not > yet. This is a regression-test script, so that complaint doesn't

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/04/2012 10:42 AM, Alvaro Herrera wrote: Excerpts from Andrew Dunstan's message of mar sep 04 01:16:39 -0300 2012: And here's the first Windows buildfarm check of pg_upgrade.

Re: [HACKERS] pg_upgrade del/rmdir path fix

On Tue, Sep 4, 2012 at 11:42:58AM -0300, Alvaro Herrera wrote: > Excerpts from Andrew Dunstan's message of mar sep 04 01:16:39 -0300 2012: > > > And here's the first Windows buildfarm check of pg_upgrade. > >

Re: [HACKERS] pg_upgrade del/rmdir path fix

Excerpts from Andrew Dunstan's message of mar sep 04 01:16:39 -0300 2012: > And here's the first Windows buildfarm check of pg_upgrade. > Great, thanks. Who's going to work now on p

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/03/2012 11:05 PM, Andrew Dunstan wrote: On 09/03/2012 10:41 PM, Bruce Momjian wrote: On Mon, Sep 3, 2012 at 02:30:18PM -0400, Andrew Dunstan wrote: Here is a patch against 9.2 sources (it applies with offsets to HEAD too) to fix the problem that pg_upgrade can write paths in arguments

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/03/2012 10:41 PM, Bruce Momjian wrote: On Mon, Sep 3, 2012 at 02:30:18PM -0400, Andrew Dunstan wrote: Here is a patch against 9.2 sources (it applies with offsets to HEAD too) to fix the problem that pg_upgrade can write paths in arguments for Windows builtin commands (specifically DEL a

Re: [HACKERS] pg_upgrade del/rmdir path fix

On Mon, Sep 3, 2012 at 02:30:18PM -0400, Andrew Dunstan wrote: > Here is a patch against 9.2 sources (it applies with offsets to HEAD > too) to fix the problem that pg_upgrade can write paths in arguments > for Windows builtin commands (specifically DEL and RMDIR) with the > wrong path separator s

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/03/2012 04:32 PM, Tom Lane wrote: Andrew Dunstan writes: OK, revised patch attached. Looks good to me. OK. I will try to get the test script wrapped up tonight or tomorrow, that's the only thing left. cheers andrew -- Sent via pgsql-hackers mailing lis

Re: [HACKERS] pg_upgrade del/rmdir path fix

Andrew Dunstan writes: > OK, revised patch attached. Looks good to me. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/03/2012 03:22 PM, Tom Lane wrote: Andrew Dunstan writes: This time with a patch. Nitpicky gripe: "fix_path" is a mighty generic name. How about "fix_path_for_windows" or something like that? I don't think I'd mark it inline, either. More generally, the behavior of combining two (mayb

Re: [HACKERS] pg_upgrade del/rmdir path fix

Andrew Dunstan writes: > This time with a patch. Nitpicky gripe: "fix_path" is a mighty generic name. How about "fix_path_for_windows" or something like that? I don't think I'd mark it inline, either. More generally, the behavior of combining two (maybe) filename segments seems overcomplicated

Re: [HACKERS] pg_upgrade del/rmdir path fix

On 09/03/2012 02:30 PM, Andrew Dunstan wrote: Here is a patch against 9.2 sources (it applies with offsets to HEAD too) to fix the problem that pg_upgrade can write paths in arguments for Windows builtin commands (specifically DEL and RMDIR) with the wrong path separator style. This should be

[HACKERS] pg_upgrade del/rmdir path fix

Here is a patch against 9.2 sources (it applies with offsets to HEAD too) to fix the problem that pg_upgrade can write paths in arguments for Windows builtin commands (specifically DEL and RMDIR) with the wrong path separator style. This should be applied all the way back to 9.0. cheers andre