I reviewed a couple patched, and I added my review to the commitfest page.
If I find a problem, its obvious I should mark the patch as returned with
feedback.
But what if I'm happy with it? I'm not a hacker so cannot do C code review, should I
leave it alone? Mark it as ready for
Em 16-01-2011 16:30, Andy Colson escreveu:
I reviewed a couple patched, and I added my review to the commitfest page.
If I find a problem, its obvious I should mark the patch as returned
with feedback.
But what if I'm happy with it? I'm not a hacker so cannot do C code
review, should I leave
On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson a...@squeakycode.net wrote:
I reviewed a couple patched, and I added my review to the commitfest page.
If I find a problem, its obvious I should mark the patch as returned with
feedback.
Only if it's got sufficiently serious flaws that getting it
On Thu, Jan 13, 2011 at 4:54 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas robertmh...@gmail.com wrote:
[ abject plea for reviewers ]
[ second abject please for reviewers ]
OK, I believe I've sent an off-list email to everyone who volunteered
to
On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas robertmh...@gmail.com wrote:
[ abject plea for reviewers ]
So far I have 6 people who have volunteered to be round-robin
reviewers, and 7 people who are listed as reviewers on the CF site
already. That leaves 45 patches without a reviewer, plus
So far I have 6 people who have volunteered to be round-robin
reviewers, and 7 people who are listed as reviewers on the CF site
already. That leaves 45 patches without a reviewer, plus whatever
comes in in the next day or so. This is not going to work unless a
lot more people pitch in.
We have 46 patches in this CommitFest so far and I know that there are
quite a few patches that have been posted but not added to the
CommitFest application yet (please fix this, if you are a patch author
who has failed to do this) and that there will be lots more patches
posted over the next few
