Re: [HACKERS] Adding \ev view editor?

2010-02-23 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Robert Haas wrote: > > On Tue, Feb 23, 2010 at 12:43 AM, Bruce Momjian wrote: > > > >> Is this a TODO? > >> > > > > Sounds good to me. > > > > > > I think it would be useful if we put line breaks in the column list it > gets, otherwise not so much for any

Re: [HACKERS] Adding \ev view editor?

2010-02-23 Thread Andrew Dunstan
Robert Haas wrote: On Tue, Feb 23, 2010 at 12:43 AM, Bruce Momjian wrote: Is this a TODO? Sounds good to me. I think it would be useful if we put line breaks in the column list it gets, otherwise not so much for any view with more than a handful of columns. That's where we c

Re: [HACKERS] Adding \ev view editor?

2010-02-23 Thread Robert Haas
On Tue, Feb 23, 2010 at 12:43 AM, Bruce Momjian wrote: > Is this a TODO? Sounds good to me. >> It doesn't seem like it would be that difficult to add a view editor as >> \ev. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Adding \ev view editor?

2010-02-22 Thread Bruce Momjian
Is this a TODO? --- Josh Berkus wrote: > All, > > I've grown to adore the new \ef function editor. > > It doesn't seem like it would be that difficult to add a view editor as > \ev. While editors would also be good for ot

Re: [HACKERS] Adding \ev view editor?

2009-09-23 Thread daveg
On Mon, Sep 21, 2009 at 02:26:05PM -0400, Andrew Dunstan wrote: >andrew=# select pg_get_viewdef('foo',true); >pg_get_viewdef >-- > SELECT 'a'::text AS b, > ( SELECT 1 >FROM dual) AS x, > random() AS

Re: [HACKERS] Adding \ev view editor?

2009-09-21 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan writes: Tom Lane wrote: That's not what I had in mind by "decoupling" the option's effects. Well, regardless of that it does what I want, and with a fairly small amount of code. Well, yeah, because you are paying no mind to what anyo

Re: [HACKERS] Adding \ev view editor?

2009-09-21 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> That's not what I had in mind by "decoupling" the option's effects. > Well, regardless of that it does what I want, and with a fairly small > amount of code. Well, yeah, because you are paying no mind to what anyone else might want. > I can make it w

Re: [HACKERS] Adding \ev view editor?

2009-09-21 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan writes: Tom Lane wrote: It might be worth pointing out that what I don't want pg_dump doing is suppressing "useless" parentheses. Adding whitespace ought to be safe enough. So if anyone wanted to do the work of decoupling those two effects of the pret

Re: [HACKERS] Adding \ev view editor?

2009-09-21 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> It might be worth pointing out that what I don't want pg_dump doing >> is suppressing "useless" parentheses. Adding whitespace ought to be >> safe enough. So if anyone wanted to do the work of decoupling those >> two effects of the prettyprint option,

Re: [HACKERS] Adding \ev view editor?

2009-09-21 Thread Andrew Dunstan
Tom Lane wrote: It might be worth pointing out that what I don't want pg_dump doing is suppressing "useless" parentheses. Adding whitespace ought to be safe enough. So if anyone wanted to do the work of decoupling those two effects of the prettyprint option, we could have "semi pretty printed

Re: [HACKERS] Adding \ev view editor?

2009-09-02 Thread Tom Lane
Andrew Dunstan writes: > David E. Wheeler wrote: >> Is there any reason that the CREATE VIEW output to pg_dump and, >> presumably, \ev, couldn't be refactored to pretty-print the VIEW >> declaration? > Tom just said a day or two ago that he doesn't want pg_dump using any > pretty printing, and

Re: [HACKERS] Adding \ev view editor?

2009-09-02 Thread Andrew Dunstan
David E. Wheeler wrote: On Sep 2, 2009, at 5:07 AM, Merlin Moncure wrote: One reason I don't like this proposal is that postgresql does not preserve the original 'create view' statement for editing. The resulting sql that is given to you to edit is hopelessly mangled and I think it's not goo

Re: [HACKERS] Adding \ev view editor?

2009-09-02 Thread David E. Wheeler
On Sep 2, 2009, at 5:07 AM, Merlin Moncure wrote: One reason I don't like this proposal is that postgresql does not preserve the original 'create view' statement for editing. The resulting sql that is given to you to edit is hopelessly mangled and I think it's not good to encourage people to mo

Re: [HACKERS] Adding \ev view editor?

2009-09-02 Thread Merlin Moncure
On Tue, Sep 1, 2009 at 2:41 PM, Josh Berkus wrote: > All, > > I've grown to adore the new \ef function editor. > > It doesn't seem like it would be that difficult to add a view editor as > \ev.  While editors would also be good for other objects, I don't think > we can do \et or \er etc. because th

Re: [HACKERS] Adding \ev view editor?

2009-09-02 Thread Dimitri Fontaine
Hi, Peter Eisentraut writes: > On tis, 2009-09-01 at 11:41 -0700, Josh Berkus wrote: >> Opinions? Other objects which could take \e? > > All of them. Well, I'd vote against \e table. Are you going to propose the CREATE TABLE statement and have magics to produce the ALTER TABLE that would resor

Re: [HACKERS] Adding \ev view editor?

2009-09-01 Thread Peter Eisentraut
On tis, 2009-09-01 at 11:41 -0700, Josh Berkus wrote: > Opinions? Other objects which could take \e? All of them. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding \ev view editor?

2009-09-01 Thread Andrew Dunstan
Josh Berkus wrote: All, I've grown to adore the new \ef function editor. It doesn't seem like it would be that difficult to add a view editor as \ev. While editors would also be good for other objects, I don't think we can do \et or \er etc. because those objects don't support CREATE OR REPL

Re: [HACKERS] Adding \ev view editor?

2009-09-01 Thread David Fetter
On Tue, Sep 01, 2009 at 11:41:31AM -0700, Josh Berkus wrote: > All, > > I've grown to adore the new \ef function editor. > > It doesn't seem like it would be that difficult to add a view editor as > \ev. While editors would also be good for other objects, I don't think > we can do \et or \er etc