Re: [Pharo-dev] Test and Patch for writeStream error

On Tuesday 18 April 2017 10:51 PM, Alistair Grant wrote: 1. This is assuming that ensureEndsWith: is only used for strings, but the implementation doesn't assume that (I tested it with an Array and it was fine). 2. If you look at existing senders of ensureEndsWith: they check that the string

Re: [Pharo-dev] Test and Patch for writeStream error

On Tuesday 18 April 2017 09:17 PM, Blondeau Vincent wrote: Hi, Thanks for reporting! If you want to contribute and have your fix integrated, I advise you to follow the procedure here: http://pharo.org/contribute-propose-fix Thanks. I opened an issue and posted my fix for review at:

Re: [Pharo-dev] Test and Patch for writeStream error

On Tue, Apr 18, 2017 at 10:39:34PM +0530, K K Subbu wrote: > On Tuesday 18 April 2017 09:51 PM, Alistair Grant wrote: > >This appears to be changing the meaning of #ensureEndsWith:. > >The previous meaning was that it always ends with the supplied object. > > The method name is ambiguous. If the

Re: [Pharo-dev] Test and Patch for writeStream error

On Tuesday 18 April 2017 09:51 PM, Alistair Grant wrote: This appears to be changing the meaning of #ensureEndsWith:. The previous meaning was that it always ends with the supplied object. The method name is ambiguous. If the collection is empty does it need an "ending"? All its senders use

Re: [Pharo-dev] Test and Patch for writeStream error

Hi Subbu, On Tue, Apr 18, 2017 at 09:04:00PM +0530, K K Subbu wrote: > Hi, > > I stumbled on an error in WriteStream>>ensureEndsWith: method. The error > caused extra blank lines in logs. > > Attached small changeset fixes it. It also adds a test to catch such errors > in the future. With this

Re: [Pharo-dev] Commenting the Session Manager

hi Guille, Thanks very much for that detailed write up. I have one concern about the [bracketed] text... A new session starts when the image starts [or when the image is saved]. A session ends when the image quits [or it is saved]. Doing the following in a playground... s1 :=

Re: [Pharo-dev] Test and Patch for writeStream error

Hi, Thanks for reporting! If you want to contribute and have your fix integrated, I advise you to follow the procedure here: http://pharo.org/contribute-propose-fix If you need help, don't hesitate to reply! Regards, Vincent > -Message d'origine- > De : Pharo-dev

[Pharo-dev] Test and Patch for writeStream error

Hi, I stumbled on an error in WriteStream>>ensureEndsWith: method. The error caused extra blank lines in logs. Attached small changeset fixes it. It also adds a test to catch such errors in the future. With this fix, ./pharo generator.image PharoVMSpur32Builder buildUnix32 gives a compact

Re: [Pharo-dev] Iceberg and git repository management

Hi Peter, It will be possible and is already doable but with no ui support. You can use these messages: iceRepository contentOfFileNamed: 'relative/path/from/git/repo/root’ commit: repository headCommit id iceRepository saveContent: ‘bla’ inWorkingCopyFile:

Re: [Pharo-dev] Please, test our 64bits builds

Hi Estaban, I've started working with this version and seems to be working ok. Just a minor detail with the zeroconf stuff, It still shows the 32 bits libraries notice when you download the image and vm: On a 64-bit system? You must install the 32-bit libraries Try `sudo aptitude install

Re: [Pharo-dev] Epicea should ask before recovering

Hi Martin. 2017-04-18 0:22 GMT+02:00 Martin Dias : > You can disable it: World Menu > Settings > Tools > Epicea > Detect lost > events on start up Idea to not disable it but to show notification about lost changes with button to open changes browser. It should remove

Re: [Pharo-dev] Missing VMMaker repo in Pharo 6

On Tue, Apr 18, 2017 at 1:57 PM, K K Subbu wrote: > On Monday 17 April 2017 11:52 PM, Cyril Ferlicot D. wrote: > > StartupPreferencesLoader default >> addAtStartupInGeneralPreferenceFolder: >> {(StartupAction >>