Re: [Pharo-project] What are the messages where we should always have a super send?

2013-01-22 Thread Stéphane Ducasse
On Jan 22, 2013, at 7:19 AM, Jan Vrany wrote: > Hi, > > On 19/01/13 10:16, Stéphane Ducasse wrote: >> Hi jan >> >> do you have an example of such tagging? > > Look at > > RBTranslateLiteralsInMenusRule class>>tagsBasic, > RBNilOrEmptyCollectionReplaceRule, > RBMethodSourceContainsLinefeedRule

Re: [Pharo-project] What are the messages where we should always have a super send?

2013-01-22 Thread Stéphane Ducasse
> Yes, #setUp and #tearDown Really. Ok I was not aware of it. Good idea. Stef > For #initialize, having a super may not be that necessary if you working on > the class side. > > Alexandre > > > On Jan 18, 2013, at 12:06 PM, Stéphane Ducasse > wrote: > >> Hi >> >> While looking at SmallL

Re: [Pharo-project] What are the messages where we should always have a super send?

2013-01-22 Thread Jan Vrany
Hi, On 19/01/13 10:16, Stéphane Ducasse wrote: Hi jan do you have an example of such tagging? Look at RBTranslateLiteralsInMenusRule class>>tagsBasic, RBNilOrEmptyCollectionReplaceRule, RBMethodSourceContainsLinefeedRule, RBTempsReadBeforeWrittenRile RBLawOfDemeterRule RBContainsNamespaceIde

Re: [Pharo-project] What are the messages where we should always have a super send?

2013-01-19 Thread Stéphane Ducasse
Hi jan do you have an example of such tagging? Right now we are also thinking that we want three kinds of rules - 1 whose result is either zero because there is no problem or zero because we flag the false positives - 2 more fuzzy one where we should have flase positive defined pe

Re: [Pharo-project] What are the messages where we should always have a super send?

2013-01-18 Thread Alexandre Bergel
Yes, #setUp and #tearDown For #initialize, having a super may not be that necessary if you working on the class side. Alexandre On Jan 18, 2013, at 12:06 PM, Stéphane Ducasse wrote: > Hi > > While looking at SmallLint rule, I saw a rule that ensures that a given > method always performs a

Re: [Pharo-project] What are the messages where we should always have a super send?

2013-01-18 Thread Jan Vrany
Hi Stef, while massaging SmallLint rules, you should also have look at Smalltalk/X version of SmallLint [1] as we have ported Pharo version and improved some rules. I have also added a tagging system. That's useful for some rules are only good if you want to ensure portable code, some are simply

[Pharo-project] What are the messages where we should always have a super send?

2013-01-18 Thread Stéphane Ducasse
Hi While looking at SmallLint rule, I saw a rule that ensures that a given method always performs a super send. Here is the current list: ^#(#release #postCopy #preBuildWith: #postOpenWith: #noticeOfWindowClose: #initialize postBuildWith:) and I'm cleaning the list because there a