Hi!
> Log:
> Implement phase 1 of rfc/incompat_ctx
>
> Just changing the error level of the message from E_STRICT to
> E_DEPRECATED. This comes one version later than the timeline
> mentioned in the RFC.
Please add it to UPGRADING and NEWS.
--
Stanislav Malyshev, Software Architect
SugarCRM:
Hi!
> May I cherry pick the commit? Or
> could you merge it to 5.5.3 branch?
5.5.3 is for fixing one specific problem - UMR in openssl fix. So I
don't think we should add more code to it, I think it'd be fine to get
this in a scheduled 5.5.4 release.
--
Stanislav Malyshev, Software Architect
Su
Hi!
> Commit:a831499b4a1029118dc45375e62af42043110ade
> Author:Xinchen Hui Tue, 6 Aug 2013 15:37:20
> +0800
> Parents: 47d66a0b4ea83bc4e1c9bfaa5c478cd42e28337c
> Branches: PHP-5.4 PHP-5.5 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=a831499b4a102
Hi!
> Something like the following? (it wasn't tested)
>
>
> #define ACCELERATOR_VERSION_BASE "7.0.3"
> #define ACCELERATOR_VERSION_SUFFIX "-dev"
>
> #iif PHP_EXTRA_VERSION
> # define ACCELERATOR_VERSION ACCELERATOR_VERSION_BASE
> ACCELERATOR_VERSION_SUFFIX
> #else
> # define ACCELERATOR_VERSIO
Hi!
> I agree, this "-dev" suffix is annoying in PHP releases.
> However, I don't see a simple way to avoid it.
Can we reuse PHP_EXTRA_VERSION from php_version.h? This was dev code
will keep -dev, but releases would have no suffix. RCs would be marked
as RC but that shouldn't be a big problem I t
Hi!
> Please add a note to UPGRADING as well.
>
> Thanks!
I understand UPGRADING still not updated? Could you please update it?
> Cheers,
>
> On Fri, May 17, 2013 at 12:18 AM, Sara Golemon wrote:
>> Commit:cfd104582220d578ab1b78a5991065d038e1f931
>> Author:Sara Golemon Thu, 1
Hi!
> I probably futs that all up, but the fixes are now in 5.4 and 5.5
> branches. I guess the norm is to commit to the lowest branch and merge
> upwards :?
I've merged up the changes, could you check out 5.4, 5.5 and master and
verify that the code changes are correct?
--
Stanislav Malyshev,
Hi!
> I probably futs that all up, but the fixes are now in 5.4 and 5.5
> branches. I guess the norm is to commit to the lowest branch and merge
> upwards :?
Yes, this is usually how it is done. Thanks, I'll check if the branches
are in sync.
--
Stanislav Malyshev, Software Architect
SugarCRM
Hi!
> Commit:0e2bcf3373d914a215784c041a2a4c3b6afc2034
> Author:Stanley Sufficool Fri, 31 May 2013
> 22:53:08 -0700
> Parents: d22c7368e77d3da464e66898e96c0457b6f2d672
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=0e2bcf3373d914a215784c
Hi!
> Imho this should have been briefly discussed on internals beforehand. At
> least to me this seems rather dubious (why is it needed? why are you
> manually parsing a part of the DLL serialization?) and also clashes with
> Stas' proposed changes to unserialize.
I don't remember any discussion
Hi!
> Log:
> Fix bug #64729: compilation failure on x32
Could you explain this patch? I regularly compile PHP on both 32-bit and
64-bit platforms and never had any errors. Is it some special version of
the compiler? Some particular OS?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://
Hi!
> Are you sure about this change?
> Because this actually changes the semantics of the code. The following piece
> of code will now evaluate differently than before:
> *p <= ' '
I also don't understand this change - this means 0xFF would now be
skipped as space while before it was not. Is it
Hi!
> replacing
> void main() {}
> with
> int main() {return 0;}
> solves the problem for me.
Ah, well, yes, you're right - the return value... I'll fix it.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.
Hi!
> The issue is that a warning wouldn't destroy that object. That object will
> occasionally segfault PHP. E_ERROR is the simplest solution which doesn't
> change the behavior of the normal operations.
Can't we just reset the object data to some known "zero" state? Having
E_ERROR in a function
Hi!
> + if (!php_date_initialize_from_hash(&return_value, &dateobj, myht
> TSRMLS_CC)) {
> + php_error(E_ERROR, "Invalid serialization data for DateTime
> object");
> + }
Why this is E_ERROR? Can't we recover from this problem? Bad
serialization data is E_NOTICE for unserial
Hi!
> - Core:
> + . Added Zend Optimizer+ extension and enable it by default. More details
> here:
> +https://wiki.php.net/rfc/optimizerplus. (Dmitry)
I think building it is enabled by default, but extension itself isn't?
Am I wrong?
--
Stanislav Malyshev, Software Architect
SugarCRM: ht
Hi!
> Commit:92430bcf5dd76bf9b12363693efcc471b3527618
> Author:Dmitry Stogov Sat, 16 Mar 2013 16:08:11
> +0400
> Parents: ac05e68f5523a2cd1b4972f43188e65c29ef4ae4
> Branches: PHP-5.5 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=92430bcf5dd76bf9b1
Hi!
> Commit:e9641141aaad136757af06fddd6d870147ac2000
> Author:Dmitry Stogov Sat, 16 Mar 2013 16:11:00
> +0400
> Parents: 92430bcf5dd76bf9b12363693efcc471b3527618
> Branches: PHP-5.5 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=e9641141aaad136757
Hi!
> +- Phar:
> + . Fixed timestamp update on Phar contents modification. (Dmitry)
Is that an old fix already included in 5.3/5.4? What is the commit/bug
number for it?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing Li
Hi!
> - if (d > LONG_MAX) {
> + if (d >= LONG_MAX) {
> return (long)(unsigned long) d;
> }
> return (long) d;
Could you please explain this one? I thought LONG_MAX is a largest
permissible long value, why when d==LONG_MAX we need to convert?
Also, why this patch
Hi!
> Commit:62059c16ee2f2802caa00f2aad2fa44c867dd1f1
> Author:Xinchen Hui Mon, 14 Jan 2013 16:23:22
> +0800
> Parents: fe27146b1b533e046e9a5841bb6e5685296208a8
> Branches: PHP-5.5
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=62059c16ee2f2802caa00f2aad2
Hi!
Doesn't change of zend_objects_API.h change binary API? I'm not sure we
can do it in 5.4.
On 1/8/13 11:30 PM, Dmitry Stogov wrote:
> Commit:f9e8678dd3a41ed8a100d8201153a41d6fd25f2e
> Author:Dmitry Stogov Wed, 9 Jan 2013 11:30:50
> +0400
> Parents: f3b1b8516906fe900e521216c
Hi!
>
>
> On 12/25/2012 05:45 PM, Pierrick Charron wrote:
>> Commit:fad960a4045da86cdbd8308a165ffc47892f05b9
>> Author:Pierrick Charron Tue, 25 Dec 2012
>> 20:45:24 -0500
>> Parents: a2b6d9c1047a4e5f3419ebc3489a66d62aa12d07
>> Branches: PHP-5.3 PHP-5.4 PHP-5.5 master
>>
>> L
Hi!
> a couple of compilers or analyzers are confused by this macro, not
> sure why, but reducing the noises at no cost help to get a better view
> in future checks.
There is a cost - now we have both zend_error_noreturn and return
statements, which is unneeded. If we say zend_error_noreturn does
Hi!
> Zend/zend_generators.c:734: warning: control reaches end of non-void function
>
> yes it's nothing difference , just make the compiler happy
zend_error_noreturn already supposed to do that. Why it does not do it
in your case? Which compiler do you use?
--
Stanislav Malyshev, Software Arc
Hi!
> Commit:9fb5cfdeb1f13f2e3ab3751494cdd366bc78cb38
> Author:Xinchen Hui Fri, 14 Dec 2012 17:21:43
> +0800
> Parents: 359d91a80756cd9a9ce945c0e3aa1d2038633e7a
> Branches: PHP-5.5
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=9fb5cfdeb1f13f2e3ab3751494c
Hi!
>> Why removing tests and not putting them as XFAIL?
>
> There is no platfrom specific XFAIL. I asked if we could add that to
> run-tests some time ago, that would be very handy.
Yes, looks like it. I'll try to look into in on the weekend and see if I
can figure out how to add it. Maybe we s
Hi!
> Commit:94cbd6374adcb3e2ac15303dd47a212953f93e98
> Author:Anatoliy Belsky Wed, 5 Dec 2012 09:55:49
> +0100
> Parents: 31ab57e052925305008c20e787f514c159d3469d
> Branches: PHP-5.3 PHP-5.4 PHP-5.5 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=9
Hi!
> +class Base {
> +const DUMMY = "XXX";
> +public function foo($var=TEST, $more=null) { return true; }
> +public function bar($var, $more=self::DUMMY) { return true; }
> +}
> +
> +class Child extends Base {
> +const DUMMY = "DDD";
> +public function foo($var=TEST) { return
Hi!
> Commit:188c124a57a27e3d6baf786608a45d713d4595f6
> Author:Lars Strojny Wed, 19 Sep 2012 22:17:35
> +0200
> Parents: ee172ce3cc65b5cb8ec49020c9579d108aca9ea1
> Branches: PHP-5.4
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=188c124a57a27e3d6baf786608
Hi!
> +typedef enum {
> + SUCCESS = 0,
> + FAILURE = -1, /* this MUST stay a negative number, or it may
> affect functions! */
> +} RESULT_CODE;
If you use a type here, I'd suggest using zend_ prefix since otherwise
you just stomp on another (frequently used) global symbol.
--
Hi!
> Commit:170ee90bf962d288bdcf6cf0c8c4a2a30c5c1ba2
> Author:Xinchen Hui Thu, 2 Aug 2012 22:28:04
> +0800
> Parents: 3b5defd3b09bf827239087126261ce9abdc13d09
> Branches: PHP-5.4
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=170ee90bf962d288bdcf6cf0c8c4
Hi!
> Commit:45d596ea1e32792c7b7b7f28be220dea861b6708
> Author:Florian Anderiasch Tue, 24 Jul 2012
> 13:15:16 +0200
> Parents: dd9d64b21e4bbc8a106a6156dc6ffefbcc33ec02
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=45d596ea1e32792c7b7b7
Hi!
> I wonder if anybody can suggest a way to detect such commits
> automatically so we can catch them. `git diff` and others show nothing
> of relevance.
We could get some commit that is only in master (like NEWS edits, for
example) and check for it - if it's ever pushed into 5.4 that's trouble
Hi!
On 7/24/12 5:15 PM, Johannes Schlüter wrote:
> Branch: PHP-5.4
> Deleted commits count: 2298
> User: Johannes Schlüter Wed, 25 Jul 2012 00:15:30
> +
>
What does this push do?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
Hi!
> Shouldn't the ticket be reopened then?
The revert is only for release version, 5.4 branch still has it fixed.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://
Hi!
> I think that's overly cautious given the simplicity of the problem and the
> fix, but it's your call.
>
> But even as a matter of principle, I don't know why you'd need a new RC in
> one case, but not in the other. You'd have a release different from the
Because revert means going b
Hi!
> Commit:b47d6b32ba8d6dc1b9d1fc91a83eef29a28363c5
> Author:Reeze Xia Tue, 17 Jul 2012 23:01:20
> +0800
> Committer: Gustavo André dos Santos Lopes Tue, 17
> Jul 2012 23:08:11 +0200
> Parents: d0e58bf6eb54676a711d98d3b72a13e828e2deef
> Branches: PHP-5.4 master
>
> L
Hi!
> I think this also needs an update of the patch file. Or did I overlook
> that somewhere?
Ah, yes, probably. But I'm not sure how to properly do it. Any takers?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (h
Hi!
> I'm not sure that this change is right. As it is now one could no
> longer pass in "123" (as a string) or 123.0 (as a float) as
> limit/offset. This goes against usual PHP semantics.
I agree, this:
>> - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
>> "O|ll", &
Hi!
> Ok. I don 't have a MSVC setup handy. Can you please test if replacing that
> line with 'idx = 0 - idx;' fixes the warnings for you?
Seems to do the trick. Is 0- same as - for unsigned on all compilers (I
know common sense says it should be but when compilers are concerned
it's better to b
Hi!
>> Commit:91ce8041a3e85594e81466a528f8d55cdc164c1f
>> Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40
>> -0400
>> Parents: be4053cea0462c9de5396641f4e4fa2f56f5a675
>> Branches: PHP-5.4
>>
>> Link:
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=91ce8041a3e85594e81466
Hi!
Could you please explain this commit? idx is ulong, why this change
improves anything?
> Commit:91ce8041a3e85594e81466a528f8d55cdc164c1f
> Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400
> Parents: be4053cea0462c9de5396641f4e4fa2f56f5a675
> Branches: PHP-5.4
>
> Link:
Hi!
>
> I hope you picked this function name to fuel the "PHP is so
> inconsistent" lovers. Could I suggest picking something a little less
> a) different from everything else, and b) different from *everything*
> else?
>
I think function name should be changed, and also all these big changes
Hi!
> this wasn't merged into master. I'm not sure whether it should be
> "NULL-merged" so the code is kept in master or whether it should be
> removed from master, too.
yeah, was busy. Will do later.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext
Hi!
> I checked with Stas and he said ok for 5.4.
Looks like there's a disagreement about this one and whether it should
be in hash or openssl, so I'll revert this for now from 5.4 and after we
discuss it on internals and decide where we want it, we'll decide where
it goes. Sorry for misunderstan
Hi!
> Commit:b5b8ea1050837fba5a6cee55e41b4574ed64158e
> Author:Scott MacVicar Mon, 11 Jun 2012
> 00:16:30 -0700
> Parents: a18cede1c5094d5255daeb99cd6debe09938399d
> Branches: PHP-5.4
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=b5b8ea1050837fba5a6cee55
Hi!
> Log:
> NEWS entry for boolval()
What about UPGRADING?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Hi!
> +- MessageFormatter::format() and related functions now don't error out when
> + an insufficient argument count is provided. Instead, the placeholders will
> + remain unsubstituted.
Is it how ICU behaves?
> +- The intl extension now requires ICU 4.0+.
Not all Linux distros still on 4.0
Hi!
> in the zend_error->php_error_cb, it will rebuild the
> active_symbol_table(if it is not built), which will change the
> execute_data->CVs[0] . then ~
Hmmm... changing CVs when there are active pointers to them may be
pretty bad idea. I think this fix does not fix the actual problem, only
h
Hi!
> Hi:
>this bug is kind of a serious one, since it's behavior wrongly.
>
>so maybe this one should merged to 5.3 and 5.4 branch..
Could you explain why the change you did fixes the bug? Why does it
matter where zend_error is called?
--
Stanislav Malyshev, Software Architect
SugarCR
Hi!
>> I'm not sure this is a good idea - output buffers can include output
>> functions IIRC, but you have already shut down modules. I would be very,
> Stas, they are request shutdown, not module shutdown :)
Request shutdown IIRC destroys functions and module's per-request data
structures, whic
Hi!
> Hi:
>you may want to review this patch.
>
>I have make sure all tests passed, but still not sure is there any
> side-effect.
I'm not sure this is a good idea - output buffers can include output
functions IIRC, but you have already shut down modules. I would be very,
very careful wi
> Any people with more git merging experience want to point to a guide
> to dealing with that sort of thing? I've used git for years, but I'm
> really having a hard time wrapping my head around the way we're using
> it, even with the guides on the Wiki.
That's a good point, I think we need to add
Hi!
> This fixes a problem caused by a change that's not in any released PHP
> version.
Which change caused the problem?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
Hi!
Sorry for tags spam - my git somehow didn't sync the tag rename and
recreated ton of the old tags :( I'll clean it up in a minute.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe
Hi!
> It would also be nice to change times - + is obviously not needed as
> it's always UTC and we don't really need the seconds probably. We could
Wait, I was wrong on that - it's not always the same, my sample was too
small :) Maybe we should convert it to always UTC?
Also, maybe we can g
Hi!
> Hi:
>
> On 20 Mar 2012, at 10:05, Derick Rethans wrote:
>
>> Commit: f05ac19fc6481815958655f483ef8d0d4fbc3bbe Author: Derick
>> Rethans(git...@derickrethans.nl) Tue, 20 Mar 2012 08:57:53
>> + Committer: Derick Rethans(git...@derickrethans.nl) Tue,
>> 20 Mar 2012 09:05:42 +
Hi!
I think what Chris is asking is to have NEWS entries in the branch
where a commit is done, no mater if the fix was already reported in a
previous branch NEWS file.
It'd mean instead of easy merge on release we'd have to have hard and
time-consuming cleanup of old NEWS - I'd have to go thr
Hi!
Users should be able to see the fixes in 5.4 by reading only 5.4 NEWS.
That's why we merge 5.3 news before the release.
I think the 5.3& 5.4 branches have to be considered distinct from now
on.
What's different now?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugar
Hi!
This one (#61173) isn't in 5.4 NEWS, since it was only fixed in 5.3.11.
Do we now duplicate 5.3 and 5.4 NEWS?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www
Hi!
What about NEWS?
It's already fixed in 5.3...
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Hi!
+Since PHP 5.4 it is possible to prevent shared extensions from unloading so
Since 5.4 doesn't look right in 5.3 upgrading :) ITYM since 5.3.11?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net
Hi!
Did you run the tests? Just from a quick skim I think this would break
both the pcntl and the posix extension.
Yes, I did - no (new) fails both on Mac and Linux. If you see any please
tell me.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext.
Hi!
Considering this little fix, it is no harm to commit to RC. :)
Anyway it also okey for me to commit after release, since this is
really a trivial bug and there are already one patche for me need to
be remembered ci after 5.4.0 released. :)
OK, it looks like we're going to have another R
Hi!
Still a known crash bug though. This is what our RCs are supposed to
catch, right?
Right, but judging by current patten we're pushing the release further
and further without any obvious end in sight. If we will wait with the
release until we have 0 bugs in PHP (or even 0 possibility of s
Hi!
Now it looks fine.
I think it should be committed into 5.4 as well.
Stas?
That would probably require new RC, i.e. release will have to be pushed
back. How serious is the problem we're talking about?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6
Hi!
rasmus Sun, 08 Jan 2012 18:43:30 +
Revision: http://svn.php.net/viewvc?view=revision&revision=321937
Log:
These tests don't work if run as root
Changed paths:
U
php/php-src/branches/PHP_5_3/ext/spl/tests/DirectoryIterator_getGroup_basic.phpt
Hi!
was only present in 5.4 as far as I can tell, see Stas' commit yesterday.
Not sure what you mean as I did identical commits to both 5.4 and trunk.
I also think it might be better to do it on RINIT, just in case.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com
Hi!
rasmus Tue, 08 Nov 2011 20:32:29 +
Revision: http://svn.php.net/viewvc?view=revision&revision=318921
Log:
This really shouldn't fail, but if it does, like on OSX under Valgrind,
let's just issue a warning.
Changed paths:
U php/php-src/branches/
Hi!
On Tue, Nov 8, 2011 at 5:59 AM, Stanislav Malyshev wrote:
Hi Stas,
you meant #54089 in your comment, right?
Yes I did. Sorry, typo :)
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To un
Hi!
On 9/26/11 4:47 PM, Ferenc Kovacs wrote:
Hi Stas.
does this fixes https://bugs.php.net/bug.php?id=55546 ?
if not, can you reproduce the problem described there?
These two do not fail for me now. The fix looks the same, so I'm closing
the bug.
--
Stanislav Malyshev, Software Architect
S
Hi!
On 9/12/11 3:04 AM, Hannes Magnusson wrote:
Shouldn't this be merged to trunk too?
Thanks, somehow I forgot to merge it. Done now.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubsc
Hi!
care to comment?
It looks like neither me nor others (inluding gcov machine) are getting
that message.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.
Hi!
On 9/6/11 5:11 AM, Ulf Wendel wrote:
FAIL LOAD DATA INFILE - open_basedir
[ext/mysql/tests/mysql_query_load_data_openbasedir.phpt]
Please check if the current fix works for you.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CV
Hi!
On 9/6/11 5:11 AM, Ulf Wendel wrote:
Am 06.09.2011 07:20, schrieb Stanislav Malyshev:
stas Tue, 06 Sep 2011 05:20:51 +
Revision: http://svn.php.net/viewvc?view=revision&revision=316205
Log:
fix test
FAIL LOAD DATA INFILE - open_basedir
[ext/mysql/
Hi!
On 9/6/11 1:24 AM, Andrey Hristov wrote:
no, it's about consistency, which you want. mysqlnd should behave like
libmysql, and it is a test that can test it. What libmysql returns in
filtered in mysqli, mysqli_num_rows() is a direct wrapper around
mysql_num_rows(), and this is what we test.
Hi!
On 9/6/11 12:28 AM, Andrey Hristov wrote:
this bug was really mysqli@mysqlnd. No other tests test this, this is
why we were not able to catch this before. Therefore, it should be
enabled also for libmysql, because it checks right behavior. It's about
regression testing, and if libmysql fails
Hi!
On 9/5/11 4:11 AM, Hannes Magnusson wrote:
You broke the iconv/tests/iconv_stream_filter.phpt test for me :]
According to the changelog for that test it is version dependent
We can however simply suppress the errormessage for older versions,
like I have done now.
Could you verify it still w
Hi!
On 9/4/11 2:44 PM, Pierre Joye wrote:
> 5.3?
It changes the API (even though old one is wrong IMO) so I'm not sure if
it belongs there. Up to 5.3 RM.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP CVS Mailing List (http://www.php
Hi!
On 9/4/11 7:21 AM, Tjerk Anne Meesters wrote:
datibbaw Sun, 04 Sep 2011 14:21:27 +
Revision: http://svn.php.net/viewvc?view=revision&revision=316108
Log:
Patch to run two more mysql test cases that would usually be skipped.
Replaced skipifdefaultconnect
Hi!
On 8/30/11 11:32 PM, Gustavo André dos Santos Lopes wrote:
cataphract Wed, 31 Aug 2011 06:32:05 +
Revision: http://svn.php.net/viewvc?view=revision&revision=315851
Log:
- Fixed test htmlentities15.phpt.
Changed paths:
U
php/php-src/branches/PHP_5_
On 8/23/11 9:40 AM, Daniel Convissor wrote:
danielc Tue, 23 Aug 2011 16:40:19 +
Revision: http://svn.php.net/viewvc?view=revision&revision=315376
Log:
Fix differences in some sub() results that were causing tests to fail.
I don't understand this fix. How
Hi!
On 8/19/11 4:06 PM, Scott MacVicar wrote:
Sigh, I wonder how many str*l* functions were introduced that were incorrect?
Looks like there wasn't an understanding that strlcat is for the destination
not source.
Well, I guess unit tests should show some breakage if it's there (like
crypt o
Hi!
On 8/16/11 6:19 AM, Johannes Schlüter wrote:
It saves one character of typing.
For me, it's the reason enough to prohibit it altogether :) Writing
weird code to save one character of typing is the worst habit we could
promote. But I digress since the idea of this patch was obviously not
On 8/14/11 4:25 AM, Derick Rethans wrote:
On Fri, 12 Aug 2011, Xinchen Hui wrote:
laruence Fri, 12 Aug 2011 07:47:03 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314808
Log:
Omitted GCC warning "comparison is always false"
I don't get this
Hi!
On 8/7/11 7:25 AM, Xinchen Hui wrote:
laruence Sun, 07 Aug 2011 14:25:30 +
memset(opts, 0, count * sizeof(opt_struct));
+ if (!opts) {
+ RETURN_FALSE;
+ }
+
I'm not sure I understand this
Hi!
On 8/7/11 8:24 AM, Rasmus Lerdorf wrote:
True, but the problem here is that name may be free'ed at that point. On
line 3355 we have:
property_info.name = (char*)name;
and then on 3365:
if (ce->type == ZEND_USER_CLASS) {
efree(property_info.name);
} e
On 7/28/11 3:58 AM, Pierre Joye wrote:
pajoye Thu, 28 Jul 2011 10:58:28 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313834
Log:
- Fix #55301 (sybase part) check if malloc succeded
Bug: https://bugs.php.net/55301 (error getting bug informat
Hi!
On 7/28/11 12:04 AM, Pierre Joye wrote:
hi Gobal,
Could you add a note in UPGRADING.INTERNALS about this change please?
AFAIK, 5.3 had no interned strings. So it's not clear what upgrading
means here.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-
Hi!
On 7/11/11 8:56 PM, Kalle Sommer Nielsen wrote:
kalleTue, 12 Jul 2011 03:56:32 +
Revision: http://svn.php.net/viewvc?view=revision&revision=313156
Log:
Changed http_response_code() to be able to set a response code
Are you sure this patch is right
Hi!
On 7/7/11 2:08 PM, Johannes Schlüter wrote:
On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote:
what kind of troubles do they see?
https://pear.php.net/bugs/bug.php?id=18656
Even if the Warning is good it's questionable for 5.3, especially during
RC.
Yes, I had problem with it too in
Hi!
On 7/6/11 12:20 PM, Rasmus Lerdorf wrote:
Given the pretty big changes that are likely to occur between alpha
releases, I think it would be a good idea to have separated NEWS
sections. And yes, when we put out the first beta we merge them all.
OK, I'll split them.
--
Stanislav Malyshev, S
Hi!
On 7/6/11 12:12 PM, Hannes Magnusson wrote:
Hmmmh..
So the news for alpha2 will not be separated from alpha1?
Thats going to make it hard to see the difference for users :]
Well, alphas aren't really for "users" - i.e., it should not be used in
any setting where the difference (as opposed
Hi!
No time to actually proper design and propose alternatives yet. That
does mean we have to accept something "just because it is ready".
Sorry
No, I think if we have working solution for a real problem, even if it's
not perfect - it is the reason to use it and "I can vaguely imagine
someth
Hi!
Besides that, did we even approve that change? Gustavo and I were two
that did not like the current implemenation/design.
There were no objections and/or proposals for improving it since I
posted the patch, which as about 2 months ago, so I assumed it's ok. If
you have any specific ideas
Hi!
There seem to be a lot of unrelated code cleanup here, and I am in
> general a bit confused in this code.
> Could you review http://php.net/streamwrapper and write up the changes to
> it?
>
>
There shouldn't be any changes except for adding one stream handler (see
rfc: https://wiki.php.net/rfc
Hi!
Some of questions:
1. Why clone is not defined? uspoof_clone exists.
2.
/* {{{ proto void Spoofchecker::areConfusable( string $str1, string
$str2[, int $error_code ] )
+ * Checks if a given text contains any confusable characters
+ */
It says void but code returns bool. Same with isSuspici
Hi!
not saying that it is not cool to finally have that but we are in the
RC phase
Sorry for being late, but this seems not to be very intrusive and next
5.3 would probably be in quite some time... But if it's not OK I could wait.
--
Stanislav Malyshev, Software Architect
SugarCRM: http:
Hi!
1) arguments can be gathered dynamically in the function, using
func_get_args. For that reason, PHP gracefully allow a call with too many
arguments.
Isn't it the case today?
Maybe also we can add some syntax like:
function foo($a, $b, ...) - where ... means "I'll deal with those
arguments
100 matches
Mail list logo
