Re: [PHP-DEV] Patches and Extensions and Such

2002-09-19 Thread Dan Hardiker
> Also, Dan's patch looks fine, ofcourse there are always some little > things with patches, but that doesn't matter right now. > > Derick I cant take credit for another mans work, I was just providing the test bed and some ideas. Devon O'Dell [[EMAIL PROTECTED]] is the author of the patch, and d

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-19 Thread Yasuo Ohgaki
[EMAIL PROTECTED] wrote: > Yasuo, > > phps works fine, removing it would make people very angry (including > me). It may not work for you, then simply don't use it. I don't use it. With php.ini-recommended, php _crashes_ when phps is used. What kind of configuration you are using if php.ini-r

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-19 Thread derick
Yasuo, phps works fine, removing it would make people very angry (including me). It may not work for you, then simply don't use it. Also, Dan's patch looks fine, ofcourse there are always some little things with patches, but that doesn't matter right now. Derick On Thu, 19 Sep 2002, Yasuo

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-19 Thread DJ Anubis
Le Mercredi 18 Septembre 2002 22:44, Mike Robinson a écrit : > I for one have no use for line numbers in a phps file. I dont't have use of line numbering in current apps. But, just wait a minute. > I do have use for being able to copy/paste out of phps > files, which would stop working with lin

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-19 Thread Yasuo Ohgaki
Dan Hardiker wrote: > Hi All, > > [all references to .phps are inheriently references to the modified > highlight_file function, which in essence is the same thing] > > To prevent this getting blown out of all proportion (as so many things to > where differences of opinion hit), can anyone with

RE: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Dan Hardiker
Hi, On a more careful inspection of the thread, you will see that you can pass in PARAMETERS (either though the function call of show_source / highlight_*, or in the query string of the .phps file [eg: ?HIGHLIGHT_FILE=(default|lineno)]). This makes it flexable either which way. Neither I (nor De

RE: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Jani Taskinen
.? --Jani >Regards >Mike Robinson > > >-Original Message- >From: Rick Widmer [mailto:[EMAIL PROTECTED]] >Sent: Wednesday, September 18, 2002 4:20 PM >To: Jani Taskinen; Devon O'Dell >Cc: Yasuo Ohgaki; [EMAIL PROTECTED] >Subject: Re: [P

RE: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Wez Furlong
On 18/09/02, "Mike Robinson" <[EMAIL PROTECTED]> wrote: > One man's feature is another man's bug. You guys wanted a valid > reason, I gave one. There's probably more. :) Here's a couple more: How about piecing together code fragments for use in documentation tools? The line numbers would get in

RE: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Mike Robinson
:) Did I miss the part in this thread about why this can't be an option? .mike -Original Message- From: Rick Widmer [mailto:[EMAIL PROTECTED]] Sent: Wednesday, September 18, 2002 5:48 PM To: [EMAIL PROTECTED] Subject: RE: [PHP-DEV] Patches and Extensions and Such At 04:44 P

RE: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Mike Robinson
Mike Robinson -Original Message- From: Rick Widmer [mailto:[EMAIL PROTECTED]] Sent: Wednesday, September 18, 2002 4:20 PM To: Jani Taskinen; Devon O'Dell Cc: Yasuo Ohgaki; [EMAIL PROTECTED] Subject: Re: [PHP-DEV] Patches and Extensions and Such At 10:12 PM 9/18/02 +0300, Jani Task

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Tit \"Black\" Petric
> > 1. Does adding the ?HIGHLIGHT_FORMAT switch to the .phps file format > >reduce or degregate current / existing functionality in any way? {if yes, > >please expand) > > No, but since no one has given any reason why line numbers should not > be on all the time, why bother with it? Just turn t

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Rick Widmer
At 01:08 PM 9/18/02 +0100, Dan Hardiker wrote: >Hi All, > 1. Does adding the ?HIGHLIGHT_FORMAT switch to the .phps file format >reduce or degregate current / existing functionality in any way? {if yes, >please expand) No, but since no one has given any reason why line numbers should not be on

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Rick Widmer
At 10:12 PM 9/18/02 +0300, Jani Taskinen wrote: > I was just thinking that .phps support is there to > just show source of some php file. I don't think it's > really any BC problem to always have line numbering on > for them. And have an optional parameter to the PHP function >

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Jani Taskinen
I was just thinking that .phps support is there to just show source of some php file. I don't think it's really any BC problem to always have line numbering on for them. And have an optional parameter to the PHP function to show those numbers if wanted. I don't under

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Yasuo Ohgaki
Oops. The mail sent before correcting poor english by mistake. But it can be understandable hopefully ;) -- Yasuo Ohgaki Yasuo Ohgaki wrote: > Devon, > > You should be able to search bug db... > > Devon O'Dell wrote: > >> Instead of telling me to read the source about how PHP/Zend works, >>

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Yasuo Ohgaki
Devon, You should be able to search bug db... Devon O'Dell wrote: > Instead of telling me to read the source about how PHP/Zend works, > how about pointing to where the problem is with .phps. Here's the I've already pointed out one mail. Encoding. You should be able to find bug report that I'

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Wez Furlong
Hi Devon, Although I personally never use .phps, I'm +1 on implementing this the way you have suggested. Yasuo: I don't like .phps either, but this is quite a clean approach in the face backwards compatibility. Since we are not likely to ever remove phps, taking highlight file into user-space ju

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Dan Hardiker
Hi All, [all references to .phps are inheriently references to the modified highlight_file function, which in essence is the same thing] To prevent this getting blown out of all proportion (as so many things to where differences of opinion hit), can anyone with a view on this matter answer the f

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Devon O'Dell
Considering I've written this, I think I've done the research. You *don't* configure x-application/x-httpd-php-source-with-line-number or whatever. When you view the .phps (or .php script with highlight_file()), if you have accessed the page with a trailing ?HIGHLIGHT_FORMAT=lineno, you get line

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Yasuo Ohgaki
This msg may be sent twice Devon O'Dell wrote: > I wonder if you understand that highligh_file() *is* a call to the > *same* function that provides .phps files with functionality. > By adding line numbers to this function, we are automatically > adding them to .phps free of charge. Doesn

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-18 Thread Devon O'Dell
I wonder if you understand that highligh_file() *is* a call to the *same* function that provides .phps files with functionality. By adding line numbers to this function, we are automatically adding them to .phps free of charge. Doesn't break anything or make anything less secure. The only securi

Re: [PHP-DEV] Patches and Extensions and Such

2002-09-17 Thread Devon O'Dell
Let me correct that, it should be http://www.dapond.net/mods Devon Devon O'Dell wrote: > The patch is mostly complete, and is open for lots of criticism. Also > available is my wrapper for the xls2xml library. > > You are welcome to get the files from http://dapond.net/mods/ (ADSL, > UK) or

[PHP-DEV] Patches and Extensions and Such

2002-09-17 Thread Devon O'Dell
The patch is mostly complete, and is open for lots of criticism. Also available is my wrapper for the xls2xml library. You are welcome to get the files from http://dapond.net/mods/ (ADSL, UK) or http://margrietje.com/~devon/mods (34MBit FO, NL). Currently there is no CVS server set up, but o