A little update on all of this.
I changed the way that the handlers are created in the apache config from
php_value uri_handler /tmp/foo.php
to
phpUriHandler /tmp/foo.php
and logically separated them from the ini structure. This eliminates
some unnecessary work that was being done before and
Here's an incremental patch on Lukas' patch which tries to address a
couple issues:
o The startup sequence has been changed to allow for post-data to make
it through if any hooks before full post-data is read are called
o works under register_globals Off ($request is now available in the
I say commit it. This stuff is very experimental as it is and lives in
its own branch. You are not going to destabilize anything.
(I just made sure you had enough karma for the commit)
-Rasmus
On Mon, 26 Aug 2002, George Schlossnagle wrote:
Here's an incremental patch on Lukas' patch which
All of this work was off HEAD. Should a new_apache_hooks branch be tagged?
Rasmus Lerdorf wrote:
I say commit it. This stuff is very experimental as it is and lives in
its own branch. You are not going to destabilize anything.
(I just made sure you had enough karma for the commit)
-Rasmus
I think if we put this in 4.3 we are going to delay 4.3 even further.
Although, I suppose if we are careful and make sure we #ifdef it nicely
and only turn it on with a configure option, we can put it in HEAD.
So, is your patch my apache_hooks stuff + Lukas's work and then your stuff
on top?
On
I wasn't proposing putting it in HEAD, just that the work was done
against HEAD not against your apache_hooks. Lukas redid all the
php-apache request object work fresh off of head, and I made changes
off of that, so it contains nothing from your apache_hooks branch.
Rasmus Lerdorf wrote:
I
Well, the problem with doing it on a branch, the way I did, and as Lukas
found out, is that it goes rather stale after a while. So I guess that I
am actually proposing putting it in HEAD but #ifdef'ed out and perhaps not
even providing a user-visible config option for it yet. You'd need to set
On Mon, 26 Aug 2002, Rasmus Lerdorf wrote:
Yeah, but the point, at least for now is that the code really isn't meant
to even be used by QA folks yet. It is work targeted for PHP 5.
hmm... starting with a PHP5 branch would be a little early now don't you
think? Well, after 4.3.0 is branched
On Mon, 26 Aug 2002, Rasmus Lerdorf wrote:
Yeah, but the point, at least for now is that the code really isn't meant
to even be used by QA folks yet. It is work targeted for PHP 5.
hmm... starting with a PHP5 branch would be a little early now don't you
think?
Yup - hence the confusion
On Mon, Aug 26, 2002 at 11:18:38AM -0700, Rasmus Lerdorf wrote:
Well, after 4.3.0 is branched I guess the next release would be
PHP 5 so it's not that far away. If only Stig would start with the
branch :) Anyway, I'm more in favor of having this nice hook stuff
in a seperate branch
i offer to do the ugly work.
i put it into the branch for now, so i dont even have to think i tiny
bit about breaking anything. and if time comes, i'll prepare the
necessary patch sets to merge into the php5 branch, without having to
use the dreaded cvs merge branch 'feature'.
would that
On Mon, Aug 26, 2002 at 02:59:01PM -0400, George Schlossnagle wrote:
I actually just made a 'new_apache_hooks' branch and am about to commit
it all there
argh. so, what now?
i don't like having two branches for this.
--
PHP Development Mailing List http://www.php.net/
To unsubscribe,
If you want to pull everything into the apche_hooks branch, I can do
that as well. But if we do that, it would probably wise to update
everything in that branch to HEAD.
George Schlossnagle wrote:
I haven't committed anything yet. It seems like the benefit of
starting with a fresh copy
Ok, this has all been added to the apache_hooks branch, which is now
up-to-date.
George Schlossnagle wrote:
If you want to pull everything into the apche_hooks branch, I can do
that as well. But if we do that, it would probably wise to update
everything in that branch to HEAD.
George
Ok, this has all been added to the apache_hooks branch, which is now
up-to-date.
Very nice. IMHO this should be merged into HEAD as soon as PHP_4_3_0 is
branched off.
Edin
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php
15 matches
Mail list logo
