[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Sascha Schumann
> I'll check and update doc if needed. That was a direct quote from the documentation. > > No. Try to read the code again. A user handler should > > simply return a non-string. > > It works sometimes, but it segfaults sometimes. (with original code) ..then please send me a tes

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
Yasuo Ohgaki wrote: > Sascha Schumann wrote: >> >>> 1. It does not work simply with current code. >>>(It seems mm works for you. While it does not for me. I guess >>> you enable register_globals) >>> >> >> I don't which you can easily derive from the test script I >> sent to you ea

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
Sascha Schumann wrote: >>I thought the reporter want valid SID defined always, since I wanted >>valid SID defined always. Document does not memtion when SID is >>defined, IIRC. >> >>Document should be updated. >> > > It has been documented since I first wrote the session > documentation.

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Sascha Schumann
> I thought the reporter want valid SID defined always, since I wanted > valid SID defined always. Document does not memtion when SID is > defined, IIRC. > > Document should be updated. It has been documented since I first wrote the session documentation. "Alternatively, you can use

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
I think there was miscommunication. That's fine. We can discuss them again :) Sascha Schumann wrote: > Here are comments regarding each commit. > > > http://news.php.net/article.php?group=php.cvs&article=9700 > > I've restored the old behaviour regarding SID (#15322). I thought th

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
I think there was miscommunication. That's fine. We can discuss them again :) Sascha Schumann wrote: > Here are comments regarding each commit. > > > http://news.php.net/article.php?group=php.cvs&article=9700 > > I've restored the old behaviour regarding SID (#15322). I thought th

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
I think there was miscommunication. That's fine. We can discuss them again :) Sascha Schumann wrote: > Here are comments regarding each commit. > > > http://news.php.net/article.php?group=php.cvs&article=9700 > > I've restored the old behaviour regarding SID (#15322). I thought th

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
Sascha Schumann wrote: > sas Wed Mar 6 07:25:01 2002 EDT > > Modified files: > /php4/ext/session mod_mm.c > Log: > Did not revert back enough. > > This patch does not make sense, because it enforces the existence > of a single directory. If you would

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Sascha Schumann
Here are comments regarding each commit. http://news.php.net/article.php?group=php.cvs&article=9700 I've restored the old behaviour regarding SID (#15322). A reordering of estrdups has also been committed. I suppose the message "fix small memory leak" refers to that.

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Yasuo Ohgaki
Sascha Schumann wrote: >>BTW, if users set wrong save_path in php.ini, they can >>use mm save handler when they set save_path in .htaccess or >>httpd.conf. >>Therefore, allowing invalid save_path for mm is not useless. >> > > The MM module uses anon-shared-memory, i.e. the shared > segmen

[PHP-DEV] Re: cvs: php4 /ext/session mod_mm.c

2002-03-06 Thread Sascha Schumann
> BTW, if users set wrong save_path in php.ini, they can > use mm save handler when they set save_path in .htaccess or > httpd.conf. > Therefore, allowing invalid save_path for mm is not useless. The MM module uses anon-shared-memory, i.e. the shared segment must be initialized in the par