philip Mon Dec 24 01:57:57 2001 EDT
Modified files:
/phpdoc/en/functionsnotes.xml
Log:
Lotus Notes: Is an experimental extension.
Index: phpdoc/en/functions/notes.xml
diff -u phpdoc/en/functions/notes.xml:1.2 phpdoc/en/functions/notes.xml:1.3
--- ph
philip Sun Dec 23 19:56:12 2001 EDT
Modified files:
/phpdoc/en/functionsfilesystem.xml
Log:
fgets: Modifying recently added note to make more sense, length is a parameter.
Index: phpdoc/en/functions/filesystem.xml
diff -u phpdoc/en/functions/filesys
> > "a $arr[foo] b"
> > "a {$arr['foo']} b"
> > 'a ' . $arr['foo'] . ' b';
> The first ist simply wrong. with $array[foo] PHP assumes foo is an
> constant with the value foo, which is not coorect when using 'strings'
> as indices.
Actually, it's not wrong. Constants are not looked for in stri
Hi,
On Sun, 23 Dec 2001 20:36:07 + (GMT)
Philip Olson <[EMAIL PROTECTED]> wrote:
> "a $arr[foo] b"
> "a {$arr['foo']} b"
> 'a ' . $arr['foo'] . ' b';
The first ist simply wrong. with $array[foo] PHP assumes foo is an
constant with the value foo, which is not coorect when using 'strings'
as
> > > $variables shoud be concatenated with '. instead of using "$var strng".
> > -1. I prefer "$var string".
>
> $var." string" is less ambigious. Actually it should be $var.' string' as
> "$var string" and '$var string' behave differently $var.' string' and $var."
> string" work the same.
-1 f
Not sure if I agree they need to be identical, I did last month but now it
doesn't seem like a big deal (pending discussion). Variety is the spice
of life :)
Regarding below examples, 'single quotes' should be used in every
instance. The spacing looks fine, though. And, whether or not to defin
> can you please give an example where 'or die()' is 'not flexible'.
I am referring to 'or' specifically. For example:
$conn = mysql_connect($host, $user, $pass) or die('Connection failed');
Okay that works. But let's say one wants to do multiple statements on
failure, the following will not
> > $variables shoud be concatenated with '. instead of using "$var strng".
> -1. I prefer "$var string".
$var." string" is less ambigious. Actually it should be $var.' string' as
"$var string" and '$var string' behave differently $var.' string' and $var."
string" work the same.
- James
Hi there.
I thought I'll start a new topic for this.
You won't punish me for that? :P
> > What do others think about that?
> I give a +1 for adapting the PEAR coding standard for Manual examples.
+1 from me.
> Slawomir Pucia said some mails ago, we should be consistent about using
> ' or " for
> Regarding whether to use echo or print, concat variables or not, etc. No
> need to get that specific imho. Just the basics, like formatting.
It simply looks nicer for reader if all examples (at least in one chapter)
are similar. Look at these lines from mysql.xml:
mysql_connect("mysql_host",
Hi,
On Sun, 23 Dec 2001 18:59:52 + (GMT)
Philip Olson <[EMAIL PROTECTED]> wrote:
> And fwiw, I'm against forcing 'or die' formatting in any example, it's
not
> all that flexible.
can you please give an example where 'or die()' is 'not flexible'.
Jan
--
Q: Thank Jan? A: http://geschenke.an.d
Hi,
On Sun, 23 Dec 2001 19:37:02 +0100
"Slawomir Pucia" <[EMAIL PROTECTED]> wrote:
> > $variables shoud be concatenated with '. instead of using "$var
strng".
>
> What is the reason? If there aren't any efficiency considerations then
IMHO
> "$var strng" is more clean
personal opinion, I think $
Hi,
On Sun, 23 Dec 2001 18:43:50 -
"James Moore" <[EMAIL PROTECTED]> wrote:
>
>
> > > What do others think about that?
> > I give a +1 for adapting the PEAR coding standard for Manual
examples.
>
> -1 for anything complicated in the manual. Keep everything clear and
concise
> why do we nee
I don't think anyone means 'use pear' in the examples, just the standard.
Like, what makes for a defining a function, construct spacing, etc. Odds
are the pear coding standard will be a base which will be modified to suit
phpdoc needs.
Regarding whether to use echo or print, concat variables or
> -1 for anything complicated in the manual. Keep everything clear and
concise
> why do we need to clutter examples with PEAR error everywhere
AFAIK the idea is to adapt PEAR *coding standard* to examples, not to use
PEAR itself.
slawek-
> > What do others think about that?
> I give a +1 for adapting the PEAR coding standard for Manual examples.
-1 for anything complicated in the manual. Keep everything clear and concise
why do we need to clutter examples with PEAR error everywhere (Nothing
against pear I think its great but I
> $variables shoud be concatenated with '. instead of using "$var strng".
What is the reason? If there aren't any efficiency considerations then IMHO
"$var strng" is more clear.
slawek-
Hi,
On Sun, 23 Dec 2001 18:38:45 +0100
"Gabor Hojtsy" <[EMAIL PROTECTED]> wrote:
> What do others think about that?
I give a +1 for adapting the PEAR coding standard for Manual examples.
Some things must be recognized. At first PEAR does have a excellent
error handling, but it is to complex to in
> Diffs are hard to read. This was a bad example from me. A better one
> would be cvs.php.net or the PHP manual itself.
But the codes in the manual are so different, as many people
added code, without following any convention, so I cannot agree
that reading the manual is a good example to get a s
From: "Gabor Hojtsy" <[EMAIL PROTECTED]>
> > > So where we can find the previously written down
> > > conventions used for writing PHP code in phpdoc?
> > > This file is even not consistent with what you
> > > have said about before-PEAR coding standards, as
> > > I can see.
> >
> > I have done m
> > This file is not that much different than the current howto
> > contents about conventions. This 1.1 really have no coding
> > conventions, just some skeletons. No rules about how to write
> > PHP code, except the form convention in point 5.
> >
> > So where we can find the previously written
From: "Gabor Hojtsy" <[EMAIL PROTECTED]>
> > See version 1.1 of README. The latest version have now only a
link
> > to the howto.tar file.
>
> OK, I have seen that file now.
> http://cvs.php.net/co.php/phpdoc/README?r=1.1
>
> Look at the function skeleton for example in that file:
>
> function so
> See version 1.1 of README. The latest version have now only a link
> to the howto.tar file.
OK, I have seen that file now.
http://cvs.php.net/co.php/phpdoc/README?r=1.1
Look at the function skeleton for example in that file:
function some_code($foo)
{
/* we all agree that four spaces of inden
www.concertband.de
> > First of all you should know, that the first writting of PHPDOC
was
> > only a rewrite of Rasmus´ PHP/FI manual. More and more authors
and
> > contributors asked many times for a coding standard. So there we
> > included some in the source.
>
> Some things were covered in
pgerzsonSun Dec 23 08:36:28 2001 EDT
Modified files:
/phpdoc/hu/functionsfunchand.xml
Log:
keep up with the EN revision
Index: phpdoc/hu/functions/funchand.xml
diff -u phpdoc/hu/functions/funchand.xml:1.9 phpdoc/hu/functions/funchand.xml:1.10
--
> First of all you should know, that the first writting of PHPDOC was
> only a rewrite of Rasmus´ PHP/FI manual. More and more authors and
> contributors asked many times for a coding standard. So there we
> included some in the source.
Some things were covered in the old howto (for those who
can
From: "Slawomir Pucia" <[EMAIL PROTECTED]>
> > Can you add anything to our coding conventions
> > discussion?
>
> First of all, I'm after PEAR coding standard in examples. However,
there are
> some elements which are not covered by PEAR docs:
First of all you should know, that the first writting
fujimotoSun Dec 23 06:40:31 2001 EDT
Modified files:
/phpdoc/ja/appendices history.xml
Log:
fixed typo.
Index: phpdoc/ja/appendices/history.xml
diff -u phpdoc/ja/appendices/history.xml:1.6 phpdoc/ja/appendices/history.xml:1.7
--- phpdoc/ja/appe
> Can you add anything to our coding conventions
> discussion?
First of all, I'm after PEAR coding standard in examples. However, there are
some elements which are not covered by PEAR docs:
1. Always use the same values for server, userneme, password and database
name, when connecting to databas
fujimotoSun Dec 23 05:03:05 2001 EDT
Modified files:
/phpdoc/ja/appendices history.xml
/phpdoc/ja/features connection-handling.xml cookies.xml
error-handling.xml http-auth.xml
persistent-connections.x
> I was just updating polish mysql.xml, and I must say that original version
> is a real mess when it comes to examples. There are lot of different
naming
> and coding conventions. I think this file needs general review of its
> examples.
Yes, we are already in the discussion of coding standards.
philip Sun Dec 23 03:05:14 2001 EDT
Modified files:
/phpdoc/en/functionsfilesystem.xml
Log:
fgets: note that length parameter become optional in 4.2.0
Index: phpdoc/en/functions/filesystem.xml
diff -u phpdoc/en/functions/filesystem.xml:1.106
phpdoc
32 matches
Mail list logo
