Re: [Piglit] [PATCH V3 0/8] Add tests for ARB_texture_multisample

On 26 February 2013 02:18, Chris Forbes wrote: > This series adds an initial set of tests for the ARB_texture_multisample > extension. I will follow this with more tests to explore some edge cases. > > Changes from V2: > - Leftover window size junk removed > - Misc small tidyups > > -- Ch

Re: [Piglit] [PATCH V3 4/8] arb_texture_multisample: new test for teximage state

On 26 February 2013 02:18, Chris Forbes wrote: > This tests that the new teximage state added in ARB_texture_multisample > exists and has correct defaults for non-multisample textures: > > - GL_TEXTURE_SAMPLES = 0 > - GL_TEXTURE_FIXED_SAMPLE_LOCATIONS = true > > V2: Don't specify window s

Re: [Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

On 27 February 2013 10:59, Chad Versace wrote: > On 02/27/2013 10:47 AM, Paul Berry wrote: > > On 27 February 2013 10:44, Eric Anholt > > wrote: > > > > Paul Berry mailto:stereotype...@gmail.com>> > writes: > > > > > Previously, if the user specified an ill-formed

Re: [Piglit] RFC: variable-index-read.sh and write for GLES

Tom Gall writes: > From tests/spec/glsl-1.10, I've extended variable-index-write.sh and > variable-index-read.sh so the scripts are able to generate tests for > GLSL ES 1.00. > > Posting the patches for the scripts is trivial but how do we want to > handle all the tests that it generates? > > Se

[Piglit] [PATCH 6/6] glsl-1.50: add simple test for varying interface block

Signed-off-by: Jordan Justen --- .../interface-blocks-simple-varying.shader_test| 50 1 file changed, 50 insertions(+) create mode 100644 tests/spec/glsl-1.50/linker/interface-blocks-simple-varying.shader_test diff --git a/tests/spec/glsl-1.50/linker/interface-block

[Piglit] [PATCH 5/6] glsl-1.50: varying keyword is not allowed within an interface block

Signed-off-by: Jordan Justen --- .../compiler/interface-blocks-varying-used.vert| 22 1 file changed, 22 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/interface-blocks-varying-used.vert diff --git a/tests/spec/glsl-1.50/compiler/interface-blocks-vary

[Piglit] [PATCH 4/6] glsl-1.50: attribute keyword is not allowed within an interface block

Signed-off-by: Jordan Justen --- .../compiler/interface-blocks-attribute-used.vert | 22 1 file changed, 22 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/interface-blocks-attribute-used.vert diff --git a/tests/spec/glsl-1.50/compiler/interface-blocks-at

[Piglit] [PATCH 3/6] glsl-es-3.00: add uniform block type mismatch link test

Signed-off-by: Jordan Justen --- ...terface-blocks-member-type-mismatch.shader_test | 39 1 file changed, 39 insertions(+) create mode 100644 tests/spec/glsl-es-3.00/linker/interface-blocks-member-type-mismatch.shader_test diff --git a/tests/spec/glsl-es-3.00/linker/int

[Piglit] [PATCH 2/6] glsl-1.10: add uniform type mismatch link test

Signed-off-by: Jordan Justen --- .../linker/uniform-type-mismatch.shader_test | 29 1 file changed, 29 insertions(+) create mode 100644 tests/spec/glsl-1.10/linker/uniform-type-mismatch.shader_test diff --git a/tests/spec/glsl-1.10/linker/uniform-type-mismatch.shad

[Piglit] [PATCH 1/6] glsl-1.50: add test for interface block member qualifier mismatch

Signed-off-by: Jordan Justen --- ...interface-blocks-member-qualifier-mismatch.vert | 22 1 file changed, 22 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/interface-blocks-member-qualifier-mismatch.vert diff --git a/tests/spec/glsl-1.50/compiler/interfa

[Piglit] RFC: variable-index-read.sh and write for GLES

From tests/spec/glsl-1.10, I've extended variable-index-write.sh and variable-index-read.sh so the scripts are able to generate tests for GLSL ES 1.00. Posting the patches for the scripts is trivial but how do we want to handle all the tests that it generates? Seems like a bit of a waste of mail

Re: [Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

For the series. Reviewed-by: Tom Gall On Wed, Feb 27, 2013 at 12:59 PM, Chad Versace wrote: > On 02/27/2013 10:47 AM, Paul Berry wrote: >> On 27 February 2013 10:44, Eric Anholt > > wrote: >> >> Paul Berry mailto:stereotype...@gmail.com>> >> writes: >> >> > Prev

Re: [Piglit] [PATCH RESEND 2/3] glslparsertest: Don't require ES compatibility extensions when testing GLES.

I don't have an objection, just thought I'd ask. If in the longer term we have the goal to build just one test binary that can be applied against different versions of GL, then we'll have to go back and get rid of these compile time checks. Regards, Tom On Wed, Feb 27, 2013 at 12:54 PM, Paul Berr

Re: [Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

On 02/27/2013 10:47 AM, Paul Berry wrote: > On 27 February 2013 10:44, Eric Anholt > wrote: > > Paul Berry mailto:stereotype...@gmail.com>> > writes: > > > Previously, if the user specified an ill-formed GLSL version number > > (or the implementation supplied

Re: [Piglit] [PATCH RESEND 2/3] glslparsertest: Don't require ES compatibility extensions when testing GLES.

On 27 February 2013 10:46, Tom Gall wrote: > Hmm is there some reason this has to be a compile time decision as > compared to use of the piglit_is_gles() function? > No, I don't really see a reason to prefer one way over the other. > > Here's a link to the patch that I had posted on the 18th.

Re: [Piglit] [PATCH 3/3] depthstencil-render-miplevels: Present the results in non-auto mode.

On 02/26/2013 12:39 PM, Eric Anholt wrote: > I tried to make the presentation be the data that was originally > probed -- there's a second readpixels that's unfortunately, but we do ^^ Is "that's" a typo? > use separate textures so that any workaround re

Re: [Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

On 27 February 2013 10:44, Eric Anholt wrote: > Paul Berry writes: > > > Previously, if the user specified an ill-formed GLSL version number > > (or the implementation supplied an ill-formed number in its response > > to glGetString(GL_SHADING_LANGUAGE_VERSION)), glslparsertest would > > access

Re: [Piglit] [PATCH RESEND 2/3] glslparsertest: Don't require ES compatibility extensions when testing GLES.

Hmm is there some reason this has to be a compile time decision as compared to use of the piglit_is_gles() function? Here's a link to the patch that I had posted on the 18th. http://lists.freedesktop.org/archives/piglit/2013-February/004952.html On Wed, Feb 27, 2013 at 12:32 PM, Paul Berry wr

Re: [Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

Paul Berry writes: > Previously, if the user specified an ill-formed GLSL version number > (or the implementation supplied an ill-formed number in its response > to glGetString(GL_SHADING_LANGUAGE_VERSION)), glslparsertest would > access uninitialized variables, resulting in unpredictable (and of

[Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

Previously, if the user specified an ill-formed GLSL version number (or the implementation supplied an ill-formed number in its response to glGetString(GL_SHADING_LANGUAGE_VERSION)), glslparsertest would access uninitialized variables, resulting in unpredictable (and often confusing) behaviour. Wi

[Piglit] [PATCH RESEND 2/3] glslparsertest: Don't require ES compatibility extensions when testing GLES.

glslparsertest should only check for the presence of GL_ARB_ES{2,3}_compatibility when the test is running under desktop GL. GLES never exposes these extensions. --- tests/glslparsertest/glslparsertest.c | 36 --- 1 file changed, 25 insertions(+), 11 deletions(-)

[Piglit] [PATCH RESEND 1/3] glslparsertest: Fix parsing of GL_SHADING_LANGUAGE_VERSION in GLES.

In desktop GL, glGetString(GL_SHADING_LANGUAGE_VERSION) returns a string that begins with the supported version number. But in GLES, the version number is preceded by the text "OpenGL ES GLSL ES ". This was causing glslparsertest to fail to parse the implementation's supported GLSL version, and t

[Piglit] [PATCH RESEND 0/3] glslparsertest: ES fixes

These patches seem to have fallen through the cracks last time I sent them (2/14). I'd appreciate some review. Without these patches, glslparsertest_gles2 doesn't work at all, since it parses the GLSL version string incorrectly, refers to uninitialized data, and checks for incorrect extensions.