Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
On Fri, Sep 27, 2013 at 9:02 AM, Paul Berry stereotype...@gmail.com wrote:
These tests verify that unsized arrays appearing inside interface
blocks obey the same rules as unsized arrays appearing outside
interface blocks. Namely, their size
On 16 October 2013 00:26, Jordan Justen jljus...@gmail.com wrote:
On Tue, Oct 8, 2013 at 11:29 AM, Paul Berry stereotype...@gmail.com
wrote:
Although it is not explicitly stated in the GLSL spec, all examples of
redeclaring built-in in/out variables (such as gl_ClipDistance)
include the
On Wed, Oct 16, 2013 at 12:43 AM, Pohjolainen, Topi
topi.pohjolai...@intel.com wrote:
I don't know why it fixes it, I just tried it without the visual settings
and
found out that I could run the shader_runner by relaxing the settings. I'm
running 7.1 debian and I thought that the gl-driver
On 10/14/2013 04:37 PM, Jordan Justen wrote:
Chad,
I wanted a similar feature, but I was also thinking of adding a
piglit-util function (piglit_get_microseconds). I think it should be
easy to port this function to windows.
I also had the cmake parts a little different, but I don't really
On Mon, Oct 14, 2013 at 05:06:18PM -0500, Aaron Watry wrote:
On Mon, Sep 30, 2013 at 9:47 AM, Tom Stellard t...@stellard.net wrote:
From: Tom Stellard thomas.stell...@amd.com
cl_size has been renamed to vec_elements and cl_mem_size has been
renamed to vec_mem_elements. This use of size
LGTM.
Jose
- Original Message -
Test error checking for width != height and depth % 6 != 0 for cube arrays.
---
tests/spec/arb_texture_storage/texture-storage.c | 66
++
1 file changed, 66 insertions(+)
diff --git
Jordan Justen jordan.l.jus...@intel.com writes:
git://people.freedesktop.org/~jljusten/piglit shader_runner-time-v1
I think shader_runner could be an easy way to develop
quick micro-benchmarks when working on performance.
I found shader_runner only required a few tweaks to
be usable for
The texture-immutable-levels.c tests these state variables after
glTexStorage calls and with a texture object bound to same.
The test I added queries these state variables after glTextureView and
with texture object bound to the view rather than the storage texture.
So that is why I added
I am not sure why the texture-immutable-levels.c file is in the
arb_texture_view directory since
it doesn't actually call glTextureView(). Should it be in the
arb_texture_storage directory instead?
On 10/15/2013 05:34 PM, Matt Turner wrote:
On Mon, Oct 14, 2013 at 2:31 PM, Jon Ashburn
On Wed, Oct 16, 2013 at 12:30 PM, Jon Ashburn j...@lunarg.com wrote:
I am not sure why the texture-immutable-levels.c file is in the
arb_texture_view directory since
it doesn't actually call glTextureView(). Should it be in the
arb_texture_storage directory instead?
The background is that ES
On Wed, Oct 16, 2013 at 12:58 PM, Jon Ashburn j...@lunarg.com wrote:
Matt:
Thanks for clarification, I understand now why the test is in
arb_texture_view directory and the purpose it serves. I still think testing
TEXTURE_IMMUTABLE_LEVELS and TEXTURE_VIEW_NUM_LEVELS after a glTextureView()
On 10/16/2013 01:46 PM, Ian Romanick wrote:
On 10/16/2013 07:43 AM, Paul Berry wrote:
On 16 October 2013 00:26, Jordan Justen jljus...@gmail.com wrote:
Also, perhaps we should log a spec bug to ask the spec to clarify this?
IMHO, the intent is already clear from the fact that all the
On 16 October 2013 13:50, Ian Romanick i...@freedesktop.org wrote:
On 10/16/2013 01:46 PM, Ian Romanick wrote:
On 10/16/2013 07:43 AM, Paul Berry wrote:
On 16 October 2013 00:26, Jordan Justen jljus...@gmail.com wrote:
Also, perhaps we should log a spec bug to ask the spec to clarify this?
On 10/16/2013 02:04 PM, Paul Berry wrote:
On 16 October 2013 13:50, Ian Romanick i...@freedesktop.org
mailto:i...@freedesktop.org wrote:
On 10/16/2013 01:46 PM, Ian Romanick wrote:
On 10/16/2013 07:43 AM, Paul Berry wrote:
On 16 October 2013 00:26, Jordan Justen
On Wed, Oct 16, 2013 at 2:14 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
This mostly reverts bd096a8a, but it keeps the subtest reporting. The
non-idomatic way this test was implemented was causing confusion for at
least one new piglit developer.
On 16 October 2013 14:19, Ian Romanick i...@freedesktop.org wrote:
On 10/16/2013 02:04 PM, Paul Berry wrote:
On 16 October 2013 13:50, Ian Romanick i...@freedesktop.org
mailto:i...@freedesktop.org wrote:
On 10/16/2013 01:46 PM, Ian Romanick wrote:
On 10/16/2013 07:43 AM, Paul
CC: Ian Romanick i...@freedesktop.org
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4ec5ddf..82a9d4a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -272,7 +272,6 @@
This defaults to true on Linux and false elswhere. If set, then CMake
requires that EGL be installed onto the system.
CC: Ian Romanick i...@freedesktop.org
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 21 -
1 file changed, 12 insertions(+), 9
On 10/14/2013 03:27 PM, Ian Romanick wrote:
On 10/14/2013 03:25 PM, Ian Romanick wrote:
I think this needs a bit more love in the CMakeLists. It can't find
EGL/egl.h and friends when they're not installed in the default places.
I sure wish cmake and pkgconfig were better friends. :(
Should fix Ian's build failure with egl-terminate-then-unbind-context.c.
Windows doesn't have pkg-config. So, if Piglit ever wants to support the EGL
tests on Windows, we will need to create a wrapper that calls into
pkg_check_modules() or find_package() based on OS.
Chad Versace (4):
cmake:
On 10/15/2013 04:33 PM, Jordan Justen wrote:
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Chad Versace chad.vers...@linux.intel.com
---
Chad, this conflicts with your Detect if system has POSIX clocks patch,
but it could be tweaked to follow your version.
I'm not opposed to
On 10/16/2013 09:55 AM, Jordan Justen wrote:
On Wed, Oct 16, 2013 at 9:24 AM, Ian Romanick i...@freedesktop.org wrote:
On 10/14/2013 04:37 PM, Jordan Justen wrote:
Chad,
I wanted a similar feature, but I was also thinking of adding a
piglit-util function (piglit_get_microseconds). I think it
On 10/16/2013 03:38 PM, Ken Phillis Jr wrote:
I think it may be a good idea to mirror this change for glesv1_cm and glesv2
I agree, and I plan on doing that next if this series gets accepted.
___
Piglit mailing list
Piglit@lists.freedesktop.org
From: Ian Romanick ian.d.roman...@intel.com
The test uses 3D textures which were not part of OpenGL until 1.2. This
doesn't matter much in practice because the Linux OpenGL ABI requires at
least OpenGL 1.2. Change the minimum GL version from 1.0 to 1.2.
Also, require GL_ARB_texture_cube_map
On 10/16/2013 09:55 AM, Jordan Justen wrote:
On Wed, Oct 16, 2013 at 9:24 AM, Ian Romanick i...@freedesktop.org wrote:
On 10/14/2013 04:37 PM, Jordan Justen wrote:
Chad,
I wanted a similar feature, but I was also thinking of adding a
piglit-util function (piglit_get_microseconds). I think it
On Wed, Oct 16, 2013 at 3:51 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
This mostly reverts bd096a8a, but it keeps the subtest reporting. The
non-idomatic way this test was implemented was causing confusion for at
least one new piglit developer.
On 10/16/2013 03:45 PM, Chad Versace wrote:
On 10/15/2013 04:33 PM, Jordan Justen wrote:
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Chad Versace chad.vers...@linux.intel.com
---
Chad, this conflicts with your Detect if system has POSIX clocks patch,
but it could be tweaked to
Updated the params test to divide it into three smaller tests: formats,
targets and params.
Also updated code to better follow current Piglit idioms and coding
practices as found in arb_sync and arb_texture_storage.
Added existing texture_view test texture_immutable_levels to all.tests.
Tests GL_ARB_texture_view and validity of input parameters.
Use both valid and invalid parameters, although mostly invalid
parameters are tested since other tests will use valid parameters.
Only the parameters texture, origtexture, minlevel, numlevels,
minlayer, numlayers are tested for
On Wed, Oct 16, 2013 at 3:51 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
The test uses 3D textures which were not part of OpenGL until 1.2. This
doesn't matter much in practice because the Linux OpenGL ABI requires at
least OpenGL 1.2. Change the
When calling glTextureView() only certain formats are valid based on the format
of the original texture. This tests valid/invalid combinations.
Tested on Nvidia Quadro 600, all tests pass.
---
tests/all.tests | 1 +
tests/spec/arb_texture_view/CMakeLists.gl.txt |
The new target supplied with textureView must be compatible with the
original textures target. This tests valid and invalid combinations.
Tested on Nvidia Quadro 600, all tests pass.
---
tests/all.tests | 1 +
tests/spec/arb_texture_view/CMakeLists.gl.txt | 1 +
On 10/16/2013 04:38 PM, Matt Turner wrote:
On Wed, Oct 16, 2013 at 3:51 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
The test uses 3D textures which were not part of OpenGL until 1.2. This
doesn't matter much in practice because the Linux OpenGL
On Wed, Oct 16, 2013 at 4:43 PM, Ian Romanick i...@freedesktop.org wrote:
On 10/16/2013 04:38 PM, Matt Turner wrote:
On Wed, Oct 16, 2013 at 3:51 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
The test uses 3D textures which were not part of OpenGL
From: Tom Stellard thomas.stell...@amd.com
---
tests/cl/program/execute/opencv-calLUT.cl | 88 +++
1 file changed, 88 insertions(+)
create mode 100644 tests/cl/program/execute/opencv-calLUT.cl
diff --git a/tests/cl/program/execute/opencv-calLUT.cl
Much better :)
Reviewed-by: Chris Forbes chr...@ijw.co.nz
On Tue, Oct 15, 2013 at 11:13 PM, Dylan Baker baker.dyla...@gmail.com wrote:
This is the commonly excepted right way in python.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 77
+def generate_HTML(self, destination, exclude):
Would probably go with 'generate_html'
On Tue, Oct 15, 2013 at 11:13 PM, Dylan Baker baker.dyla...@gmail.com wrote:
Fix style issues with camel case method names.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py
37 matches
Mail list logo
