Re: [Piglit] [PATCH] gles-es-1.00: add linker test to check default precision qualifier redeclaration

2016-10-20 Thread Samuel Iglesias Gonsálvez
On 21/10/16 05:55, Timothy Arceri wrote: > On Thu, 2016-10-20 at 12:37 +0200, Samuel Iglesias Gonsálvez wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97804 >> Signed-off-by: Samuel Iglesias Gonsálvez >> --- >>

Re: [Piglit] [PATCH] gles-es-1.00: add linker test to check default precision qualifier redeclaration

2016-10-20 Thread Timothy Arceri
On Thu, 2016-10-20 at 12:37 +0200, Samuel Iglesias Gonsálvez wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97804 > Signed-off-by: Samuel Iglesias Gonsálvez > --- >  ...t-precision-qualifier-redeclaration.shader_test | 34 > ++ >  1 file

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dave Airlie
On 21 October 2016 at 12:26, Dan Kegel wrote: > On Thu, Oct 20, 2016 at 6:49 PM, Dave Airlie wrote: >> If piglit crashes or explodes it's the driver's fault. > > Are you quite sure? There could be bugs in piglit, no? It would most likely crash on all drivers

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dan Kegel
On Thu, Oct 20, 2016 at 6:49 PM, Dave Airlie wrote: > If piglit crashes or explodes it's the driver's fault. Are you quite sure? There could be bugs in piglit, no? > But really you don't debug piglit tests without access to the source > code of the driver, and for that you

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dave Airlie
On 21 October 2016 at 05:56, Dan Kegel wrote: > I guess the underlying question is "how much work would it > be to get piglit to the point where errors it reports when > run against nvidia's proprietary drivers are actual problems in those > drivers". > I suspect it'd be a good

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Add GL_ARB_compute_variable_group_size requirement

2016-10-20 Thread Ian Romanick
On 10/17/2016 09:03 PM, Matt Turner wrote: > On Mon, Oct 17, 2016 at 6:04 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick > > I actually sent and committed this patch earlier today. I

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dan Kegel
I guess the underlying question is "how much work would it be to get piglit to the point where errors it reports when run against nvidia's proprietary drivers are actual problems in those drivers". I suspect it'd be a good summer project. On Thu, Oct 20, 2016 at 12:39 PM, Ilia Mirkin

Re: [Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Ilia Mirkin
On Thu, Oct 20, 2016 at 3:27 PM, Dan Kegel wrote: > Hi folks, > a few piglit tests seem to leave a little noise in dmesg when run on > nvidia proprietary drivers. > Is this expected? > > 1) > > dmesg output: > texsubimage[27980]: segfault at 20e0d20 ip 7fc0492ce5d5 sp >

[Piglit] Piglit tests that leave noise in dmesg on nvidia proprietary drivers

2016-10-20 Thread Dan Kegel
Hi folks, a few piglit tests seem to leave a little noise in dmesg when run on nvidia proprietary drivers. Is this expected? 1) dmesg output: texsubimage[27980]: segfault at 20e0d20 ip 7fc0492ce5d5 sp 7ffc97347800 error 4 in libnvidia-glcore.so.370.28[7fc0481ad000+13bd000] reproducers:

Re: [Piglit] [PATCH] gles-es-1.00: add linker test to check default precision qualifier redeclaration

2016-10-20 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/20/2016 01:37 PM, Samuel Iglesias Gonsálvez wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97804 Signed-off-by: Samuel Iglesias Gonsálvez --- ...t-precision-qualifier-redeclaration.shader_test | 34

[Piglit] [PATCH] gles-es-1.00: add linker test to check default precision qualifier redeclaration

2016-10-20 Thread Samuel Iglesias Gonsálvez
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97804 Signed-off-by: Samuel Iglesias Gonsálvez --- ...t-precision-qualifier-redeclaration.shader_test | 34 ++ 1 file changed, 34 insertions(+) create mode 100644

Re: [Piglit] [PATCH] glsl-1.20: test declaring gl_Position with the invariant qualifier.

2016-10-20 Thread Marek Olšák
If it's just a linker test, the draw call is unnecessary. I think this can be used instead: [test] link success Whether or not you use that fix: Reviewed-by: Marek Olšák Marek On Wed, Oct 19, 2016 at 1:28 AM, Brian Paul wrote: > To exercise a Mesa GLSL

Re: [Piglit] [PATCH 2/2] arb_gpu_shader_fp64: add some inout function argument tests

2016-10-20 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Mon, Oct 17, 2016 at 7:21 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This exposes a bug in st_glsl_to_tgsi. > --- > .../execution/fs-function-inout-array.shader_test

[Piglit] [PATCH] shaders/out-parameter-indexing: add a more complex indexing case

2016-10-20 Thread Nicolai Hähnle
From: Nicolai Hähnle Cc: Ian Romanick --- .../fs-inout-index-two-level.shader_test | 49 ++ 1 file changed, 49 insertions(+) create mode 100644