[Piglit] [PATCH] all.py: add missing argument to arb_sample_shading-samplemask test

2017-10-13 Thread Brian Paul
As it was, argc != 4 caused the test to print usage info and exit with PIGLIT_FAIL. Fixes bbc27395cfc93d3f3 "arb_sample_shading: add more extensive gl_SampleMask(In) tests". --- tests/all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index

[Piglit] [PATCH 10/11] all.py: run ARB_draw_buffers_blend test concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index 5bd0e5d..046c02b 100644 --- a/tests/all.py +++ b/tests/all.py @@ -4291,7 +4291,7 @@ with profile.test_list.group_manager( PiglitGLTest, grouptools.join('spec',

[Piglit] [PATCH 03/11] all.py: run ARB_instanced_arrays tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/all.py b/tests/all.py index 33b441c..76a17af 100644 --- a/tests/all.py +++ b/tests/all.py @@ -3851,10 +3851,9 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 09/11] all.py: run EXT_draw_buffers2 tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 73ee729..5bd0e5d 100644 --- a/tests/all.py +++ b/tests/all.py @@ -4283,9 +4283,9 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 02/11] all.py: run ati_draw_buffers tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/all.py b/tests/all.py index f21575d..33b441c 100644 --- a/tests/all.py +++ b/tests/all.py @@ -3841,11 +3841,9 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 01/11] all.py run ARB_depth_clamp tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index f9ff6b0..f21575d 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1978,9 +1978,9 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 07/11] all.py: remove run_concurrent=False from some GLSL 1.30 tests

2017-10-13 Thread Brian Paul
--- tests/all.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/all.py b/tests/all.py index 9055979..5a2f112 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1632,25 +1632,24 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 04/11] all.py: run ARB_seamless_cube_map tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 76a17af..01eca2c 100644 --- a/tests/all.py +++ b/tests/all.py @@ -3911,9 +3911,9 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 05/11] all.py: run NV_conditional_render tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/tests/all.py b/tests/all.py index 01eca2c..055608e 100644 --- a/tests/all.py +++ b/tests/all.py @@ -3959,22 +3959,16 @@ with profile.test_list.group_manager(

[Piglit] [PATCH 11/11] all.py: run ARB_draw_buffers tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 046c02b..9f37ba2 100644 --- a/tests/all.py +++ b/tests/all.py @@ -4276,9 +4276,9 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 08/11] all.py: run ARB_blend_func_extended tests concurrently

2017-10-13 Thread Brian Paul
--- tests/all.py | 41 + 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/tests/all.py b/tests/all.py index 5a2f112..73ee729 100644 --- a/tests/all.py +++ b/tests/all.py @@ -4296,30 +4296,23 @@ with profile.test_list.group_manager( with

Re: [Piglit] [PATCH 0/7] framework, shader_runner: misc fixed and cleanups

2017-10-13 Thread Eric Anholt
Nicolai Hähnle writes: > Hi all, > > Mostly no-op changes in comments, but a few functional changes as well. This series is: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mailing

[Piglit] [PATCH 6/9] all.py: remove run_concurrent=False from ARB_draw_instanced test

2017-10-13 Thread Brian Paul
--- tests/all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index bf67813..f4fdd10 100644 --- a/tests/all.py +++ b/tests/all.py @@ -2008,7 +2008,7 @@ with profile.test_list.group_manager( 'negative-arrays-first-negative')

[Piglit] [PATCH 4/9] all.py: remove run_concurrent=False from most GL 3.0 tests

2017-10-13 Thread Brian Paul
gl30basic does front buffer rendering, so keep it non-concurrent. --- tests/all.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/all.py b/tests/all.py index b4cd2ad..62db45a 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1213,7 +1213,7 @@ with

[Piglit] [PATCH 5/9] all.py: remove run_concurrent=False from ARB_draw_elements_base_vertex tests

2017-10-13 Thread Brian Paul
--- tests/all.py | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/tests/all.py b/tests/all.py index 62db45a..bf67813 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1987,21 +1987,16 @@ with profile.test_list.group_manager( PiglitGLTest,

[Piglit] [PATCH 9/9] all.py remove run_concurrent=False from ARB_fragment_program tests

2017-10-13 Thread Brian Paul
Not needed after fixing trinity-fp1 and fp-fragment-position tests. --- tests/all.py | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/all.py b/tests/all.py index f4fdd10..f9ff6b0 100644 --- a/tests/all.py +++ b/tests/all.py @@

[Piglit] [PATCH 3/9] gl30basic: configure with requires_displayed_window = true

2017-10-13 Thread Brian Paul
There are calls to glDraw/ReadBuffer(GL_FRONT) which fail with fbo rendering. --- tests/general/gl30basic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/general/gl30basic.c b/tests/general/gl30basic.c index d9d8ab8..cb85a91 100644 --- a/tests/general/gl30basic.c +++

[Piglit] [PATCH 2/9] all.py: remove run_concurrent=False from GL 2.0 tests

2017-10-13 Thread Brian Paul
Not needed, AFAICT. No change with llvmpipe. --- tests/all.py | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/all.py b/tests/all.py index 168dd85..b4cd2ad 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1143,9 +1143,9 @@ with

[Piglit] [PATCH 1/9] all.py put GL 1.1 tests after GL 1.0 tests

2017-10-13 Thread Brian Paul
Trivial clean-up. --- tests/all.py | 74 ++-- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/tests/all.py b/tests/all.py index a450e42..168dd85 100644 --- a/tests/all.py +++ b/tests/all.py @@ -898,6 +898,43 @@ with

[Piglit] [PATCH 7/9] trinity-fp1: use glGenTextures() instead of hard-coded texture IDs

2017-10-13 Thread Brian Paul
This allows the test to run with -fbo --- tests/shaders/trinity-fp1.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/shaders/trinity-fp1.c b/tests/shaders/trinity-fp1.c index 0ea32ad..89a201e 100644 --- a/tests/shaders/trinity-fp1.c +++

[Piglit] [PATCH 8/9] fp-fragment-position: use glGenTextures()

2017-10-13 Thread Brian Paul
Instead of hard-coded texture IDs. This allows the test to run with -fbo. --- tests/shaders/fp-fragment-position.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/shaders/fp-fragment-position.c b/tests/shaders/fp-fragment-position.c index fad97f5..84dbf3c 100644

Re: [Piglit] [PATCH 4/4] simple-readbuffer: simplify a conditional

2017-10-13 Thread Eric Anholt
Brian Paul writes: > I find this slightly easier to read. Series is: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH 1/5] all.py: remove run_concurrent=False from most 1.1 tests

2017-10-13 Thread Eric Anholt
Brian Paul writes: > There was no reason for most of these tests to be marked as > run_concurrent=False. The previous commits fixed a few issues > when enabling concurrency. > > Also, move some of the slower-running tests (like streaming-texture-leak) > to the top of the list

[Piglit] [PATCH] util: add casts in strchrnul()

2017-10-13 Thread Brian Paul
To fix build on MacOS. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103248 --- tests/util/piglit-util.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util.h b/tests/util/piglit-util.h index c4e7818..3757f86 100644 ---

[Piglit] [Bug 103248] piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 --- Comment #5 from Brian Paul --- Patch posted to piglit mailing list for review. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Piglit] [PATCH 1/4] arb_direct_state_access: fix sample count in texture-storage-multisample

2017-10-13 Thread Brian Paul
Use value of GL_MAX_COLOR_TEXTURE_SAMPLES for glTextureStorage2DMultisample(). Allows sub tests to pass instead of fail with llvmpipe. --- .../texture-storage-multisample.c| 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git

[Piglit] [PATCH 2/4] arb_texture_storage_multisample fix sample count in tex-storage.c

2017-10-13 Thread Brian Paul
Use GL_MAX_COLOR_TEXTURE_SAMPLES as sample count for glTextureStorage2DMultisample(). Allows the test to pass on llvmpipe. --- tests/spec/arb_texture_storage_multisample/tex-storage.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[Piglit] [PATCH 4/4] gl-3.2: fix sample count in layered rendering tests

2017-10-13 Thread Brian Paul
Use GL_MAX_COLOR_TEXTURE_SAMPLES as sample count for glTextureStorage3DMultisample(). Allows these tests to pass on llvmpipe. --- .../gl-3.2/layered-rendering/framebuffer-layered-attachments.c | 7 +-- tests/spec/gl-3.2/layered-rendering/gl-layer-render-storage.c | 5 -

[Piglit] [PATCH 3/4] glsl-1.50: fix sample count in interface-block-centroid.c

2017-10-13 Thread Brian Paul
Use GL_MAX_SAMPLES as sample count for glRenderbufferStorageMultisample(). Allows the test to pass on llvmpipe. --- tests/spec/glsl-1.50/execution/interface-block-centroid.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH 1/4] framework: fix comment typos

2017-10-13 Thread Alejandro Piñeiro
The 4-patches series: Reviewed-by: Alejandro Piñeiro On 13/10/17 06:22, Brian Paul wrote: > --- > framework/test/shader_test.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/framework/test/shader_test.py b/framework/test/shader_test.py >