Re: [Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

2018-06-20 Thread Marek Olšák
On Thu, Jun 21, 2018 at 12:12 AM, Timothy Arceri wrote: > > > On 21/06/18 14:05, Marek Olšák wrote: >> >> On Mon, Jun 18, 2018 at 12:50 AM, Timothy Arceri >> wrote: >>> >>> --- >>> tests/opengl.py | 1 + >>> .../arb_tessellation_shader/CMakeLists.gl.txt | 1 +

Re: [Piglit] [PATCH 2/2] arb_tessellation_shader: test tes interaction with fixed function fragment shader

2018-06-20 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Sun, Jun 17, 2018 at 10:46 PM, Timothy Arceri wrote: > --- > .../compatibility/tcs-tes-ff-frag.shader_test | 63 +++ > 1 file changed, 63 insertions(+) > create mode 100644 > tests/spec/arb_tessellation_shader/execution/compa

Re: [Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

2018-06-20 Thread Timothy Arceri
On 21/06/18 14:05, Marek Olšák wrote: On Mon, Jun 18, 2018 at 12:50 AM, Timothy Arceri wrote: --- tests/opengl.py | 1 + .../arb_tessellation_shader/CMakeLists.gl.txt | 1 + .../immediate-mode-draw-patches.c | 111 ++ 3 files

Re: [Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

2018-06-20 Thread Marek Olšák
On Mon, Jun 18, 2018 at 12:50 AM, Timothy Arceri wrote: > --- > tests/opengl.py | 1 + > .../arb_tessellation_shader/CMakeLists.gl.txt | 1 + > .../immediate-mode-draw-patches.c | 111 ++ > 3 files changed, 113 insertions(+) > create

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: test display list support

2018-06-20 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Tue, Jun 19, 2018 at 6:07 AM, Timothy Arceri wrote: > --- > tests/opengl.py | 1 + > .../arb_gpu_shader_fp64/CMakeLists.gl.txt | 1 + > .../arb_gpu_shader_fp64/dlist-fp64-uniforms.c | 406 ++ > 3 files changed

Re: [Piglit] [PATCH] arb_shader_subroutine: add simple display list test

2018-06-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jun 19, 2018 at 9:13 PM, Timothy Arceri wrote: > --- > .../simple-subroutine-dlist.shader_test | 92 +++ > 1 file changed, 92 insertions(+) > create mode 100644 > tests/spec/arb_shader_subroutine/execution/simple-subroutine-dlist.s

Re: [Piglit] [PATCH] arb_viewport_array: test display list support

2018-06-20 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Wed, Jun 20, 2018 at 8:24 PM, Timothy Arceri wrote: > --- > tests/opengl.py | 1 + > .../spec/arb_viewport_array/CMakeLists.gl.txt | 1 + > tests/spec/arb_viewport_array/dlist.c | 355 ++ > 3 files changed

[Piglit] [PATCH] deqp: Add Mesa version overrides for khr_gl* testlist generation.

2018-06-20 Thread Eric Anholt
The runner will assertion fail if it can't create an appropriate context, so just force the version so that we can get our testlists generated. --- framework/test/deqp.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/framework/test/deqp.py b/framework/test/deqp.py index

[Piglit] [PATCH] arb_viewport_array: test display list support

2018-06-20 Thread Timothy Arceri
--- tests/opengl.py | 1 + .../spec/arb_viewport_array/CMakeLists.gl.txt | 1 + tests/spec/arb_viewport_array/dlist.c | 355 ++ 3 files changed, 357 insertions(+) create mode 100644 tests/spec/arb_viewport_array/dlist.c diff --git a/tests

Re: [Piglit] [PATCH v2 4/4] getteximage-simple: Stress an i965 blitter path

2018-06-20 Thread Nanley Chery
On Wed, Jun 20, 2018 at 09:35:21PM +0100, Lionel Landwerlin wrote: > On 20/06/18 20:49, Nanley Chery wrote: > > On Wed, Jun 20, 2018 at 06:32:58PM +0100, Lionel Landwerlin wrote: > > > On 19/06/18 18:53, Nanley Chery wrote: > > > > On Tue, Jun 19, 2018 at 11:03:17AM +0100, Lionel Landwerlin wrote:

Re: [Piglit] [PATCH v2 4/4] getteximage-simple: Stress an i965 blitter path

2018-06-20 Thread Lionel Landwerlin
On 20/06/18 20:49, Nanley Chery wrote: On Wed, Jun 20, 2018 at 06:32:58PM +0100, Lionel Landwerlin wrote: On 19/06/18 18:53, Nanley Chery wrote: On Tue, Jun 19, 2018 at 11:03:17AM +0100, Lionel Landwerlin wrote: On 18/06/18 19:57, Nanley Chery wrote: Change the dimension of the texture to tes

Re: [Piglit] [PATCH v2 4/4] getteximage-simple: Stress an i965 blitter path

2018-06-20 Thread Nanley Chery
On Wed, Jun 20, 2018 at 06:32:58PM +0100, Lionel Landwerlin wrote: > On 19/06/18 18:53, Nanley Chery wrote: > > On Tue, Jun 19, 2018 at 11:03:17AM +0100, Lionel Landwerlin wrote: > > > On 18/06/18 19:57, Nanley Chery wrote: > > > > Change the dimension of the texture to test how i965 handles having

Re: [Piglit] [PATCH v2 4/4] getteximage-simple: Stress an i965 blitter path

2018-06-20 Thread Lionel Landwerlin
On 19/06/18 18:53, Nanley Chery wrote: On Tue, Jun 19, 2018 at 11:03:17AM +0100, Lionel Landwerlin wrote: On 18/06/18 19:57, Nanley Chery wrote: Change the dimension of the texture to test how i965 handles having a row pitch too large for the BLT engine. v2: Query the maximum supported texture

Re: [Piglit] [PATCH v2 00/24] ARB_gl_spirv: support for loading SPIR-V binaries, plus first set of tests

2018-06-20 Thread Alejandro Piñeiro
I forgot to mention that you can find this series, rebased against today master, here: https://github.com/Igalia/piglit/tree/arb_gl_spirv-series1-uniforms-v2 On 20/06/18 14:40, Alejandro Piñeiro wrote: > Hi, > > this is the second version of the first series of patches to add tests > for the ARB

[Piglit] [PATCH 16/24] arb_gl_spirv: Add a test for a sampler within a struct

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/sampler2d-struct.shader_test | 98 ++ 1 file changed, 98 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d-struct.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/sampler2d-s

[Piglit] [PATCH v2 00/24] ARB_gl_spirv: support for loading SPIR-V binaries, plus first set of tests

2018-06-20 Thread Alejandro Piñeiro
Hi, this is the second version of the first series of patches to add tests for the ARB_gl_spirv spec. This is basically a rebased against master version of the original series. You can find the details here: https://lists.freedesktop.org/archives/piglit/2018-April/024145.html Sending again as th

[Piglit] [PATCH 20/24] arb_gl_spirv: Add a test for non-sequential explicit uniform locations

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts Tests using two uniforms that have explicit uniform locations with a gap between them. --- .../uniform/nonsequential-locations.shader_test| 69 ++ 1 file changed, 69 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/nonsequent

[Piglit] [PATCH 17/24] arb_gl_spirv: Add a test for nonconst array of sampler structs

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts This is a simple port of arb_arrays_of_arrays/execution/sampler/ fs-nested-struct-arrays-nonconst-nested-array.shader_test --- .../sampler2d-nonconst-nested-array.shader_test| 225 + 1 file changed, 225 insertions(+) create mode 100644 tests/spec/arb_

[Piglit] [PATCH 14/24] arb_gl_spirv: uniform sampler2D

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/sampler2d.shader_test| 70 ++ 1 file changed, 70 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/sampler2d.shader_test b/tests/spec/arb_

[Piglit] [PATCH 15/24] arb_gl_spirv: Add tests for sampler2D uniform binding initialisers

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../uniform/sampler2d-binding-array.shader_test| 85 ++ .../uniform/sampler2d-binding.shader_test | 70 ++ 2 files changed, 155 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/sampler2d-binding-a

[Piglit] [PATCH 09/24] arb_gl_spirv: basic uniform test with names still present

2018-06-20 Thread Alejandro Piñeiro
From: Nicolai Hähnle Signed-off-by: Nicolai Hähnle Signed-off-by: Neil Roberts --- .../execution/uniform/simple.shader_test | 124 + 1 file changed, 124 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/simple.shader_test diff --git a/te

[Piglit] [PATCH 06/24] shader_runner: debug prints if running on SPIR-V mode.

2018-06-20 Thread Alejandro Piñeiro
Fancy to be sure that shader_runner is trying to run in SPIR-V mode. Didn't print if it is running on GLSL mode as that is the default. Initially only some small amount of tests will run on SPIR-V mode. --- tests/shaders/shader_runner.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/

[Piglit] [PATCH 12/24] arb_gl_spirv: add a small test with an array of uniforms

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/array.shader_test| 137 + 1 file changed, 137 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/array.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/array.shader_test b/tests/spec/arb_gl_spirv

[Piglit] [PATCH 23/24] arb_gl_spirv: Add a test for an array of structs uniform

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/struct-array.shader_test | 140 + 1 file changed, 140 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/struct-array.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/struct-array.sh

[Piglit] [PATCH 24/24] arb_gl_spirv: Add a fiddly test for uniform index calculation

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts This is a somewhat convoluted test to catch a particular problem with the code we were using to assign a uniform index to a variable. A uniform’s location starts off being the explicit location. Previously while recursing through the uniform’s type, whenever the location matche

[Piglit] [PATCH 13/24] arb_gl_spirv: add execution test for multi-dimensional (aoa) uniform

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/arrays-of-arrays.shader_test | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/arrays-of-arrays.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/arrays-of-arrays.shader_test b/

[Piglit] [PATCH 05/24] shader_runner/spirv: Add support for SPIR-V specializations

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts There can now be extra sections such as the following in the shader_test file: [vertex shader specializations] uint 0 3 These will get passed to glSpecializeShader when compiling the corresponding shader. --- tests/shaders/shader_runner.c | 181 ++

[Piglit] [PATCH 21/24] arb_gl_spirv: Add a test for a struct uniform

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/struct.shader_test | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/struct.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/struct.shader_test b/t

[Piglit] [PATCH 22/24] arb_gl_spirv: Add a test for a uniform struct with struct members

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/uniform/embedded-structs.shader_test | 151 + 1 file changed, 151 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/embedded-structs.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/embedded-s

[Piglit] [PATCH 18/24] arb_gl_spirv: add two linking tests for uniform multisample images

2018-06-20 Thread Alejandro Piñeiro
Use a uniform image2DMS and image2DMSArray. The latter related with SpvCapabilityImageMSArray. Note that those are linking tests, because although the specific extensions are supported, in the practice multisampling is not allowed as GL_MAX_IMAGE_SAMPLES is zero for most mesa drivers. Signed-off-

[Piglit] [PATCH 11/24] arb_gl_spirv: add basic test with two uniforms

2018-06-20 Thread Alejandro Piñeiro
--- .../execution/uniform/two-uniforms.shader_test | 132 + 1 file changed, 132 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/uniform/two-uniforms.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/uniform/two-uniforms.shader_test b/tests/sp

[Piglit] [PATCH 01/24] util: Add a utility to stream data through an external process

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts The data is given as a buffer which is streamed through the standard in of the child process. The standard output is captured into a buffer. --- tests/util/CMakeLists.txt | 1 + tests/util/piglit-subprocess.c | 207 + tests/util/p

[Piglit] [PATCH 03/24] framework: add --glsl option

2018-06-20 Thread Alejandro Piñeiro
So when executing shader tests, they will be executed with -glsl. This is the force GLSL mode, that is only relevant if the shader test includes SPIR-V shaders. So for example: ./piglit run tests/shader.py -t ARB_gl_spirv --glsl results/results Will try to run all the shader tests for ARB_gl_spir

[Piglit] [PATCH 10/24] arb_gl_spirv: add basic uniform test without names

2018-06-20 Thread Alejandro Piñeiro
From: Nicolai Hähnle The names were removed from the text-format SPIR-V by hand. Signed-off-by: Alejandro Piñeiro Signed-off-by: Nicolai Hähnle --- .../uniform/simple-without-names.shader_test | 111 + 1 file changed, 111 insertions(+) create mode 100644 tests/spec

[Piglit] [PATCH 04/24] shader_runner/spirv: add vertex shader passthrough support on SPIR-V

2018-06-20 Thread Alejandro Piñeiro
Adds a equivalent to the existing GLSL passthrough_vertex_shader_source, but with an SPIR-V assembly one. As it is somewhat big, moved to a different header. An alternative would be kept the assembly on a file, and open it when required. --- tests/shaders/shader_runner.c| 8 +

[Piglit] [PATCH 08/24] arb_gl_spirv: Add a test using specializations

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts --- .../execution/vs-ps-specializations.shader_test| 181 + 1 file changed, 181 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/vs-ps-specializations.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/vs-ps-specializations

[Piglit] [PATCH 07/24] arb_gl_spirv: add really simple execution test

2018-06-20 Thread Alejandro Piñeiro
Really basic VS-PS pipeline, without uniforms. --- .../execution/vs-ps-simple.shader_test | 119 + 1 file changed, 119 insertions(+) create mode 100644 tests/spec/arb_gl_spirv/execution/vs-ps-simple.shader_test diff --git a/tests/spec/arb_gl_spirv/execution/vs-ps-

[Piglit] [PATCH 02/24] shader_runner/spirv: support loading SPIR-V shaders

2018-06-20 Thread Alejandro Piñeiro
From: Nicolai Hähnle This commit add support to load a SPIR-V shader, possible since ARB_gl_spirv. The SPIR-V shader is included on the shader_test script on new shader stage versions ([vertex shader spirv], [fragment shader spirv], etc). It is not in direct binary format, but in assembly format

[Piglit] [PATCH 19/24] arb_gl_spirv: Add 4 tests for uniform initializers

2018-06-20 Thread Alejandro Piñeiro
From: Neil Roberts This includes a basic test with uniform initializers, one using a mat4x3 type, one using a dvec4 and finally a complex one using a combination of types (arrays, structs and mats). # This is the commit message #2: --- .../uniform/initializer-complex.shader_test| 180 ++