Re: [Piglit] [PATCH] gl-1.5-vertex-buffer-offsets: test unusual vertex offsets/strides

2015-06-19 Thread Brian Paul
On 06/19/2015 08:47 AM, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 10:39 AM, Brian Paul wrote: The draw-vertices tests exercises unusual vertex sizes and strides, but not with interleaved arrays. This test creates a VBO with interleaved vertex positions and colors. The colors are positioned

[Piglit] [PATCH] gl-1.5-vertex-buffer-offsets: test unusual vertex offsets/strides

2015-06-19 Thread Brian Paul
ILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +/* + * Test interleaved vertex arrays with unusual element offsets and strides. + * Brian Paul + */ + +#include "

Re: [Piglit] [PATCH] cmake: Only build GLES tests by default on systems which support EGL.

2015-06-08 Thread Brian Paul
Looks OK to me. Reviewed-by: Brian Paul On 06/08/2015 06:43 AM, Jose Fonseca wrote: GLES tests require EGL support, so it only make sense that they are on on systems which support EGL, which is Linux ATM. --- CMakeLists.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions

Re: [Piglit] [PATCH 1/3] cmake, util: Disable MacOSX depracation warnings everywhere.

2015-06-08 Thread Brian Paul
red "-Wdeprecated-declarations" -#endif - struct piglit_glut_framework { struct piglit_gl_framework gl_fw; For 1 & 2, Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] util: Implement basename for MSVC.

2015-06-08 Thread Brian Paul
til/piglit-util.h @@ -82,6 +82,8 @@ extern "C" { #define usleep(__usec) Sleep(((__usec) + 999)/1000) +char *basename(char *path); + #endif /* defined(_MSC_VER) */ #if (__GNUC__ >= 3) Looks OK otherwise. Reviewed-by: Brian Paul ___

Re: [Piglit] [PATCH] texwrap: test wrapping texture offsets

2015-05-27 Thread Brian Paul
. Reviewed-by: Brian Paul Thanks. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] texwrap: test wrapping texture offsets

2015-05-26 Thread Brian Paul
On 05/26/2015 07:16 PM, Dave Airlie wrote: while writing softpipe support I realised we didn't have tests for any of this, this just adds a new parameter to texwrap to test texture offsets, Signed-off-by: Dave Airlie --- tests/texturing/texwrap.c | 66 +

Re: [Piglit] [PATCH] dsa: avoid stencil8 in gettextureimage-formats

2015-05-25 Thread Brian Paul
On 05/22/2015 06:37 PM, Ilia Mirkin wrote: This causes an assert failure in mesa and it doesn't seem like this test is designed for depth/stencil formats. If we've got a piglit test that triggers a Mesa assertion, it means there's probably a Mesa bug too, right? -Brian Signed-off-by: Ili

[Piglit] [PATCH] gl-1.0/push-no-attribs: new test of glPushAttrib(0), glPopAttrib()

2015-05-15 Thread Brian Paul
--- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/push-no-attribs.c | 58 + 3 files changed, 60 insertions(+) create mode 100644 tests/spec/gl-1.0/push-no-attribs.c diff --git a/tests/all.py b/tests/a

Re: [Piglit] [PATCH 1/2] shader_runner: add ARB_shader_subroutine support (v3)

2015-04-24 Thread Brian Paul
On 04/23/2015 06:36 PM, Dave Airlie wrote: From: Dave Airlie This adds basic support for executing shader subroutine tests. it comes with two intro tests, and probably a lot of bugs. tested against NVIDIA, for some reason -auto fails here. It might pass if you build piglit w/ glut instead o

Re: [Piglit] [PATCH] tests: Narrow down the scope of Windows unhandled exception filter.

2015-04-21 Thread Brian Paul
_try1/__except1 macros. Tested Mingw32, Mingw64, and MSVC32 builds of build with FreeGLUT. "builds of piglit" I presume. Acked-by: Brian Paul --- .../piglit-framework-gl/piglit_glut_framework.c| 79 ++ tests/util/piglit-util.c |

Re: [Piglit] [PATCH] glsl-1.10: new test for a special case in glsl-to-tgsi

2015-04-13 Thread Brian Paul
Reviewed-by: Brian Paul On 04/13/2015 12:00 PM, Marek Olšák wrote: From: Marek Olšák --- .../glsl-1.10/execution/uniform-update.shader_test | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/uniform-update.shader_test diff

Re: [Piglit] nvidia fails with -auto was Re: [PATCH] drawpixels-color-index: new test for glDrawPixels(GL_COLOR_INDEX)

2015-04-08 Thread Brian Paul
On 04/08/2015 12:12 PM, Brian Paul wrote: On 04/07/2015 08:43 PM, Dave Airlie wrote: On 19 February 2015 at 02:40, Brian Paul wrote: To exercise a Mesa failure after the format overhaul. Note: this test fails on nvidia if the -auto option is given. I noticed this on a bunch of tests I was

Re: [Piglit] nvidia fails with -auto was Re: [PATCH] drawpixels-color-index: new test for glDrawPixels(GL_COLOR_INDEX)

2015-04-08 Thread Brian Paul
On 04/07/2015 08:43 PM, Dave Airlie wrote: On 19 February 2015 at 02:40, Brian Paul wrote: To exercise a Mesa failure after the format overhaul. Note: this test fails on nvidia if the -auto option is given. I noticed this on a bunch of tests I was writing, anyone got any idea when this

Re: [Piglit] [PATCH] V4. Add a case to valid gl_VertexID for bug 87611

2015-04-07 Thread Brian Paul
On 04/07/2015 07:21 PM, Ian Romanick wrote: This test uses tabs for indentation. The coding style for piglit is to never used tabs. Instead, use 4-spaces for each indentation level. Uh, since when? IFAIK, we've been using 8-space tabs for indentation for a long time in piglit. -Brian ___

Re: [Piglit] GSoC 2015: Request for Registration for Mentorship

2015-04-02 Thread Brian Paul
Sorry, I've been busy too. What's the URL for the sign-up? -Brian On Thu, Apr 2, 2015 at 11:00 AM, Laura Ekstrand wrote: > Hi, > > I haven't been able to do this yet because I have a lot going on. > > Sorry. > > Laura > > On Mon, Mar 30, 2015 at 1:10 AM, Juliet Fru wrote: > >> >> Hello +Laur

Re: [Piglit] [PATCH] Move crash cubemap order test from bugs/ to spec/

2015-04-01 Thread Brian Paul
On 04/01/2015 07:58 AM, Guy-Daniel Tiku wrote: From: guy-D --- tests/bugs/CMakeLists.gl.txt | 1 - tests/bugs/crash-cubemap-order.c | 51 -- tests/spec/CMakeLists.txt | 1 + .../arb_texture_cube_map_orde

Re: [Piglit] [PATCH] Adjust draw-pixel-with-texture to ensure glTexCoord is taken into account.

2015-03-25 Thread Brian Paul
into glDrawPixels, to ensure each quadrant of the texture is visibly different. - Add explanatory comment about the texture coordinates. Reviewed-by: Brian Paul (v1) --- tests/general/draw-pixel-with-texture.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests

Re: [Piglit] [PATCH 1/3] cmake: Silence CMP0042 warnings on MacOSX.

2015-03-24 Thread Brian Paul
(CheckIncludeFile) INCLUDE (FindPkgConfig) +# http://www.cmake.org/cmake/help/v3.0/policy/CMP0042.html +if (POLICY CMP0042) + cmake_policy (SET CMP0042 NEW) +endif() + project (piglit) # Require MSVC 2013 U4 Series LGTM. Reviewed-by: Brian Paul

Re: [Piglit] [PATCH] framework; Catch "No results found" exception

2015-03-23 Thread Brian Paul
Reviewed-by: Brian Paul On 03/23/2015 04:22 PM, Dylan Baker wrote: This adds a couple of catches for results not found and cleanly exits without a traceback when this is an expected error condition. Signed-off-by: Dylan Baker --- framework/programs/summary.py | 12 ++-- framework

Re: [Piglit] [PATCH] summary: Add an aggregate function

2015-03-23 Thread Brian Paul
LGTM. Thanks. Reviewed-by: Brian Paul On 03/23/2015 04:14 PM, Dylan Baker wrote: This summarizer can be used to aggregate a set of individual tests together into a single results file. Signed-off-by: Dylan Baker --- framework/programs/summary.py | 41

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Brian Paul
On 03/23/2015 03:38 PM, Dylan Baker wrote: On Mon, Mar 23, 2015 at 03:24:21PM -0600, Brian Paul wrote: On 03/23/2015 03:07 PM, Dylan Baker wrote: On Mon, Mar 23, 2015 at 02:57:07PM -0600, Brian Paul wrote: Hmm, can you give me a concrete example of how to do this? I have an aborted run and

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Brian Paul
On 03/23/2015 03:07 PM, Dylan Baker wrote: On Mon, Mar 23, 2015 at 02:57:07PM -0600, Brian Paul wrote: Hmm, can you give me a concrete example of how to do this? I have an aborted run and tests/ contains several thousand NNN.json files. What "piglit summary console" command shoul

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Brian Paul
combine them as well. Dylan On Tue, Mar 17, 2015 at 09:36:01AM -0600, Brian Paul wrote: Hi Dylan, I don't know when this changed, but when piglit runs now, it creates individual tests/.json files for each test. Then at the end, it combines them into the results.json file. If the piglit

Re: [Piglit] [PATCH] Adjust draw-pixel-with-texture to ensure glTexCoord is taken into account.

2015-03-23 Thread Brian Paul
pixels[i + 3] = 1; } Reviewed-by: Brian Paul Works fine w/ nvidia's driver, but fails with Mesa swrast. swrast should pass since I remember implementing this at one point but I don't have time to investigate right now. -Brian _

Re: [Piglit] [PATCH] fs-discard-exit-2: Fix Clang absolute-value warnings.

2015-03-23 Thread Brian Paul
8; - int dx = fabs(sx - x / 8); - int dy = fabs(sy - y / 8); + int dx = abs(sx - x / 8); + int dy = abs(sy - y / 8); float pixel[4]; if (dx ==

Re: [Piglit] [PATCH] select: Fix Clang absolute-value warnings.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:50 AM, Vinson Lee wrote: select.c:126:10: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] diffz = abs(hit1[MIN_Z] - hit2[MIN_Z])/zscale; ^ select.c:126:10: note: remove the call to 'abs' since unsigned

Re: [Piglit] [PATCH] ext_packed_depth_stencil: Fix Clang absolute-value warning.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:48 AM, Vinson Lee wrote: readpixels-24_8.c:62:6: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] abs((value >> 8) - (expected >> 8)) > 1) { ^ readpixels-24_8.c:62:6: note: remove the call to 'abs' sinc

Re: [Piglit] [PATCH] glsl-1.50-geometry-primitive-id-restart: Add NORETURN attribute to print_usage_and_exit.

2015-03-23 Thread Brian Paul
prim_type_info }; -static void +NORETURN static void print_usage_and_exit(const char *prog_name) { int i; Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_pipeline_statistics_query-comp: Fix out-of-bounds reads.

2015-03-23 Thread Brian Paul
ARRAY_SIZE(sizes); xi++) { + for (xi = 0; xi < ARRAY_SIZE(sizes); xi++) { x = sizes[xi]; if ((x * y * z) > 1024) break; Reviewed-by: Brian Paul ___

Re: [Piglit] [PATCH] arb_direct_state_access: Remove unused variables.

2015-03-23 Thread Brian Paul
t_t { struct tbo_state_t { Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_direct_state_access: Ignore scanf return value.

2015-03-23 Thread Brian Paul
rintf("\n"); glDeleteTextures(1, &name); Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_fbo: add test of mixed color/depth buffer sizes

2015-03-20 Thread Brian Paul
;s of different size? On Fri, Mar 20, 2015 at 5:45 PM, Brian Paul wrote: GL_ARB_framebuffer_object (unlike GL_EXT_framebuffer_object) allows the FBO attachments to be off different sizes. AFAICT, we had no tests to exercise rendering with mixed buffer sizes. ---

[Piglit] [PATCH] arb_fbo: add test of mixed color/depth buffer sizes

2015-03-20 Thread Brian Paul
ffer/texture sizes works + * as expected. If the color and depth buffers aren't the same size, + * the rendering in the intersection area should be valid. + * + * \author Brian Paul + */ + +#include "piglit-util-gl.h" + +PIGLIT_GL_TEST_CONFIG_BEGIN + config.supports_gl_compat_versi

[Piglit] recovering from aborted runs

2015-03-17 Thread Brian Paul
Hi Dylan, I don't know when this changed, but when piglit runs now, it creates individual tests/.json files for each test. Then at the end, it combines them into the results.json file. If the piglit run is interrupted (host crash/freeze), I'm left with all those individual files and no

Re: [Piglit] [PATCH 1/3] framework: Handle supports_gl_compat_version >= 32 with Waffle.

2015-03-16 Thread Brian Paul
ttrib_list[i++] = WAFFLE_CONTEXT_COMPATIBILITY_PROFILE; + } + head_attrib_list[i++] = WAFFLE_CONTEXT_MAJOR_VERSION; head_attrib_list[i++] = test_config->supports_gl_compat_version / 10; Series LGTM. Reviewed-by: Brian Pa

Re: [Piglit] [PATCH 0/7] Replace the '/' in groups with '@'

2015-03-12 Thread Brian Paul
On 03/12/2015 04:42 PM, Dylan Baker wrote: This series replaces the '/' separator in groups with '@', in the process it works to make another such change easier by using a constant for the separator. This stems from problems with os.path.join being intertwined with grouptools, which happens to w

[Piglit] [PATCH] arb_clear_texture-clear-max-level: exercise an nvidia ARB_clear_texture bug

2015-03-10 Thread Brian Paul
--- tests/all.py | 1 + tests/spec/arb_clear_texture/CMakeLists.gl.txt | 1 + tests/spec/arb_clear_texture/clear-max-level.c | 130 + 3 files changed, 132 insertions(+) create mode 100644 tests/spec/arb_clear_texture/clear-max-level.c

Re: [Piglit] [PATCH] s3tc-errors: Use -4, not -3 as an invalid x offset

2015-03-10 Thread Brian Paul
= 8; w = 4; h = 4; Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] utils: Handle WM_QUIT properly.

2015-02-26 Thread Brian Paul
+ PostQuitMessage(EXIT_SUCCESS); + break; case WM_QUIT: /* TODO: cleanup/teardown things */ - exit(0); + exit(msg.wParam); default: break; } F

Re: [Piglit] [PATCH] amd_pinned_memory: Port to Windows.

2015-02-20 Thread Brian Paul
Ugh, I didn't see this and just posted my own fix. I don't think your patch will work though since unistd.h is still included. I went ahead with the OS abstractions. -Brian On 02/20/2015 03:01 PM, Jose Fonseca wrote: We might want to have some OS abstractions for aligned memory if more test

[Piglit] [PATCH 1/2] util: add piglit_get_page_size(), piglit_align_alloc/free()

2015-02-20 Thread Brian Paul
--- tests/util/piglit-util.c | 35 +++ tests/util/piglit-util.h | 10 ++ 2 files changed, 45 insertions(+) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index f18560e..668f362 100644 --- a/tests/util/piglit-util.c +++ b/tests/util/piglit-

[Piglit] [PATCH 2/2] AMD_pinned_memory: use new helper functions to fix Windows build

2015-02-20 Thread Brian Paul
--- tests/spec/amd_pinned_memory/test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/amd_pinned_memory/test.c b/tests/spec/amd_pinned_memory/test.c index 239e620..96e05c6 100644 --- a/tests/spec/amd_pinned_memory/test.c +++ b/tests/spec/amd_pinned_memory/te

[Piglit] [PATCH] drawpixels-color-index: new test for glDrawPixels(GL_COLOR_INDEX)

2015-02-18 Thread Brian Paul
To exercise a Mesa failure after the format overhaul. Note: this test fails on nvidia if the -auto option is given. --- tests/all.py | 1 + tests/spec/gl-1.0/CMakeLists.gl.txt| 5 +- tests/spec/gl-1.0/drawpixels-color-index.c | 162

Re: [Piglit] [PATCH] tex-upload-scale-bias: tests texture upload with scale/bias transfer options

2015-02-13 Thread Brian Paul
general/tex-upload-scale-bias.c b/tests/general/tex-upload-scale-bias.c Looks good, but would you consider renaming the test "teximage-scale-bias"? Most other glTexImage-related tests have "teximage" in the name. Also, we generally use tabs (8-space) indentation in piglit

[Piglit] [PATCH] gl-1.0-blend: print current blend state if probe fails

2015-02-05 Thread Brian Paul
--- tests/spec/gl-1.0/blend.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c index 9fe345c..065b8bb 100644 --- a/tests/spec/gl-1.0/blend.c +++ b/tests/spec/gl-1.0/blend.c @@ -529,7 +529,7 @@ run_factor

Re: [Piglit] [PATCH] arb_shader_image_load_store: fix MSVC build

2015-02-03 Thread Brian Paul
On 02/03/2015 01:08 PM, Francisco Jerez wrote: Francisco Jerez writes: Francisco Jerez writes: Brian Paul writes: MSVC doesn't seem to like function calls inside struct initializers. That's awful. But fine: Reviewed-by: Francisco Jerez Actually it's surprising tha

[Piglit] [PATCH] arb_shader_image_load_store: fix MSVC build

2015-02-03 Thread Brian Paul
MSVC doesn't seem to like function calls inside struct initializers. --- tests/spec/arb_shader_image_load_store/image.h| 20 +-- tests/spec/arb_shader_image_load_store/max-size.c | 24 +-- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/test

Re: [Piglit] [PATCH] glsl-fs-function-samplers: rename mix parameter to mixFactor

2015-01-26 Thread Brian Paul
On 01/26/2015 02:44 PM, Ian Romanick wrote: On 01/26/2015 08:30 AM, Brian Paul wrote: To avoid a compile failure on NVIDIA. The mix function parameter is hiding the built-in mix() function. The point of this test is not to exercise compile-time name resolution. Is NVIDIA's behavior co

[Piglit] [PATCH] glsl-fs-function-samplers: rename mix parameter to mixFactor

2015-01-26 Thread Brian Paul
To avoid a compile failure on NVIDIA. The mix function parameter is hiding the built-in mix() function. The point of this test is not to exercise compile-time name resolution. --- tests/shaders/glsl-fs-functions-samplers.shader_test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Piglit] [PATCH] Add a new shader attachment/link ordering test.

2015-01-26 Thread Brian Paul
AFAICT, the GL and GLSL specs don't say anything about the significance of the order in which shaders are attached to a program object. For example, if there's two vertex shader A and B, it shouldn't matter if they're attached in order A,B or B,A. This pair of shader tests exercises that. Both p

[Piglit] [PATCH] arb-provoking-vertex-render: a new test that actually checks all prim types

2015-01-13 Thread Brian Paul
None of the other provoking vertex tests actually check the rendering of all the different primitive types with first/last provoking vertex. --- tests/all.py | 1 + tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 1 + tests/spec/arb_provoking_vertex/ren

Re: [Piglit] [PATCH] piglit-print-commands.py: PEP8 fixes.

2015-01-10 Thread Brian Paul
include_filter=args.include_tests) # Change to the piglit's path piglit_dir = path.dirname(path.realpath(sys.argv[0])) For this, and "glx-query-drawable: Initialize variable" and "ext_framebuffer_multisample_blit_scaled: Use con

Re: [Piglit] [PATCH v2] arb_direct_state_access: Fix memory leak.

2015-01-10 Thread Brian Paul
On 01/09/2015 06:45 PM, Vinson Lee wrote: Fix resource leak defect reported by Coverity. Also move piglit_rgbw_image_ubyte call outside of loop as suggested by Brian Paul. Signed-off-by: Vinson Lee --- tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 6 -- 1 file

Re: [Piglit] [PATCH] arb_direct_state_access: Fix memory leak.

2015-01-08 Thread Brian Paul
On 01/08/2015 06:43 PM, Vinson Lee wrote: Fix resource leak defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_direct_state_access/getcompressedtextureima

Re: [Piglit] [PATCH] framebuffer-srgb: Remove dead assignment.

2015-01-08 Thread Brian Paul
); Let's make that (void) glIsEnabled(GL_FRAMEBUFFER_SRGB_EXT); /* ignore return value */ just to be clear. With that, Reviewed-by: Brian Paul ret = glGetError(); if (ret != 0) { printf("unexpected error getting IsEnabled

Re: [Piglit] [PATCH] arb_shader_atomic_counters: Check piglit_probe_pixel_rgb results.

2015-01-08 Thread Brian Paul
* piglit_height / 4, white) && pass; piglit_present_results(); Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] pbo: fix MSVC compile error

2015-01-08 Thread Brian Paul
Arrays can't be dimensioned by variables. --- tests/spec/gl-2.1/pbo.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/spec/gl-2.1/pbo.c b/tests/spec/gl-2.1/pbo.c index b6c51e9..26b7138 100644 --- a/tests/spec/gl-2.1/pbo.c +++ b/tests/spec/gl-2.1/pbo.c @@ -526,

Re: [Piglit] [PATCH] gl-3.0-vertexattribipointer: Fix GCC maybe-uninitialized warning.

2015-01-08 Thread Brian Paul
For all three, Reviewed-by: Brian Paul On 01/08/2015 01:35 PM, Vinson Lee wrote: vertexattribipointer.c: In function 'piglit_display': vertexattribipointer.c:156:4: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized] memcpy(attr_buffe

Re: [Piglit] [PATCH] gl-1.0-blend-func: Fix GCC maybe-uninitialized warnings.

2015-01-07 Thread Brian Paul
{ - float sf[4], df[4]; + float sf[4] = { 0 }; + float df[4] = { 0 }; if (op_rgb != GL_MIN && op_rgb != GL_MAX) { /* Src RGB term */ For all three patches: Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 00/24] Change Test to use only a list for 1st argument

2015-01-05 Thread Brian Paul
On 01/05/2015 02:50 PM, Dylan Baker wrote: Currently Test takes a command argument, which can either be a list of strings or a string. String by itself causes problems on cygwin (as reported by Brian Paul), so it's worth fixing that. This also simplifies the signature by not allowing Te

[Piglit] [PATCH] Add new test to exercise GLSL compiler bug involving unused const arrays

2015-01-02 Thread Brian Paul
Currently, this test causes the GLSL compiler to abort in ir_validate.cpp with the message: "ir_dereference_variable @ 0x182ee80 specifies undeclared variable `unused_array' @ 0x182ed80" --- .../compiler/unused-const-array.shader_test| 26 ++ 1 file changed, 26 insertio

Re: [Piglit] [PATCH] fbo: Changing mrt binding with same shader source

2015-01-02 Thread Brian Paul
Just a few minor nits below. Reviewed-by: Brian Paul On 12/22/2014 03:53 PM, Mike Stroyan wrote: New test fbo-mrt-new-bind asserts correct behavior for changing framebuffer binding without changing the shaders. That can cause trouble if the new binding selects a different shader kernel

Re: [Piglit] [PATCH 2/3] ext_transform_feedback: test immediate uniform buffer reuse

2015-01-02 Thread Brian Paul
Minor nits below (which also apply to patch 1/3.) For the series: Reviewed-by: Brian Paul On 01/01/2015 07:17 AM, Marek Olšák wrote: From: Marek Olšák --- tests/all.py | 1 + .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1

Re: [Piglit] [PATCH] arb_texture_buffer_object-formats: Initialize variable.

2014-12-19 Thread Brian Paul
*expected) static bool get_expected_i(const struct format *format, int sample, uint32_t *expected) { - uint32_t chans[4]; + uint32_t chans[4] = { 0 }; int i; for (i = 0; i < format->components; i++) { Reviewe

[Piglit] [PATCH] cubemap-mismatch: new test of mismatched cube map faces

2014-12-18 Thread Brian Paul
OpenGL actually allows creating a cube map with different sizes and formats per-face. Though, it can't actually be used for texturing. This test checks that no unexpected error is raised when such a texture is created and that the GL actually keeps track of the per-face sizes. --- tests/all.py

Re: [Piglit] [PATCH] GL_ARB_get_texture_sub_image: add new tests for this extension

2014-12-18 Thread Brian Paul
On 12/18/2014 06:44 AM, Jose Fonseca wrote: Reviewed-by: Jose Fonseca A few comments inline. On 13/12/14 14:43, Brian Paul wrote: --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + .../arb_get_texture_sub_image

Re: [Piglit] [PATCH piglit 1/3] texsubimage: Fix updating a sub-region of a 3D texture

2014-12-17 Thread Brian Paul
arget == GL_TEXTURE_3D) { glTexSubImage3D(target, 0, tx, ty, tz, tw, th, td, srcFormat, GL_UNSIGNED_BYTE, img); } The series LGTM. Reviewed-by: Brian Paul Thanks. ___ P

Re: [Piglit] [PATCH] tests/all.py: use list for built-in-constants command line arguments

2014-12-17 Thread Brian Paul
iewed-by: Dylan Baker On Wednesday, December 17, 2014 10:46:38 AM Brian Paul wrote: As with the previous patch, fixes patch corruption on Cygwin. --- tests/all.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/all.py b/tests/all.py index 2

[Piglit] [PATCH] tests/all.py: use list for vpfp-generic command line arguments

2014-12-17 Thread Brian Paul
As with the previous patch, fixes patch corruption on Cygwin. --- tests/all.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index e518222..2ffb920 100644 --- a/tests/all.py +++ b/tests/all.py @@ -501,8 +501,8 @@ for subtest in ('interstage', '

[Piglit] [PATCH] tests/all.py: use list for built-in-constants command line arguments

2014-12-17 Thread Brian Paul
As with the previous patch, fixes patch corruption on Cygwin. --- tests/all.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/all.py b/tests/all.py index 2ffb920..ba26ebd 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1030,7 +1030,7 @@ spec['glsl

[Piglit] [PATCH] tests/all.py: use list for asmparsertest command line arguments

2014-12-17 Thread Brian Paul
Instead of passing a string like "asmparsertest ARBfp1.0 path/to/mad.txt", now pass a list like ["asmparsertest", "ARBfp1.0", path/to/mad.txt]. This fixes the asmparsertest tests on Cygwin. Before, all the tests were failing because the backslash characters in the path were getting removed. ---

Re: [Piglit] [PATCH] arb_sample_shading-builtin-gl-num-samples: Use const reference.

2014-12-17 Thread Brian Paul
8,7 +118,7 @@ piglit_init(int argc, char **argv) } } -bool test_builtin_num_samples(Fbo ms_fbo) +bool test_builtin_num_samples(const Fbo& ms_fbo) { GLint samples; GLfloat expected[4] = {0.0, 1.0, 0.0, 1.0}; For both arb_sample_shading patches, Reviewed-

Re: [Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

2014-12-15 Thread Brian Paul
nment var PIGLIT_PLATFORM must be set " "when piglit is built without GLX support\n"); These changes look OK to me, though I don't have too much experience in this area. Reviewed-by: Brian Paul ___ P

Re: [Piglit] [PATCH] cl-api-get-device-info: Fix memory leak.

2014-12-14 Thread Brian Paul
100644 --- a/tests/cl/api/get-device-info.c +++ b/tests/cl/api/get-device-info.c @@ -162,5 +162,7 @@ piglit_cl_test(const int argc, piglit_merge_result(&result, PIGLIT_FAIL); } + free(int_value); + return result; } Reviewed-by: Brian

Re: [Piglit] [PATCH] gl-1.0-logicop: Fix memory leak.

2014-12-14 Thread Brian Paul
-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] cl-api-enqueue-map-buffer: Initialize variable.

2014-12-14 Thread Brian Paul
result; + enum piglit_result result = PIGLIT_PASS; cl_mem device_mem; cl_ulong alloc_size = 64; cl_int *host_mem; Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.or

Re: [Piglit] [PATCH] gl-1.0-readpixsanity: Initialize variables.

2014-12-14 Thread Brian Paul
(h * w * sizeof *buf); double current_error = 0.0; GLfloat dd; double err; - int xerr, yerr; + int xerr = 0, yerr = 0; GLint dbits; glGetIntegerv(GL_DEPTH_BITS, &dbits); Reviewed-by: Brian

Re: [Piglit] [PATCH] teximage-colors: Remove self assignment.

2014-12-14 Thread Brian Paul
: - expected[0] = expected[0]; expected[1] = expected[0]; expected[2] = expected[0]; break; For this and the v2 teximage-color patch: Reviewed-by: Brian Paul ___ Piglit mailing list Piglit

[Piglit] [PATCH] GL_ARB_get_texture_sub_image: add new tests for this extension

2014-12-13 Thread Brian Paul
--- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + .../arb_get_texture_sub_image/CMakeLists.gl.txt| 16 + .../spec/arb_get_texture_sub_image/CMakeLists.txt | 1 + tests/spec/arb_get_texture_sub_image/errors.c | 1

Re: [Piglit] [PATCH 1/3] util: far/near macros must be undefined on all Windows builds.

2014-12-03 Thread Brian Paul
Series LGTM. Reviewed-by: Brian Paul On 12/03/2014 08:37 AM, Jose Fonseca wrote: From: José Fonseca And not just MSVC. Fixes build with MinGW. --- tests/util/piglit-util.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/util/piglit-util.h b/tests

Re: [Piglit] [PATCH] ext_texture_array: add simple API errors test

2014-12-03 Thread Brian Paul
On 12/03/2014 12:47 AM, Tapani Pälli wrote: On 12/02/2014 06:43 PM, Brian Paul wrote: --- tests/all.py | 1 + tests/spec/ext_texture_array/CMakeLists.gl.txt | 1 + tests/spec/ext_texture_array/errors.c | 170 + 3

[Piglit] MSCV build problem in piglit-util.h

2014-12-03 Thread Brian Paul
Hi Emil, This from our automated build. I think the warnings can be ignored for now, but there's an error: tests\util\piglit-util.h(196) : warning C4056: overflow in floating-point constant arithmetic tests\util\piglit-util.h(207) : error C2440: 'initializing' : cannot convert from 'const cha

Re: [Piglit] [PATCH] getteximage-luminance: remove obsolete piglit_dispatch_default_init() call

2014-12-03 Thread Brian Paul
) { - piglit_dispatch_default_init(PIGLIT_DISPATCH_GL); + /* empty */ } Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] ext_timer_query: the timestamp test does not require the EXT extension

2014-12-03 Thread Brian Paul
On 12/03/2014 06:37 AM, Emil Velikov wrote: The test itself is written against the ARB extension, and neither the test or the ARB extension requires the EXT one. Signed-off-by: Emil Velikov --- It's unlikely that anyone will hit this (i.e. has support for ARB but lacks the EXT extension) but f

[Piglit] [PATCH] ext_texture_array: add simple API errors test

2014-12-02 Thread Brian Paul
--- tests/all.py | 1 + tests/spec/ext_texture_array/CMakeLists.gl.txt | 1 + tests/spec/ext_texture_array/errors.c | 170 + 3 files changed, 172 insertions(+) create mode 100644 tests/spec/ext_texture_array/errors.c diff --g

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Brian Paul
On 11/17/2014 05:00 PM, Ben Widawsky wrote: Signed-off-by: Ben Widawsky --- .../spec/arb_pipeline_statistics/CMakeLists.gl.txt | 2 + .../arb_pipeline_statistics/pipeline_stats_geom.c | 146 + tests/spec/arb_pipeline_statistics/pipestat_help.c | 3 +- 3 files change

Re: [Piglit] [PATCH v4] Add tests arb_conditional_render_inverted

2014-11-17 Thread Brian Paul
On 11/15/2014 08:56 PM, Tobias Klausmann wrote: Adopted tests from NV_conditional_render Signed-off-by: Tobias Klausmann In several places you have config.supports_gl_compat_version = 10; and later piglit_require_gl_version(30); I think you could just specify config.supports_gl_compat_ver

Re: [Piglit] [PATCH 2/2] glx_ext_create_context_es2_profile: Update versions.

2014-11-14 Thread Brian Paul
For both: Reviewed-by: Brian Paul On 11/14/2014 07:57 AM, jfons...@vmware.com wrote: From: José Fonseca Tested with NVIDIA drivers. --- .../glx_arb_create_context/invalid-es-version.c| 23 +++--- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/tests/spec

Re: [Piglit] [PATCH] ext_transform_feedback: Silence GCC maybe-uninitialized warning.

2014-11-13 Thread Brian Paul
Luint progs[2] = { 0 }; GLuint pipes[2]; GLuint bufs[NUM_BUFFERS]; float initial_xfb_buffer_contents[XFB_BUFFER_SIZE]; Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_separate_shader_object: Silence GCC maybe-uninitialized warnings.

2014-11-13 Thread Brian Paul
g_vs, prog_fs, prog_gs = 0, prog_tcs = 0, prog_tes = 0, prog_tess; + GLint prog_vs_fs, prog_vs_gs = 0; GLint separable; int version; Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] profile.py: If the test list is empty after being filtered exit

2014-11-03 Thread Brian Paul
sys.exit(1) + def _pre_run_hook(self): """ Hook executed at the start of TestProfile.run Reviewed-by: Brian Paul Thanks! ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] failed assertion in json_.py

2014-11-03 Thread Brian Paul
I'm not sure when this started (haven't bisected it yet). But when I run a test like this I'm getting an assertion: $ ./piglit-run.py -v -t ext_transform_feedback tests/all.tests results/xfb [0/0] Running Test(s): 0 Traceback (most recent call last): File "./piglit-run.py", line 32, in

[Piglit] [PATCH] ext_transform_feedback-points: a new, simple xfb test

2014-11-03 Thread Brian Paul
If argv[1]="large", draw large points (which may get converted to quads). --- tests/all.py |2 + .../spec/ext_transform_feedback/CMakeLists.gl.txt |1 + tests/spec/ext_transform_feedback/points.c | 177 3 files changed, 1

Re: [Piglit] [PATCH 2/2] gl-1.0-readpixsanity: Eliminate use of variable length arrays.

2014-10-29 Thread Brian Paul
On 10/29/2014 05:48 AM, jfons...@vmware.com wrote: From: José Fonseca Non-standard GCC extension. --- For both, Reviewed-by: Brian Paul ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 2/6] arb_texture_view-cubemap-view: new test to check an NVIDIA cubemap bug

2014-10-28 Thread Brian Paul
From: Shibdas Bandyopadhyay --- tests/all.py |1 + tests/spec/arb_texture_view/CMakeLists.gl.txt |1 + tests/spec/arb_texture_view/cubemap-view.c| 171 + 3 files changed, 173 insertions(+) create mode 100644 tests/spec/arb_te

[Piglit] [PATCH 5/6] gl-3.2-pointsprite-origin: test a MacOS sprite origin bug

2014-10-28 Thread Brian Paul
From: Shibdas Bandyopadhyay --- tests/all.py |1 + tests/spec/gl-3.2/CMakeLists.gl.txt|1 + tests/spec/gl-3.2/pointsprite-origin.c | 181 3 files changed, 183 insertions(+) create mode 100644 tests/spec/gl-3.2/pointsprite-o

[Piglit] [PATCH 6/6] arb_framebuffer_srgb-clear: check an AMD sRGB clearing bug

2014-10-28 Thread Brian Paul
From: Shibdas Bandyopadhyay --- tests/all.py |1 + tests/spec/arb_framebuffer_srgb/CMakeLists.gl.txt |1 + tests/spec/arb_framebuffer_srgb/clear.c | 166 + 3 files changed, 168 insertions(+) create mode 100644 tests/spe

[Piglit] [PATCH 1/6] arb_texture_view-max-level: new test for an NVIDIA texelFetch() bug

2014-10-28 Thread Brian Paul
From: Shibdas Bandyopadhyay --- tests/all.py |1 + tests/spec/arb_texture_view/CMakeLists.gl.txt |1 + tests/spec/arb_texture_view/max-level.c | 252 + 3 files changed, 254 insertions(+) create mode 100644 tests/spec/arb_te

[Piglit] [PATCH 3/6] arb_copy_image/srgb-copy: test an NVIDIA GL_ARB_copy_image / sRGB bug

2014-10-28 Thread Brian Paul
From: Shibdas Bandyopadhyay --- tests/all.py|2 +- tests/spec/arb_copy_image/CMakeLists.gl.txt |1 + tests/spec/arb_copy_image/srgb-copy.c | 127 +++ 3 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 tests

<    1   2   3   4   5   6   7   8   9   10   >