Re: [Piglit] [Mesa-dev] Rename "master" branch to "main"?

On 2021-03-25 08:11:45, Jason Ekstrand wrote: > On Thu, Mar 25, 2021 at 9:41 AM Rob Clark wrote: > > > > yeah, I meant to convert a repo w/ more MRs than 7 but less than mesa > > using the script to beta test that, wasn't suggesting to do it by hand > > Plan is to convert piglit next. It's sitti

[Piglit] piglit default main branch results - Re: [Mesa-dev] Rename "master" branch to "main"?

On 2021-03-24 23:47:46, Jordan Justen wrote: > On 2021-03-24 21:14:57, Jason Ekstrand wrote: > > > > Jordan, is there any way you can make the script sort by last updated > > before it > > re-targets the MRs so they at least stay in the same order? Updating them >

Re: [Piglit] [Mesa-dev] Rename "master" branch to "main"?

On 2021-03-24 21:14:57, Jason Ekstrand wrote: > > Jordan, is there any way you can make the script sort by last updated before > it > re-targets the MRs so they at least stay in the same order? Updating them in > MR > # order wouldn't be bad either, I guess. > It already does process them sort

Re: [Piglit] [Mesa-dev] Rename "master" branch to "main"?

On 2021-03-23 09:38:59, Eric Anholt wrote: > On Tue, Mar 23, 2021 at 7:02 AM Jason Ekstrand wrote: > > > > Trying to pick this discussion back up. Daniel Stone thinks it's a > > half hour of API bashing to retarget all the MRs so, if the fd.o > > admins have some heads up, it should be tractable.

[Piglit] Should piglit drop bugzilla and move to using gitlab issues?

I guess piglit makes very light usage of bugzilla. Would it be simpler to just use gitlab issues in the piglit gitlab project? -Jordan ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] Piglit gitlab merge requests enabled - Re: GitLab migration of Piglit

On 2019-02-20 07:36:48, Den wrote: > > Given the discussion below, I think we'll make piglit a sub-project of > > mesa.  Those who need commit access to piglit but not mesa can be > > added directly to the piglit project. > > Hi list. > > Since piglit was also moved to the gitlab, same with mes

Re: [Piglit] Piglit website in sphinx

On 2018-12-18 14:57:43, Dylan Baker wrote: > Quoting Eric Anholt (2018-12-18 11:21:08) > > Jordan Justen writes: > > > > > On 2018-12-17 22:07:21, Tapani Pälli wrote: > > >> Hi; > > >> > > >> On 12/17/18 11:50 AM, Jordan Justen w

Re: [Piglit] Piglit website in sphinx

On 2018-12-17 22:07:21, Tapani Pälli wrote: > Hi; > > On 12/17/18 11:50 AM, Jordan Justen wrote: > > Although I doubt it generates much traffic, I wanted to try to convert > > the https://piglit.freedesktop.org/ homepage into an 'auto-building' > > gitlab bran

Re: [Piglit] Piglit website in sphinx

On 2018-12-17 12:09:23, Eric Anholt wrote: > Jordan Justen writes: > > > Although I doubt it generates much traffic, I wanted to try to convert > > the https://piglit.freedesktop.org/ homepage into an 'auto-building' > > gitlab branch. > > > > I thin

[Piglit] Piglit website in sphinx

Although I doubt it generates much traffic, I wanted to try to convert the https://piglit.freedesktop.org/ homepage into an 'auto-building' gitlab branch. I think the current site was built by ikiwiki, but I was after spending way more time that I hoped, I still was unable to reproduce the site wi

[Piglit] [PATCH 1/3] sanity: Fix test names

er Signed-off-by: Jordan Justen --- tests/sanity.py | 62 + 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/tests/sanity.py b/tests/sanity.py index 6ba80ccbc..ed3aba004 100644 --- a/tests/sanity.py +++ b/tests/sanity.py @@ -49

[Piglit] [PATCH 3/3] sanity: Add some generated tests

Signed-off-by: Jordan Justen --- tests/sanity.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/sanity.py b/tests/sanity.py index 0011000a2..12f1614c9 100644 --- a/tests/sanity.py +++ b/tests/sanity.py @@ -81,19 +81,26 @@ shader_tests = ( 'shaders/glsl-fs-max-3.shader

[Piglit] [PATCH 2/3] sanity: Support generated shader tests

Cc: Dylan Baker Signed-off-by: Jordan Justen --- tests/CMakeLists.no_api.txt | 2 +- tests/sanity.py | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/CMakeLists.no_api.txt b/tests/CMakeLists.no_api.txt index 632c6786a..455b059d8 100644 --- a/tests

[Piglit] [PATCH 2/2] sanity: Add various shader_runner tests

Signed-off-by: Jordan Justen --- tests/sanity.py | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/sanity.py b/tests/sanity.py index 566d63218..5550cd13e 100644 --- a/tests/sanity.py +++ b/tests/sanity.py @@ -67,10 +67,35 @@ def add_shader_test(shader

[Piglit] [PATCH 1/2] sanity: Turn shader_test list into a string

Signed-off-by: Jordan Justen --- tests/sanity.py | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/sanity.py b/tests/sanity.py index 88bf27457..566d63218 100644 --- a/tests/sanity.py +++ b/tests/sanity.py @@ -66,10 +66,15 @@ def add_shader_test(shader

Re: [Piglit] [PATCH] tests/sanity: Rework sanity to be more useful

tallpath = os.path.relpath(shader, gen_basepath) > +else: > +installpath = None > + > +dirpath = os.path.dirname(shader) > +groupname = grouptools.from_path(os.path.relpath( > +dirpath, GENERATED_TESTS_DIR if installpath else TESTS_DIR)) > +te

Re: [Piglit] [PATCH] framework: add a --timeout parameter

gt; +dest='timeout', > +action='store', > +type=int, > +default=None, > +metavar='', > +help='Sets a timeout threshold for tes

[Piglit] [PATCH 1/2] glsl-1.10 / glsl-1.20: Don't use ortho in variable indexing tests.

: Jordan Justen Cc: Kenneth Graunke --- .../templates/gen_variable_index_read_tests/helpers.mako | 7 ++- .../gen_variable_index_write_tests/fs.shader_test.mako | 3 --- .../templates/gen_variable_index_write_tests/helpers.mako | 4 ++-- .../gen_variable_index_write_tests

[Piglit] [PATCH 2/2] glsl-1.20: Don't use ortho in outerProduct tests.

From: Matt Turner Ref: https://lists.freedesktop.org/archives/piglit/2013-November/008299.html [jordan.l.jus...@intel.com: convert from shell script to mako] Signed-off-by: Jordan Justen Cc: Kenneth Graunke --- .../gen_outerproduct_tests/template.shader_test.mako | 11 --- 1 file

Re: [Piglit] [PATCH 1/9] shader_runner: Support testing GL_NUM_PROGRAM_BINARY_FORMATS

ks great thanks for working on it :) > > Reviewed-by: Timothy Arceri > > On 09/06/18 15:47, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > tests/shaders/shader_runner.c | 16 > > 1 file changed, 16 insertions(+) >

[Piglit] [PATCH 5/9] shader_runner: Add 'program binary save restore' command

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 0b449c056..b954520f3 100644 --- a/tests/shaders/shader_runner.c +++ b

[Piglit] [PATCH 4/9] shader_runner: Support SHADER_RUNNER_GET_PROGRAM_BINARY env var

If set to 1/yes/true, SHADER_RUNNER_GET_PROGRAM_BINARY will run as if the -get-program-binary parameter were used. This allows comparing piglit runs with and without shader runner using GetProgramBinary. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 5 - 1 file changed

[Piglit] [PATCH 9/9] ARB_get_program_binary: Test that restoring active program takes effect

Signed-off-by: Jordan Justen Cc: Timothy Arceri --- .../arb_get_program_binary/CMakeLists.gl.txt | 2 + .../restore-implicit-use-program.c| 145 ++ 2 files changed, 147 insertions(+) create mode 100644 tests/spec/arb_get_program_binary/restore-implicit-use

[Piglit] [PATCH 8/9] ARB_get_program_binary: Test that uniforms are reset on program reload (API)

Signed-off-by: Jordan Justen --- .../arb_get_program_binary/CMakeLists.gl.txt | 1 + .../arb_get_program_binary/reset-uniform.c| 121 ++ 2 files changed, 122 insertions(+) create mode 100644 tests/spec/arb_get_program_binary/reset-uniform.c diff --git a/tests/spec

[Piglit] [PATCH 7/9] ARB_get_program_binary: Add some common functions

--- .../spec/arb_get_program_binary/gpb-common.c | 126 ++ .../spec/arb_get_program_binary/gpb-common.h | 37 + 2 files changed, 163 insertions(+) create mode 100644 tests/spec/arb_get_program_binary/gpb-common.c create mode 100644 tests/spec/arb_get_program_binary/gpb-com

[Piglit] [PATCH 1/9] shader_runner: Support testing GL_NUM_PROGRAM_BINARY_FORMATS

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 794524e8f..c4e25a33d 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders

[Piglit] [PATCH 3/9] util: Add piglit_env_var_as_boolean

This is copied from Mesa's env_var_as_boolean. Signed-off-by: Jordan Justen --- tests/util/piglit-util.c | 27 +++ tests/util/piglit-util.h | 9 + 2 files changed, 36 insertions(+) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index ed7d

[Piglit] [PATCH 2/9] shader_runner: Add -get-program-binary parameter

written shader runner tests to be run while testing get_program_binary. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 96 +++ 1 file changed, 96 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index

[Piglit] [PATCH 6/9] ARB_get_program_binary: Test that uniforms are reset on program reload

Signed-off-by: Jordan Justen --- .../uniform-after-restore.shader_test | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 tests/spec/arb_get_program_binary/execution/uniform-after-restore.shader_test diff --git a/tests/spec/arb_get_program_binary/execution

[Piglit] [PATCH 2/2] shader_runner: Support PIGLIT_DEFAULT_SIZE env var

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 700b11327..c6ee8e3de 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders

[Piglit] [PATCH 1/2] framework-gl: Export window size override function

Signed-off-by: Jordan Justen --- tests/util/piglit-framework-gl.c | 6 +++--- tests/util/piglit-framework-gl.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/util/piglit-framework-gl.c b/tests/util/piglit-framework-gl.c index 1b2078d5c..c80441870 100644 --- a/tests

Re: [Piglit] [PATCH] compute: add test variants for local_size decls in other shaders

Reviewed-by: Jordan Justen On 2017-10-22 14:58:00, Ilia Mirkin wrote: > Only one shader is required to have a local_size layout, and it's not > required to be the one with the main function. Add tests which verify > that these derived values are properly computed in such

Re: [Piglit] [PATCH] arb_compute_variable_group_size: ensure local size works with fixed

Reviewed-by: Jordan Justen On 2017-10-22 15:12:58, Ilia Mirkin wrote: > The new gl_LocalGroupSizeARB variable is meant to work with fixed sizes > as well. Test it. > > Signed-off-by: Ilia Mirkin > --- > .../execution/fixed-local-size.shader_test | 32 > ++

[Piglit] [PATCH] crucible: Convert from glslc to glslang

just to remove the additional shaderc/glslc dependency. An advantage of using glslangValidator is that the SPIR-V binary and assembly code can be generated with a single invocation of glslangValidator. Cc: Jason Ekstrand Signed-off-by: Jordan Justen --- INSTALL | 2 +- Makefile.am

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

Reviewed-by: Jordan Justen On 2016-10-17 12:39:18, Matt Turner wrote: > --- > .../linker/mixed_fixed_variable_local_work_size.shader_test | 2 > +- > .../linker/no_local_size_specified.shader_test | 2 > +- > 2 files changed, 2 insertio

Re: [Piglit] [PATCH] framework: Fix piglit-command

ust have been some other interaction... This one works too, so: Reviewed-by: Jordan Justen > Signed-off-by: Dylan Baker > CC: jordan.l.jus...@intel.com > --- > piglit | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/piglit b/piglit > index 05fff

Re: [Piglit] [PATCH] piglit: Print help instead of excepting if no arguments are given

e line just causes piglit to print the help message if > +# ./piglit is run without any positional arguments > +parser.set_defaults(func=lambda *_, **__: parser.print_help()) Not sure about the comment (I'd be fine to drop it), but: Reviewed-by: Jordan Justen > subparser

Re: [Piglit] [PATCH] arb_query_buffer_object: Silence Coverity unchecked return value defect.

Reviewed-by: Jordan Justen On 2016-07-01 14:39:41, Vinson Lee wrote: > CID: 1361479 > Signed-off-by: Vinson Lee > --- > tests/spec/arb_query_buffer_object/qbo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/spec/arb_query_buffer_ob

Re: [Piglit] [PATCH] shader_runner: Use %u in "probe atomic counter" scanf calls.

mic_uint"... > > Fair enough. For ssbo I made it read 0xfoo for those. And there's already a > > tests/spec/arb_compute_shader/execution/atomic-counter.shader_test:probe > atomic counter 1 == 4294966784 > And another bug as well: https://bugs.freedesktop.org/show_bug.cgi

[Piglit] [PATCH v2] arb_query_buffer_object: Update and add more test scenarios

sults available. v2: * Only check GL_ARB_pipeline_statistics_query queries if the extension is supported (Ilia) Signed-off-by: Jordan Justen --- tests/spec/arb_query_buffer_object/qbo.c | 351 --- 1 file changed, 232 insertions(+), 119 deletions(-) diff --git a/tests

[Piglit] [PATCH] arb_query_buffer_object: Update and add more test scenarios

sults available. Signed-off-by: Jordan Justen --- tests/spec/arb_query_buffer_object/qbo.c | 324 +++ 1 file changed, 205 insertions(+), 119 deletions(-) diff --git a/tests/spec/arb_query_buffer_object/qbo.c b/tests/spec/arb_query_buffer_object/qbo.c index 0cee6c8..847642a 1

[Piglit] [PATCH] arb_compute_shader: Add test for Mesa bug 93840

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93840 Signed-off-by: Jordan Justen --- .../linker/bug-93840.shader_test | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 tests/spec/arb_compute_shader/linker/bug-93840.shader_test diff

Re: [Piglit] [PATCH v2] compute: add an execution test for shared atomics

Tested-by: Jordan Justen Passes on IVB and BDW. As you noted on patch v1, it fails on HSW. Reviewed-by: Jordan Justen On 2016-02-19 10:07:34, Ilia Mirkin wrote: > This adds a very simple test of atomicAdd on a shared variable. > > Signed-off-by: Ilia Mirkin > --- > > v1

Re: [Piglit] [PATCH] cmake: don't fail, on Linux, if X11 is not found

On 2016-02-16 10:54:30, Mircea Gherzan wrote: > If X11 is not found then GLX cannot be available, so just disable the > building of the OpenGL test instead of hardcoding libGL/GLX as a build > requirement. You can run GL tests without GLX. We can't build GL tests without X11-dev? -Jordan > GLES

[Piglit] [PATCH 2/2] arb_compute_shader: Add test for dispatches with a zero size

The ARB_compute_shader spec says: "If the work group count in any dimension is zero, no work groups are dispatched." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94100 Signed-off-by: Jordan Justen --- tests/all.py | 1 +

[Piglit] [PATCH 1/2] arb_compute_shader: Support ID tests with work group sizes of 0

The ARB_compute_shader spec says: "If the work group count in any dimension is zero, no work groups are dispatched." Signed-off-by: Jordan Justen --- tests/spec/arb_compute_shader/cs-ids-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [Piglit] [PATCH V2 1/3] util: add infrastructure to look-up glMemoryBarrier() enums via names

On 2015-12-10 14:42:27, Timothy Arceri wrote: > V2: make the existing piglit_get_gl_enum_from_name() function handle the > memory barrier enums (Suggested by Jordan). > > Cc: Jordan Justen > --- > tests/util/gen_dispatch.py | 15 ++- > tests/util/piglit-ut

Re: [Piglit] [PATCH 1/3] util: add infrastructure to look-up glMemoryBarrier() enums via names

Thanks for looking at this! I wanted to add the memory barrier command to shader_runner to, but I also found that piglit_get_gl_enum_from_name would not handle those strings. My question is, why not just make piglit_get_gl_enum_from_name handle more strings? I think the enum=>string translation i

[Piglit] [PATCH] arb_shader_storage_buffer_object: Test linking programs with large copies

We test linking of programs that copy a large array, and a large structure. Signed-off-by: Jordan Justen --- tests/spec/arb_shader_storage_buffer_object/execution/large-field-copy.shader_test seemed a bit too complex, when the more immediate issue was the linking failure. Maybe it would be

[Piglit] [PATCH] arb_shader_storage_buffer_object: Test copying a large SSBO item

Signed-off-by: Jordan Justen Cc: Kristian Høgsberg Cc: Samuel Iglesias Gonsalvez Cc: Iago Toral Quiroga --- This fails to link on i965. .../execution/large-field-copy.shader_test | 66 ++ 1 file changed, 66 insertions(+) create mode 100644 tests/spec

Re: [Piglit] [PATCH] arb_compute_shader: Fix loop bounds.

Reviewed-by: Jordan Justen On 2015-11-14 23:29:29, Vinson Lee wrote: > Fixes "out-of-bounds read" defect reported by Coverity. > > Signed-off-by: Vinson Lee > --- > tests/spec/arb_compute_shader/cs-ids-common.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 de

[Piglit] [PATCH] arb_compute_shader: Test parsing shared variables

Signed-off-by: Jordan Justen --- .../compiler/shared-variables.comp | 44 ++ 1 file changed, 44 insertions(+) create mode 100644 tests/spec/arb_compute_shader/compiler/shared-variables.comp diff --git a/tests/spec/arb_compute_shader/compiler/shared

Re: [Piglit] [PATCH 1/3] arb_compute_shader: Add compiler tests for CS memory barrier functions

On 2015-11-05 10:57:12, Ilia Mirkin wrote: > On Thu, Nov 5, 2015 at 1:50 PM, Jordan Justen > wrote: > > Signed-off-by: Jordan Justen > > --- > > .../arb_compute_shader/compiler/groupMemoryBarrier.comp | 15 > > +++ > > .../comp

[Piglit] [PATCH v2 1/2] shader_runner: Allow compute shaders in OpenGLES 3.1

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index a967e52..59a76fa 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

[Piglit] [PATCH v2 2/2] shader_runner: Allow geometry and tessellation shaders in OpenGLES 3.2

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 59a76fa..b010cbb 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders

[Piglit] [PATCH 3/3] arb_compute_shader: shared variable atomic functions compiler tests

Signed-off-by: Jordan Justen --- .../compiler/shared-atomics.comp | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 tests/spec/arb_compute_shader/compiler/shared-atomics.comp diff --git a/tests/spec/arb_compute_shader/compiler/shared

[Piglit] [PATCH 1/3] arb_compute_shader: Add compiler tests for CS memory barrier functions

Signed-off-by: Jordan Justen --- .../arb_compute_shader/compiler/groupMemoryBarrier.comp | 15 +++ .../compiler/memoryBarrierAtomicCounter.comp | 15 +++ .../arb_compute_shader/compiler/memoryBarrierBuffer.comp | 15 +++ .../arb_compute_shader

[Piglit] [PATCH 2/3] arb_compute_shader: Add barrier() function compiler test

Signed-off-by: Jordan Justen --- tests/spec/arb_compute_shader/compiler/barrier.comp | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 tests/spec/arb_compute_shader/compiler/barrier.comp diff --git a/tests/spec/arb_compute_shader/compiler/barrier.comp b/tests/spec

[Piglit] [PATCH 1/2] shader_runner: Allow compute shaders in OpenGLES 3.1

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index a967e52..17a3e3a 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders

[Piglit] [PATCH 2/2] shader_runner: Allow geometry and tessellation shaders in OpenGLES 3.2

Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 17a3e3a..764f46d 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders

Re: [Piglit] [PATCH 1/3] Make atomic counter tests more robust against race conditions.

Series Reviewed-by: Jordan Justen On 2015-10-21 01:11:25, Kenneth Graunke wrote: > From: Chris Wilson > > Drivers with synchronization bugs could generate errors such as: > > Probe value at (0) > Expected: 0x0001 > Observed: 0x0001 > > This is because

Re: [Piglit] [PATCH 1/2] shader_runner: Add SSBO buffer initialization command

ase also binds buffer to the generic buffer binding point specified by target." -Jordan >- Chris > On Wed, Sep 30, 2015 at 1:10 PM, Jordan Justen >wrote: > > The command is: > >ssbo > > where is the size in bytes to allocate fo

[Piglit] [PATCH 1/2] shader_runner: Add SSBO buffer initialization command

The command is: ssbo where is the size in bytes to allocate for the SSBO buffer. This command only sets of a buffer for SSBO index 0. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/shaders/shader_runner.c b

[Piglit] [PATCH 2/2] arb_compute_shader: A simple CS test with SSBO

Signed-off-by: Jordan Justen --- .../execution/basic-ssbo.shader_test | 74 ++ 1 file changed, 74 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/basic-ssbo.shader_test diff --git a/tests/spec/arb_compute_shader/execution/basic

Re: [Piglit] [PATCH v1] Remove Occluqry Glean test.

Add aedc01a5979ec5e6a4498ed3054aa67927f70ca8 reference to commit message? Reviewed-by: Jordan Justen On 2015-09-25 15:19:51, Juliet Fru wrote: > --- > tests/all.py | 1 - > tests/glean/toccluqry.cpp | 708 > -- &g

[Piglit] [PATCH] arb_compute_shader: Use gl_NumWorkGroups in global ID tests

The test program for IDs (generated in cs-ids-common.c) has hx, hy and hz variables that are half of the maximum ID for that dimension. Previously we only considered the local workgroup size, even when we were reading the gl_GlobalInvocationID variable. Signed-off-by: Jordan Justen --- tests

[Piglit] [PATCH 4/5] arb_compute_shader: Add render + compute test

This test verifieds that rendering and compute operations can be interleaved. Signed-off-by: Jordan Justen --- tests/all.py | 1 + tests/spec/arb_compute_shader/CMakeLists.gl.txt| 1 + tests/spec/arb_compute_shader/render-and-compute.c | 101

[Piglit] [PATCH 2/5] arb_compute_shader: Add common functions for checking invocation IDs

Signed-off-by: Jordan Justen --- tests/spec/arb_compute_shader/CMakeLists.gl.txt | 2 +- tests/spec/arb_compute_shader/cs-ids-common.c | 422 tests/spec/arb_compute_shader/cs-ids-common.h | 67 3 files changed, 490 insertions(+), 1 deletion(-) create mode

[Piglit] [PATCH 1/5] arb_compute_shader: Add common functions to generate a CS program

These are a very simplified version of the similar image load/store versions. Signed-off-by: Jordan Justen --- tests/spec/arb_compute_shader/CMakeLists.gl.txt | 2 + tests/spec/arb_compute_shader/common.c | 98 + tests/spec/arb_compute_shader/common.h

[Piglit] [PATCH 5/5] arb_compute_shader: Add indirect compute dispatch test

Signed-off-by: Jordan Justen --- tests/all.py | 1 + tests/spec/arb_compute_shader/CMakeLists.gl.txt | 1 + tests/spec/arb_compute_shader/indirect-compute.c | 88 3 files changed, 90 insertions(+) create mode 100644 tests/spec

[Piglit] [PATCH 3/5] arb_compute_shader: Check local ids at various sizes using atomic counters

Signed-off-by: Jordan Justen --- tests/all.py| 1 + tests/spec/arb_compute_shader/CMakeLists.gl.txt | 2 + tests/spec/arb_compute_shader/local-id.c| 60 + 3 files changed, 63 insertions(+) create mode 100644 tests/spec

[Piglit] [PATCH] arb_shader_storage_buffer_object: Test std430 packing of vec2/vec3 array data

Signed-off-by: Jordan Justen Cc: Samuel Iglesias Gonsálvez --- Passes on NVidia's 340.76 driver & Igalia's SSBO branch for i965 .../layout-std430-write-shader.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

[Piglit] [PATCH] ARB_shader_image_load_store: Test loading from a cleared image

Signed-off-by: Jordan Justen Cc: Francisco Jerez --- .../execution/load-from-cleared-image.shader_test | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 tests/spec/arb_shader_image_load_store/execution/load-from-cleared-image.shader_test diff --git a/tests

[Piglit] [PATCH 2/3] arb_compute_shader: Test values of gl_WorkGroupID

Signed-off-by: Jordan Justen --- .../execution/basic-group-id.shader_test | 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/basic-group-id.shader_test diff --git a/tests/spec/arb_compute_shader/execution/basic

[Piglit] [PATCH 3/3] arb_compute_shader: Test values of gl_LocalInvocationIndex

Signed-off-by: Jordan Justen --- .../execution/basic-local-index.shader_test| 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/basic-local-index.shader_test diff --git a/tests/spec/arb_compute_shader/execution

[Piglit] [PATCH 1/3] arb_compute_shader: Test values of gl_GlobalInvocationID

Signed-off-by: Jordan Justen --- .../execution/basic-global-id.shader_test | 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/spec/arb_compute_shader/execution/basic-global-id.shader_test diff --git a/tests/spec/arb_compute_shader/execution/basic

Re: [Piglit] [PATCH] xz: Use --help when detecting xz presence

On 2015-08-02 09:57:00, Dylan Baker wrote: >On Aug 2, 2015 00:45, "Jordan Justen" wrote: >> >> If xz is present, and the piglit command's output is redirected, then >> xz will think its output is redirected. This will cause xz to try to >

[Piglit] [PATCH] xz: Use --help when detecting xz presence

from trying to compress data from stdin. Since we don't want to see 'xz --help' output from piglit, we now need to redirect both stdout and stderr to /dev/null. Signed-off-by: Jordan Justen Cc: Dylan Baker --- framework/backends/compression.py | 2 +- 1 file changed, 1 inse

[Piglit] Redirect summary console output

Dylan, I often send piglit summary console output to less or grep, but lately it doesn't seem to work. For example, if I try to send it to cat, I have to press Ctrl-C, and then I see this output: $ ./piglit summary console results/t | cat ^CTraceback (most recent call last): File "./piglit", l

Re: [Piglit] [PATCH 2/2] arb_shader_image_load_store/invalid: Skip the index bounds test on Intel Ivybridge hardware.

On 2015-07-24 12:49:05, Francisco Jerez wrote: > Jordan Justen writes: > > I don't know of any other cases where we skip a test based on the > > render name. I don't think this is a good practice to start. > > What do you think we should do in that case? * Let t

Re: [Piglit] [PATCH 2/2] arb_shader_image_load_store/invalid: Skip the index bounds test on Intel Ivybridge hardware.

I don't know of any other cases where we skip a test based on the render name. I don't think this is a good practice to start. -Jordan On 2015-07-24 11:01:47, Francisco Jerez wrote: > This test is known to cause a GPU hang on IVB due to a hardware bug. > The reason is that the hardware seems to b

Re: [Piglit] [PATCH 1/2] arb_shader_image_load_store/host-mem-barrier: Skip UBO/RaW test if the required UBO size is unsupported.

Reviewed-by: Jordan Justen On 2015-07-24 11:01:46, Francisco Jerez wrote: > This test assumes it can bind a UBO of size larger than the minimum > maximum guaranteed by the GL standard, what recently started causing > failures unrelated to ARB_shader_image_load_store since Mesa beca

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object/maxblocks: fail test if glGetIntegerv() gives an error

Reviewed-by: Jordan Justen On 2015-07-10 00:12:04, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez > --- > tests/spec/arb_shader_storage_buffer_object/maxblocks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

[Piglit] [PATCH] shader_runner: Check return value on sscanf (clip plane / draw arrays)

sscanf returns EOF if not all values are scanned. This can be interpreted as 'true' in these cases leading to the clip plane command being incorrectly requested. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Piglit] [PATCH v2 1/4] shader_runner: Use strndup to get a null-terminated string for 'line'

On 2015-06-16 04:07:35, Francisco Jerez wrote: > Jordan Justen writes: > > > In order to use sscanf with optional parameters, the string needs to > > be null terminated. Otherwise, sscanf will treat the newline as > > whitespace and continue to look for matches on the fol

[Piglit] [PATCH v2 4/4] arb_shader_image_load_store: Use GL_RGBA8 for image internal format

er runner tests, we must override the default internal format when creating the image. Signed-off-by: Jordan Justen Cc: Francisco Jerez --- .../execution/basic-imageStore-from-uniform.shader_test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[Piglit] [PATCH v2 2/4] shader_runner: Support optional internal format for 'texture rgbw'

rgbw 0 (16, 16) GL_RGBA8 v2: * Drop 'base type' parameter Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 41024cd..7

[Piglit] [PATCH v2 1/4] shader_runner: Use strndup to get a null-terminated string for 'line'

In order to use sscanf with optional parameters, the string needs to be null terminated. Otherwise, sscanf will treat the newline as whitespace and continue to look for matches on the following lines. v2: * Call strndup before skipping newline char in next_line Signed-off-by: Jordan Justen

[Piglit] [PATCH v2 3/4] arb_compute_shader: Use GL_RGBA8 for image_load_store internal format

er runner tests, we must override the default internal format when creating the image. Signed-off-by: Jordan Justen Reviewed-by: Francisco Jerez --- generated_tests/gen_builtin_uniform_tests.py| 2 +- .../arb_compute_shader/execution/basic-uniform-access.sh

Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests

e_buffer_object/program-interface-query.c > create mode 100644 tests/spec/arb_shader_storage_buffer_object/rendering.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/shaderstorageblockbinding.c similar? These patches seemed to have survived past the 2-weeks with no na

Re: [Piglit] [PATCH 1/3] shader_runner: Use strndup to get a null-terminated string for 'line'

On 2015-05-26 05:10:05, Francisco Jerez wrote: > Jordan Justen writes: > > > In order to use sscanf with optional parameters, the string needs to > > be null terminated. Otherwise, sscanf will treat the newline as > > whitespace and continue to look for matche

Re: [Piglit] [PATCH 2/3] shader_runner: Support optional format paramters for 'texture rgbw'

On 2015-05-26 05:12:08, Francisco Jerez wrote: > Jordan Justen writes: > > > The motivation for this is that (as noted by curro) > > ARB_shader_image_load_store doesn't support images with an internal > > format of GL_RGBA. > > > > See 'Table X.2

[Piglit] [PATCH 1/3] shader_runner: Use strndup to get a null-terminated string for 'line'

In order to use sscanf with optional parameters, the string needs to be null terminated. Otherwise, sscanf will treat the newline as whitespace and continue to look for matches on the following lines. Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 21 ++--- 1

[Piglit] [PATCH 2/3] shader_runner: Support optional format paramters for 'texture rgbw'

ple: texture rgbw 0 (16, 16) GL_RGBA8 Additionally, an optional fifth paramter can be added. This will specify the base type for the image. For example: texture rgbw 0 (16, 16) GL_RGBA8 GL_UNSIGNED_NORMALIZED Signed-off-by: Jordan Justen Cc: Francisco Jerez --- tests/shaders/shade

[Piglit] [PATCH 3/3] cs: Use GL_RGBA8 for image_load_store internal format

er runner tests, we must override the default internal format when creating the image. Signed-off-by: Jordan Justen Cc: Francisco Jerez --- generated_tests/gen_builtin_uniform_tests.py| 2 +- .../arb_compute_shader/execution/basic-uniform-access.shader_test | 2 +-

Re: [Piglit] [PATCH 2/2] util: Add a -png option to dump PNG files on piglit_present_results().

base_format, GL_UNSIGNED_BYTE, image); > + assert(glGetError() == GL_NO_ERROR); > + > + asprintf(&filename, "%s%03d.png", fileprefix, frame++); > + > + printf("Writing %s...\n", filename); > + p

[Piglit] [PATCH] framework: Support PIGLIT_DEFAULT_SIZE env variable

. Not all piglit tests will operate properly at every size, so this environment variable should be used carefully. Signed-off-by: Jordan Justen --- tests/util/piglit-framework-gl.c | 31 +++ tests/util/piglit-framework-gl.h | 7 --- 2 files changed, 31 insertions

Re: [Piglit] [PATCH] Delete redundant condition-07.vert test.

Reviewed-by: Jordan Justen On 2015-03-05 23:22:52, Kenneth Graunke wrote: > This test is redundant with: > glsl-1.20/compiler/structure-and-array-operations/array-selection.vert > > Both contain the same shader code and the same spec citation - the only > difference is variabl

[Piglit] [PATCH v2 3/3] ARB_shader_atomic_counters: Add simple VS test with inc/dec/read

Simple test of atomicCounterIncrement, atomicCounterDecrement and atomicCounter being used in the VS. v2: * Drop CORE requirement * Add GL_ARB_shader_atomic_counters requirement * Require INT GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS >= 2 Signed-off-by: Jordan Justen Reviewed-by: Ilia Mir

[Piglit] [PATCH v2 2/3] shader_runner: Add INT support in require section

This allows a shader_test to require something like: INT GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS >= 2 Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.

  1   2   3   4   >