We only use one parameter which means the texture unit index must
match the image unit index.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 846db4c
Compute shaders must be linked separately to process minimums
and maximums.
In the line following the version, we now look for a shader
type string. (One of vertex, geometry, fragment or compute.)
If specified, then that shader type will be tested separately.
Signed-off-by: Jordan Justen
Also, convert two glslparsertest tests to use built-in-constants.
Signed-off-by: Jordan Justen
---
tests/all.py | 1 +
.../compiler/gl_MaxComputeWorkGroupCount.comp| 20
.../compiler/gl_MaxComputeWorkGroupSize.comp
Signed-off-by: Jordan Justen
---
.../execution/simple-barrier.shader_test | 56 ++
1 file changed, 56 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/simple-barrier.shader_test
diff --git a/tests/spec/arb_compute_shader/execution/simple
Signed-off-by: Jordan Justen
---
.../execution/multiple-texture-reading.shader_test | 80 ++
1 file changed, 80 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/multiple-texture-reading.shader_test
diff --git
a/tests/spec/arb_compute_shader
This will allow probing from the texture for operations that want
to target a texture rather than the draw framebuffer. (For example,
imageStore)
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 29 +
1 file changed, 29 insertions(+)
diff --git a
This will run glDispatchCompute allowing a compute shader to run.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 4f9fd47..b71a401
This will allow us to bind a texture to a framebuffer for rendering
and probing.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests
Signed-off-by: Jordan Justen
---
Series available at 'cs' branch of:
git://people.freedesktop.org/~jljusten/piglit
tests/shaders/shader_runner.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runn
Signed-off-by: Jordan Justen
---
.../execution/multiple-workgroups.shader_test | 37 ++
1 file changed, 37 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/multiple-workgroups.shader_test
diff --git
a/tests/spec/arb_compute_shader/execution
Signed-off-by: Jordan Justen
---
.../execution/basic-uniform-access.shader_test | 37 ++
1 file changed, 37 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/basic-uniform-access.shader_test
diff --git
a/tests/spec/arb_compute_shader/execution
Signed-off-by: Jordan Justen
---
tests/all.py| 4
tests/spec/arb_tessellation_shader/minimum-maximums.txt | 16
2 files changed, 20 insertions(+)
create mode 100644 tests/spec/arb_tessellation_shader/minimum-maximums.txt
diff
This test will add no extra tessellated triangles. It basically passes
verticies through the tessellation stages and draws two triangles.
Signed-off-by: Jordan Justen
---
tests/all.py | 3 ++
.../execution/nop.shader_test | 63
Signed-off-by: Jordan Justen
---
tests/all.py | 3 +++
tests/spec/arb_tessellation_shader/compiler/nop.tessc | 14 ++
tests/spec/arb_tessellation_shader/compiler/nop.tesse | 12
3 files changed, 29 insertions(+)
create mode
.tessc: Tessellation Control shader test
.tesse: Tessellation Evaluation shader test
Signed-off-by: Jordan Justen
---
tests/glslparsertest/glslparsertest.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/tests/glslparsertest/glslparsertest.c
b/tests/glslparsertest
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 75 ---
1 file changed, 71 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index b71a401..5f6722a 100644
--- a/tests/shaders
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 5f6722a..a4be7a5 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
@@ -2066,6
ages.
Signed-off-by: Jordan Justen
---
Series available at 'ts' branch of:
git://people.freedesktop.org/~jljusten/piglit
tests/shaders/built-in-constants.c | 97 +++---
1 file changed, 90 insertions(+), 7 deletions(-)
diff --git a/tests/shaders/built-in-
Signed-off-by: Jordan Justen
---
tests/all.py | 1 +
tests/spec/CMakeLists.txt | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt | 15
tests/spec/arb_tessellation_shader/CMakeLists.txt | 1 +
tests/spec
Whoops, self-NAK this series. As Chris points out, Fabian already has
some patches out for arb_ts.
-Jordan
On Mon, Jun 2, 2014 at 3:44 PM, Jordan Justen wrote:
> Note: If the file requests testing only with GL_TESS_CONTROL_SHADER or
> GL_TESS_EVALUATION_SHADER, then the vertex, ge
On Fri, May 2, 2014 at 12:35 PM, Anuj Phogat wrote:
> On Sat, Apr 26, 2014 at 9:04 PM, Chris Forbes wrote:
>> Signed-off-by: Chris Forbes
>> ---
>> .../compiler/precise-qualifier/precise-01.vert | 12 +++
>> .../compiler/precise-qualifier/precise-02.vert | 12 +++
>> ...
I pushed the other 14 patches in this series. (I got the 'install
tesc/tese' v2 from your github repo.)
For this one, what do you think about the minmax test I posted
yesterday for the limits?
For the defaults, hmm, maybe we should create some standard helper
functions like minmax? I wouldn't say
This command initializes the specified number of atomic counters all
containing an initial value of 0.
For example, 'atomic counters 2' creates an zeroed 8 byte buffer
for 2 atomic counters.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 11 ++-
1 file c
and ensure the value is greater than 512.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 56 +++
1 file changed, 56 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 4babd36..8c8d8f6 100
Signed-off-by: Jordan Justen
---
.../execution/atomic-counter.shader_test | 29 ++
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/atomic-counter.shader_test
diff --git a/tests/spec/arb_compute_shader/execution/atomic
On Mon, Jun 16, 2014 at 1:05 AM, Samuel Iglesias Gonsálvez
wrote:
> On Sun, 2014-06-15 at 19:18 -0400, Ilia Mirkin wrote:
>> On Wed, Jun 11, 2014 at 12:31 PM, Jordan Justen wrote:
>> > On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral wrote:
>> >> Hi Chris,
>>
On 2014-06-18 01:47:21, Chris Forbes wrote:
> Not really thrilled with the parens in 2/3, but I need this working
> for the tests I'm writing :)
I'll drop the parens.
> This series is:
>
> Reviewed-by: Chris Forbes
Thanks!
> On Sun, Jun 8, 2014 at 6:58 AM, Jorda
Reviewed-by: Jordan Justen
On Tue, Jun 17, 2014 at 8:45 AM, Dylan Baker wrote:
> Previously spec['glsl-3.30'] was initialized to {} twice, meaning all
> tests added before the second assignment were discarded.
>
> Signed-off-by: Dylan Baker
> ---
> tests/all.py |
Make sure ARB_shader_image_load_store is supported before calling
glMemoryBarrier.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders
On Sun, Jun 22, 2014 at 10:49 PM, Kenneth Graunke wrote:
> On Saturday, June 21, 2014 08:34:05 PM Chris Forbes wrote:
>> Ian,
>>
>> That's true, but... we will probably have compute finished long before
> images.
>>
>> Is there an acceptable thing to do here in the interim?
>>
>> -- Chris
>
> How?
On Mon, Jul 7, 2014 at 4:20 PM, Dylan Baker wrote:
> With this patch piglit.conf can live in a number of different places. It
> can live in the current directory, then in XDG_CONFIG_HOME
> ($HOME/.config by default), and finally in the piglit source directory.
>
> v2: - fix types (chadv)
> - c
On Tue, Jul 15, 2014 at 7:02 AM, Dylan Baker wrote:
> [snip]
>> > +else:
>> > +if __debug__:
>> > +print('Warning: piglit.conf not found!\n'
>> > + '(searching current dir, $HOME/.config, '
>> > + '$XDG_CONFIG_HOME, and
On Tue, Jul 15, 2014 at 6:39 PM, Dylan Baker wrote:
> On Tuesday, July 15, 2014 04:44:31 PM Jordan Justen wrote:
>> On Tue, Jul 15, 2014 at 7:02 AM, Dylan Baker
> wrote:
>> > [snip]
>> >
>> >> > +else:
>> >> > +
2.
Signed-off-by: Jordan Justen
---
tests/spec/arb_compute_shader/minimum-maximums.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_compute_shader/minimum-maximums.txt
b/tests/spec/arb_compute_shader/minimum-maximums.txt
index 3d55c8f..85cac37 100644
--- a/
anted, correct?
Uh, yeah. Patch 18 anyway. :)
Series Reviewed-by: Jordan Justen
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Typo in subject: addtional => additional
On Tue, Aug 19, 2014 at 1:25 PM, Dylan Baker wrote:
> If a config file doesn't have a section for the external suites they
> will raise an exception. This causes the tests to skip if there is a
> NoSectionError
>
> Signed-off-by: Dylan Baker
> ---
> fram
Signed-off-by: Jordan Justen
---
generated_tests/gen_builtin_uniform_tests.py | 44
1 file changed, 44 insertions(+)
diff --git a/generated_tests/gen_builtin_uniform_tests.py
b/generated_tests/gen_builtin_uniform_tests.py
index 3e9b64c..d89a6f3 100644
--- a
Compute shader tests will not need a VS or FS.
Signed-off-by: Jordan Justen
---
generated_tests/gen_builtin_uniform_tests.py | 35 +++-
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/generated_tests/gen_builtin_uniform_tests.py
b/generated_tests
Signed-off-by: Jordan Justen
---
generated_tests/gen_builtin_uniform_tests.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/generated_tests/gen_builtin_uniform_tests.py
b/generated_tests/gen_builtin_uniform_tests.py
index 975c9ef..3e9b64c 100644
--- a/generated_tests
these internal libraries causes this message to go away.
Signed-off-by: Jordan Justen
---
cmake/piglit_util.cmake | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmake/piglit_util.cmake b/cmake/piglit_util.cmake
index e2c3454..45143d2 100644
--- a/cmake/piglit_util.cmake
+++ b/
On 2014-09-29 10:01:59, Matt Turner wrote:
> On Mon, Sep 29, 2014 at 9:34 AM, Emil Velikov
> wrote:
> > While I've been through the RELEASES document I believe it would be
> > beneficial if we regularly create a tag("release"), that is to serve the
> > following
> > - Human understandable format
On Mon, Sep 29, 2014 at 5:01 PM, Matt Turner wrote:
> On Mon, Sep 29, 2014 at 4:52 PM, Jordan Justen wrote:
>> Anyway, I discussed it with Ian around Mesa 10.2. While I don't think
>> he was excited about it, he also did not express any reasons for not
>> doing it. B
On Mon, Sep 29, 2014 at 7:39 PM, Matt Turner wrote:
> On Mon, Sep 29, 2014 at 6:45 PM, Jordan Justen wrote:
>> On Mon, Sep 29, 2014 at 5:01 PM, Matt Turner wrote:
>>> On Mon, Sep 29, 2014 at 4:52 PM, Jordan Justen wrote:
>>>> Anyway, I discussed it with Ian a
On Tue, Sep 30, 2014 at 8:18 AM, Ian Romanick wrote:
> On 09/29/2014 10:01 AM, Matt Turner wrote:
>> On Mon, Sep 29, 2014 at 9:34 AM, Emil Velikov
>> wrote:
>>> While I've been through the RELEASES document I believe it would be
>>> beneficial if we regularly create a tag("release"), that is to
On Thu, Oct 2, 2014 at 4:43 PM, Emil Velikov wrote:
> On 02/10/14 21:44, Ian Romanick wrote:
>> On 09/30/2014 09:55 AM, Emil Velikov wrote:
>>> On 30/09/14 16:18, Ian Romanick wrote:
On 09/29/2014 10:01 AM, Matt Turner wrote:
> On Mon, Sep 29, 2014 at 9:34 AM, Emil Velikov
> wrote:
On 2014-11-01 00:06:33, Ben Widawsky wrote:
> From: Jordan Justen
>
> If GBM is enabled, attempt to locate libcaca too.
>
> If the test was not run with -auto, then use libcaca
> to draw a text version of the test's results to the
> console.
>
> v2 (Ben): Rebase
Signed-off-by: Jordan Justen
---
.../execution/basic-texelFetch.shader_test | 62 ++
1 file changed, 62 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/basic-texelFetch.shader_test
diff --git
a/tests/spec/arb_compute_shader/execution/basic
Signed-off-by: Jordan Justen
---
.../execution/basic-local-id-atomic.shader_test| 61 ++
1 file changed, 61 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/basic-local-id-atomic.shader_test
diff --git
a/tests/spec/arb_compute_shader/execution
A simple compute shader that uses atomics with a barrier call.
Signed-off-by: Jordan Justen
---
.../execution/simple-barrier-atomics.shader_test | 35 ++
1 file changed, 35 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/simple-barrier
Signed-off-by: Jordan Justen
---
.../basic-uniform-access-atomic.shader_test| 56 ++
1 file changed, 56 insertions(+)
create mode 100644
tests/spec/arb_compute_shader/execution/basic-uniform-access-atomic.shader_test
diff --git
a/tests/spec/arb_compute_shader
As documented in:
https://www.opengl.org/registry/specs/ARB/compute_shader.txt
gl_WorkGroupSize's type is uvec3, not ivec3.
Signed-off-by: Jordan Justen
---
.../arb_compute_shader/compiler/gl_WorkGroupSize_before_layout.comp | 2 +-
.../compiler/gl_WorkGroupSize_matches_layout
Reviewed-by: Jordan Justen
On 2014-11-29 12:54:21, Chris Forbes wrote:
> Mesa's GLSL implementation has different paths for these cases. Just
> make sure we cover them all.
>
> Signed-off-by: Chris Forbes
> ---
> .../interface-blocks-name-reused
Signed-off-by: Jordan Justen
Cc: Francisco Jerez
---
Francisco,
Question for your image-load-store branch:
Should we parse the memory qualifiers separately from
storage_qualifier?
I did a quick hack to bypass this issue:
- if ($2.has_storage())
+ if ($1.has_storage() &
Signed-off-by: Jordan Justen
Cc: Francisco Jerez
---
Francisco,
I was looking at your image-load-store branch. I noticed using
imageStore directly from a uniform results in:
brw_ir_svec4.h:94: brw::array_reg brw::half(const brw::array_reg&,
unsigned int) [with R = fs_reg]: Asser
On 2014-12-04 02:33:06, Francisco Jerez wrote:
> Jordan Justen writes:
>
> > Signed-off-by: Jordan Justen
> > Cc: Francisco Jerez
> > ---
> > Francisco,
> >
> > Question for your image-load-store branch:
> >
> > Should we parse the m
Previously we created a 16 x 16 texture. But, the generated tests
require a variable width based on the number of sub-test-cases. The
tests also only need a texture with a height of 1.
Signed-off-by: Jordan Justen
---
On Nvidia, this allows 211 more tests to pass.
generated_tests
ugh patch 10, it
seems possible that that output might be unchanged.
I'm not saying it is a requirement that it be exactly the same
generated tests, but it would make it easier to say 'go ahead' with
the changes.
For 1-3 & 11-12: Reviewed-by: Jordan Justen
Signed-off-by: Jordan Justen
Cc: Ben Widawsky
---
Requires Ben's ARB_pipeline_statistics_query series.
tests/all.py | 2 +
.../spec/arb_pipeline_statistics/CMakeLists.gl.txt | 2 +
.../arb_pipeline_statistics/pipeline_stats_comp.c
Ken pointed out cucul_flop in the original libcaca patch, but going
back to 2008-09-27, r2821,
http://caca.zoy.org/browser/libcaca/trunk/caca/caca.h?rev=2821#L251
caca_flop seems to be preferred.
Signed-off-by: Jordan Justen
---
.../util/piglit-framework-gl/piglit_gbm_framework.c | 20
Signed-off-by: Jordan Justen
---
%^$# @^&* %^$# !!!
tests/util/piglit-framework-gl/piglit_gbm_framework.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-framework-gl/piglit_gbm_framework.c
b/tests/util/piglit-framework-gl/piglit_gbm_framework.c
i
On 2015-01-31 07:41:23, Francisco Jerez wrote:
> Define a variant of piglit_compile_shader_text() that doesn't call
> piglit_report_result() on failure killing the program, which is quite
> annoying for tests that expect a compilation to fail and for tests
> that are structured in a number of subte
Reviewed-by: Jordan Justen
On 2015-01-31 07:41:24, Francisco Jerez wrote:
> Define helper data structures and functions to query several kinds of
> information for any supported image format, target or shader stage,
> like the matching pixel transfer type and format for a given image
On 2015-01-31 11:45:59, Francisco Jerez wrote:
> Jordan Justen writes:
>
> > On 2015-01-31 07:41:23, Francisco Jerez wrote:
> >> Define a variant of piglit_compile_shader_text() that doesn't call
> >> piglit_report_result() on failure killing the program, whi
image_qualifier_info *qual;
> +const struct image_stage_info *stage_w;
> +const struct image_stage_info *stage_r;
> +enum piglit_result status = PIGLIT_PASS;
> +unsigned l;
> +
> +piglit_require_extension("GL_A
Take into account the aspect ratio of piglit_width to piglit_height.
The assumption is made that the console window is 80 x 24.
Signed-off-by: Jordan Justen
---
.../piglit-framework-gl/piglit_gbm_framework.c | 41 +++---
1 file changed, 37 insertions(+), 4 deletions(-)
diff
Signed-off-by: Jordan Justen
---
tests/util/piglit-framework-gl/piglit_gbm_framework.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-framework-gl/piglit_gbm_framework.c
b/tests/util/piglit-framework-gl/piglit_gbm_framework.c
index d6344f8
Signed-off-by: Jordan Justen
---
tests/util/piglit-framework-gl/piglit_gbm_framework.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/util/piglit-framework-gl/piglit_gbm_framework.c
b/tests/util/piglit-framework-gl/piglit_gbm_framework.c
index 581ca99..d6344f8 100644
--- a
8-10 and 21 Reviewed-by: Jordan Justen
These are some challenging tests to review, but they seem very
thorough.
For the rest, I think you should proceed with your plan and commit
them without an r-b.
-Jordan
On 2015-01-31 07:41:32, Francisco Jerez wrote:
> Add tests for the glMemoryBarr
Simple test of atomicCounterIncrement, atomicCounterDecrement and
atomicCounter being used in the VS.
Signed-off-by: Jordan Justen
---
tests/all.py | 3 +
.../execution/vs-simple-inc-dec-read.shader_test | 70 ++
2 files changed, 73
This allows a shader_test to require something like:
INT GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS >= 2
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/tests/shaders/shader_runner.
Signed-off-by: Jordan Justen
Reviewed-by: Chad Versace
---
tests/util/gen_dispatch.py| 21 ++-
tests/util/piglit-util-gl-enum-gen.c.mako | 35 +++
tests/util/piglit-util-gl.h | 9
3 files changed, 64 insertions
Simple test of atomicCounterIncrement, atomicCounterDecrement and
atomicCounter being used in the VS.
v2:
* Drop CORE requirement
* Add GL_ARB_shader_atomic_counters requirement
* Require INT GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS >= 2
Signed-off-by: Jordan Justen
Cc: Ilia Mirkin
---
te
On 2015-02-18 14:32:29, Jordan Justen wrote:
> diff --git a/tests/util/piglit-util-gl.h b/tests/util/piglit-util-gl.h
> index 0f8eb81..fa4a6e4 100644
> --- a/tests/util/piglit-util-gl.h
> +++ b/tests/util/piglit-util-gl.h
> @@ -87,6 +87,15 @@ const char* piglit_get_gl_error_na
Update the README?
1-7 Reviewed-by: Jordan Justen
On 2015-02-20 18:17:54, Dylan Baker wrote:
> Six is a module that provides a clean, standardized interface for
> handling python2 and python3 from the same code base. This adds a
> requirement on six as a build-time dependency, the p
e learn some new git magic. :)
git show --word-diff-regex=. dcbaker/submit/python3~26
Reviewed-by: Jordan Justen
> Signed-off-by: Dylan Baker
> ---
> generated_tests/gen_outerproduct_tests.py | 4 +++-
> .../gen_outerproduct_tests/template.shader_test.mako | 18
&
generates.
> """
>
> -from builtin_function import *
> -import mako.template
Seems unrelated, but meh...
9-13 Reviewed-by: Jordan Justen
> +from builtin_function import *
> import os
>
> +import six
> +from six.moves import range
> +
> from tem
six.PY2:
> +# long is undefined in python3, and we are aware of that
> +# pylint: disable=undefined-variable
> +self.num_value = long(self.str_value, base)
> +elif six.PY3:
How about?
else:
assert six.PY3
14-25 Reviewed-by: Jordan
Series Reviewed-by: Jordan Justen
except 31 (add MIT header) which I think you should get confirmation
from the authors.
I responded to a few patches with notes, but nothing critical.
-Jordan
On 2015-02-20 18:17:47, Dylan Baker wrote:
> This series hybridizes the python generator framew
This allows a shader_test to require something like:
INT GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS >= 2
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/tests/shaders/shader_runner.
Simple test of atomicCounterIncrement, atomicCounterDecrement and
atomicCounter being used in the VS.
v2:
* Drop CORE requirement
* Add GL_ARB_shader_atomic_counters requirement
* Require INT GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS >= 2
Signed-off-by: Jordan Justen
Reviewed-by: Ilia Mir
Reviewed-by: Jordan Justen
On 2015-03-05 23:22:52, Kenneth Graunke wrote:
> This test is redundant with:
> glsl-1.20/compiler/structure-and-array-operations/array-selection.vert
>
> Both contain the same shader code and the same spec citation - the only
> difference is variabl
.
Not all piglit tests will operate properly at every size, so this
environment variable should be used carefully.
Signed-off-by: Jordan Justen
---
tests/util/piglit-framework-gl.c | 31 +++
tests/util/piglit-framework-gl.h | 7 ---
2 files changed, 31 insertions
base_format, GL_UNSIGNED_BYTE, image);
> + assert(glGetError() == GL_NO_ERROR);
> +
> + asprintf(&filename, "%s%03d.png", fileprefix, frame++);
> +
> + printf("Writing %s...\n", filename);
> + p
ple:
texture rgbw 0 (16, 16) GL_RGBA8
Additionally, an optional fifth paramter can be added. This will
specify the base type for the image. For example:
texture rgbw 0 (16, 16) GL_RGBA8 GL_UNSIGNED_NORMALIZED
Signed-off-by: Jordan Justen
Cc: Francisco Jerez
---
tests/shaders/shade
er runner tests, we
must override the default internal format when creating the image.
Signed-off-by: Jordan Justen
Cc: Francisco Jerez
---
generated_tests/gen_builtin_uniform_tests.py| 2 +-
.../arb_compute_shader/execution/basic-uniform-access.shader_test | 2 +-
In order to use sscanf with optional parameters, the string needs to
be null terminated. Otherwise, sscanf will treat the newline as
whitespace and continue to look for matches on the following lines.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 21 ++---
1
On 2015-05-26 05:12:08, Francisco Jerez wrote:
> Jordan Justen writes:
>
> > The motivation for this is that (as noted by curro)
> > ARB_shader_image_load_store doesn't support images with an internal
> > format of GL_RGBA.
> >
> > See 'Table X.2
On 2015-05-26 05:10:05, Francisco Jerez wrote:
> Jordan Justen writes:
>
> > In order to use sscanf with optional parameters, the string needs to
> > be null terminated. Otherwise, sscanf will treat the newline as
> > whitespace and continue to look for matche
e_buffer_object/program-interface-query.c
> create mode 100644 tests/spec/arb_shader_storage_buffer_object/rendering.c
> create mode 100644
> tests/spec/arb_shader_storage_buffer_object/shaderstorageblockbinding.c
similar?
These patches seemed to have survived past the 2-weeks with no na
er runner tests, we
must override the default internal format when creating the image.
Signed-off-by: Jordan Justen
Reviewed-by: Francisco Jerez
---
generated_tests/gen_builtin_uniform_tests.py| 2 +-
.../arb_compute_shader/execution/basic-uniform-access.sh
In order to use sscanf with optional parameters, the string needs to
be null terminated. Otherwise, sscanf will treat the newline as
whitespace and continue to look for matches on the following lines.
v2:
* Call strndup before skipping newline char in next_line
Signed-off-by: Jordan Justen
er runner tests, we
must override the default internal format when creating the image.
Signed-off-by: Jordan Justen
Cc: Francisco Jerez
---
.../execution/basic-imageStore-from-uniform.shader_test | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
rgbw 0 (16, 16) GL_RGBA8
v2:
* Drop 'base type' parameter
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 41024cd..7
On 2015-06-16 04:07:35, Francisco Jerez wrote:
> Jordan Justen writes:
>
> > In order to use sscanf with optional parameters, the string needs to
> > be null terminated. Otherwise, sscanf will treat the newline as
> > whitespace and continue to look for matches on the fol
sscanf returns EOF if not all values are scanned. This can be
interpreted as 'true' in these cases leading to the clip plane command
being incorrectly requested.
Signed-off-by: Jordan Justen
---
tests/shaders/shader_runner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jordan Justen
On 2015-07-10 00:12:04, Samuel Iglesias Gonsalvez wrote:
> Signed-off-by: Samuel Iglesias Gonsalvez
> ---
> tests/spec/arb_shader_storage_buffer_object/maxblocks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff
Reviewed-by: Jordan Justen
On 2015-07-24 11:01:46, Francisco Jerez wrote:
> This test assumes it can bind a UBO of size larger than the minimum
> maximum guaranteed by the GL standard, what recently started causing
> failures unrelated to ARB_shader_image_load_store since Mesa beca
I don't know of any other cases where we skip a test based on the
render name. I don't think this is a good practice to start.
-Jordan
On 2015-07-24 11:01:47, Francisco Jerez wrote:
> This test is known to cause a GPU hang on IVB due to a hardware bug.
> The reason is that the hardware seems to b
On 2015-07-24 12:49:05, Francisco Jerez wrote:
> Jordan Justen writes:
> > I don't know of any other cases where we skip a test based on the
> > render name. I don't think this is a good practice to start.
>
> What do you think we should do in that case?
* Let t
Dylan,
I often send piglit summary console output to less or grep, but lately
it doesn't seem to work.
For example, if I try to send it to cat, I have to press Ctrl-C, and
then I see this output:
$ ./piglit summary console results/t | cat
^CTraceback (most recent call last):
File "./piglit", l
1 - 100 of 375 matches
Mail list logo
