Re: [Piglit] Vulkan headers dependency

there are lots of precedents for tests being optionally built. Jose From: Lionel Landwerlin Sent: Tuesday, May 5, 2020 15:46 To: Jose Fonseca ; Eleni Maria Stea Cc: piglit@lists.freedesktop.org Subject: Re: [Piglit] Vulkan headers dependency Maybe embedding them

[Piglit] Vulkan headers dependency

Hi Eleni, Could we please make Vulkan headers an optional dependency? It would simplify building and running piglit on Windows. Jose Sent: Tuesday, May 5, 2020 15:32 piglit-mingw32 - Build # 3770 - Failure: Log: [...truncated 47 lines...]

[Piglit] [PATCH] appveyor: Update instructions for personal repositories.

With GitLab is now much easier to setup. --- appveyor.yml | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 1f8779187..56f0d5a57 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,22 +1,16 @@ -#

[Piglit] [PATCH] appveyor: Fix build with CMake 3.13.3.

Newer CMake versions (in particular 3.13.3 currently used by default Appveyor machine) expects GLUT_glut_LIBRARY_RELEASE variable, instead of GLUT_glut_LIBRARY. --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index

Re: [Piglit] [PATCH] fbo-blending-snorm: new test for testing snorm blend behavior

ending-snorm.c new file mode 100644 index 000..a7c2bba --- /dev/null +++ b/tests/fbo/fbo-blending-snorm.c @@ -0,0 +1,358 @@ +/* We should update copyright here. Otherwise looks great to me. Thanks. Reviewed-by: Jose Fonseca <jfons...@vmware.com> Jose + * Copyright © 2010 Intel

Re: [Piglit] [PATCH] cmake: also install Windows manifest files

n10-manifest.txt) + + install(FILES $<TARGET_FILE:${target}>.manifest + DESTINATION ${PIGLIT_INSTALL_LIBDIR}/bin) endif() endif() endfunction(piglit_create_manifest_file) Looks great! Reviewed-by: Jose Fonsec

Re: [Piglit] [PATCH] cmake: create Win10 manifest files for particular executables

On 27/10/17 17:12, Brian Paul wrote: On Windows10 (and possibly older versions), UAC (User Account Control) intervenes when starting an executables with "patch", "update" or "setup" in their name. This requires the user to approve execution by clicking in a dialog window (and even then, causes

Re: [Piglit] [PATCH] mingw: build shader_runner with 2MB stack

nks Reviewed-by: Jose Fonseca <jfons...@vmware.com> > Note that this causes two -Wl,--stack,XXX flags to be passed to the linker. But the later one specifying 2MB wins. Perhaps there's a way to avoid that in CMake. I don't know a good way neither. Jose --- tests/shaders/CMakeList

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

On 12/10/17 23:08, Roland Scheidegger wrote: Am 12.10.2017 um 21:19 schrieb Brian Paul: On 10/12/2017 12:11 PM, Jose Fonseca wrote: On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

On 12/10/17 20:19, Brian Paul wrote: On 10/12/2017 12:11 PM, Jose Fonseca wrote: On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevented us from setting a huge stack size on both MinGW and MSVC alike, as both

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevented us from setting a huge stack size on both MinGW and MSVC alike, as both toolchains allow to congifure the stack size to whatever we want. The key issue here

Re: [Piglit] [PATCH] Remove MSVC build support.

o Clang by default on Windows -- https://news.ycombinator.com/item?id=14877963 . Maybe one day we can switch Mesa too. From: Brian Paul Sent: Monday, July 31, 2017 15:33 To: Jose Fonseca; piglit@lists.freedesktop.org Subject: Re: [PATCH] Remove MSVC build su

[Piglit] [PATCH] Remove MSVC build support.

MSVC build of Piglit was broken for over a month. No point in sustaining it. --- CMakeLists.txt | 6 ++-- HACKING | 10 ++ README | 68 +++-- appveyor.yml| 8 -

[Piglit] [PATCH] drawoverhead: Fix Windows builds.

On Windows, OpenGL entrypoints need to be declared with APIENTRY qualifier to get the right calling convention. Using the piglit dispactch typedefs makes this even easier. --- tests/perf/drawoverhead.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [PATCH] tests/util: remove unneeded cmake code for WGL

o refactor it? - include_directories( - ${GLPROTO_INCLUDE_DIRS} - ) - add_definitions ( -DPIGLIT_USE_WGL ) piglit_add_library (piglitwglutil piglit-shader.c Reviewed-by: Jose Fonseca <jfons.

Re: [Piglit] [PATCH] wgl: initial check-in of wgl utility code and wgl sanity check program

On 11/07/17 17:06, Brian Paul wrote: Like the glx tests/utility code, but for wgl. Note, one must set the PIGLIT_PLATFORM env var to "wgl" before running Piglit. It looks like there's some Waffle work to look at before this can be made automatic. --- CMakeLists.txt | 7 ++

Re: [Piglit] [PATCH 1/7] appveyro: Remove help invocation from cmake

I see. Fair enough. Reviewed-by: Jose Fonseca <jfons...@vmware.com> Jose On 14/06/17 19:01, Dylan Baker wrote: According to the man page (for 3.8.2): --help,-help,-usage,-h,-H,/? Print usage information and exit. Usage describes the basic comman

Re: [Piglit] Appveyor: Add support for python tests in addition to native tests

I got the missing PATCH 3/4. Reviewed-by: Jose Fonseca <jfons...@vmware.com> From: Dylan Baker <dy...@pnwbakers.com> Sent: Tuesday, June 13, 2017 21:59 To: piglit@lists.freedesktop.org Cc: Jose Fonseca Subject: Appveyor: Add support for python tests

Re: [Piglit] [PATCH 1/7] appveyro: Remove help invocation from cmake

arguments in the end. Jose From: Dylan Baker <dy...@pnwbakers.com> Sent: Tuesday, June 13, 2017 21:59 To: piglit@lists.freedesktop.org Cc: Jose Fonseca Subject: [PATCH 1/7] appveyro: Remove help invocation from cmake Signed-off-by: Dylan Baker <dylanx.c.ba...@

Re: [Piglit] [PATCH 5/7] appveyor: Convert to powerscript blocks for install and build_script

;dy...@pnwbakers.com> Sent: Tuesday, June 13, 2017 21:59 To: piglit@lists.freedesktop.org Cc: Jose Fonseca Subject: [PATCH 5/7] appveyor: Convert to powerscript blocks for install and build_script This is required to run two types of tests, which is what is needed to add back tests for the python runner.

Re: [Piglit] [PATCH 7/7] appveyor: Add python tests

I thinks it's fine to restrict the supported Python versions on Windows. (Eg., only 2.7 and 3.6.) Either way, this is Reviewed-by: Jose Fonseca <jfons...@vmware.com> I haven't received PATCH 3 and 4 yet. But 2, 5, 6 are also Reviewed-by: Jose Fonseca <jfons...@vmware.co

Re: [Piglit] [PATCH] util: fix Windows stdout/stderr buffering

-by: Jose Fonseca <jfons...@vmware.com> though it might be worth rephrasing the comment, as I don't think Windows differs from Linux in this regard. Jose Refactor the init code a bit to avoid calling setbuf() from some arbitrary place otherwise. --- tests/util/piglit-framework-gl.

[Piglit] [PATCH 2/2] appveyor: Allow building with MSVC too.

Disabled by default, as I'm not sure it's worth supporting MSVC build. --- appveyor.yml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 54e7a420f..302308599 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -35,18 +35,26 @@

[Piglit] [PATCH 1/2] appveyor: Build piglit for Windows using MinGW.

This replaces the previous appveyor.yml with python tox tests. See https://ci.appveyor.com/project/jrfonseca/piglit-fc01r for the runs. --- appveyor.yml | 130 +++ 1 file changed, 78 insertions(+), 52 deletions(-) diff --git a/appveyor.yml

Re: [Piglit] [PATCH 0/3] apitrace test runner for piglit

On 16/09/16 11:05, Eric Anholt wrote: Jose Fonseca <jfons...@vmware.com> writes: On 14/09/16 11:03, Eric Anholt wrote: I've applied Dylan's comments to the RFC series, and I've pushed a starting trace-db with reference images for my i965 and vc4: https://github.com/anholt/trace-db

Re: [Piglit] [PATCH 0/3] apitrace test runner for piglit

On 14/09/16 11:03, Eric Anholt wrote: I've applied Dylan's comments to the RFC series, and I've pushed a starting trace-db with reference images for my i965 and vc4: https://github.com/anholt/trace-db Eric, This is great initiative IMO. One suggestion: you can get much smaller traces by

Re: [Piglit] [PATCH 0/4] Add support for subtests in JUnit as nested testsuite elements

processes / test systems in place. So I'm happy to let you guys to do what you think best. Therefore the series is Acked-by: Jose Fonseca <jfons...@vmware.com> And if Jenkin's xUnit parser gives better results than Junit parser, I'm happy to make the switch too. Is it just a

Re: [Piglit] [PATCH] arb_internalformat_query2: add APIENTRY qualifier to fix MSVC build

Reviewed-by: Jose Fonseca <jfons...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Wednesday, July 13, 2016 16:01 To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Jose Fonseca; Brian Paul Subject: [PATCH] arb_internalf

Re: [Piglit] [PATCH] builtin_function: try and use casts for 64-bits instead of dtype setting.

On 04/07/16 07:20, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> The dtype setting only works with numpy 1.9 and above, which doesn't seem to be in most distros yet. Reported-by: Jose Fonseca <jfons...@vmware.com> Signed-off-by: Dave Airlie <air

Re: [Piglit] [PATCH] arb_gpu_shader_int64: add test generation to standard testing template

On 10/06/16 04:39, Dave Airlie wrote: +f('abs', 1, 150, np.abs, None, [np.linspace(-10, 15, 5, dtype=np.dtype(np.int64))], + extension="ARB_gpu_shader_int64") +f('sign', 1, 150, np.sign, None, [np.linspace(-15, 15, 5, dtype=np.dtype(np.int64))], +

Re: [Piglit] [PATCH] util: specify channel sizes for choose_config_attribs()

, 1)); + } + if (!ok) goto fail; Seems a good idea to me. Reviewed-by: Jose Fonseca <jfons...@vmware.com> Given certain tests appear to rely on having 8 bit precision, I think we should warn, and possibly even fail, when we don't get such visuals.

Re: [Piglit] [PATCH 02/20] appveyor.yml: Add appveyor for python code

the framework on windows anymore. It's a start. Thanks for doing this! Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> Acked-by: Jose Fonseca <jfons...@vmware.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.fre

Re: [Piglit] [PATCH] tex-miplevel-selection: only require glsl 1.30 for textureOffset 2DArrayShadow

On 19/04/16 18:21, Roland Scheidegger wrote: Am 19.04.2016 um 18:41 schrieb Jose Fonseca: On 19/04/16 01:32, srol...@vmware.com wrote: From: Roland Scheidegger <srol...@vmware.com> The spec doesn't really say this should work in older versions. It was first added in glsl 4.30, ment

Re: [Piglit] [PATCH] tex-miplevel-selection: only require glsl 1.30 for textureOffset 2DArrayShadow

On 19/04/16 01:32, srol...@vmware.com wrote: From: Roland Scheidegger The spec doesn't really say this should work in older versions. It was first added in glsl 4.30, mentioning it was forgotten (initially part of EXT_gpu_shader4, hence should have been added with 1.30),

Re: [Piglit] [PATCH] gl-1.0-simple-readbuffer: new trivial glReadBuffer() test

lit_check_gl_error(GL_NO_ERROR)) { + piglit_report_result(PIGLIT_FAIL); + } + + piglit_report_result(PIGLIT_PASS); +} Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 0/6] Cleanup and prepare for pre OpenGL 3.0 drivers

On 31/03/16 17:26, Emil Velikov wrote: On 31 March 2016 at 12:21, Jose Fonseca <jfons...@vmware.com> wrote: On 31/03/16 00:44, Emil Velikov wrote: On 30 March 2016 at 21:54, Jose Fonseca <jfons...@vmware.com> wrote: On 30/03/16 11:14, Emil Velikov wrote: On 29 March 2016 at

Re: [Piglit] [PATCH 0/6] Cleanup and prepare for pre OpenGL 3.0 drivers

On 31/03/16 00:44, Emil Velikov wrote: On 30 March 2016 at 21:54, Jose Fonseca <jfons...@vmware.com> wrote: On 30/03/16 11:14, Emil Velikov wrote: On 29 March 2016 at 23:53, Ilia Mirkin <imir...@alum.mit.edu> wrote: Isn't this backwards? Shouldn't waffle just

Re: [Piglit] [PATCH 0/6] Cleanup and prepare for pre OpenGL 3.0 drivers

On 30/03/16 11:14, Emil Velikov wrote: On 29 March 2016 at 23:53, Ilia Mirkin wrote: Isn't this backwards? Shouldn't waffle just work without the ARB_create_context or whatever ext and just create a context and see what version it is? It isn't, imho. Waffle follows the

Re: [Piglit] [PATCH] Add new test to exercise glBitmap in display lists

free(refImage); + + return pass ? PIGLIT_PASS : PIGLIT_FAIL; +} + + +void +piglit_init(int argc, char **argv) +{ + init_bitmaps(); +} Otherwise looks good. Reviewed-by: Jose Fonseca <jfon...@vmware.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Add a new GL_ARB_clip_control viewport test (v2)

Looks good to me. Thanks Brian! Reviewed-by: Jose Fonseca <jfons...@vmware.com> One question: the test case attached to the bug was with a texture bound to FBO. Does this matter and should we add an additional test case for FBO vs window drawables? Or is this pretty much orthogonal?

Re: [Piglit] [PATCH 00/44] Port framework to run on both python 2.7 and 3.3+

On 02/02/16 22:37, Dylan Baker wrote: Okay, it was a pretty trivial bug, I've pushed an updated branch to github, I can send an updated patch too if you prefer. No, I got it. I've also quickly skimmed through the patch series. I've spotted no problem. Series is Acked-by: Jose Fonseca

Re: [Piglit] [PATCH 00/44] Port framework to run on both python 2.7 and 3.3+

- Build piglit as usual On 02/02/16 02:09, Dylan Baker wrote: You're right, on python 3.3 and 3.5 it works, but not on python 2.7. I'll have a look at it in the morning and see if I can get it sorted. Dylan Quoting Jose Fonseca (2016-02-01 15:35:25) Dylan, I tried to build your branch

Re: [Piglit] [PATCH 00/44] Port framework to run on both python 2.7 and 3.3+

Dylan, I tried to build your branch. With Python 2.7 for starters (just for conveniency, then my plan was to build with Python 3.) But I get this failure, both on Windows and Linux: [21/3075] Generating tests/util/piglit-dispatch-gen.c, tests/util/piglit-dispatch-gen.h,

Re: [Piglit] [PATCH 2/2] framework: Get traceback into json results.

Thanks. I wasn't sure if your changes already had taken care of this. I've pushed it now. Jose On 12/01/16 00:08, Dylan Baker wrote: reviewed-by: Dylan Baker <baker.dyla...@gmail.com <mailto:baker.dyla...@gmail.com>> On Tue, Dec 8, 2015 at 8:14 AM, Jose Fonseca <jfon

Re: [Piglit] [PATCH] glsl-1.50-geometry-end-primitive: ensure position data is reasonably aligned

ot; vec2 tmp = r*vec2(cos(theta), sin(theta));\n" + " // ensure reasonably aligned vertices\n" + " return floor(tmp * 2048.0f) / 2048.0f;\n" "}\n"; /** Looks good to me too. Short and simple. Reviewed-by: Jose Fonseca <jfons...@vmwar

Re: [Piglit] [PATCH] gl-1.0-rastercolor: basic test of the raster color used for bitmap drawing

t;); + pass = false; + } + + piglit_present_results(); + + return pass ? PIGLIT_PASS : PIGLIT_FAIL; +} + + +void +piglit_init(int argc, char **argv) +{ + glPixelStorei(GL_UNPACK_ALIGNMENT, 1); +} Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___

Re: [Piglit] [PATCH] polygon-mode-facing: verify facing information is preserved with unfilled prims

eturn PIGLIT_PASS; +} + + +void +piglit_init(int argc, char **argv) +{ + GLuint prog; + piglit_require_GLSL_version(130); + piglit_ortho_projection(piglit_width, piglit_height, false); + prog = piglit_build_simple_program(vstext, fstext); + glUseProgram(prog); +} Otherwise Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] framework/exceptions.py: Drop PIGLIT_DEBUG

+70,9 @@ class PiglitInternalError(Exception): These should always be handled. """ +def __str__(self): +return 'An internal error occured:\n{}'.format( +super(PiglitInternalError, self).__str__()) class PiglitFatalEr

Re: [Piglit] C99

On 10/12/15 10:05, Timothy Arceri wrote: On Thu, 2015-12-10 at 07:49 +, Jose Fonseca wrote: Piglit build failed due to C99 usage. Roland already fixed it, but in fact it's fine to use most C99 -- the MSVC version we require supports most of it too. What I don't why this didn't cause

[Piglit] [PATCH] cmake: Target C99.

GCC 5.x and 4.x have different defaults, so it's better to explicitly specify the target C standard to keep builds consistent. --- CMakeLists.txt| 6 ++ tests/shaders/shader_runner.c | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt

Re: [Piglit] [PATCH v2] framework/test/opengl.py: Fix opengl fast-skipping wflinfo errors

e: $ wflinfo --platform glx --api gles3 Waffle platform: glx Waffle api: gles3 OpenGL vendor string: WFLINFO_GL_ERROR OpenGL renderer string: WFLINFO_GL_ERROR OpenGL version string: WFLINFO_GL_ERROR class TestWflInfoOSError(object): """Tests for the Wflin

Re: [Piglit] [PATCH] framework/results.py: write and restore traceback.

ef test_traceback(self): +"""results.TestResult.to_json: Adds the traceback attribute""" + nt.eq_(self.test.traceback, self.dict['traceback']) + def test_TestResult_update(): """results.TestResult.update: result is updated"&qu

Re: [Piglit] [PATCH v2] framework/profile.py: raise exception from pool.

s the exception and aborts. Just in case the internals of multiprocessing change again. Eitherway, Reviewed-by: Jose Fonseca <jfons...@vmware.com> + pool.close() + +for r in results: +r.get() +

Re: [Piglit] [PATCH 1/2] framework: Write exceptions and traceback to /dev/stderr and json results.

On 07/12/15 22:21, Jose Fonseca wrote: On 07/12/15 18:06, Dylan Baker wrote: On Mon, Dec 07, 2015 at 02:25:59PM +, Jose Fonseca wrote: Both were being completely hidden. Junit is probably still busted. But the right fix is beyond any doubt to not catch generic Python exceptions

[Piglit] [PATCH 1/3] framework: Never redirect sys.stderr to /dev/null.

Awful idea, as it prevents easy debugging/diagnosis of framework issues. If the test is verbose, then the child process' stderr should be redirected, and not Python's process. --- framework/tests/profile_tests.py| 3 --- framework/tests/run_parser_tests.py | 10 -- 2 files changed,

[Piglit] [PATCH 2/3] framework: Write exceptions and traceback to /dev/stderr and json results.

Exceptions were not reaching neither. Junit is probably still busted. But the right fix is to not catch generic Python exceptions, at all. --- framework/results.py | 3 ++- framework/test/base.py | 7 --- templates/test_result.mako | 8 3 files changed, 14 insertions(+),

[Piglit] [PATCH 3/3] framework: Temporarily disable parsing GL/GLSL version from wflinfo.

It's making many assumptions about the wflinfo output which are not always true. So completely disable it as a temporary workaround. --- framework/test/opengl.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/framework/test/opengl.py b/framework/test/opengl.py index 29da2d1..fa17873

Re: [Piglit] [PATCH 2/2] framework: Don't try to parse GL/GLSL version from wflinfo.

On 08/12/15 00:40, Dylan Baker wrote: On Mon, Dec 07, 2015 at 02:26:00PM +, Jose Fonseca wrote: It's making many assumptions about the wflinfo which are not true. So completely disable it as a workaround. Though I wonder if there's really any merit in adding a depending on wflinfo. IMO

Re: [Piglit] [PATCH 1/3] framework: Never redirect sys.stderr to /dev/null.

On 08/12/15 15:38, Dylan Baker wrote: On Tue, Dec 08, 2015 at 01:23:28PM +, Jose Fonseca wrote: Awful idea, as it prevents easy debugging/diagnosis of framework issues. If the test is verbose, then the child process' stderr should be redirected, and not Python's process. --- framework

[Piglit] [PATCH 2/2] framework: Get traceback into json results.

Exceptions were not reaching it. --- framework/results.py | 3 ++- templates/test_result.mako | 8 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/framework/results.py b/framework/results.py index eeffcb7..ef19fd4 100644 --- a/framework/results.py +++

[Piglit] [PATCH 1/2] framework: Write exceptions and traceback to /dev/stderr.

--- framework/test/base.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/framework/test/base.py b/framework/test/base.py index bf998d8..378f185 100644 --- a/framework/test/base.py +++ b/framework/test/base.py @@ -184,11 +184,12 @@ class Test(object): #

Re: [Piglit] [PATCH] framework: Never redirect sys.stderr to /dev/null.

On 07/12/15 18:20, Dylan Baker wrote: On Mon, Dec 07, 2015 at 03:31:59PM +, Jose Fonseca wrote: I figured out how to not redirect stderr, but I can't figure out how to not catch the exceptions for the life of me. There's not a single exception handler, but many. I identified some

Re: [Piglit] [PATCH 1/3] framework: Never redirect sys.stderr to /dev/null.

On 08/12/15 15:56, Dylan Baker wrote: On Tue, Dec 08, 2015 at 03:51:40PM +, Jose Fonseca wrote: On 08/12/15 15:38, Dylan Baker wrote: On Tue, Dec 08, 2015 at 01:23:28PM +, Jose Fonseca wrote: Awful idea, as it prevents easy debugging/diagnosis of framework issues. If the test

Re: [Piglit] Silent Python exceptions

On 07/12/15 13:55, Ilia Mirkin wrote: On Mon, Dec 7, 2015 at 8:26 AM, Jose Fonseca <jfons...@vmware.com> wrote: Is there any way to tell piglit framework to not trap and hide Python exceptions, so they can be debugged? Also, I'd much prefer that Python exceptions would cause the ab

[Piglit] [PATCH 2/2] framework: Don't try to parse GL/GLSL version from wflinfo.

It's making many assumptions about the wflinfo which are not true. So completely disable it as a workaround. Though I wonder if there's really any merit in adding a depending on wflinfo. IMO, if piglit cares for the advertised GL/GLSL versions, it should have its own internally utility program

[Piglit] [PATCH 1/2] framework: Write exceptions and traceback to /dev/stderr and json results.

Both were being completely hidden. Junit is probably still busted. But the right fix is beyond any doubt to not catch generic Python exceptions, or override stderr, at all. --- framework/results.py | 3 ++- framework/test/base.py | 9 ++--- templates/test_result.mako | 8

[Piglit] [PATCH] framework: Never redirect sys.stderr to /dev/null.

Awful idea, as it prevents easy debugging/diagnosis of framework issues. If the test is verbose, then the child process' stderr should be redirected, and not Python's process. --- framework/test/base.py | 4 +--- framework/tests/profile_tests.py| 3 ---

Re: [Piglit] [PATCH] framework: Never redirect sys.stderr to /dev/null.

On 07/12/15 15:31, Jose Fonseca wrote: I figured out how to not redirect stderr, but I can't figure out how to not catch the exceptions for the life of me. There's not a single exception handler, but many. I identified some as drafted in the attached, but there are apparently more

[Piglit] Silent Python exceptions

I just realized piglit has been producing lots of spurious failures. The weird thing is that neither the JUnit nor JSON backend give any explanation of why. Inspecting results.json directly I found some clues: "tests": {

Re: [Piglit] [PATCH] framework: Never redirect sys.stderr to /dev/null.

I figured out how to not redirect stderr, but I can't figure out how to not catch the exceptions for the life of me. There's not a single exception handler, but many. I identified some as drafted in the attached, but there are apparently more. They are hidden inside accessors and function

Re: [Piglit] [PATCH 2/2] framework/backends/junit.py: Handle tests with subtests as testsuite elements

Sounds alright then. Thanks for the heads up. Acked-by: Jose Fonseca <jfons...@vmware.com> Jose On 05/12/15 23:26, Dylan Baker wrote: According to the schema it's allowed. The schema is in the piglit repo at "framework/tests/schema/junit-7.xsd" On Sat, Dec 5, 2015 at 4:36

Re: [Piglit] [PATCH 1/2] framework: Write exceptions and traceback to /dev/stderr and json results.

On 07/12/15 18:06, Dylan Baker wrote: On Mon, Dec 07, 2015 at 02:25:59PM +, Jose Fonseca wrote: Both were being completely hidden. Junit is probably still busted. But the right fix is beyond any doubt to not catch generic Python exceptions, or override stderr, at all. --- framework

Re: [Piglit] [PATCH] framework/profile.py: raise exception from pool.

On 07/12/15 19:40, Dylan Baker wrote: On Mon, Dec 07, 2015 at 10:53:10AM -0800, baker.dyla...@gmail.com wrote: From: Dylan Baker By using Multiprocessing.dummy.Pool.apply_async() instead of .imap(), an exception in the thread can be raised stopping the run of the

Re: [Piglit] [PATCH 2/2] framework: Don't try to parse GL/GLSL version from wflinfo.

On 07/12/15 18:12, Dylan Baker wrote: On Mon, Dec 07, 2015 at 02:26:00PM +, Jose Fonseca wrote: It's making many assumptions about the wflinfo which are not true. So completely disable it as a workaround. Though I wonder if there's really any merit in adding a depending on wflinfo. IMO

Re: [Piglit] [PATCH 2/2] framework/backends/junit.py: Handle tests with subtests as testsuite elements

On 05/12/15 00:21, baker.dyla...@gmail.com wrote: From: Dylan Baker Currently the JUnit backend has no way to represent subtests in such a way that they can be understood by jenkins and by the summary tools. Mark, Nanley and myself consulted and came up with several

Re: [Piglit] [PATCH] gl-3.2: add layered rendering test doing clipping

p;& pass; + + pass = piglit_check_gl_error(GL_NO_ERROR) && pass; + + /* Clean up */ + glDeleteTextures(1, ); + glDeleteFramebuffers(1, ); + + pass = piglit_check_gl_error(GL_NO_ERROR) && pass; + + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL); +} + +enum piglit_result +piglit_display(void) +{ + /* UNREACHABLE */ + return PIGLIT_FAIL; +} Looks good AFAICT. Thanks. Reviewed-by: Jose Fonseca <jfons...@vmware.com> Jose ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] Allow junit to be used for summary generation

On 09/10/15 01:21, baker.dyla...@gmail.com wrote: This series updates the junit backend to allow it to properly load junit and convert it back into piglit's internal representation, thus allowing it to be summarized using the piglit summary tools There is still some work that needs to be done

Re: [Piglit] Allow junit to be used for summary generation

On 09/10/15 17:44, Mark Janes wrote: Jose Fonseca <jfons...@vmware.com> writes: On 09/10/15 01:21, baker.dyla...@gmail.com wrote: This series updates the junit backend to allow it to properly load junit and convert it back into piglit's internal representation, thus al

Re: [Piglit] [PATCH 8/9] tests/all.py: add arb_robustness_draw-vbo-bounds

On 02/09/15 20:51, Dylan Baker wrote: This was never added to all.py Yes, that was because the test uses random numbers, hence might yield variable results (fail once, pass another). Rather than all.py, it probably makes sense to move this sort of tests to a new stress.py test-list. The

Re: [Piglit] [PATCH] cmake: Enable __USE_MINGW_ANSI_STDIO for MinGW builds.

. To avoid surprises. Jose On Mon, Jul 20, 2015 at 11:51 PM, Jose Fonseca jfons...@vmware.com wrote: Interesting, I didn't know about __USE_MINGW_ANSI_STDIO. However, it solves the MinGW problem, but not MSVC -- https://msdn.microsoft.com/en-us/library/tcxf1dw6.aspx A more portable solution would

Re: [Piglit] [PATCH] arb_get_texture_sub_image: new tests for GL_ARB_get_texture_sub_image

On 22/07/15 18:25, Brian Paul wrote: errors.c - test error detection get.c - test glGetTextureSubImage getcompressed.c - test glGetCompressedTextureSubImage cubemap.c - extra tests for getting cubemap images v2: move guts of the tests from piglit_display() to piglit_init(), test cube map

Re: [Piglit] [PATCH] cmake: Enable __USE_MINGW_ANSI_STDIO for MinGW builds.

Interesting, I didn't know about __USE_MINGW_ANSI_STDIO. However, it solves the MinGW problem, but not MSVC -- https://msdn.microsoft.com/en-us/library/tcxf1dw6.aspx A more portable solution would be to use inttypes.h PRIdPTR or avoid size_t arguments to printf. Jose On 21/07/15 05:23,

Re: [Piglit] [PATCH 0/5] Python 3 port, again

On 17/07/15 14:24, Timothy Arceri wrote: On Thu, 2015-07-16 at 15:53 -0700, Dylan Baker wrote: On Thu, Jul 09, 2015 at 02:25:40PM -0700, Dylan Baker wrote: This series ports the python framework to python 3. This is an updated version of the previous incarnations of this series, rebased on

Re: [Piglit] [PATCH] arb_direct_state_access: allow tests to run with core profile

; config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE; Reviewed-by: Jose Fonseca jfons...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] ext_packed_float: fix getteximage-invalid-format-for-packed-type test

); for (j = 0; j ARRAY_SIZE(testedTypes); j++) { for (i = 0; i ARRAY_SIZE(formatTypes); i++) { Otherwise looks good to me. Reviewed-by: Jose Fonseca jfons...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH] glsl-1.10: exercise variable-indexed arrays

, 0.0) (1.0, 0.5, 1.0, 1.0) +relative probe rgb (0.0, 1.0) (1.0, 0.5, 1.0, 1.0) +relative probe rgb (1.0, 1.0) (1.0, 0.5, 1.0, 1.0) Reviewed-by: Jose Fonseca jfons...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http

[Piglit] [PATCH 1/2] glsl-vs-arrays-rw: New test for temporary read-write indirection.

Similar to glsl-vs-arrays, but due to optimizations, glsl-vs-arrays actually ends up doing indirection of the CONST registers, not TEMP. VMWARE PR 1470667. --- tests/shaders/glsl-vs-arrays-rw.shader_test | 37 + 1 file changed, 37 insertions(+) create mode 100644

[Piglit] [PATCH 2/2] cmake: Match MSVC default stack size on MinGW builds.

MSVC defaults to 1MB stack size. MinGW defaults to a larger value. But in order to trap problems with excessive usage of the stack on Windows we really want to match MSVC. --- CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index

Re: [Piglit] [PATCH] gl-2.0-large-point-fs: new test of large points with fragment shaders

(PIGLIT_FAIL); + } + + glUseProgram(prog); + + color_bias_uniform = glGetUniformLocation(prog, color_bias); + color_scale_uniform = glGetUniformLocation(prog, color_scale); +} Reviewed-by: Jose Fonseca jfons...@vmware.com ___ Piglit

[Piglit] [PATCH] cl/api: Avoid deprecated declarations warnings.

--- tests/cl/api/create-image.c| 2 ++ tests/cl/api/unload-compiler.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/cl/api/create-image.c b/tests/cl/api/create-image.c index a1e143b..1ee5f71 100644 --- a/tests/cl/api/create-image.c +++ b/tests/cl/api/create-image.c @@ -24,6

Re: [Piglit] [PATCH] Ignore piglit warning status in JUnit

No objections from me (I have enough crashes and fails to worry about, so warns are rarely something I have time for.) It might make sense to have an option like GCC's -Werror that makes warnings errors. Though I suppose anybody interesting in finding out warnings can also run the json

Re: [Piglit] [PATCH] gl-1.5-vertex-buffer-offsets: test unusual vertex offsets/strides

, not fail (see comments above) */ + return pass ? PIGLIT_PASS : PIGLIT_WARN; +} I also wonder if we should fail instead of just warn on x86, or whatever platform (Windows or Linux) that Flockers runs. Either way Reviewed-by: Jose Fonseca jfons...@vmware.com Jose

Re: [Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

On 19/06/15 20:45, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 3:39 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 13:32, Timothy Arceri wrote: Hi all, Unfortunately since its introduction patchwork hasn't seen a lot of love in the Piglit and Mesa projects so I thought I'd try

[Piglit] [PATCH] framework/test/base: Recognize returncode 3 as crash on Windows.

Programs that terminate via MSVCRT's abort(), including failed assertions, return code 3, not a negative number. This is particularly pertinent now that the use of the standard assert macro has increased in (over gallium's assert macro, which would trap the debugger with INT3, and return a

Re: [Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

On 19/06/15 13:32, Timothy Arceri wrote: Hi all, Unfortunately since its introduction patchwork hasn't seen a lot of love in the Piglit and Mesa projects so I thought I'd try something out to bring it out of the shadows and into the limelight. The idea is simple we have many useful but long

[Piglit] [PATCH] all.py: Actually add_texwrap_target_tests's target parameter to the test.

The target was only being used for the test name -- all test instances were duplicate of one another. Noticed this because llvmpipe started failing several tests when offset was added, and all test command lines were exactly the same. --- tests/all.py | 12 +++- 1 file changed, 7

Re: [Piglit] [PATCH] arb_dsa: avoid non-determinism in create-programpipelines subtests

this one too, but didn't had opportunity to do anything about it. Reviewed-by: Jose Fonseca jfons...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 0/6] Replace variable-index read shell generator with python

Sounds neat in principle. I skimmed through the code, and nothing caught my eye, but I'm not familiar with all of it to be honest. Did you compare the python generated tests match the shell ones? Assuming they are identical, Acked-by: Jose Fonseca jfons...@vmware.com Jose On 29/05/15 20:37

Re: [Piglit] [PATCH 3/3] util: Implement basename for MSVC.

On 08/06/15 14:47, Brian Paul wrote: On 06/08/2015 06:17 AM, Jose Fonseca wrote: Not really tested, but it should hopefully work, and at very least it prevents link failures on MSVC due to absence of basename. --- tests/util/piglit-util.c | 29 + tests/util/piglit

  1   2   3   >